November 2025 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-sgsn[master]: pdpctx: Use pdp->teic_own as rate_ctr id
by fixeria 19 Nov '25

19 Nov '25

Attention is currently required from: daniel, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/41458?usp=email ) Change subject: pdpctx: Use pdp->teic_own as rate_ctr id ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/41458?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I388d7e4550e874cabc51e016d1a35a1074be7ac3 Gerrit-Change-Number: 41458 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Nov 2025 18:17:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-sgsn[master]: Pass pdp_t to sgsn_pdp_ctx_alloc()
by fixeria 19 Nov '25

19 Nov '25

Attention is currently required from: daniel, lynxis lazus, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/41457?usp=email ) Change subject: Pass pdp_t to sgsn_pdp_ctx_alloc() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/41457?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ie7312039fc97f50d09f00661e7c156610f3304b8 Gerrit-Change-Number: 41457 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 18 Nov 2025 18:16:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-pfcp[master]: pfcp_msg: Add osmo_pfcp_ie_node_id_cmp()
by fixeria 19 Nov '25

19 Nov '25

Attention is currently required from: neels, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/41452?usp=email ) Change subject: pfcp_msg: Add osmo_pfcp_ie_node_id_cmp() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/41452?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: Id9bda11078d7d940474389c95d23e90db7bc5bed Gerrit-Change-Number: 41452 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Nov 2025 17:15:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-hnbgw[master]: vty: Drop SS7 route info in 'show cnlink'
by fixeria 19 Nov '25

19 Nov '25

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/41451?usp=email ) Change subject: vty: Drop SS7 route info in 'show cnlink' ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/41451?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I2b029e99da45408f9fed41f9f280d19eb646d548 Gerrit-Change-Number: 41451 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Nov 2025 17:14:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmocom-bb[master]: mobile app: Indicate ER-GSM band support in MS classmark 3
by fixeria 19 Nov '25

19 Nov '25

Attention is currently required from: jolly, laforge. fixeria has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41360?usp=email ) The change is no longer submittable: Code-Review is unsatisfied now. Change subject: mobile app: Indicate ER-GSM band support in MS classmark 3 ...................................................................... Patch Set 5: Code-Review+1 (1 comment) Patchset: PS5: BTW, I am not really sure if we want to indicate this band by default. This is needed only in a very specific usage scenarios, and is making the classmark unnecessary long for those who are not playing with GSM-R. In other words, I would keep it disabled by default. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41360?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ica13814eddb5293c7d7a2a21dd6a7a437cd1d351 Gerrit-Change-Number: 41360 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 18 Nov 2025 17:13:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in ...osmo-s1gw[master]: config: Set pfcp_net_inst_* fields as strings
by fixeria 19 Nov '25

19 Nov '25

Attention is currently required from: laforge, lynxis lazus, osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41461?usp=email ) Change subject: config: Set pfcp_net_inst_* fields as strings ...................................................................... Patch Set 2: (2 comments) Patchset: PS2: > @vyanitskiy@sysmocom. […] Yes, see my other comment. File src/erab_fsm.erl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41461/comment/0a4acf86_d49c… : PS2, Line 88: bin_fqdn() :: [bin_fqdn_label()]. : I believe this type spec is wrong and this is making the dialyzer unhappy. At the end of `enc_net_inst/1` you're calling `list_to_binary/1`, which is expected to return a `binary()`, not a list. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41461?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I7c2da02945829066d317100556e09e55483bd7e7 Gerrit-Change-Number: 41461 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 18 Nov 2025 17:09:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in pysim[master]: card_key_provider: add unit-test
by fixeria 19 Nov '25

19 Nov '25

Attention is currently required from: dexter. fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41448?usp=email ) Change subject: card_key_provider: add unit-test ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41448?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I52519847a4c4a13a7bca49985133872b01c4aaab Gerrit-Change-Number: 41448 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Nov 2025 17:04:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in ...osmo-s1gw[master]: config: Set pfcp_net_inst_* fields as strings
by pespin 19 Nov '25

19 Nov '25

Attention is currently required from: laforge, lynxis lazus, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41461?usp=email ) Change subject: config: Set pfcp_net_inst_* fields as strings ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: @vyanitskiy@sysmocom.de any idea on how to solve the dyalizer error? -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41461?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I7c2da02945829066d317100556e09e55483bd7e7 Gerrit-Change-Number: 41461 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 18 Nov 2025 16:51:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in ...osmo-s1gw[master]: config: Set pfcp_net_inst_* fields as strings
by pespin 19 Nov '25

19 Nov '25

Attention is currently required from: laforge, lynxis lazus, osmith, pespin. Hello Jenkins Builder, fixeria, laforge, lynxis lazus, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41461?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: config: Set pfcp_net_inst_* fields as strings ...................................................................... config: Set pfcp_net_inst_* fields as strings The encoded format is not user friendly at all, since length of each DNS label (subdomain) needs to be encoded in the bytestring. Related: SYS#7734 Change-Id: I7c2da02945829066d317100556e09e55483bd7e7 --- M config/sys.config M src/erab_fsm.erl 2 files changed, 24 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/61/41461/2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41461?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I7c2da02945829066d317100556e09e55483bd7e7 Gerrit-Change-Number: 41461 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[M] Change in pysim[master]: card_key_provider: add unit-test
by dexter 19 Nov '25

19 Nov '25

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/41448?usp=email to look at the new patch set (#4). Change subject: card_key_provider: add unit-test ...................................................................... card_key_provider: add unit-test There is no unit-test for the CardKeyProviderCsv class yet. Let's add one to ensure that the CardKeyProviderCsv class keeps working as expected. Related: SYS#7725 Change-Id: I52519847a4c4a13a7bca49985133872b01c4aaab --- A tests/unittests/test_card_key_provider.csv A tests/unittests/test_card_key_provider.py 2 files changed, 85 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/48/41448/4 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41448?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I52519847a4c4a13a7bca49985133872b01c4aaab Gerrit-Change-Number: 41448 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log November 2025