November 2025 - gerrit-log - lists.osmocom.org

[XS] Change in libosmo-netif[master]: netif/sctp.h: Add missing dep netinet/sctp.h
by pespin 20 Nov '25

20 Nov '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/41445?usp=email ) Change subject: netif/sctp.h: Add missing dep netinet/sctp.h ...................................................................... netif/sctp.h: Add missing dep netinet/sctp.h Change-Id: Icac109aad6dc5a694309c1aedfe4622b04c44c9c --- M include/osmocom/netif/sctp.h 1 file changed, 1 insertion(+), 8 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved osmith: Looks good to me, but someone else must approve diff --git a/include/osmocom/netif/sctp.h b/include/osmocom/netif/sctp.h index 9dcb6dd..3e1d775 100644 --- a/include/osmocom/netif/sctp.h +++ b/include/osmocom/netif/sctp.h @@ -1,6 +1,7 @@ #pragma once #include <osmocom/core/utils.h> +#include <netinet/sctp.h> /* Relevant SCTP RFCs: * rfc9260 (obsoletes rfc4960): SCTP protocol @@ -8,22 +9,18 @@ * rfc6458: SCTP Sockets API Extensions */ -enum sctp_sac_state; extern const struct value_string osmo_sctp_assoc_chg_strs[]; static inline const char *osmo_sctp_assoc_chg_str(enum sctp_sac_state val) { return get_value_string(osmo_sctp_assoc_chg_strs, val); } -enum sctp_spc_state; extern const struct value_string osmo_sctp_paddr_chg_strs[]; static inline const char *osmo_sctp_paddr_chg_str(enum sctp_spc_state val) { return get_value_string(osmo_sctp_paddr_chg_strs, val); } -enum sctp_sn_type; extern const struct value_string osmo_sctp_sn_type_strs[]; static inline const char *osmo_sctp_sn_type_str(enum sctp_sn_type val) { return get_value_string(osmo_sctp_sn_type_strs, val); } -enum sctp_sn_error; extern const struct value_string osmo_sctp_sn_error_strs[]; static inline const char *osmo_sctp_sn_error_str(enum sctp_sn_error val) { return get_value_string(osmo_sctp_sn_error_strs, val); } @@ -43,18 +40,14 @@ OSMO_SCTP_OP_ERR_UNER_INITED_ABORT = 12, OSMO_SCTP_OP_ERR_PROTO_VERSION = 13, }; - - extern const struct value_string osmo_sctp_op_error_strs[]; static inline const char *osmo_sctp_op_error_str(enum osmo_sctp_op_error val) { return get_value_string(osmo_sctp_op_error_strs, val); } -enum sctp_spinfo_state; extern const struct value_string osmo_sctp_spinfo_state_strs[]; static inline const char *osmo_sctp_spinfo_state_str(enum sctp_spinfo_state val) { return get_value_string(osmo_sctp_spinfo_state_strs, val); } -enum sctp_sstat_state; extern const struct value_string osmo_sctp_sstat_state_strs[]; static inline const char *osmo_sctp_sstat_state_str(enum sctp_sstat_state val) { return get_value_string(osmo_sctp_sstat_state_strs, val); } -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/41445?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Icac109aad6dc5a694309c1aedfe4622b04c44c9c Gerrit-Change-Number: 41445 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-netif[master]: netif/sctp.h: Add missing dep netinet/sctp.h
by fixeria 20 Nov '25

20 Nov '25

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-netif/+/41445?usp=email ) Change subject: netif/sctp.h: Add missing dep netinet/sctp.h ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/41445?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Icac109aad6dc5a694309c1aedfe4622b04c44c9c Gerrit-Change-Number: 41445 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 19 Nov 2025 17:32:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-netif[master]: stream: Support overwriting tx_queue_max_length per srv conn
by fixeria 20 Nov '25

20 Nov '25

Attention is currently required from: daniel, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-netif/+/41434?usp=email ) Change subject: stream: Support overwriting tx_queue_max_length per srv conn ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/41434?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ibc68612bd8dee4f9b8031ce2c3f5c7ff6bb639e3 Gerrit-Change-Number: 41434 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 19 Nov 2025 17:31:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in osmo-upf[master]: up_peer: Use Node Id as identifier
by pespin 20 Nov '25

20 Nov '25

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-upf/+/41453?usp=email ) Change subject: up_peer: Use Node Id as identifier ...................................................................... Patch Set 1: Code-Review-2 (1 comment) Patchset: PS1: I'll abandon this patch and I'm instead splitting up_peer into pfcp_node_peer and pfcp_entity_peer. -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/41453?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Idff2865ff63ad2de5e48cceb99f47e6255b330aa Gerrit-Change-Number: 41453 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 19 Nov 2025 17:04:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: pySim-shell: add command to manually query the Card Key Provider
by dexter 20 Nov '25

20 Nov '25

Attention is currently required from: dexter. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/41467?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: pySim-shell: add command to manually query the Card Key Provider ...................................................................... pySim-shell: add command to manually query the Card Key Provider The Card Key Provider is a built in mechanism of pySim-shell which allows the user to read key material from a CSV file in order to avoid having to lookup and enter the key material himself. The lookup normally done by the pySim-shell commands automatically. However, in some cases it may also be useful to be able to query the CSV file manually in order to get certain fields displayed. Such a command is in particular helpful to check and diagnose the CSV data source. Related: SYS#7725 Change-Id: I76e0f883572a029bdca65a5a6b3eef306db1c221 --- M pySim-shell.py 1 file changed, 17 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/67/41467/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41467?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I76e0f883572a029bdca65a5a6b3eef306db1c221 Gerrit-Change-Number: 41467 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: bssgp: Fix non-uniqe rate_ctr ids
by daniel 20 Nov '25

20 Nov '25

Attention is currently required from: fixeria, laforge, lynxis lazus, pespin. daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41456?usp=email ) Change subject: bssgp: Fix non-uniqe rate_ctr ids ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: > I now see this was already proposed here: https://gerrit.osmocom.org/c/libosmocore/+/13206 […] At least from the view of osmo-gbproxy we absolutely have the same BVCI on multiple NSEs so I would say this fix is fine. I still think having a string identifier might be a better option in the future. Then the "index" could be something like "NSE00101-BVC00023". -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41456?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I782e11a75a8adc10292238fde46bf9c3975d970d Gerrit-Change-Number: 41456 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 19 Nov 2025 15:46:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in pysim[master]: card_key_provider: rename parameter filename to csv_filename
by dexter 20 Nov '25

20 Nov '25

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/41465?usp=email ) Change subject: card_key_provider: rename parameter filename to csv_filename ...................................................................... card_key_provider: rename parameter filename to csv_filename let's rename the parameter filename to csv_filename to make it more clear to what kind of file this parameter refers. Change-Id: Id5b7c61b5e72fb205e30d2787855b2c276840a7b --- M pySim/card_key_provider.py 1 file changed, 7 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/65/41465/1 diff --git a/pySim/card_key_provider.py b/pySim/card_key_provider.py index 6292f93..16403ff 100644 --- a/pySim/card_key_provider.py +++ b/pySim/card_key_provider.py @@ -176,16 +176,16 @@ csv_file = None filename = None - def __init__(self, filename: str, transport_keys: dict): + def __init__(self, csv_filename: str, transport_keys: dict): """ Args: - filename : file name (path) of CSV file containing card-individual key/data + csv_filename : file name (path) of CSV file containing card-individual key/data transport_keys : (see class CardKeyFieldCryptor) """ - self.csv_file = open(filename, 'r') + self.csv_file = open(csv_filename, 'r') if not self.csv_file: - raise RuntimeError("Could not open CSV file '%s'" % filename) - self.filename = filename + raise RuntimeError("Could not open CSV file '%s'" % csv_filename) + self.csv_filename = csv_filename self.crypt = CardKeyFieldCryptor(transport_keys) def get(self, fields: List[str], key: str, value: str) -> Dict[str, str]: @@ -194,7 +194,7 @@ self.csv_file.seek(0) cr = csv.DictReader(self.csv_file) if not cr: - raise RuntimeError("Could not open DictReader for CSV-File '%s'" % self.filename) + raise RuntimeError("Could not open DictReader for CSV-File '%s'" % self.csv_filename) cr.fieldnames = [field.upper() for field in cr.fieldnames] rc = {} @@ -204,7 +204,7 @@ if f in row: rc.update({f: self.crypt.decrypt_field(f, row[f])}) else: - raise RuntimeError("CSV-File '%s' lacks column '%s'" % (self.filename, f)) + raise RuntimeError("CSV-File '%s' lacks column '%s'" % (self.csv_filename, f)) return rc -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41465?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id5b7c61b5e72fb205e30d2787855b2c276840a7b Gerrit-Change-Number: 41465 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: card_key_provider: remove unnecessary class property definitions
by dexter 20 Nov '25

20 Nov '25

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/41466?usp=email ) Change subject: card_key_provider: remove unnecessary class property definitions ...................................................................... card_key_provider: remove unnecessary class property definitions The two properties csv_file and csv_filename are defined by the constructor anyway, let's remove the declaration in the class body because it is not needed. Change-Id: Ibbe8e17b03a4ba0041c0e9990a5e9614388d9c03 --- M pySim/card_key_provider.py 1 file changed, 0 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/66/41466/1 diff --git a/pySim/card_key_provider.py b/pySim/card_key_provider.py index 16403ff..f98f06e 100644 --- a/pySim/card_key_provider.py +++ b/pySim/card_key_provider.py @@ -173,9 +173,6 @@ class CardKeyProviderCsv(CardKeyProvider): """Card key provider implementation that allows to query against a specified CSV file.""" - csv_file = None - filename = None - def __init__(self, csv_filename: str, transport_keys: dict): """ Args: -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41466?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ibbe8e17b03a4ba0041c0e9990a5e9614388d9c03 Gerrit-Change-Number: 41466 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in pysim[master]: pySim-shell: add command to manually query the Card Key Provider
by dexter 20 Nov '25

20 Nov '25

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/41467?usp=email ) Change subject: pySim-shell: add command to manually query the Card Key Provider ...................................................................... pySim-shell: add command to manually query the Card Key Provider The Card Key Provider is a built in mechanism of pySim-shell which allows the user to read key material from a CSV file in order to avoid having to lookup and enter the key material himself. The lookup normally done by the pySim-shell commands automatically. However, in some cases it may also be useful to be able to query the CSV file manually in order to get certain fields displayed. Such a command is in particular helpful to check and diagnose the CSV data source. Related: SYS#7725 Change-Id: I76e0f883572a029bdca65a5a6b3eef306db1c221 --- M pySim-shell.py 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/67/41467/1 diff --git a/pySim-shell.py b/pySim-shell.py index 8b0b58e..b933a03 100755 --- a/pySim-shell.py +++ b/pySim-shell.py @@ -498,6 +498,21 @@ """Echo (print) a string on the console""" self.poutput(' '.join(opts.STRING)) + query_card_key_parser = argparse.ArgumentParser() + query_card_key_parser.add_argument('FIELDS', help="fields to query", type=str, nargs='+') + query_card_key_parser.add_argument('--key', help='lookup key (typically \'ICCID\' or \'EID\')', + type=str, required=True) + query_card_key_parser.add_argument('--value', help='lookup key match value (e.g \'8988211000000123456\')', + type=str, required=True) + @cmd2.with_argparser(query_card_key_parser) + @cmd2.with_category(CUSTOM_CATEGORY) + def do_query_card_key(self, opts): + """Manually query the Card Key Provider""" + result = card_key_provider_get(opts.FIELDS, opts.key, opts.value) + self.poutput("Result:") + for k in result.keys(): + self.poutput(" %s: %s" % (str(k), str(result.get(k)))) + @cmd2.with_category(CUSTOM_CATEGORY) def do_version(self, opts): """Print the pySim software version.""" -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41467?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I76e0f883572a029bdca65a5a6b3eef306db1c221 Gerrit-Change-Number: 41467 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in pysim[master]: pySim-shell: re-organize Card Key Provider related options
by dexter 20 Nov '25

20 Nov '25

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/41468?usp=email ) Change subject: pySim-shell: re-organize Card Key Provider related options ...................................................................... pySim-shell: re-organize Card Key Provider related options As we plan to support other formats as data source for the Card Key Provider soon, the more commandline options may be added and it makes sense to group the Card Key Provider options in a dedicated group. Let's also rename the option "--csv-column-key" to just "--column-key". The column encryption is a generic concept and not CSV format specific. (let's silently keep the "--csv-column-key" argument so maintain backward compatibility) Related: SYS#7725 Change-Id: I5093f8383551f8c9b84342ca6674c1ebdbbfc19c --- M pySim-shell.py 1 file changed, 13 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/68/41468/1 diff --git a/pySim-shell.py b/pySim-shell.py index b933a03..72e988c 100755 --- a/pySim-shell.py +++ b/pySim-shell.py @@ -1124,10 +1124,6 @@ global_group = option_parser.add_argument_group('General Options') global_group.add_argument('--script', metavar='PATH', default=None, help='script with pySim-shell commands to be executed automatically at start-up') -global_group.add_argument('--csv', metavar='FILE', - default=None, help='Read card data from CSV file') -global_group.add_argument('--csv-column-key', metavar='FIELD:AES_KEY_HEX', default=[], action='append', - help='per-CSV-column AES transport key') global_group.add_argument("--card_handler", dest="card_handler_config", metavar="FILE", help="Use automatic card handling machine") global_group.add_argument("--noprompt", help="Run in non interactive mode", @@ -1137,6 +1133,14 @@ global_group.add_argument("--verbose", help="Enable verbose logging", action='store_true', default=False) +card_key_group = option_parser.add_argument_group('Card Key Provider Options') +card_key_group.add_argument('--csv', metavar='FILE', + default=None, help='Read card data from CSV file') +card_key_group.add_argument('--csv-column-key', metavar='FIELD:AES_KEY_HEX', default=[], action='append', + help=argparse.SUPPRESS, dest='column_key') +card_key_group.add_argument('--column-key', metavar='FIELD:AES_KEY_HEX', default=[], action='append', + help='per-column AES transport key', dest='column_key') + adm_group = global_group.add_mutually_exclusive_group() adm_group.add_argument('-a', '--pin-adm', metavar='PIN_ADM1', dest='pin_adm', default=None, help='ADM PIN used for provisioning (overwrites default)') @@ -1162,15 +1166,15 @@ # Register csv-file as card data provider, either from specified CSV # or from CSV file in home directory - csv_column_keys = {} - for par in opts.csv_column_key: + column_keys = {} + for par in opts.column_key: name, key = par.split(':') - csv_column_keys[name] = key + column_keys[name] = key csv_default = str(Path.home()) + "/.osmocom/pysim/card_data.csv" if opts.csv: - card_key_provider_register(CardKeyProviderCsv(opts.csv, csv_column_keys)) + card_key_provider_register(CardKeyProviderCsv(opts.csv, column_keys)) if os.path.isfile(csv_default): - card_key_provider_register(CardKeyProviderCsv(csv_default, csv_column_keys)) + card_key_provider_register(CardKeyProviderCsv(csv_default, column_keys)) # Init card reader driver sl = init_reader(opts, proactive_handler = Proact()) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41468?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5093f8383551f8c9b84342ca6674c1ebdbbfc19c Gerrit-Change-Number: 41468 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log November 2025