August 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ggsn[master]: ggsn: kernel gtpu: Support updating pdp ctx remote IP address and TEID
by pespin 19 Aug '24

19 Aug '24

Attention is currently required from: daniel, fixeria, laforge, lynxis lazus, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/37691?usp=email ) Change subject: ggsn: kernel gtpu: Support updating pdp ctx remote IP address and TEID ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/37691?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I1fc48be5c0f177ccf6fbe97c003b4df44809c0fe Gerrit-Change-Number: 37691 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 19 Aug 2024 10:07:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-sgsn[master]: Replace gprs_ra_id with modern osmo_routing_area_id
by pespin 19 Aug '24

19 Aug '24

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37860?usp=email ) Change subject: Replace gprs_ra_id with modern osmo_routing_area_id ...................................................................... Patch Set 2: Code-Review+1 (6 comments) File src/sgsn/gprs_gmm.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/37860/comment/f1ea0230_7660f467?us… : PS2, Line 1645: osmo_routing_area_id_decode(&old_ra_id, cur, msgb_l3len(msg) - 3); where does the 3 come from? "cur - gh" ? https://gerrit.osmocom.org/c/osmo-sgsn/+/37860/comment/0d1a4673_eee5a654?us… : PS2, Line 1729: bssgp_parse_cell_id2(&new_ra_id, NULL, msgb_bcid(msg), 8); isn't this 8 you hardcoded supposed to be passed from space available in msg to avoid read out of bounds? https://gerrit.osmocom.org/c/osmo-sgsn/+/37860/comment/71861a84_ade28dd0?us… : PS2, Line 1772: bssgp_parse_cell_id2(&mmctx->ra, NULL, msgb_bcid(msg), 8); isn't this 8 you hardcoded supposed to be passed from space available in msg to avoid read out of bounds? https://gerrit.osmocom.org/c/osmo-sgsn/+/37860/comment/2ea4a0cf_84f25c35?us… : PS2, Line 2346: bssgp_parse_cell_id2(&ra_id, NULL, msgb_bcid(msg), 8); isn't this 8 you hardcoded supposed to be passed from space available in msg to avoid read out of bounds? File src/sgsn/gprs_sndcp.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/37860/comment/6c1ccbb3_1d65b00d?us… : PS2, Line 837: bssgp_parse_cell_id2(&sne->ra_id, NULL, msgb_bcid(msg), 8); same File src/sgsn/gprs_subscriber.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/37860/comment/7b2301d0_4ca96131?us… : PS2, Line 880: if (subscr->lac != mmctx->ra.lac.lac) we should add a define to name "lac" as "lai" in that struct :) -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37860?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ia41eb8f51d3836b1bc65325ff1ec6bdb16e20c7e Gerrit-Change-Number: 37860 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 19 Aug 2024 10:06:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ggsn[master]: ggsn: kernel gtpu: Support updating pdp ctx remote IP address and TEID
by pespin 19 Aug '24

19 Aug '24

Attention is currently required from: daniel, fixeria, laforge, lynxis lazus, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/37691?usp=email ) Change subject: ggsn: kernel gtpu: Support updating pdp ctx remote IP address and TEID ...................................................................... Patch Set 3: (1 comment) File ggsn/ggsn.c: https://gerrit.osmocom.org/c/osmo-ggsn/+/37691/comment/a5ddea45_a80e235f?us… : PS3, Line 587: static > why `static`? Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/37691?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I1fc48be5c0f177ccf6fbe97c003b4df44809c0fe Gerrit-Change-Number: 37691 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 19 Aug 2024 09:57:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-ggsn[master]: ggsn: kernel gtpu: Support updating pdp ctx remote IP address and TEID
by pespin 19 Aug '24

19 Aug '24

Attention is currently required from: daniel, fixeria, laforge, lynxis lazus, osmith, pespin. Hello Jenkins Builder, daniel, fixeria, laforge, lynxis lazus, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ggsn/+/37691?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+1 by daniel, Code-Review+1 by fixeria, Code-Review+1 by osmith, Verified+1 by Jenkins Builder Change subject: ggsn: kernel gtpu: Support updating pdp ctx remote IP address and TEID ...................................................................... ggsn: kernel gtpu: Support updating pdp ctx remote IP address and TEID Whenever the SGSN sends the GGSN a UpdatePDPCtxReq, it may offer a new remote IP address or/and remote TEID, eg. because it wants to establish a Direct Tunnel and point the GTPU towards the RNC, or to point it back to itself. If the gtpu kernel is used, osmo-ggsn lacked updating the kernel with the new remote data. The gtp kernel module doesn't provide an efficient/explicit way to update a pdp context keeping the4 same local IP+TEID and changing only the remote remote IP+TEID, hence first destroy the pdp ctx in the gtp kernel module and then recreate it. This fixes test GGSN_Tests_v4_only.TC_pdp4_act_update_teid in ttcn3-ggsn-test-kernel-net-next. Related: OS#6523 Change-Id: I1fc48be5c0f177ccf6fbe97c003b4df44809c0fe --- M ggsn/ggsn.c 1 file changed, 37 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/91/37691/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/37691?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I1fc48be5c0f177ccf6fbe97c003b4df44809c0fe Gerrit-Change-Number: 37691 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[M] Change in libosmo-sccp[master]: Reject M3UA with "M3UA Network Appearance"
by pespin 19 Aug '24

19 Aug '24

Attention is currently required from: jolly. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/37817?usp=email ) Change subject: Reject M3UA with "M3UA Network Appearance" ...................................................................... Patch Set 4: (4 comments) Commit Message: https://gerrit.osmocom.org/c/libosmo-sccp/+/37817/comment/805d5366_288faa34… : PS4, Line 13: Related: SYS#6240 OS#6240 File src/m3ua.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/37817/comment/6f69afb3_0e4debd5… : PS4, Line 360: static struct xua_msg *m3ua_gen_error_msg(struct osmo_ss7_asp *asp, uint32_t err_code, struct msgb *msg) May be worth stating that asp can be null here? or it cannot? https://gerrit.osmocom.org/c/libosmo-sccp/+/37817/comment/4cb021b2_e87ffca7… : PS4, Line 368: if (!err) sounds like hidding a bug here without logging? File src/xua_rkm.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/37817/comment/16e62ae5_5cb39174… : PS4, Line 179: if (xua_msg_find_tag(inner, M3UA_IEI_NET_APPEAR)) { I'd keep the "/* network appearance (optional) */" -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/37817?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ia2c2004a7495376fd3f44d26f6cf1b6d277c9b2f Gerrit-Change-Number: 37817 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Mon, 19 Aug 2024 09:53:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in libosmocore[master]: add convert functions for old gprs_ra_id and the new osmo_routing_are...
by pespin 19 Aug '24

19 Aug '24

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmocore/+/37831?usp=email ) Change subject: add convert functions for old gprs_ra_id and the new osmo_routing_area_id ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37831?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iaef54cac541913534af00f40483723e9952a6807 Gerrit-Change-Number: 37831 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 19 Aug 2024 09:39:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmocore[master]: gb: add bssgp_parse_cell_id2/bssgp_create_cell_id2
by pespin 19 Aug '24

19 Aug '24

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmocore/+/37794?usp=email ) Change subject: gb: add bssgp_parse_cell_id2/bssgp_create_cell_id2 ...................................................................... Patch Set 5: Code-Review+1 (2 comments) File src/gb/gprs_bssgp.c: https://gerrit.osmocom.org/c/libosmocore/+/37794/comment/34faf5ce_7a6bc46c?… : PS5, Line 370: *cid = osmo_load16be(buf+6); buf + sizeof(struct gsm48_ra_id) https://gerrit.osmocom.org/c/libosmocore/+/37794/comment/0419d716_1ceae3cb?… : PS5, Line 398: osmo_store16be(cid, buf+6); buf + sizeof(struct gsm48_ra_id) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37794?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6cdae75a32547968add2421a07d287a0a42bdbc0 Gerrit-Change-Number: 37794 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 19 Aug 2024 09:36:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-upf[master]: nft: batch nftables commands
by pespin 19 Aug '24

19 Aug '24

Attention is currently required from: neels. pespin has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-upf/+/37762?usp=email ) Change subject: nft: batch nftables commands ...................................................................... Patch Set 4: Code-Review+1 (1 comment) File src/osmo-upf/upf_nft.c: https://gerrit.osmocom.org/c/osmo-upf/+/37762/comment/2098ecda_50d35b32?usp… : PS4, Line 164: /* is that being cut off? then revert the addition. This should never happen in practice. */ why do you say this should never happen in practice? what's the rationale? -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/37762?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ib0a8e86b29bab1559d94fc55a89daa00ec670318 Gerrit-Change-Number: 37762 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 Aug 2024 09:30:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XL] Change in osmo-upf[master]: osmo-pfcp-tool: add GTP flooding using io_uring
by pespin 19 Aug '24

19 Aug '24

Attention is currently required from: laforge, neels. pespin has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-upf/+/37764?usp=email ) Change subject: osmo-pfcp-tool: add GTP flooding using io_uring ...................................................................... Patch Set 6: (4 comments) Patchset: PS4: > * might make sense to change all naming from gtp to gtpu to indicate it's about user-plane GTP flood […] I agree with Harald that terminology gtpu or gtp1u/gtpv1u should be used in lots of places, otherwise it's difficult to gasp what's gtp1c/gtp2c, what's gtp1u, etc. File contrib/osmo-pfcp-tool-scripts/gtp_flood.vty: https://gerrit.osmocom.org/c/osmo-upf/+/37764/comment/1b8592aa_a827229e?usp… : PS6, Line 1: # Establish N PFCP sessions for tunend, and emit massive GTP traffic to the UPF GTP-U traffic File src/osmo-pfcp-tool/pfcp_tool.c: https://gerrit.osmocom.org/c/osmo-upf/+/37764/comment/6abd5aa9_ef46b765?usp… : PS6, Line 206: LOGP(DLGLOBAL, LOGL_ERROR, "insufficient UE IP addresses, wrapped back to first\n"); this sounds more like a fatal error where program should simply exit with an error? osmo_panic() or alike? File src/osmo-pfcp-tool/pfcp_tool_vty.c: https://gerrit.osmocom.org/c/osmo-upf/+/37764/comment/c639826e_7244f1f0?usp… : PS6, Line 1112: * A local GTP port from osmo-pfcp-tool's point of view. */ GTPv1U port right? -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/37764?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I332aa0e2efd55f6e357cde4752a3d8b584db531b Gerrit-Change-Number: 37764 Gerrit-PatchSet: 6 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 19 Aug 2024 09:27:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[M] Change in osmo-sgsn[master]: Replace gprs_ra_id with modern osmo_routing_area_id
by lynxis lazus 19 Aug '24

19 Aug '24

Attention is currently required from: lynxis lazus, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37860?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: Replace gprs_ra_id with modern osmo_routing_area_id ...................................................................... Replace gprs_ra_id with modern osmo_routing_area_id The new modern osmo_routing_area_id is more flexible and allow to access PLMN, LAC more convient. Depends: Iaef54cac541913534af00f40483723e9952a6807 (libosmocore) Change-Id: Ia41eb8f51d3836b1bc65325ff1ec6bdb16e20c7e --- M include/osmocom/sgsn/gprs_gmm.h M include/osmocom/sgsn/gprs_sndcp.h M include/osmocom/sgsn/gtp.h M include/osmocom/sgsn/mmctx.h M src/sgsn/gprs_bssgp.c M src/sgsn/gprs_gmm.c M src/sgsn/gprs_sndcp.c M src/sgsn/gprs_subscriber.c M src/sgsn/mmctx.c M src/sgsn/sgsn_auth.c M src/sgsn/sgsn_cdr.c M src/sgsn/sgsn_libgtp.c M src/sgsn/sgsn_vty.c M tests/sgsn/sgsn_test.c 14 files changed, 70 insertions(+), 65 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/60/37860/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37860?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ia41eb8f51d3836b1bc65325ff1ec6bdb16e20c7e Gerrit-Change-Number: 37860 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

2026

2025

2024

2023

2022

gerrit-log August 2024