Attention is currently required from: lynxis lazus.

pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37860?usp=email )

Change subject: Replace gprs_ra_id with modern osmo_routing_area_id ......................................................................

Patch Set 2: Code-Review+1

(6 comments)

File src/sgsn/gprs_gmm.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/37860/comment/f1ea0230_7660f467?usp... : PS2, Line 1645: osmo_routing_area_id_decode(&old_ra_id, cur, msgb_l3len(msg) - 3); where does the 3 come from? "cur - gh" ?

https://gerrit.osmocom.org/c/osmo-sgsn/+/37860/comment/0d1a4673_eee5a654?usp... : PS2, Line 1729: bssgp_parse_cell_id2(&new_ra_id, NULL, msgb_bcid(msg), 8); isn't this 8 you hardcoded supposed to be passed from space available in msg to avoid read out of bounds?

https://gerrit.osmocom.org/c/osmo-sgsn/+/37860/comment/71861a84_ade28dd0?usp... : PS2, Line 1772: bssgp_parse_cell_id2(&mmctx->ra, NULL, msgb_bcid(msg), 8); isn't this 8 you hardcoded supposed to be passed from space available in msg to avoid read out of bounds?

https://gerrit.osmocom.org/c/osmo-sgsn/+/37860/comment/2ea4a0cf_84f25c35?usp... : PS2, Line 2346: bssgp_parse_cell_id2(&ra_id, NULL, msgb_bcid(msg), 8); isn't this 8 you hardcoded supposed to be passed from space available in msg to avoid read out of bounds?

File src/sgsn/gprs_sndcp.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/37860/comment/6c1ccbb3_1d65b00d?usp... : PS2, Line 837: bssgp_parse_cell_id2(&sne->ra_id, NULL, msgb_bcid(msg), 8); same

File src/sgsn/gprs_subscriber.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/37860/comment/7b2301d0_4ca96131?usp... : PS2, Line 880: if (subscr->lac != mmctx->ra.lac.lac) we should add a define to name "lac" as "lai" in that struct :)