Attention is currently required from: jolly.

pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/37817?usp=email )

Change subject: Reject M3UA with "M3UA Network Appearance" ......................................................................

Patch Set 4:

(4 comments)

Commit Message:

https://gerrit.osmocom.org/c/libosmo-sccp/+/37817/comment/805d5366_288faa34?... : PS4, Line 13: Related: SYS#6240 OS#6240

File src/m3ua.c:

https://gerrit.osmocom.org/c/libosmo-sccp/+/37817/comment/6f69afb3_0e4debd5?... : PS4, Line 360: static struct xua_msg *m3ua_gen_error_msg(struct osmo_ss7_asp *asp, uint32_t err_code, struct msgb *msg) May be worth stating that asp can be null here? or it cannot?

https://gerrit.osmocom.org/c/libosmo-sccp/+/37817/comment/4cb021b2_e87ffca7?... : PS4, Line 368: if (!err) sounds like hidding a bug here without logging?

File src/xua_rkm.c:

https://gerrit.osmocom.org/c/libosmo-sccp/+/37817/comment/16e62ae5_5cb39174?... : PS4, Line 179: if (xua_msg_find_tag(inner, M3UA_IEI_NET_APPEAR)) { I'd keep the "/* network appearance (optional) */"