August 2024 - gerrit-log - lists.osmocom.org

[M] Change in libosmo-sccp[master]: Reject M3UA with "M3UA Network Appearance"
by jolly 19 Aug '24

19 Aug '24

Attention is currently required from: pespin. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/37817?usp=email ) Change subject: Reject M3UA with "M3UA Network Appearance" ...................................................................... Patch Set 7: (1 comment) File src/m3ua.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/37817/comment/9008881b_d5ecf431… : PS7, Line 386: if (asp) { > tbh, seeing it this way now, imho this logging message most probably belongs to whatever parent is c […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/37817?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ia2c2004a7495376fd3f44d26f6cf1b6d277c9b2f Gerrit-Change-Number: 37817 Gerrit-PatchSet: 7 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 Aug 2024 13:37:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmo-sccp[master]: Reject M3UA with "M3UA Network Appearance"
by jolly 19 Aug '24

19 Aug '24

Attention is currently required from: jolly, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sccp/+/37817?usp=email to look at the new patch set (#8). The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: Reject M3UA with "M3UA Network Appearance" ...................................................................... Reject M3UA with "M3UA Network Appearance" The information element "Network Appearance" is not supported. In case it is included in a received message, an error is sent to the remote peer to indicate this. Additionally a message is sent on the log output. Related: OS#6240 Change-Id: Ia2c2004a7495376fd3f44d26f6cf1b6d277c9b2f --- M src/m3ua.c M src/xua_rkm.c 2 files changed, 61 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/17/37817/8 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/37817?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ia2c2004a7495376fd3f44d26f6cf1b6d277c9b2f Gerrit-Change-Number: 37817 Gerrit-PatchSet: 8 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: ggsn: Split test and relax expectations testing gtpu access over ipv6...
by pespin 19 Aug '24

19 Aug '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37688?usp=email ) Change subject: ggsn: Split test and relax expectations testing gtpu access over ipv6 ll-addr ...................................................................... ggsn: Split test and relax expectations testing gtpu access over ipv6 ll-addr Testing gtpu traffic to some potentially external IP address using the link-local address has no clear usecase and it also depends on the network setup and the implementation of the GGSN. Hence, remove it from the regular test and move it to another test which has a relaxed validation accepting different resolutions. This allows knowing/testing the code path in the GGSN, while accepting different outcomes. Related: OS#6382 Change-Id: Icfae181ba1bb0dfb8a1a15dfe3a1d542ce69d88a --- M ggsn_tests/GGSN_Tests.ttcn 1 file changed, 56 insertions(+), 9 deletions(-) Approvals: pespin: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/ggsn_tests/GGSN_Tests.ttcn b/ggsn_tests/GGSN_Tests.ttcn index 3f373aa..70bb1c3 100644 --- a/ggsn_tests/GGSN_Tests.ttcn +++ b/ggsn_tests/GGSN_Tests.ttcn @@ -1073,15 +1073,6 @@ var OCT16 dns1_addr := f_PCO_extract_proto(ctx.pco_neg, '0003'O); - /* Check if we can use valid link-local src addr. */ - var OCT16 saddr_ll := f_ipv6_link_local(ctx.eua.endUserAddress.endUserAddressIPv6.ipv6_address); - f_send_gtpu(ctx, f_gen_icmpv6_echo(saddr_ll, dns1_addr)); - if (m_ggsn_impl == GGSN_IMPL_OSMOCOM) { - f_wait_icmp6_echo_reply(ctx); - } else { - f_wait_gtpu_fail(ctx); - } - /* Check if we can use valid global src addr, should work */ var OCT16 saddr_glob := f_ipv6_global(ctx.eua.endUserAddress.endUserAddressIPv6.ipv6_address); f_send_gtpu(ctx, f_gen_icmpv6_echo(saddr_glob, dns1_addr)); @@ -1091,6 +1082,61 @@ f_shutdown_helper(); } + /* Same as TC_pdp6_act_deact_gtpu_access, but using the ll addr as src address. + * The ability to reach the DNS IP using this ll-addr is not really + * well-specified, and it really depends on the network/routing setup, + * the address of the DNS server, etc. + * osmo-ggsn (userspace) and open5gs allow using it, but open5gs doesn't support it. + * Also osmo-ggsn (gtp-u kernel module) is unable to use it due to kernel implementation + * constrains, see OS#6382. + * Hence, run the test for completeness to test the GGSN, but expect/allow both behaviors. + */ + testcase TC_pdp6_act_deact_gtpu_access_ll_saddr() runs on GT_CT { + var Gtp1uUnitdata ud; + + f_init(); + var PdpContext ctx := valueof(t_DefinePDP(f_rnd_imsi('26242'H), "1234", c_ApnInet6, valueof(t_EuaIPv6Dyn))); + ctx.pco_req := valueof(ts_PCO_IPv6_DNS); + f_pdp_ctx_act(ctx); + + f_send_gtpu(ctx, f_icmpv6_rs_for_pdp(ctx)); + f_wait_rtr_adv(ctx); + f_send_gtpu(ctx, f_gen_icmpv6_neigh_solicit_for_pdp(ctx)); + + var OCT16 dns1_addr := f_PCO_extract_proto(ctx.pco_neg, '0003'O); + + /* Check if we can use valid link-local src addr. */ + var OCT16 saddr_ll := f_ipv6_link_local(ctx.eua.endUserAddress.endUserAddressIPv6.ipv6_address); + f_send_gtpu(ctx, f_gen_icmpv6_echo(saddr_ll, dns1_addr)); + T_default.start; + alt { + [] GTPU.receive(tr_GTPU_GPDU(g_peer_u, ?)) -> value ud { + var octetstring gpdu := ud.gtpu.gtpu_IEs.g_PDU_IEs.data; + var IPv6_packet ip6 := f_IPv6_dec(gpdu); + if (ip6.header.ver != 6 or ip6.header.nexthead != 58) { + repeat; + } + var PDU_ICMPv6 icmp6 := f_dec_PDU_ICMPv6(ip6.payload); + if (not match(icmp6, (tr_ICMPv6_ERP,tr_ICMPv6_DU))) { + repeat; + } + log("This GGSN does support forwarding link-local source address."); + T_default.stop; + } + [] GTPU.receive(tr_GTPU_GPDU(?, ?)) { repeat; } + [] GTPU.receive { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("Received unexpected GTPU while waiting for ICMPv6: ", (tr_ICMPv6_ERP,tr_ICMPv6_DU))); + } + [] T_default.timeout { + log("This GGSN does NOT support forwarding link-local source address."); + } + } + + f_pdp_ctx_del(ctx, '1'B); + f_shutdown_helper(); + } + /* Check that attempting RA with another ll src addr won't work, packet dropped: */ testcase TC_pdp6_act_deact_gtpu_access_wrong_ll_saddr() runs on GT_CT { f_init(); @@ -2246,6 +2292,7 @@ execute(TC_pdp6_act_deact_pcodns()); execute(TC_pdp6_act_deact_icmp6()); execute(TC_pdp6_act_deact_gtpu_access()); + execute(TC_pdp6_act_deact_gtpu_access_ll_saddr()); execute(TC_pdp6_act_deact_gtpu_access_wrong_ll_saddr()); execute(TC_pdp6_act_deact_gtpu_access_wrong_global_saddr()); execute(TC_pdp6_act_deact_gtpu_access_ipv4_apn6()); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37688?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Icfae181ba1bb0dfb8a1a15dfe3a1d542ce69d88a Gerrit-Change-Number: 37688 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: ggsn: Split test and relax expectations testing gtpu access over ipv6...
by pespin 19 Aug '24

19 Aug '24

Attention is currently required from: laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37688?usp=email ) Change subject: ggsn: Split test and relax expectations testing gtpu access over ipv6 ll-addr ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37688?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Icfae181ba1bb0dfb8a1a15dfe3a1d542ce69d88a Gerrit-Change-Number: 37688 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 19 Aug 2024 13:11:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-sccp[master]: Reject M3UA with "M3UA Network Appearance"
by pespin 19 Aug '24

19 Aug '24

Attention is currently required from: jolly. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/37817?usp=email ) Change subject: Reject M3UA with "M3UA Network Appearance" ...................................................................... Patch Set 7: (1 comment) File src/m3ua.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/37817/comment/6e77a1ff_02fa0488… : PS7, Line 386: if (asp) { tbh, seeing it this way now, imho this logging message most probably belongs to whatever parent is calling this function, not here. The log should be done at the code path where it is detected (hence providing meaningful file+line) instead of here when generating the error message. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/37817?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ia2c2004a7495376fd3f44d26f6cf1b6d277c9b2f Gerrit-Change-Number: 37817 Gerrit-PatchSet: 7 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Mon, 19 Aug 2024 13:09:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in libosmo-sccp[master]: Reject M3UA with "M3UA Network Appearance"
by pespin 19 Aug '24

19 Aug '24

Attention is currently required from: jolly. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/37817?usp=email ) Change subject: Reject M3UA with "M3UA Network Appearance" ...................................................................... Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/37817?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ia2c2004a7495376fd3f44d26f6cf1b6d277c9b2f Gerrit-Change-Number: 37817 Gerrit-PatchSet: 7 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Mon, 19 Aug 2024 13:07:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: sgsn: Fix running with testenv.py podman setup
by pespin 19 Aug '24

19 Aug '24

Attention is currently required from: fixeria, laforge, lynxis lazus, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37862?usp=email ) Change subject: sgsn: Fix running with testenv.py podman setup ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: This fixes TC_attach_pdp_act_user and TC_update_ctx_err_ind_from_ggsn failing in jenkins (running under podman). -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37862?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia0af52f8b7d61c15bdf2b6152fae27dd003d00e8 Gerrit-Change-Number: 37862 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 19 Aug 2024 13:06:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-ttcn3-hacks[master]: sgsn: Fix running with testenv.py podman setup
by pespin 19 Aug '24

19 Aug '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37862?usp=email ) Change subject: sgsn: Fix running with testenv.py podman setup ...................................................................... sgsn: Fix running with testenv.py podman setup The initial testenv.py setup introduced in osmo-ttcn3-hacks.git 6baec93cb85fa8a0051e9aacd0178e90adbfdadc lacked some recent updates to the ttcn3 testsuite setup where a second IP address is added to the container in order to distinguish between RNC and CN in GTPU. Change-Id: Ia0af52f8b7d61c15bdf2b6152fae27dd003d00e8 --- M sgsn/SGSN_Tests.cfg M sgsn/osmo-stp.cfg 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/62/37862/1 diff --git a/sgsn/SGSN_Tests.cfg b/sgsn/SGSN_Tests.cfg index 4f92ac2..365d4cd 100644 --- a/sgsn/SGSN_Tests.cfg +++ b/sgsn/SGSN_Tests.cfg @@ -55,7 +55,7 @@ } SGSN_Tests.mp_ranap_cfg := { { - sctp_addr := { 23908, "127.0.0.103", 2905, "127.0.0.200" } + sctp_addr := { 23908, "127.0.0.104", 2905, "127.0.0.200" } } } SGSN_Tests.mp_hlr_ip := "127.0.0.103" diff --git a/sgsn/osmo-stp.cfg b/sgsn/osmo-stp.cfg index 23c4e8f..e79c298 100644 --- a/sgsn/osmo-stp.cfg +++ b/sgsn/osmo-stp.cfg @@ -39,7 +39,7 @@ xua rkm routing-key-allocation dynamic-permitted asp virt-rnc0-0 23908 2905 m3ua local-ip 127.0.0.200 - remote-ip 127.0.0.103 + remote-ip 127.0.0.104 role sg sctp-role server as virt-rnc0 m3ua -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37862?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia0af52f8b7d61c15bdf2b6152fae27dd003d00e8 Gerrit-Change-Number: 37862 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmo-sccp[master]: Reject M3UA with "M3UA Network Appearance"
by jolly 19 Aug '24

19 Aug '24

Attention is currently required from: pespin. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/37817?usp=email ) Change subject: Reject M3UA with "M3UA Network Appearance" ...................................................................... Patch Set 6: (1 comment) File src/m3ua.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/37817/comment/98fea5b4_de95a643… : PS6, Line 353: if (!xua) { > this can probably be OSMO_ASSERT(xua), but fine anyway. Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/37817?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ia2c2004a7495376fd3f44d26f6cf1b6d277c9b2f Gerrit-Change-Number: 37817 Gerrit-PatchSet: 6 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 Aug 2024 12:40:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmo-sccp[master]: Reject M3UA with "M3UA Network Appearance"
by jolly 19 Aug '24

19 Aug '24

Attention is currently required from: jolly, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sccp/+/37817?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: Reject M3UA with "M3UA Network Appearance" ...................................................................... Reject M3UA with "M3UA Network Appearance" The information element "Network Appearance" is not supported. In case it is included in a received message, an error is sent to the remote peer to indicate this. Additionally a message is sent on the log output. Related: OS#6240 Change-Id: Ia2c2004a7495376fd3f44d26f6cf1b6d277c9b2f --- M src/m3ua.c M src/xua_rkm.c 2 files changed, 68 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/17/37817/7 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/37817?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ia2c2004a7495376fd3f44d26f6cf1b6d277c9b2f Gerrit-Change-Number: 37817 Gerrit-PatchSet: 7 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log August 2024