August 2024 - gerrit-log - lists.osmocom.org

[M] Change in libosmo-sccp[master]: Reject M3UA with "M3UA Network Appearance"
by Jenkins Builder 19 Aug '24

19 Aug '24

Attention is currently required from: jolly. Jenkins Builder has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/37817?usp=email ) Change subject: Reject M3UA with "M3UA Network Appearance" ...................................................................... Patch Set 5: (1 comment) File src/m3ua.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17843): https://gerrit.osmocom.org/c/libosmo-sccp/+/37817/comment/abcf3dd5_d0aa7ecb… : PS5, Line 354: LOGP(DLM3UA, LOGL_NOTICE, "Faild to allocate M3UA MGMT error message.\n"); 'Faild' may be misspelled - perhaps 'Failed'? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/37817?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ia2c2004a7495376fd3f44d26f6cf1b6d277c9b2f Gerrit-Change-Number: 37817 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Mon, 19 Aug 2024 10:41:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in libosmo-sccp[master]: Reject M3UA with "M3UA Network Appearance"
by jolly 19 Aug '24

19 Aug '24

Attention is currently required from: jolly. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sccp/+/37817?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: Reject M3UA with "M3UA Network Appearance" ...................................................................... Reject M3UA with "M3UA Network Appearance" The information element "Network Appearance" is not supported. In case it is included in a received message, an error is sent to the remote peer to indicate this. Additionally a message is sent on the log output. Related: OS#6240 Change-Id: Ia2c2004a7495376fd3f44d26f6cf1b6d277c9b2f --- M src/m3ua.c M src/xua_rkm.c 2 files changed, 66 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/17/37817/5 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/37817?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ia2c2004a7495376fd3f44d26f6cf1b6d277c9b2f Gerrit-Change-Number: 37817 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu>

1 0

[S] Change in osmo-hnbgw[master]: on RUA DT for unknown context, respond with RUA Disconnect
by pespin 19 Aug '24

19 Aug '24

Attention is currently required from: neels. pespin has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/37808?usp=email ) Change subject: on RUA DT for unknown context, respond with RUA Disconnect ...................................................................... Patch Set 2: (1 comment) File src/osmo-hnbgw/hnbgw_rua.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/37808/comment/b9d68cfa_68cd42ab?u… : PS2, Line 292: goto tx_disconnect; I see you are now using it twice, but now we end up with a mixture of early returns and gotos. Let's please have a helper function do "return helper_func()" here to avoid readers going paranoid here with unnecessary gotos. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/37808?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: If0b9a999649c9822f55b42b0cae8408af668e1b8 Gerrit-Change-Number: 37808 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 Aug 2024 10:35:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-hnbgw[master]: on RUA Connect failure, respond with RUA Disconnect
by pespin 19 Aug '24

19 Aug '24

Attention is currently required from: laforge, neels. pespin has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/37807?usp=email ) Change subject: on RUA Connect failure, respond with RUA Disconnect ...................................................................... Patch Set 2: (1 comment) File src/osmo-hnbgw/hnbgw_rua.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/37807/comment/3a994d91_d9f55bc3?u… : PS2, Line 313: tx_disconnect: I find this goto here not really useful and adding complexity to the code, since it's only used in one code path and the function above has no general "return" statement just above. I'd say either move this entire code block directly where it belongs, or put it in a static helper function and call it in the code path where it belongs. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/37807?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Iafb30c31a4c5db53ecdda99a0e0b5937b71e362c Gerrit-Change-Number: 37807 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 19 Aug 2024 10:33:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in osmo-ttcn3-hacks[master]: hnbgw: test for RUA Disconnect when there is no CN
by pespin 19 Aug '24

19 Aug '24

Attention is currently required from: neels. pespin has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37809?usp=email ) Change subject: hnbgw: test for RUA Disconnect when there is no CN ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File hnbgw/HNBGW_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37809/comment/ea95e0bb_d906… : PS1, Line 3015: f_TC_cnpool_compl_l3_list(ps_domain, compl3, {0, 0, 0, 0}, omit, // FIXME failure counter? what about this FIXME? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37809?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2b5c024a395e736538c0c37db40d34f3b8d99991 Gerrit-Change-Number: 37809 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 Aug 2024 10:29:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[L] Change in libosmo-gprs[master]: tests/gmm: Introduce skeleton for gmm_prim_network tests
by pespin 19 Aug '24

19 Aug '24

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/37726?usp=email ) Change subject: tests/gmm: Introduce skeleton for gmm_prim_network tests ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/37726?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I832f16f598f49c18455531fac75367376a3065e6 Gerrit-Change-Number: 37726 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 Aug 2024 10:23:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in libosmo-gprs[master]: gmm: Introduce interface GMMBSSGP
by pespin 19 Aug '24

19 Aug '24

Attention is currently required from: fixeria, lynxis lazus, neels. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/37724?usp=email ) Change subject: gmm: Introduce interface GMMBSSGP ...................................................................... Patch Set 1: (1 comment) File include/osmocom/gprs/gmm/gmm_prim.h: https://gerrit.osmocom.org/c/libosmo-gprs/+/37724/comment/feb7b728_6102c0e0… : PS1, Line 369: /* Alloc primitive for GMMBSSGP SAP: */ > objectively, the names are unusually long indeed. […] The idea at some point (when we stabilize the API) is to have a single alloc API for the entire set of primitives sharing a parent struct. But as mentioned, this can be done at a later point and then be done for all APIs at once, which will be easier, so I really plan to merge this as is for now. Having the way it is now it makes it easier to initial integration since users of the library can easily see which primitives are expected to be pushed to the library and which ones received from it. Having implemented most of the upper layers GPRS stack in the MS side, I found this useful since it's not always clear when/how to use/expect the primitives, and the SGSN code is already too mangled so having it like for now is useful while we develop support for libosmo-gprs on a branch. -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/37724?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I39045833fd43cfe98cb1a3812fbce3fdcaae6dc6 Gerrit-Change-Number: 37724 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 19 Aug 2024 10:23:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in docker-playground[master]: ttcn3-epdg-test: remove latest code path
by pespin 19 Aug '24

19 Aug '24

pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/docker-playground/+/37781?usp=email ) Change subject: ttcn3-epdg-test: remove latest code path ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37781?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I522824a6df3c58d26788c8d9e978759e7ec8a462 Gerrit-Change-Number: 37781 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 Aug 2024 10:15:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: ggsn: Split test and relax expectations testing gtpu access over ipv6...
by pespin 19 Aug '24

19 Aug '24

Attention is currently required from: laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37688?usp=email ) Change subject: ggsn: Split test and relax expectations testing gtpu access over ipv6 ll-addr ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I'll merge this one this afternoon since I saw no complains so far for the last 2 weeks. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37688?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Icfae181ba1bb0dfb8a1a15dfe3a1d542ce69d88a Gerrit-Change-Number: 37688 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 19 Aug 2024 10:08:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-ggsn[master]: ggsn: kernel gtpu: Support updating pdp ctx remote IP address and TEID
by pespin 19 Aug '24

19 Aug '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/37691?usp=email ) Change subject: ggsn: kernel gtpu: Support updating pdp ctx remote IP address and TEID ...................................................................... ggsn: kernel gtpu: Support updating pdp ctx remote IP address and TEID Whenever the SGSN sends the GGSN a UpdatePDPCtxReq, it may offer a new remote IP address or/and remote TEID, eg. because it wants to establish a Direct Tunnel and point the GTPU towards the RNC, or to point it back to itself. If the gtpu kernel is used, osmo-ggsn lacked updating the kernel with the new remote data. The gtp kernel module doesn't provide an efficient/explicit way to update a pdp context keeping the4 same local IP+TEID and changing only the remote remote IP+TEID, hence first destroy the pdp ctx in the gtp kernel module and then recreate it. This fixes test GGSN_Tests_v4_only.TC_pdp4_act_update_teid in ttcn3-ggsn-test-kernel-net-next. Related: OS#6523 Change-Id: I1fc48be5c0f177ccf6fbe97c003b4df44809c0fe --- M ggsn/ggsn.c 1 file changed, 37 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/ggsn/ggsn.c b/ggsn/ggsn.c index e682a26..a6cfc58 100644 --- a/ggsn/ggsn.c +++ b/ggsn/ggsn.c @@ -582,6 +582,41 @@ return 0; } +static int update_context_ind(struct pdp_t *pdp) +{ + char apn_name[256]; + struct gsn_t *gsn = pdp->gsn; + struct ggsn_ctx *ggsn = gsn->priv; + struct apn_ctx *apn; + bool apn_found = false; + int rc; + + if (!osmo_apn_to_str(apn_name, pdp->apn_use.v, pdp->apn_use.l)) { + LOGPPDP(LOGL_ERROR, pdp, "Unable to decode associated APN len=%d buf: %s\n", + pdp->apn_use.l, osmo_hexdump(pdp->apn_use.v, pdp->apn_use.l)); + return gtp_update_context_resp(ggsn->gsn, pdp, GTPCAUSE_MISSING_APN); + } + + llist_for_each_entry (apn, &ggsn->apn_list, list) { + if (strncmp(apn_name, apn->cfg.name, sizeof(apn_name)) != 0) + continue; + apn_found = true; + break; + } + if (!apn_found) { + LOGPPDP(LOGL_ERROR, pdp, "Unable to find associated APN %s\n", apn_name); + return gtp_update_context_resp(ggsn->gsn, pdp, GTPCAUSE_MISSING_APN); + } + + if (apn->cfg.gtpu_mode == APN_GTPU_MODE_KERNEL_GTP) { + /* Update the kernel with the potentially new remote data IP address + TEID */ + gtp_kernel_tunnel_del(pdp, apn->tun.cfg.dev_name); + gtp_kernel_tunnel_add(pdp, apn->tun.cfg.dev_name); + } + rc = gtp_update_context_resp(ggsn->gsn, pdp, GTPCAUSE_ACC_REQ); + return rc; +} + /* Internet-originated IP packet, needs to be sent via GTP towards MS */ static int cb_tun_ind(struct tun_t *tun, void *pack, unsigned len) { @@ -848,8 +883,9 @@ OSMO_ASSERT(rc == 0); gtp_set_cb_data_ind(ggsn->gsn, encaps_tun); - gtp_set_cb_delete_context(ggsn->gsn, delete_context); gtp_set_cb_create_context_ind(ggsn->gsn, create_context_ind); + gtp_set_cb_update_context_ind(ggsn->gsn, update_context_ind); + gtp_set_cb_delete_context(ggsn->gsn, delete_context); gtp_set_cb_conf(ggsn->gsn, cb_conf); gtp_set_cb_recovery3(ggsn->gsn, cb_recovery3); -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/37691?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I1fc48be5c0f177ccf6fbe97c003b4df44809c0fe Gerrit-Change-Number: 37691 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log August 2024