[S] Change in osmo-hnbgw[master]: on RUA DT for unknown context, respond with RUA Disconnect - gerrit-log

19 Aug 2024


      Attention is currently required from: neels.
pespin has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/37808?usp=email )
Change subject: on RUA DT for unknown context, respond with RUA Disconnect
......................................................................
Patch Set 2:
(1 comment)
File src/osmo-hnbgw/hnbgw_rua.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/37808/comment/b9d68cfa_68cd42ab?us... :
PS2, Line 292: 			goto tx_disconnect;
I see you are now using it twice, but now we end up with a mixture of early returns and gotos. Let's please have a helper function do "return helper_func()" here to avoid readers going paranoid here with unnecessary gotos.
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/37808?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: If0b9a999649c9822f55b42b0cae8408af668e1b8
Gerrit-Change-Number: 37808
Gerrit-PatchSet: 2
Gerrit-Owner: neels nhofmeyr@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge laforge@osmocom.org
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: neels nhofmeyr@sysmocom.de
Gerrit-Comment-Date: Mon, 19 Aug 2024 10:35:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No