Attention is currently required from: laforge, neels.

pespin has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-upf/+/37764?usp=email )

Change subject: osmo-pfcp-tool: add GTP flooding using io_uring ......................................................................

Patch Set 6:

(4 comments)

Patchset:

PS4:

• might make sense to change all naming from gtp to gtpu to indicate it's about user-plane GTP flood […]

I agree with Harald that terminology gtpu or gtp1u/gtpv1u should be used in lots of places, otherwise it's difficult to gasp what's gtp1c/gtp2c, what's gtp1u, etc.

File contrib/osmo-pfcp-tool-scripts/gtp_flood.vty:

https://gerrit.osmocom.org/c/osmo-upf/+/37764/comment/1b8592aa_a827229e?usp=... : PS6, Line 1: # Establish N PFCP sessions for tunend, and emit massive GTP traffic to the UPF GTP-U traffic

File src/osmo-pfcp-tool/pfcp_tool.c:

https://gerrit.osmocom.org/c/osmo-upf/+/37764/comment/6abd5aa9_ef46b765?usp=... : PS6, Line 206: LOGP(DLGLOBAL, LOGL_ERROR, "insufficient UE IP addresses, wrapped back to first\n"); this sounds more like a fatal error where program should simply exit with an error? osmo_panic() or alike?

File src/osmo-pfcp-tool/pfcp_tool_vty.c:

https://gerrit.osmocom.org/c/osmo-upf/+/37764/comment/c639826e_7244f1f0?usp=... : PS6, Line 1112: * A local GTP port from osmo-pfcp-tool's point of view. */ GTPv1U port right?