Attention is currently required from: laforge, neels.
4 comments:
Patchset:
* might make sense to change all naming from gtp to gtpu to indicate it's about user-plane GTP flood […]
I agree with Harald that terminology gtpu or gtp1u/gtpv1u should be used in lots of places, otherwise it's difficult to gasp what's gtp1c/gtp2c, what's gtp1u, etc.
File contrib/osmo-pfcp-tool-scripts/gtp_flood.vty:
Patch Set #6, Line 1: # Establish N PFCP sessions for tunend, and emit massive GTP traffic to the UPF
GTP-U traffic
File src/osmo-pfcp-tool/pfcp_tool.c:
Patch Set #6, Line 206: LOGP(DLGLOBAL, LOGL_ERROR, "insufficient UE IP addresses, wrapped back to first\n");
this sounds more like a fatal error where program should simply exit with an error? osmo_panic() or alike?
File src/osmo-pfcp-tool/pfcp_tool_vty.c:
Patch Set #6, Line 1112: * A local GTP port from osmo-pfcp-tool's point of view. */
GTPv1U port right?
To view, visit change 37764. To unsubscribe, or for help writing mail filters, visit settings.