March 2024 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-netif[master]: osmo_stream_cli_write(): fix double-free of msgb

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36159?usp=email ) Change subject: osmo_stream_cli_write(): fix double-free of msgb ...................................................................... osmo_stream_cli_write(): fix double-free of msgb Change-Id: I954678acd90593e5311d22a10033c7741f280be3 Fixes: 48f9a3c2 "stream_cli: Proper handling of send() socket errors" --- M src/stream_cli.c 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/59/36159/1 diff --git a/src/stream_cli.c b/src/stream_cli.c index 1197b53..63da2e1 100644 --- a/src/stream_cli.c +++ b/src/stream_cli.c @@ -301,7 +301,6 @@ llist_add(&msg->list, &cli->tx_queue); return 0; } - msgb_free(msg); osmo_stream_cli_reconnect(cli); } -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36159?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I954678acd90593e5311d22a10033c7741f280be3 Gerrit-Change-Number: 36159 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 0

[M] Change in osmo-mgw[master]: migrate mgcp_client from osmo_wqueue to osmo_io

by laforge

Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/36142?usp=email ) Change subject: migrate mgcp_client from osmo_wqueue to osmo_io ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/36142?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I766224da4691695c023d4d08d042a4bbeba05e47 Gerrit-Change-Number: 36142 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Mon, 04 Mar 2024 19:17:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[M] Change in osmo-bsc[master]: CBSP: Port over to use osmo_io via libosmo-netif

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/36146?usp=email ) Change subject: CBSP: Port over to use osmo_io via libosmo-netif ...................................................................... CBSP: Port over to use osmo_io via libosmo-netif Change-Id: Icce412e6ee69366c7b131c9bc1d51e8d44204917 Depends: libosmocore.git Change-Id I5e922c54b3431d759b38e81e55076125c5a34008 Related: OS#5755 --- M TODO-RELEASE M src/osmo-bsc/cbsp_link.c 2 files changed, 21 insertions(+), 42 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/TODO-RELEASE b/TODO-RELEASE index 7a7ec22..91e8dae 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -8,3 +8,4 @@ # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line libosmocore > 1.9.0 working (compiling) OSMO_SOCKADDR_STR_FMT_ARGS_NOT_NULL +libosmocore > 1.9.0 we use the new osmo_cbsp_segmentation_cb diff --git a/src/osmo-bsc/cbsp_link.c b/src/osmo-bsc/cbsp_link.c index 849b802..98f25d3 100644 --- a/src/osmo-bsc/cbsp_link.c +++ b/src/osmo-bsc/cbsp_link.c @@ -54,7 +54,6 @@ static int cbsp_srv_closed_cb(struct osmo_stream_srv *conn) { struct bsc_cbc_link *cbc = osmo_stream_srv_get_data(conn); - //struct osmo_fd *ofd = osmo_stream_srv_get_ofd(conn); LOGP(DCBS, LOGL_NOTICE, "CBSP Server lost connection from %s\n", cbc->server.sock_name); talloc_free(cbc->server.sock_name); @@ -63,29 +62,11 @@ return 0; } -static int cbsp_srv_cb(struct osmo_stream_srv *conn) +static int cbsp_srv_read_cb(struct osmo_stream_srv *conn, struct msgb *msg) { struct bsc_cbc_link *cbc = osmo_stream_srv_get_data(conn); - struct osmo_fd *ofd = osmo_stream_srv_get_ofd(conn); struct osmo_cbsp_decoded *decoded; - struct msgb *msg; - int rc; - /* READ */ - rc = osmo_cbsp_recv_buffered(cbc, ofd->fd, &msg, &cbc->server.msg); - if (rc <= 0) { - if (rc == -EAGAIN || rc == -EINTR) { - /* more data needs to be read */ - return 0; - } else if (rc == -EPIPE || rc == -ECONNRESET) { - /* lost connection */ - } else if (rc == 0) { - /* connection closed */ - } - osmo_stream_srv_destroy(conn); - cbc->server.srv = NULL; - return -EBADF; - } OSMO_ASSERT(msg); decoded = osmo_cbsp_decode(conn, msg); if (decoded) { @@ -117,12 +98,15 @@ return -1; } - srv = osmo_stream_srv_create(cbc, link, fd, cbsp_srv_cb, cbsp_srv_closed_cb, cbc); + srv = osmo_stream_srv_create2(cbc, link, fd, cbc); if (!srv) { LOGP(DCBS, LOGL_ERROR, "Unable to create stream server for %s\n", osmo_sock_get_name2(fd)); return -1; } + osmo_stream_srv_set_read_cb(srv, cbsp_srv_read_cb); + osmo_stream_srv_set_closed_cb(srv, cbsp_srv_closed_cb); + osmo_stream_srv_set_segmentation_cb(srv, osmo_cbsp_segmentation_cb); cbc->server.srv = srv; if (cbc->server.sock_name) @@ -141,11 +125,10 @@ static int cbsp_client_connect_cb(struct osmo_stream_cli *cli) { struct bsc_cbc_link *cbc = osmo_stream_cli_get_data(cli); - struct osmo_fd *ofd = osmo_stream_cli_get_ofd(cli); if (cbc->client.sock_name) talloc_free(cbc->client.sock_name); - cbc->client.sock_name = osmo_sock_get_name(cbc, ofd->fd); + cbc->client.sock_name = osmo_sock_get_name(cbc, osmo_stream_cli_get_fd(cli)); LOGP(DCBS, LOGL_NOTICE, "CBSP Client connected to CBC: %s\n", cbc->client.sock_name); @@ -165,28 +148,11 @@ return 0; } -static int cbsp_client_read_cb(struct osmo_stream_cli *cli) +static int cbsp_client_read_cb(struct osmo_stream_cli *cli, struct msgb *msg) { struct bsc_cbc_link *cbc = osmo_stream_cli_get_data(cli); - struct osmo_fd *ofd = osmo_stream_cli_get_ofd(cli); struct osmo_cbsp_decoded *decoded; - struct msgb *msg = NULL; - int rc; - /* READ */ - rc = osmo_cbsp_recv_buffered(cbc, ofd->fd, &msg, &cbc->client.msg); - if (rc <= 0) { - if (rc == -EAGAIN || rc == -EINTR) { - /* more data needs to be read */ - return 0; - } else if (rc == -EPIPE || rc == -ECONNRESET) { - /* lost connection */ - } else if (rc == 0) { - /* connection closed */ - } - osmo_stream_cli_reconnect(cli); - return -EBADF; - } OSMO_ASSERT(msg); decoded = osmo_cbsp_decode(cli, msg); if (decoded) { @@ -244,7 +210,8 @@ osmo_stream_cli_set_data(cbc->client.cli, cbc); osmo_stream_cli_set_connect_cb(cbc->client.cli, cbsp_client_connect_cb); osmo_stream_cli_set_disconnect_cb(cbc->client.cli, cbsp_client_disconnect_cb); - osmo_stream_cli_set_read_cb(cbc->client.cli, cbsp_client_read_cb); + osmo_stream_cli_set_read_cb2(cbc->client.cli, cbsp_client_read_cb); + osmo_stream_cli_set_segmentation_cb(cbc->client.cli, osmo_cbsp_segmentation_cb); } /* CBC side */ osmo_stream_cli_set_addr(cbc->client.cli, cbc->client.remote_addr.ip); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/36146?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icce412e6ee69366c7b131c9bc1d51e8d44204917 Gerrit-Change-Number: 36146 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

[M] Change in osmo-bsc[master]: CBSP: Port over to use osmo_io via libosmo-netif

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/36146?usp=email ) Change subject: CBSP: Port over to use osmo_io via libosmo-netif ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/36146?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icce412e6ee69366c7b131c9bc1d51e8d44204917 Gerrit-Change-Number: 36146 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Mar 2024 19:16:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in libosmo-sccp[master]: ipa: Use pseudo-random number for SLS in IPA->M3UA direction

by laforge

Attention is currently required from: fixeria, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/36115?usp=email ) Change subject: ipa: Use pseudo-random number for SLS in IPA->M3UA direction ...................................................................... Patch Set 3: (1 comment) File src/osmo_ss7_asp.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/36115/comment/a7851c42_0de02873 PS2, Line 990: asp->asp_id = rand() & 0xf; > I see you are "using" it here. […] yes. I didn't want to break ABI. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/36115?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ia4e66d660b6057338f66a47fffc8a0d32759f733 Gerrit-Change-Number: 36115 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Mar 2024 19:15:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[M] Change in libosmocore[master]: osmo_io: Remove union in struct osmo_io_ops

by laforge

laforge has abandoned this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35079?usp=email ) Change subject: osmo_io: Remove union in struct osmo_io_ops ...................................................................... Abandoned superseded by I9d302df8d00369e7b30437a52deb205f75882be3 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35079?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I138d57843edc29000530bb7896bcb239002ecbec Gerrit-Change-Number: 35079 Gerrit-PatchSet: 4 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: abandon

1 year, 5 months

1
0
0 0

[M] Change in libosmocore[master]: osmo_io: Remove union in struct osmo_io_ops

by laforge

Attention is currently required from: arehbein, daniel, neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35079?usp=email ) Change subject: osmo_io: Remove union in struct osmo_io_ops ...................................................................... Patch Set 4: (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/35079/comment/572dad2d_287fe761 PS4, Line 11: from distinguishing between write_cb() and sendto_cb() etc. > AFAIU, iofd->mode should distinguish which union members are in use, so it should be possible to han […] it is not possible to do what you are asking. the various structs in th union all alias to the exact same address. So whether I look at read_cb or recvfrom_cb or recvmsg_cb, they all are at the exact same address in memory. Hence the reason for this patch 😊 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35079?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I138d57843edc29000530bb7896bcb239002ecbec Gerrit-Change-Number: 35079 Gerrit-PatchSet: 4 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Mar 2024 19:14:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: various: update expected-results.xml

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36157?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: various: update expected-results.xml ...................................................................... various: update expected-results.xml Change-Id: I21052636bf892e5da86ef736d16035ec324aedbe --- M bsc/expected-results.xml M hlr/expected-results.xml M hnbgw/expected-results.xml M mgw/expected-results.xml M pcu/expected-results.xml M pgw/expected-results.xml M sgsn/expected-results.xml M sip/expected-results.xml M upf/expected-results.xml 9 files changed, 74 insertions(+), 17 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/bsc/expected-results.xml b/bsc/expected-results.xml index eaa863b..2d69eee 100644 --- a/bsc/expected-results.xml +++ b/bsc/expected-results.xml @@ -1,5 +1,5 @@ <?xml version="1.0"?> -<testsuite name='BSC_Tests' tests='297' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'> +<testsuite name='BSC_Tests' tests='317' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'> <testcase classname='BSC_Tests' name='TC_ctrl_msc_connection_status' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_ctrl_msc0_connection_status' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_stat_num_msc_connected_1' time='MASKED'/> @@ -24,6 +24,7 @@ <testcase classname='BSC_Tests' name='TC_si2quater_49_earfcns' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_si_acc_rotate' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_si_acc_ramp_rotate' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_si2_ncc_permitted' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_chan_act_noreply' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_chan_act_counter' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_chan_act_ack_noest' time='MASKED'/> @@ -219,6 +220,8 @@ <testcase classname='BSC_Tests' name='TC_mscpool_paging_and_response_tmsi' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_mscpool_no_allow_attach_round_robin' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_mscpool_no_allow_attach_valid_nri' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_mscpool_sccp_n_pcstate_detaches_msc' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_mscpool_sccp_n_pcstate_attaches_msc' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_early_conn_fail' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_late_conn_fail' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_stats_conn_fail' time='MASKED'/> @@ -264,10 +267,12 @@ <testcase classname='BSC_Tests' name='TC_chan_alloc_algo_ass_dynamic' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_mgwpool_all_used' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_mgwpool_blocked_not_used' time='MASKED'/> - <testcase classname='BSC_Tests' name='TC_mgwpool_keepalive_down_not_used' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_mgwpool_pin_bts' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_mgwpool_keepalive_down_not_used' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_ho_meas_rep_multi_band' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_ho_out_of_this_bsc' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_unbreak_lchan_after_missing_rel_ack_1' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_unbreak_lchan_after_missing_rel_ack_2' time='MASKED'/> <testcase classname='BSC_Tests_LCLS' name='TC_lcls_gcr_only' time='MASKED'/> <testcase classname='BSC_Tests_LCLS' name='TC_lcls_gcr_bway_connect' time='MASKED'/> <testcase classname='BSC_Tests_LCLS' name='TC_lcls_gcr_bway_connect_hr' time='MASKED'/> diff --git a/hlr/expected-results.xml b/hlr/expected-results.xml index 2175a81..0ed9798 100644 --- a/hlr/expected-results.xml +++ b/hlr/expected-results.xml @@ -1,11 +1,12 @@ <?xml version="1.0"?> -<testsuite name='Titan' tests='37' failures='5' errors='0' skipped='0' inconc='0' time='MASKED'> +<testsuite name='Titan' tests='38' failures='3' errors='2' skipped='0' inconc='0' time='MASKED'> <testcase classname='HLR_Tests' name='TC_gsup_sai_err_invalid_imsi' time='MASKED'/> <testcase classname='HLR_Tests' name='TC_gsup_sai' time='MASKED'/> <testcase classname='HLR_Tests' name='TC_gsup_sai_num_auth_vectors' time='MASKED'/> <testcase classname='HLR_Tests' name='TC_gsup_sai_eps' time='MASKED'/> <testcase classname='HLR_Tests' name='TC_gsup_ul_unknown_imsi' time='MASKED'/> <testcase classname='HLR_Tests' name='TC_gsup_ul_unknown_imsi_via_proxy' time='MASKED'/> + <testcase classname='HLR_Tests' name='TC_gsup_ul_unknown_imsi_roaming_not_allowed' time='MASKED'/> <testcase classname='HLR_Tests' name='TC_gsup_sai_err_unknown_imsi' time='MASKED'/> <testcase classname='HLR_Tests' name='TC_gsup_ul' time='MASKED'/> <testcase classname='HLR_Tests' name='TC_gsup_ul_via_proxy' time='MASKED'/> diff --git a/hnbgw/expected-results.xml b/hnbgw/expected-results.xml index fb86108..a48c232 100644 --- a/hnbgw/expected-results.xml +++ b/hnbgw/expected-results.xml @@ -1,8 +1,8 @@ <?xml version="1.0"?> -<testsuite name='Titan' tests='13' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'> +<testsuite name='Titan' tests='42' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'> <testcase classname='HNBGW_Tests' name='TC_hnb_register' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_hnb_register_duplicate' time='MASKED'/> - <testcase classname='HNBGW_Tests' name='TC_hnb_register_duplicate_reuse_sctp_assoc' time='MASKED' + <testcase classname='HNBGW_Tests' name='TC_hnb_register_duplicate_reuse_sctp_assoc' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_ranap_cs_initial_ue' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_ranap_ps_initial_ue' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_ranap_cs_initial_ue_empty_cr' time='MASKED'/> @@ -17,5 +17,29 @@ <testcase classname='HNBGW_Tests' name='TC_ranap_cs_mo_disconnect' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_ranap_ps_mo_disconnect' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_ps_rab_assignment_without_pfcp' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_mscpool_L3Compl_on_1_cnlink' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_mscpool_L3Complete_by_imsi_round_robin' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_mscpool_LU_by_tmsi_null_nri_0_round_robin' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_mscpool_LU_by_tmsi_null_nri_1_round_robin' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_mscpool_L3Complete_by_tmsi_unassigned_nri_round_robin' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_mscpool_L3Complete_by_tmsi_valid_nri_msc_not_connected_round_robin' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_mscpool_L3Complete_by_tmsi_valid_nri_1' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_mscpool_L3Complete_by_tmsi_valid_nri_2' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_mscpool_LU_by_tmsi_from_other_PLMN' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_mscpool_paging_imsi' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_mscpool_paging_tmsi' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_mscpool_no_allow_attach_round_robin' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_mscpool_no_allow_attach_valid_nri' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_mscpool_sccp_n_pcstate_detaches_cnlink' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_mscpool_sccp_n_pcstate_attaches_cnlink' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_sgsnpool_L3Compl_on_1_cnlink' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_sgsnpool_L3Complete_no_nri_round_robin' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_sgsnpool_L3Complete_valid_nri_1' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_sgsnpool_L3Complete_valid_nri_2' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_sgsnpool_nri_from_other_PLMN' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_sgsnpool_sccp_n_pcstate_detaches_cnlink' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_sgsnpool_sccp_n_pcstate_attaches_cnlink' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_second_rab_assignment' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_hnb_reregister_reuse_sctp_assoc' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_apply_sccp' time='MASKED'/> </testsuite> diff --git a/mgw/expected-results.xml b/mgw/expected-results.xml index 3c438bd..d9b9a15 100644 --- a/mgw/expected-results.xml +++ b/mgw/expected-results.xml @@ -1,5 +1,5 @@ <?xml version="1.0"?> -<testsuite name='Titan' tests='71' failures='8' errors='0' skipped='0' inconc='0' time='MASKED'> +<testsuite name='Titan' tests='84' failures='5' errors='0' skipped='0' inconc='0' time='MASKED'> <testcase classname='MGCP_Test' name='TC_selftest' time='MASKED'/> <testcase classname='MGCP_Test' name='TC_auep_null' time='MASKED'/> <testcase classname='MGCP_Test' name='TC_crcx' time='MASKED'/> @@ -35,6 +35,7 @@ <testcase classname='MGCP_Test' name='TC_one_crcx_loopback_osmux' time='MASKED'/> <testcase classname='MGCP_Test' name='TC_two_crcx_and_rtp_osmux' time='MASKED'/> <testcase classname='MGCP_Test' name='TC_two_crcx_and_rtp_osmux_bidir' time='MASKED'/> + <testcase classname='MGCP_Test' name='TC_two_crcx_and_rtp_osmux_bidir_amr_bwe' time='MASKED'/> <testcase classname='MGCP_Test' name='TC_two_crcx_mdcx_and_rtp_osmux_wildcard' time='MASKED'/> <testcase classname='MGCP_Test' name='TC_two_crcx_mdcx_and_rtp_osmux_fixed' time='MASKED'/> <testcase classname='MGCP_Test' name='TC_crcx_dlcx_30ep' time='MASKED'/> @@ -49,10 +50,16 @@ <testcase classname='MGCP_Test' name='TC_two_crcx_mdcx_and_rtp' time='MASKED'/> <testcase classname='MGCP_Test' name='TC_two_crcx_and_unsolicited_rtp' time='MASKED'/> <testcase classname='MGCP_Test' name='TC_two_crcx_and_one_mdcx_rtp_ho' time='MASKED'/> + <testcase classname='MGCP_Test' name='TC_two_crcx_confecho_sendonly_rtp' time='MASKED'/> <testcase classname='MGCP_Test' name='TC_ts101318_rfc5993_rtp_conversion' time='MASKED'/> + <testcase classname='MGCP_Test' name='TC_ts101318_rfc5993_rtp_conversion_fmtp' time='MASKED'/> <testcase classname='MGCP_Test' name='TC_amr_oa_bwe_rtp_conversion' time='MASKED'/> <testcase classname='MGCP_Test' name='TC_amr_oa_oa_rtp_conversion' time='MASKED'/> <testcase classname='MGCP_Test' name='TC_amr_bwe_bwe_rtp_conversion' time='MASKED'/> + <testcase classname='MGCP_Test' name='TC_amr_oa_oa_no_bwe_rtp_conversion' time='MASKED'/> + <testcase classname='MGCP_Test' name='TC_amr_oa_no_bwe_oa_rtp_conversion' time='MASKED'/> + <testcase classname='MGCP_Test' name='TC_amr_bwe_bwe_no_oa_rtp_conversion' time='MASKED'/> + <testcase classname='MGCP_Test' name='TC_amr_bwe_no_oa_bwe_rtp_conversion' time='MASKED'/> <testcase classname='MGCP_Test' name='TC_conn_timeout' time='MASKED'/> <testcase classname='MGCP_Test' name='TC_e1_crcx_and_dlcx_ep' time='MASKED'> <failure type='fail-verdict'>Response didn't match template @@ -82,15 +89,15 @@ <testcase classname='MGCP_Test' name='TC_crcx_mdcx_ip6' time='MASKED'/> <testcase classname='MGCP_Test' name='TC_two_crcx_mdcx_and_rtp_ipv4_ipv6' time='MASKED'/> <testcase classname='MGCP_Test' name='TC_two_crcx_mdcx_and_rtp_ipv6' time='MASKED'/> - <testcase classname='MGCP_Test' name='TC_two_crcx_and_rtp_osmux_bidir_ipv6' time='MASKED' /> - <testcase classname='MGCP_Test' name='TC_two_crcx_and_rtp_osmux_bidir_ipv4_ipv6' time='MASKED' /> + <testcase classname='MGCP_Test' name='TC_two_crcx_and_rtp_osmux_bidir_ipv6' time='MASKED'/> + <testcase classname='MGCP_Test' name='TC_two_crcx_and_rtp_osmux_bidir_ipv4_ipv6' time='MASKED'/> <testcase classname='MGCP_Test' name='TC_two_crcx_and_rtp_osmux_bidir_ipv6_ipv4' time='MASKED'/> - <testcase classname='MGCP_Test' name='TC_two_crcx_mdcx_and_rtp_osmux_ipv6' time='MASKED' /> - <testcase classname='MGCP_Test' name='TC_two_crcx_mdcx_and_rtp_osmux_ipv4_ipv6' time='MASKED' /> + <testcase classname='MGCP_Test' name='TC_two_crcx_mdcx_and_rtp_osmux_ipv6' time='MASKED'/> + <testcase classname='MGCP_Test' name='TC_two_crcx_mdcx_and_rtp_osmux_ipv4_ipv6' time='MASKED'/> <testcase classname='MGCP_Test' name='TC_two_crcx_mdcx_and_rtp_osmux_ipv6_ipv4' time='MASKED'/> <testcase classname='MGCP_Test' name='TC_two_crcx_mdcx_and_iuup' time='MASKED'/> - <testcase classname='MGCP_Test' name='TC_two_crcx_mdcx_and_iuup_mdcx_recvonly' time='MASKED'/> <testcase classname='MGCP_Test' name='TC_two_crcx_mdcx_and_iuup_rfci_unordered' time='MASKED'/> + <testcase classname='MGCP_Test' name='TC_two_crcx_mdcx_and_iuup_mdcx_recvonly' time='MASKED'/> <testcase classname='MGCP_Test' name='TC_two_crcx_mdcx_and_iuup_rtp' time='MASKED'/> <testcase classname='MGCP_Test' name='TC_two_crcx_mdcx_and_iuup_rtp_rfci_unordered' time='MASKED'/> <testcase classname='MGCP_Test' name='TC_two_crcx_mdcx_and_iuup_rtp_mdcx_recvonly' time='MASKED'/> diff --git a/pcu/expected-results.xml b/pcu/expected-results.xml index 2a25934..17d95cc 100644 --- a/pcu/expected-results.xml +++ b/pcu/expected-results.xml @@ -1,5 +1,5 @@ <?xml version="1.0"?> -<testsuite name='Titan' tests='110' failures='4' errors='0' skipped='0' inconc='0' time='MASKED'> +<testsuite name='Titan' tests='117' failures='5' errors='0' skipped='0' inconc='0' time='MASKED'> <testcase classname='PCU_Tests' name='TC_pcuif_suspend' time='MASKED'/> <testcase classname='PCU_Tests' name='TC_pcuif_suspend_active_tbf' time='MASKED'/> <testcase classname='PCU_Tests' name='TC_ta_ptcch_idle' time='MASKED'/> @@ -108,6 +108,8 @@ <testcase classname='PCU_Tests' name='TC_multiplex_dl_gprs_egprs' time='MASKED'/> <testcase classname='PCU_Tests' name='TC_pcuif_info_ind_subsequent' time='MASKED'/> <testcase classname='PCU_Tests' name='TC_nacc_outbound_success' time='MASKED'/> + <testcase classname='PCU_Tests' name='TC_nacc_outbound_success_utran' time='MASKED'/> + <testcase classname='PCU_Tests' name='TC_nacc_outbound_success_eutran' time='MASKED'/> <testcase classname='PCU_Tests' name='TC_nacc_outbound_success_no_ctrl_ack' time='MASKED'/> <testcase classname='PCU_Tests' name='TC_nacc_outbound_success_twice' time='MASKED'/> <testcase classname='PCU_Tests' name='TC_nacc_outbound_success_twice_nocache' time='MASKED'/> diff --git a/pgw/expected-results.xml b/pgw/expected-results.xml index 35d0ce9..20c073b 100644 --- a/pgw/expected-results.xml +++ b/pgw/expected-results.xml @@ -1,5 +1,5 @@ <?xml version="1.0"?> -<testsuite name='Titan' tests='7' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'> +<testsuite name='Titan' tests='9' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'> <testcase classname='PGW_Tests' name='TC_tx_echo' time='MASKED'/> <testcase classname='PGW_Tests' name='TC_createSession' time='MASKED'/> <testcase classname='PGW_Tests' name='TC_createSession_ping4' time='MASKED'/> diff --git a/sgsn/expected-results.xml b/sgsn/expected-results.xml index 35b2926..bef13dc 100644 --- a/sgsn/expected-results.xml +++ b/sgsn/expected-results.xml @@ -1,5 +1,5 @@ <?xml version="1.0"?> -<testsuite name='Titan' tests='73' failures='4' errors='0' skipped='0' inconc='0' time='MASKED'> +<testsuite name='Titan' tests='74' failures='4' errors='0' skipped='0' inconc='0' time='MASKED'> <testcase classname='SGSN_Tests' name='TC_attach' time='MASKED'/> <testcase classname='SGSN_Tests' name='TC_attach_mnc3' time='MASKED'/> <testcase classname='SGSN_Tests' name='TC_attach_umts_aka_umts_res' time='MASKED'/> diff --git a/sip/expected-results.xml b/sip/expected-results.xml index 87895ba..1d2b670 100644 --- a/sip/expected-results.xml +++ b/sip/expected-results.xml @@ -1,5 +1,5 @@ <?xml version="1.0"?> -<testsuite name='Titan' tests='7' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'> +<testsuite name='Titan' tests='9' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'> <testcase classname='SIP_Tests' name='TC_mt_success_rel_gsm' time='MASKED'/> <testcase classname='SIP_Tests' name='TC_mt_success_rel_gsm_ipv6' time='MASKED'/> <testcase classname='SIP_Tests' name='TC_mt_success_rel_sip' time='MASKED'/> @@ -7,4 +7,6 @@ <testcase classname='SIP_Tests' name='TC_mo_success_rel_gsm_ipv6' time='MASKED'/> <testcase classname='SIP_Tests' name='TC_mo_success_rel_sip' time='MASKED'/> <testcase classname='SIP_Tests' name='TC_mo_setup_disc_late_rtp' time='MASKED'/> + <testcase classname='SIP_Tests' name='TC_mt_with_sdp' time='MASKED'/> + <testcase classname='SIP_Tests' name='TC_mo_with_sdp' time='MASKED'/> </testsuite> diff --git a/upf/expected-results.xml b/upf/expected-results.xml index 3504126..78f0103 100644 --- a/upf/expected-results.xml +++ b/upf/expected-results.xml @@ -1,4 +1,11 @@ <?xml version="1.0"?> -<testsuite name='UPF_Tests' tests='0' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'> - +<testsuite name='UPF_Tests' tests='8' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'> + <testcase classname='UPF_Tests' name='TC_assoc_node_id_v4' time='MASKED'/> + <testcase classname='UPF_Tests' name='TC_assoc_node_id_fqdn' time='MASKED'/> + <testcase classname='UPF_Tests' name='TC_session_est_tunend' time='MASKED'/> + <testcase classname='UPF_Tests' name='TC_session_term_by_assoc_rel' time='MASKED'/> + <testcase classname='UPF_Tests' name='TC_session_est_noop' time='MASKED'/> + <testcase classname='UPF_Tests' name='TC_session_est_tunmap' time='MASKED'/> + <testcase classname='UPF_Tests' name='TC_session_est_mod_tunmap' time='MASKED'/> + <testcase classname='UPF_Tests' name='TC_session_est_mod_tunmap2' time='MASKED'/> </testsuite> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36157?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I21052636bf892e5da86ef736d16035ec324aedbe Gerrit-Change-Number: 36157 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: stp: Add expected-results.xml

by laforge

laforge has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36156?usp=email ) Change subject: stp: Add expected-results.xml ...................................................................... Abandoned duplicate of Id4081af9e9d5b0a95dc2fe7d137778747dc27bd0 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36156?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3346f7c50f332136380d184b43fe173c28cad778 Gerrit-Change-Number: 36156 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: abandon

1 year, 5 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: stp: check-in expected-results.xml from Jenkins

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36147?usp=email ) Change subject: stp: check-in expected-results.xml from Jenkins ...................................................................... stp: check-in expected-results.xml from Jenkins Change-Id: Id4081af9e9d5b0a95dc2fe7d137778747dc27bd0 --- A stp/expected-results.xml 1 file changed, 58 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/stp/expected-results.xml b/stp/expected-results.xml new file mode 100644 index 0000000..0f6073b --- /dev/null +++ b/stp/expected-results.xml @@ -0,0 +1,49 @@ +<?xml version="1.0"?> +<testsuite name='STP_Tests' tests='46' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'> + <testcase classname='STP_Tests_M3UA' name='TC_connect_asp_up' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_beat' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_beat_payload' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_asp_act' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_asp_act_override' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_asp_act_loadshare' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_asp_act_broadcast' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_tmt_override' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_tmt_loadshare' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_tmt_broadcast' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_act_rctx_data_no_rctx' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_rkm_reg_static_notpermitted' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_rkm_reg_static_permitted' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_rkm_reg_dynamic_permitted' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_rkm_unreg_never_registered' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_rkm_unreg_invalid' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_rkm_unreg_registered' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_rkm_unreg_active' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_clnt_connect_asp_up' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_clnt_asp_act' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_clnt_sg_to_asp' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_clnt_asp_to_sg' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_clnt_sg_to_asp_norctx' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_clnt_asp_to_sg_norctx' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_clnt_quirk_no_notify_asp_act' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_clnt_no_daud_in_asp' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_clnt_quirk_daud_in_asp' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_clnt_no_snm_inactive' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_clnt_quirk_snm_inactive' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_ssnm_aspac_dava_aspia_duna' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_ssnm_distribution_dava_duna' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_ssnm_distribution_dava_duna_multipc' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_ssnm_distribution_dupu' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_ssnm_distribution_scon' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_clnt_asp_act_tmt_loadshare' time='MASKED'/> + <testcase classname='STP_Tests_IPA' name='TC_unknown_client_nodynamic' time='MASKED'/> + <testcase classname='STP_Tests_IPA' name='TC_known_client_nodynamic' time='MASKED'/> + <testcase classname='STP_Tests_IPA' name='TC_unknown_client_dynamic' time='MASKED'/> + <testcase classname='STP_Tests_IPA' name='TC_tmt_override' time='MASKED'/> + <testcase classname='STP_Tests_IPA' name='TC_unknown_client_dynamic_tmt_override' time='MASKED'/> + <testcase classname='STP_Tests_IPA' name='TC_tmt_loadshare' time='MASKED'/> + <testcase classname='STP_Tests_IPA' name='TC_unknown_client_dynamic_tmt_loadshare' time='MASKED'/> + <testcase classname='STP_Tests' name='TC_m3ua_to_ipa' time='MASKED'/> + <testcase classname='STP_Tests' name='TC_ipa_to_m3ua' time='MASKED'/> + <testcase classname='STP_Tests' name='TC_ipa_to_m3ua_ni' time='MASKED'/> + <testcase classname='STP_Tests' name='TC_ipa_to_m3ua_patch_sccp' time='MASKED'/> +</testsuite> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36147?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id4081af9e9d5b0a95dc2fe7d137778747dc27bd0 Gerrit-Change-Number: 36147 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2024