Attention is currently required from: pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: DIAMETER_Types: Generate types for 3GPP TS 29.273
......................................................................
DIAMETER_Types: Generate types for 3GPP TS 29.273
Change-Id: I17f7f025ff31d9ce619cd23bfa5f1af282969dbf
---
M library/DIAMETER_Types.ttcn
M library/regen-DIAMETER_Types_ttcn.sh
2 files changed, 547 insertions(+), 108 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/62/36162/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I17f7f025ff31d9ce619cd23bfa5f1af282969dbf
Gerrit-Change-Number: 36162
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36161?usp=email )
Change subject: Remove unwanted epdg/ICMP_Types.ttcn
......................................................................
Remove unwanted epdg/ICMP_Types.ttcn
It seems I somehow ended up adding this link file in
bf03d7764938ee7e109c60eaecf4991fbcda2038 when submitting the patch.
Get rid of it since it is totally undesired.
Change-Id: Iec812841bc474ae423b447707adc520cf4039499
---
D epdg/ICMP_Types.ttcn
1 file changed, 13 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/61/36161/1
diff --git a/epdg/ICMP_Types.ttcn b/epdg/ICMP_Types.ttcn
deleted file mode 120000
index 361cad1..0000000
--- a/epdg/ICMP_Types.ttcn
+++ /dev/null
@@ -1 +0,0 @@
-../deps/titan.ProtocolModules.ICMP/src/ICMP_Types.ttcn
\ No newline at end of file
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36161?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iec812841bc474ae423b447707adc520cf4039499
Gerrit-Change-Number: 36161
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newchange
Attention is currently required from: daniel, fixeria.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36159?usp=email )
Change subject: osmo_stream_cli_write(): fix double-free of msgb
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
Patchset:
PS1:
before
PS1:
> I guess it may be that we actually want to return at the end of that 'ret < 0' clause? not sure if r […]
before I462cb176ebc51f3e99ee796310e8665144c84ccc was introduced by pespin in August 2023, we did return from the clause (at least in EAGAIN case).
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36159?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I954678acd90593e5311d22a10033c7741f280be3
Gerrit-Change-Number: 36159
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 05 Mar 2024 10:25:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment