gerrit-log March 2024

gerrit-log@lists.osmocom.org

1 participants
2054 discussions

[S] Change in osmo-msc[master]: libsmpputil: fix -Wtautological-constant-out-of-range-compare

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35966?usp=email ) Change subject: libsmpputil: fix -Wtautological-constant-out-of-range-compare ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35966?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ia71a0b6b9421911dc5113782d2f555a640fd90ed Gerrit-Change-Number: 35966 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Mar 2024 07:11:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

[S] Change in osmo-msc[master]: msc_a_up_call_assignment_complete(): handle all CSD modes

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35881?usp=email ) Change subject: msc_a_up_call_assignment_complete(): handle all CSD modes ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35881?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I92f7ab11ebc2e53700b27c38e91679c2c6f72050 Gerrit-Change-Number: 35881 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Mar 2024 07:11:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

[S] Change in osmo-msc[master]: libvlr: fix auth_fsm_term(): use proper value-string for cause

by fixeria

Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35964?usp=email ) Change subject: libvlr: fix auth_fsm_term(): use proper value-string for cause ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35964?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ia0868dce2da5cb78c30cf518870c3d91144499b9 Gerrit-Change-Number: 35964 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Mar 2024 07:11:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

[S] Change in pysim[master]: Revert "tlv: Fix from_dict() symmetry"

by lynxis lazus

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/36127?usp=email ) Change subject: Revert "tlv: Fix from_dict() symmetry" ...................................................................... Revert "tlv: Fix from_dict() symmetry" This reverts commit a9b21bdb1f24e3eabcee82950e4a3efdb90b2fa9. The ara-m applet interface got broken by it. Change-Id: I1710bf9124acf7952d3231b104407e9ac998d6a8 --- M pySim/tlv.py 1 file changed, 16 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/27/36127/1 diff --git a/pySim/tlv.py b/pySim/tlv.py index 8bf43c6..bfaab6b 100644 --- a/pySim/tlv.py +++ b/pySim/tlv.py @@ -153,13 +153,13 @@ def from_dict(self, decoded: dict): """Set the IE internal decoded representation to data from the argument. If this is a nested IE, the child IE instance list is re-created.""" - expected_key_name = camel_to_snake(type(self).__name__) - if not expected_key_name in decoded: - raise ValueError("Dict %s doesn't contain expected key %s" % (decoded, expected_key_name)) if self.nested_collection: - self.children = self.nested_collection.from_dict(decoded[expected_key_name]) + self.children = self.nested_collection.from_dict(decoded) else: self.children = [] + expected_key_name = camel_to_snake(type(self).__name__) + if not expected_key_name in decoded: + raise ValueError("Dict %s doesn't contain expected key %s" % (decoded, expected_key_name)) self.decoded = decoded[expected_key_name] def is_constructed(self): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36127?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I1710bf9124acf7952d3231b104407e9ac998d6a8 Gerrit-Change-Number: 36127 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newchange

1 year, 5 months

Jump to page:

2025

2024

2023

2022

gerrit-log March 2024