Attention is currently required from: laforge.
jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36123?usp=email )
Change subject: stream_cli: Do not try to send msg, if not connected
......................................................................
Patch Set 3:
(1 comment)
File src/stream_cli.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/36123/comment/37356515_8f5c4ada
PS3, Line 999: LOGSCLI(cli, LOGL_ERROR, "Not connected with srv.\n");
> I think this message is not really telling the user anything useful. […]
Done
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36123?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I9e5f5db9b45615dacb05115c4de8ff3f715815c8
Gerrit-Change-Number: 36123
Gerrit-PatchSet: 3
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Fri, 01 Mar 2024 09:37:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/36061?usp=email )
Change subject: doc: fix typo ndoe -> node
......................................................................
doc: fix typo ndoe -> node
Change-Id: Ib78b5de45b93a7534163de2cd91211e9be75445d
---
M doc/manuals/chapters/configuration.adoc
1 file changed, 15 insertions(+), 6 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/doc/manuals/chapters/configuration.adoc b/doc/manuals/chapters/configuration.adoc
index e87e5b0..5314d10 100644
--- a/doc/manuals/chapters/configuration.adoc
+++ b/doc/manuals/chapters/configuration.adoc
@@ -101,7 +101,7 @@
----
<1> Change into privileged mode
<2> Enter the interactive configuration mode
-<3> Enter the config ndoe of the GGSN instance `ggsn0`
+<3> Enter the config node of the GGSN instance `ggsn0`
<4> Take the GGSN instance out of shutdown
@@ -121,7 +121,7 @@
----
<1> Change into privileged mode
<2> Enter the interactive configuration mode
-<3> Enter the config ndoe of the GGSN instance `ggsn0`
+<3> Enter the config node of the GGSN instance `ggsn0`
<4> Shut down the GGSN instance
@@ -215,8 +215,8 @@
----
<1> Change into privileged mode
<2> Enter the interactive configuration mode
-<3> Enter the config ndoe of the GGSN instance `ggsn0`
-<4> Enter the config ndoe of the APN `internet`
+<3> Enter the config node of the GGSN instance `ggsn0`
+<4> Enter the config node of the APN `internet`
<5> Take the APN out of shutdown
@@ -237,8 +237,8 @@
----
<1> Change into privileged mode
<2> Enter the interactive configuration mode
-<3> Enter the config ndoe of the GGSN instance `ggsn0`
-<4> Enter the config ndoe of the APN `internet`
+<3> Enter the config node of the GGSN instance `ggsn0`
+<4> Enter the config node of the APN `internet`
<5> Shut down the APN
[[ggsn_no_root]]
--
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36061?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: Ib78b5de45b93a7534163de2cd91211e9be75445d
Gerrit-Change-Number: 36061
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: merged
Attention is currently required from: pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36126?usp=email )
Change subject: Split GTP_CodecPort/GTP_Templates into C and U variants
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36126?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic15c9a2e92828cbafb4dda7355ee534107051e2d
Gerrit-Change-Number: 36126
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 01 Mar 2024 08:07:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: jolly.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36122?usp=email )
Change subject: stream: Initialize outmsg in stream_iofd_sctp_send_msgb()
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I think this can be abandoned; it has become part of another change
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36122?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: If4c8239c17deceeb56f64ebaff435df1e9d782cd
Gerrit-Change-Number: 36122
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Fri, 01 Mar 2024 08:06:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment