jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/36131?usp=email )
Change subject: osmo_io: do check_mode_callback_compat() only if ioops is set at osmo_iofd_setup()
......................................................................
osmo_io: do check_mode_callback_compat() only if ioops is set at osmo_iofd_setup()
Setting ioops is optional when calling osmo_iofd_setup(). If it is not
set, do not call check_mode_callback_compat() to check for
compatibility.
Closes: Coverity CID#349578
Change-Id: I1e25f3e420f25a44cbf73a4da9a498b7561e9ddd
---
M src/core/osmo_io.c
1 file changed, 15 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/31/36131/1
diff --git a/src/core/osmo_io.c b/src/core/osmo_io.c
index 33466e5..5a5e05c 100644
--- a/src/core/osmo_io.c
+++ b/src/core/osmo_io.c
@@ -619,7 +619,7 @@
return NULL;
}
- if (!check_mode_callback_compat(mode, ioops))
+ if (ioops && !check_mode_callback_compat(mode, ioops))
return NULL;
iofd = talloc_zero(ctx, struct osmo_io_fd);
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36131?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I1e25f3e420f25a44cbf73a4da9a498b7561e9ddd
Gerrit-Change-Number: 36131
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-MessageType: newchange
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36129?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: epdg: Introduce test TC_upf_echo_req
......................................................................
epdg: Introduce test TC_upf_echo_req
Change-Id: I3fd96f212175959cb113d2f6a362c0e77e5ca0d7
---
M epdg/EPDG_Tests.ttcn
1 file changed, 61 insertions(+), 6 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/29/36129/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36129?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I3fd96f212175959cb113d2f6a362c0e77e5ca0d7
Gerrit-Change-Number: 36129
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36128?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: GTPv2_Emulation: Add support to handle GTPv1-U
......................................................................
GTPv2_Emulation: Add support to handle GTPv1-U
Change-Id: I34c744015c09a387cbf736063303bdb61ca4744e
---
M epdg/EPDG_Tests.ttcn
M epdg/gen_links.sh
M epdg/regen_makefile.sh
M library/GTPv2_Emulation.ttcn
4 files changed, 54 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/28/36128/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36128?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I34c744015c09a387cbf736063303bdb61ca4744e
Gerrit-Change-Number: 36128
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset