March 2024 - gerrit-log - lists.osmocom.org

[L] Change in osmo-ttcn3-hacks[master]: ggsn_tests: Split out generic ICMP(v6) related templates and functions

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36130?usp=email ) Change subject: ggsn_tests: Split out generic ICMP(v6) related templates and functions ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36130?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I53a5da05caeef4cdd59778840a6f4eed489f1b93 Gerrit-Change-Number: 36130 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 02 Mar 2024 09:13:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: epdg: Introduce test TC_upf_echo_req

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36129?usp=email ) Change subject: epdg: Introduce test TC_upf_echo_req ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: why is there an 'upf' in the subject? I think fundamentally there is nothing in the 4G/EPC architecture that would mandate the use of an UPF. I think formally it's the SGW-U or PWG-U that speaks GTPv1-U (or possibly even the GSN?), which may or may not use CUPS (and hence an UPF) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36129?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3fd96f212175959cb113d2f6a362c0e77e5ca0d7 Gerrit-Change-Number: 36129 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 02 Mar 2024 09:13:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: epdg: Introduce test TC_upf_echo_req

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36129?usp=email ) Change subject: epdg: Introduce test TC_upf_echo_req ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36129?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3fd96f212175959cb113d2f6a362c0e77e5ca0d7 Gerrit-Change-Number: 36129 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 02 Mar 2024 09:11:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: GTPv2_Emulation: Add support to handle GTPv1-U

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36128?usp=email ) Change subject: GTPv2_Emulation: Add support to handle GTPv1-U ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36128?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I34c744015c09a387cbf736063303bdb61ca4744e Gerrit-Change-Number: 36128 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 02 Mar 2024 09:11:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in pysim[master]: tests: assertEquals() is deprecated, use assertEqual()

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/36139?usp=email ) Change subject: tests: assertEquals() is deprecated, use assertEqual() ...................................................................... tests: assertEquals() is deprecated, use assertEqual() This fixes deprecation warnings printed by Python 3.11.7. Change-Id: I1de93b0fee9e8439f7da8a3b9fd2a6974973fb4f --- M tests/test_euicc.py 1 file changed, 16 insertions(+), 5 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/tests/test_euicc.py b/tests/test_euicc.py index 05d71ed..29c66ea 100755 --- a/tests/test_euicc.py +++ b/tests/test_euicc.py @@ -16,16 +16,16 @@ self.assertFalse(verify_eid_checksum(89049032123451234512345678901234)) def test_eid_encode_with_32_digits(self): - self.assertEquals(compute_eid_checksum('89049032123451234512345678901200'), '89049032123451234512345678901235') - self.assertEquals(compute_eid_checksum('89086030202200000022000023022900'), '89086030202200000022000023022943') + self.assertEqual(compute_eid_checksum('89049032123451234512345678901200'), '89049032123451234512345678901235') + self.assertEqual(compute_eid_checksum('89086030202200000022000023022900'), '89086030202200000022000023022943') def test_eid_encode_with_30digits(self): - self.assertEquals(compute_eid_checksum('890490321234512345123456789012'), '89049032123451234512345678901235') + self.assertEqual(compute_eid_checksum('890490321234512345123456789012'), '89049032123451234512345678901235') def test_eid_encode_with_wrong_csum(self): # input: EID with wrong checksum - self.assertEquals(compute_eid_checksum('89049032123451234512345678901299'), '89049032123451234512345678901235') - self.assertEquals(compute_eid_checksum(89049032123451234512345678901299), '89049032123451234512345678901235') + self.assertEqual(compute_eid_checksum('89049032123451234512345678901299'), '89049032123451234512345678901235') + self.assertEqual(compute_eid_checksum(89049032123451234512345678901299), '89049032123451234512345678901235') if __name__ == "__main__": unittest.main() -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36139?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I1de93b0fee9e8439f7da8a3b9fd2a6974973fb4f Gerrit-Change-Number: 36139 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

[S] Change in pysim[master]: tests: assertEquals() is deprecated, use assertEqual()

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/36139?usp=email ) Change subject: tests: assertEquals() is deprecated, use assertEqual() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36139?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I1de93b0fee9e8439f7da8a3b9fd2a6974973fb4f Gerrit-Change-Number: 36139 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sat, 02 Mar 2024 09:10:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in osmo-hnbgw[master]: improve HNBAP error logging

by neels

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36141?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: improve HNBAP error logging ...................................................................... improve HNBAP error logging We have a situation where HNBAP is not answered by osmo-hnbgw, and the log is all silent. Add logging to a lot more of the possible HNBAP failure paths to find out what is wrong. Related: SYS#6810 Change-Id: I17d2809f59087d32e7c11a3ada1d3fadf6f0b660 --- M src/osmo-hnbgw/hnbgw.c M src/osmo-hnbgw/hnbgw_hnbap.c 2 files changed, 35 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/41/36141/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36141?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I17d2809f59087d32e7c11a3ada1d3fadf6f0b660 Gerrit-Change-Number: 36141 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 year, 5 months

1
0
0 0

[S] Change in osmo-hnbgw[master]: improve HNBAP error logging

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36141?usp=email ) Change subject: improve HNBAP error logging ...................................................................... improve HNBAP error logging We have a situation where HNBAP is not answered by osmo-hnbgw, and the log is all silent. Add logging to a lot more of the possible HNBAP failure paths to find out what is wrong. Related: SYS#6810 Change-Id: I17d2809f59087d32e7c11a3ada1d3fadf6f0b660 --- M src/osmo-hnbgw/hnbgw.c M src/osmo-hnbgw/hnbgw_hnbap.c 2 files changed, 32 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/41/36141/1 diff --git a/src/osmo-hnbgw/hnbgw.c b/src/osmo-hnbgw/hnbgw.c index 086582e..7d09d57 100644 --- a/src/osmo-hnbgw/hnbgw.c +++ b/src/osmo-hnbgw/hnbgw.c @@ -188,8 +188,10 @@ struct ue_context *ue; ue = talloc_zero(g_hnbgw, struct ue_context); - if (!ue) + if (!ue) { + LOGHNB(hnb, DHNBAP, LOGL_ERROR, "Failed to allocate new ue_context\n"); return NULL; + } ue->hnb = hnb; if (imsi) diff --git a/src/osmo-hnbgw/hnbgw_hnbap.c b/src/osmo-hnbgw/hnbgw_hnbap.c index 06d1a9d..b5f39af 100644 --- a/src/osmo-hnbgw/hnbgw_hnbap.c +++ b/src/osmo-hnbgw/hnbgw_hnbap.c @@ -148,6 +148,9 @@ rc = hnbap_encode_ueregisteraccepties(&accept_out, &accept); ASN_STRUCT_FREE_CONTENTS_ONLY(asn_DEF_OCTET_STRING, &accept.uE_Identity.choice.iMSI); if (rc < 0) { + LOGHNB(ue->hnb, DHNBAP, LOGL_ERROR, + "Failed to encode HNBAP UE Register Accept message for UE IMSI-%s TMSI-0x%x\n", + ue->imsi, ue->tmsi); return rc; } @@ -158,7 +161,12 @@ ASN_STRUCT_FREE_CONTENTS_ONLY(asn_DEF_HNBAP_UERegisterAccept, &accept_out); - return hnbgw_hnbap_tx(ue->hnb, msg); + rc = hnbgw_hnbap_tx(ue->hnb, msg); + if (rc) + LOGHNB(ue->hnb, DHNBAP, LOGL_ERROR, + "Failed to enqueue HNBAP UE Register Accept message for UE IMSI-%s TMSI-0x%x\n", + ue->imsi, ue->tmsi); + return rc; } static int hnbgw_tx_ue_register_rej_tmsi(struct hnb_context *hnb, HNBAP_UE_Identity_t *ue_id) @@ -526,14 +534,19 @@ ue = ue_context_by_imsi(imsi); if (!ue) ue = ue_allocated = ue_context_alloc(ctx, imsi, 0); + else + LOGHNB(ctx, DHNBAP, LOGL_DEBUG, "UE context for IMSI %s already exists\n", imsi); /* Send UERegisterAccept */ rc = hnbgw_tx_ue_register_acc(ue); if (rc < 0) { + LOGHNB(ctx, DHNBAP, LOGL_ERROR, "Failed to transmit HNBAP UE Register Accept for IMSI %s\n", imsi); /* If we allocated the UE context but the UE REGISTER fails, get rid of it again: there will likely * never be a UE DE-REGISTER for this UE from the HNB, and the ue_context would linger forever. */ - if (ue_allocated) + if (ue_allocated) { ue_context_free(ue_allocated); + LOGHNB(ctx, DHNBAP, LOGL_INFO, "Freed UE context for IMSI %s\n", imsi); + } } free_and_return_rc: hnbap_free_ueregisterrequesties(&ies); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36141?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I17d2809f59087d32e7c11a3ada1d3fadf6f0b660 Gerrit-Change-Number: 36141 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 0

[S] Change in pysim[master]: [RFC] ePDGId: allow passing both string and int type values

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/36140?usp=email ) Change subject: [RFC] ePDGId: allow passing both string and int type values ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: This is a proposal. If people like this idea, we should also modify other `Switch` subcons. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36140?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I231fad78f5c5b5c23f38a6c913df957cfa06259e Gerrit-Change-Number: 36140 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 01 Mar 2024 18:48:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in pysim[master]: tests: assertEquals() is deprecated, use assertEqual()

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/36139?usp=email ) Change subject: tests: assertEquals() is deprecated, use assertEqual() ...................................................................... tests: assertEquals() is deprecated, use assertEqual() This fixes deprecation warnings printed by Python 3.11.7. Change-Id: I1de93b0fee9e8439f7da8a3b9fd2a6974973fb4f --- M tests/test_euicc.py 1 file changed, 16 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/39/36139/1 diff --git a/tests/test_euicc.py b/tests/test_euicc.py index 05d71ed..29c66ea 100755 --- a/tests/test_euicc.py +++ b/tests/test_euicc.py @@ -16,16 +16,16 @@ self.assertFalse(verify_eid_checksum(89049032123451234512345678901234)) def test_eid_encode_with_32_digits(self): - self.assertEquals(compute_eid_checksum('89049032123451234512345678901200'), '89049032123451234512345678901235') - self.assertEquals(compute_eid_checksum('89086030202200000022000023022900'), '89086030202200000022000023022943') + self.assertEqual(compute_eid_checksum('89049032123451234512345678901200'), '89049032123451234512345678901235') + self.assertEqual(compute_eid_checksum('89086030202200000022000023022900'), '89086030202200000022000023022943') def test_eid_encode_with_30digits(self): - self.assertEquals(compute_eid_checksum('890490321234512345123456789012'), '89049032123451234512345678901235') + self.assertEqual(compute_eid_checksum('890490321234512345123456789012'), '89049032123451234512345678901235') def test_eid_encode_with_wrong_csum(self): # input: EID with wrong checksum - self.assertEquals(compute_eid_checksum('89049032123451234512345678901299'), '89049032123451234512345678901235') - self.assertEquals(compute_eid_checksum(89049032123451234512345678901299), '89049032123451234512345678901235') + self.assertEqual(compute_eid_checksum('89049032123451234512345678901299'), '89049032123451234512345678901235') + self.assertEqual(compute_eid_checksum(89049032123451234512345678901299), '89049032123451234512345678901235') if __name__ == "__main__": unittest.main() -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36139?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I1de93b0fee9e8439f7da8a3b9fd2a6974973fb4f Gerrit-Change-Number: 36139 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2024