Attention is currently required from: pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36163?usp=email )
Change subject: DIAMETER_Types: Move RFC ddf files earlier in the dependency list of files to generate
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36163?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Idcbdfd97332195af05928c81068f6a4779ac306e
Gerrit-Change-Number: 36163
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 05 Mar 2024 13:58:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36165?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: Small improvements to DIAMETER_ts29_272_Templates.ttcn
......................................................................
Small improvements to DIAMETER_ts29_272_Templates.ttcn
* Move Service-Selection template to the TS 29.272 since it belongs
there.
* Set some parameter types to "template (value)" which makes it easier
for users, since both a template and a value can then be passed.
Change-Id: Ic57b2c5ec0a953f9a1751d4ce4ad441daafd3c87
---
M epdg/gen_links.sh
M library/DIAMETER_Templates.ttcn
M library/DIAMETER_ts29_272_Templates.ttcn
M library/DIAMETER_ts29_273_Templates.ttcn
4 files changed, 44 insertions(+), 28 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/65/36165/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36165?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic57b2c5ec0a953f9a1751d4ce4ad441daafd3c87
Gerrit-Change-Number: 36165
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: DIAMETER_Types: Generate types for 3GPP TS 29.273
......................................................................
DIAMETER_Types: Generate types for 3GPP TS 29.273
The ddf file is added at the end of the list since it depends on tons of
other RFC and 3GGP TS specs, see for instance TS 29.372 Table 8.2.3.0.
Change-Id: I17f7f025ff31d9ce619cd23bfa5f1af282969dbf
---
M library/DIAMETER_Types.ttcn
M library/regen-DIAMETER_Types_ttcn.sh
2 files changed, 445 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/62/36162/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I17f7f025ff31d9ce619cd23bfa5f1af282969dbf
Gerrit-Change-Number: 36162
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36161?usp=email )
Change subject: Remove unwanted epdg/ICMP_Types.ttcn
......................................................................
Remove unwanted epdg/ICMP_Types.ttcn
It seems I somehow ended up adding this link file in
bf03d7764938ee7e109c60eaecf4991fbcda2038 when submitting the patch.
Get rid of it since it is totally undesired.
Change-Id: Iec812841bc474ae423b447707adc520cf4039499
---
D epdg/ICMP_Types.ttcn
1 file changed, 13 insertions(+), 1 deletion(-)
Approvals:
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/epdg/ICMP_Types.ttcn b/epdg/ICMP_Types.ttcn
deleted file mode 120000
index 361cad1..0000000
--- a/epdg/ICMP_Types.ttcn
+++ /dev/null
@@ -1 +0,0 @@
-../deps/titan.ProtocolModules.ICMP/src/ICMP_Types.ttcn
\ No newline at end of file
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36161?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iec812841bc474ae423b447707adc520cf4039499
Gerrit-Change-Number: 36161
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged