March 2024 - gerrit-log - lists.osmocom.org

[XL] Change in osmo-ttcn3-hacks[master]: DIAMETER_Types: Move RFC ddf files earlier in the dependency list of ...

by fixeria

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36163?usp=email ) Change subject: DIAMETER_Types: Move RFC ddf files earlier in the dependency list of files to generate ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36163?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idcbdfd97332195af05928c81068f6a4779ac306e Gerrit-Change-Number: 36163 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 05 Mar 2024 18:14:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: epdg: Introduce test TC_authinfo_MAA_unknown_user

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36172?usp=email ) Change subject: epdg: Introduce test TC_authinfo_MAA_unknown_user ...................................................................... epdg: Introduce test TC_authinfo_MAA_unknown_user Related: OS#6391 Change-Id: Ie4d9d019ed56401e7e19197b4a777a1e6a55e7ee --- M epdg/EPDG_Tests.ttcn M library/DIAMETER_Templates.ttcn M library/DIAMETER_ts29_273_Templates.ttcn M library/GSUP_Templates.ttcn 4 files changed, 153 insertions(+), 32 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/72/36172/1 diff --git a/epdg/EPDG_Tests.ttcn b/epdg/EPDG_Tests.ttcn index 15d4341..45d7a1d 100644 --- a/epdg/EPDG_Tests.ttcn +++ b/epdg/EPDG_Tests.ttcn @@ -19,6 +19,7 @@ import from DIAMETER_Types all; import from DIAMETER_Templates all; import from DIAMETER_rfc4004_Templates all; +import from DIAMETER_ts29_272_Templates all; import from DIAMETER_ts29_273_Templates all; import from DIAMETER_Emulation all; @@ -381,26 +382,50 @@ return hex2str(g_pars.imsi) & "@" & mp_s6b_nai_realm; } -/* Diameter SWx MAR + MAA. */ -private altstep as_DIA_SWx_MA_success() runs on EPDG_ConnHdlr { - var PDU_DIAMETER rx_dia; +private function f_DIA_SWx_tx_MAA_success(PDU_DIAMETER rx_mar) runs on EPDG_ConnHdlr { var template (omit) AVP avp; var octetstring sess_id; var template (value) GenericAVP sip_auth_data_item; + + avp := f_DIAMETER_get_avp(rx_mar, c_AVP_Code_BASE_NONE_Session_Id); + sess_id := valueof(avp.avp_data.avp_BASE_NONE_Session_Id); + sip_auth_data_item := ts_AVP_3GPP_SIPAuthDataItem(0, + g_pars.vec.rand, + g_pars.vec.ik, + g_pars.vec.ck, + g_pars.vec.autn, + g_pars.vec.auts); + /* Send MAA to translator; expect it to show up on GSUP side */ + SWx.send(ts_DIA_SWx_MAA(g_pars.imsi, sip_auth_data_item, + sess_id := sess_id, + hbh_id := rx_mar.hop_by_hop_id, + ete_id := rx_mar.end_to_end_id)); +} + +private function f_DIA_SWx_tx_MAA_error(PDU_DIAMETER rx_mar, template (value) GenericAVP result) runs on EPDG_ConnHdlr { + var template (omit) AVP avp; + var octetstring sess_id; + var template (value) GenericAVP sip_auth_data_item; + + avp := f_DIAMETER_get_avp(rx_mar, c_AVP_Code_BASE_NONE_Session_Id); + sess_id := valueof(avp.avp_data.avp_BASE_NONE_Session_Id); + sip_auth_data_item := ts_AVP_3GPP_SIPAuthDataItem(0, + g_pars.vec.rand, + g_pars.vec.ik, + g_pars.vec.ck, + g_pars.vec.autn, + g_pars.vec.auts); + SWx.send(ts_DIA_SWx_MAA_result(g_pars.imsi, result, + sess_id := sess_id, + hbh_id := rx_mar.hop_by_hop_id, + ete_id := rx_mar.end_to_end_id)); +} + +/* Diameter SWx MAR + MAA. */ +private altstep as_DIA_SWx_MA_success() runs on EPDG_ConnHdlr { + var PDU_DIAMETER rx_dia; [] SWx.receive(tr_DIA_SWx_MAR(g_pars.imsi)) -> value rx_dia { - avp := f_DIAMETER_get_avp(rx_dia, c_AVP_Code_BASE_NONE_Session_Id); - sess_id := valueof(avp.avp_data.avp_BASE_NONE_Session_Id); - sip_auth_data_item := ts_AVP_3GPP_SIPAuthDataItem(0, - g_pars.vec.rand, - g_pars.vec.ik, - g_pars.vec.ck, - g_pars.vec.autn, - g_pars.vec.auts); - /* Send MAA to translator; expect it to show up on GSUP side */ - SWx.send(ts_DIA_SWx_MAA(g_pars.imsi, sip_auth_data_item, - sess_id := sess_id, - hbh_id := rx_dia.hop_by_hop_id, - ete_id := rx_dia.end_to_end_id)); + f_DIA_SWx_tx_MAA_success(rx_dia); setverdict(pass); } [] SWx.receive(PDU_DIAMETER:?) -> value rx_dia { @@ -729,28 +754,47 @@ } } -/* GSUP AuthInfo Req + Resp, triggers SWx MAR + MAA. */ -private function f_GSUP_AI_success() runs on EPDG_ConnHdlr { +private function f_GSUP_tx_SAI_REQ() runs on EPDG_ConnHdlr { var GSUP_PDU rx_gsup; - var template (present) GSUP_IE auth_tuple_ie; var template (value) GSUP_IEs pdp_info; - auth_tuple_ie := tr_GSUP_IE_AuthTuple3G(g_pars.vec.rand, - g_pars.vec.ik, - g_pars.vec.ck, - g_pars.vec.autn, - g_pars.vec.rand & g_pars.vec.auts); pdp_info := { ts_GSUP_IE_PDP_CONTEXT_ID('00'O), ts_GSUP_IE_PDP_ADDRESS(ts_EuaIPv4Dyn), ts_GSUP_IE_APN(f_enc_dns_hostname(g_pars.apn)) }; GSUP.send(ts_GSUP_SAI_REQ_PDP_INFO(g_pars.imsi, pdp_info)); - as_DIA_SWx_MA_success(); - /* Expect a positive response back to the translator; expect AIA */ - alt { - [] GSUP.receive(tr_GSUP_SAI_RES(g_pars.imsi, auth_tuple_ie)); +} + + +private altstep as_GSUP_rx_SAI_RES() runs on EPDG_ConnHdlr { + var GSUP_PDU rx_gsup; + var template (present) GSUP_IE auth_tuple_ie := tr_GSUP_IE_AuthTuple3G( + g_pars.vec.rand, + g_pars.vec.ik, + g_pars.vec.ck, + g_pars.vec.autn, + g_pars.vec.rand & g_pars.vec.auts); + + [] GSUP.receive(tr_GSUP_SAI_RES(g_pars.imsi, auth_tuple_ie)) -> value rx_gsup { + } [] GSUP.receive(GSUP_PDU:?) -> value rx_gsup { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, log2str("Unexpected GSUP msg rx: ", rx_gsup)); - } } +} + +private altstep as_GSUP_rx_SAI_ERR(template (present) integer cause := ?) runs on EPDG_ConnHdlr { + var GSUP_PDU rx_gsup; + + [] GSUP.receive(tr_GSUP_SAI_ERR(g_pars.imsi, cause)) -> value rx_gsup { + } + [] GSUP.receive(GSUP_PDU:?) -> value rx_gsup { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, log2str("Unexpected GSUP msg rx: ", rx_gsup)); + } +} + +/* GSUP AuthInfo Req + Resp, triggers SWx MAR + MAA. */ +private function f_GSUP_AI_success() runs on EPDG_ConnHdlr { + f_GSUP_tx_SAI_REQ(); + as_DIA_SWx_MA_success(); + as_GSUP_rx_SAI_RES(); setverdict(pass); } @@ -863,6 +907,27 @@ setverdict(pass); } +private function f_TC_authinfo_MAA_unknown_user(charstring id) runs on EPDG_ConnHdlr { + var PDU_DIAMETER rx_dia; + var DIAMETER_ExperimentalResultcode exp_result_code := DIAMETER_ERROR_USER_UNKNOWN; + f_GSUP_tx_SAI_REQ(); + + SWx.receive(tr_DIA_SWx_MAR(g_pars.imsi)) -> value rx_dia; + f_DIA_SWx_tx_MAA_error(rx_dia, + ts_AVP_ExperimentalResult(vendor_id_3GPP, + int2oct(enum2int(exp_result_code), 4))); + /* cause 2 = IMSI_UNKNOWN */ + as_GSUP_rx_SAI_ERR(2); +} +testcase TC_authinfo_MAA_unknown_user() runs on MTC_CT { + var EPDG_ConnHdlrPars pars := f_init_pars(); + var EPDG_ConnHdlr vc_conn; + f_init(); + vc_conn := f_start_handler(refers(f_TC_authinfo_MAA_unknown_user), pars); + vc_conn.done; + setverdict(pass); +} + private function f_TC_ho_lte_to_wifi(charstring id) runs on EPDG_ConnHdlr { f_initial_attach(); /* Whenever UE comes from 3GPP, PGW may activate a dedicated S2b bearer @@ -998,6 +1063,7 @@ control { execute ( TC_authinfo_normal() ); + execute ( TC_authinfo_MAA_unknown_user() ); execute ( TC_ho_lte_to_wifi() ); execute ( TC_ho_wifi_to_lte() ); execute ( TC_s2b_CreateSession_rejected() ); diff --git a/library/DIAMETER_Templates.ttcn b/library/DIAMETER_Templates.ttcn index 5390d6e..338899f 100644 --- a/library/DIAMETER_Templates.ttcn +++ b/library/DIAMETER_Templates.ttcn @@ -337,11 +337,11 @@ } } -template (value) GenericAVP ts_AVP_VendorId(Vendor_Id vendor_id) := { +template (value) GenericAVP ts_AVP_VendorId(template (value) Vendor_Id vendor_id) := { avp := { avp_header := ts_DIA_Hdr(c_AVP_Code_BASE_NONE_Vendor_Id, '00000000'B), avp_data := { - avp_BASE_NONE_Vendor_Id := int2oct(enum2int(vendor_id), 4) + avp_BASE_NONE_Vendor_Id := int2oct(enum2int(valueof(vendor_id)), 4) } } } @@ -522,6 +522,14 @@ } } } +template (value) GenericAVP ts_AVP_ExperimentalResultCode(template (value) AVP_Unsigned32 n) := { + avp := { + avp_header := ts_DIA_Hdr(c_AVP_Code_BASE_NONE_Experimental_Result_Code), + avp_data := { + avp_BASE_NONE_Experimental_Result_Code := n + } + } +} template (present) GenericAVP tr_AVP_ExperimentalResult(template (present) Vendor_Id vendor_id := ?, template (present) AVP_Unsigned32 err_code := ? @@ -536,6 +544,19 @@ } } } +template (value) GenericAVP ts_AVP_ExperimentalResult(template (value) Vendor_Id vendor_id := vendor_id_3GPP, + template (value) AVP_Unsigned32 err_code + ) := { + avp := { + avp_header := ts_DIA_Hdr(c_AVP_Code_BASE_NONE_Experimental_Result), + avp_data := { + avp_BASE_NONE_Experimental_Result := { + ts_AVP_VendorId(vendor_id), + ts_AVP_ExperimentalResultCode(err_code) + } + } + } +} template (value) GenericAVP ts_AVP_SuppVendorIdRaw(uint32_t vendor_id) := { avp := { diff --git a/library/DIAMETER_ts29_273_Templates.ttcn b/library/DIAMETER_ts29_273_Templates.ttcn index 899dfb4..f0ac442 100644 --- a/library/DIAMETER_ts29_273_Templates.ttcn +++ b/library/DIAMETER_ts29_273_Templates.ttcn @@ -180,6 +180,30 @@ ts_AVP_3GPP_SIPNumAuthDataItems(1) }); +template (value) PDU_DIAMETER +ts_DIA_SWx_MAA_result(template (value) hexstring imsi, + template (value) GenericAVP result, + template (value) uint32_t vendor_app_id := c_DIAMETER_3GPP_SWx_AID, + template (value) octetstring sess_id := c_def_sess_id, + template (value) charstring orig_host := "hss.localdomain", + template (value) charstring orig_realm := "localdomain", + template (value) UINT32 hbh_id := '00000000'O, + template (value) UINT32 ete_id := '00000000'O) := + ts_DIAMETER(flags := '01000000'B, + cmd_code := Multimedia_Auth, + app_id := int2oct(c_DIAMETER_3GPP_SWx_AID, 4), + hbh_id := hbh_id, + ete_id := ete_id, + avps := { + ts_AVP_SessionId(sess_id), + ts_AVP_VendorSpecAppId(vendor_id_3GPP, valueof(vendor_app_id)), + result, + ts_AVP_AuthSessionState(NO_STATE_MAINTAINED), + ts_AVP_OriginHost(orig_host), + ts_AVP_OriginRealm(orig_realm), + ts_AVP_UserNameImsi(valueof(imsi)) + }); + /* Server-Assignment-Request, * 3GPP TS 29.273 8.1.2.2.2 UE/PDN Registration/DeRegistration Notification * 3GPP TS 29.273 8.2.2.3 Non-3GPP IP Access Registration Procedure */ diff --git a/library/GSUP_Templates.ttcn b/library/GSUP_Templates.ttcn index 9daf9c0..6d14b02 100644 --- a/library/GSUP_Templates.ttcn +++ b/library/GSUP_Templates.ttcn @@ -374,7 +374,7 @@ ts_GSUP(OSMO_GSUP_MSGT_SEND_AUTH_INFO_RESULT, { valueof(ts_GSUP_IE_IMSI(imsi)), auth_tuple }); -template GSUP_PDU tr_GSUP_SAI_ERR(template hexstring imsi, template integer cause) := +template GSUP_PDU tr_GSUP_SAI_ERR(template hexstring imsi, template (present) integer cause := ?) := tr_GSUP(OSMO_GSUP_MSGT_SEND_AUTH_INFO_ERROR, { tr_GSUP_IE_IMSI(imsi), tr_GSUP_IE_Cause(cause) }); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36172?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie4d9d019ed56401e7e19197b4a777a1e6a55e7ee Gerrit-Change-Number: 36172 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 0

[S] Change in ...osmo-epdg[master]: diameter_3gpp_ts29_273_swx.dia: Fix missing dependency RFC4004

by lynxis lazus

Attention is currently required from: pespin. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36170?usp=email ) Change subject: diameter_3gpp_ts29_273_swx.dia: Fix missing dependency RFC4004 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36170?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Ifaea9ffaec1f50b5ec996a03f3addd70ccd2349f Gerrit-Change-Number: 36170 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 05 Mar 2024 16:55:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in ...osmo-epdg[master]: Forward PGW Address PGW->AAA->HSS

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36171?usp=email ) Change subject: Forward PGW Address PGW->AAA->HSS ...................................................................... Forward PGW Address PGW->AAA->HSS We were missing passing the actual IP address of the PDN-GW when transmitting SAR to the HSS (precisely with the aim of updating that information). Change-Id: Ia99442487fef56c16c4be2fb7f36221d016e55e0 --- M src/aaa_diameter_s6b_cb.erl M src/aaa_diameter_swx.erl M src/aaa_ue_fsm.erl 3 files changed, 32 insertions(+), 17 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/71/36171/1 diff --git a/src/aaa_diameter_s6b_cb.erl b/src/aaa_diameter_s6b_cb.erl index ab15bd6..b3fe209 100644 --- a/src/aaa_diameter_s6b_cb.erl +++ b/src/aaa_diameter_s6b_cb.erl @@ -58,12 +58,13 @@ 'Auth-Application-Id' = AuthAppId, 'Auth-Request-Type' = AuthReqType, 'User-Name' = [UserName], - 'Service-Selection' = [Apn]} = Req, + 'Service-Selection' = [Apn], + 'MIP6-Agent-Info' = AgentInfoOpt } = Req, Imsi = conv:nai_to_imsi(UserName), PidRes = aaa_ue_fsm:get_pid_by_imsi(Imsi), case PidRes of PidRes when is_pid(PidRes) -> - ok = aaa_ue_fsm:ev_rx_s6b_aar(PidRes, Apn), + ok = aaa_ue_fsm:ev_rx_s6b_aar(PidRes, {Apn, AgentInfoOpt}), lager:debug("Waiting for S6b AAA~n", []), receive {aaa, ResultCode} -> lager:debug("Rx AAA with ResultCode=~p~n", [ResultCode]) diff --git a/src/aaa_diameter_swx.erl b/src/aaa_diameter_swx.erl index be301f2..72a360e 100644 --- a/src/aaa_diameter_swx.erl +++ b/src/aaa_diameter_swx.erl @@ -51,7 +51,7 @@ -export([init/1, handle_call/3, handle_cast/2, handle_info/2]). -export([code_change/3]). -export([multimedia_auth_request/7]). --export([server_assignment_request/3]). +-export([server_assignment_request/4]). -export([test/0, test/1]). %% Diameter Application Definitions @@ -146,9 +146,9 @@ gen_server:call(?SERVER, {mar, {IMSI, NumAuthItems, AuthScheme, RAT, CKey, IntegrityKey, PdpTypeNr}}). % APN is optional and should be [] -server_assignment_request(IMSI, Type, APN) -> +server_assignment_request(IMSI, Type, APN, AgentInfoOpt) -> gen_server:call(?SERVER, - {sar, {IMSI, Type, APN}}). + {sar, {IMSI, Type, APN, AgentInfoOpt}}). result_code_success(2001) -> ok; result_code_success(2002) -> ok; @@ -235,8 +235,8 @@ {reply, {error, Err}, State} end; -handle_call({sar, {IMSI, Type, APN}}, {Pid, _Tag} = _From, State) -> - lager:debug("SWx Tx SAR Imsi=~p Type=~p APN=~p~n", [IMSI, Type, APN]), +handle_call({sar, {IMSI, Type, APN, AgentInfoOpt}}, {Pid, _Tag} = _From, State) -> + lager:debug("SWx Tx SAR Imsi=~p Type=~p APN=~p AgentInfoOpt=~p ~n", [IMSI, Type, APN, AgentInfoOpt]), SessionId = diameter:session_id(application:get_env(?ENV_APP_NAME, origin_host, ?ENV_DEFAULT_ORIG_HOST)), SAR = #'SAR'{'Vendor-Specific-Application-Id' = #'Vendor-Specific-Application-Id'{ 'Vendor-Id' = ?VENDOR_ID_3GPP, @@ -245,7 +245,8 @@ 'User-Name' = IMSI, 'Auth-Session-State' = 1, 'Server-Assignment-Type' = Type, - 'Service-Selection' = [APN] + 'Service-Selection' = [APN], + 'MIP6-Agent-Info' = AgentInfoOpt }, Ret = diameter_call(SAR, Pid, State), case Ret of diff --git a/src/aaa_ue_fsm.erl b/src/aaa_ue_fsm.erl index fd39061..9fa868e 100644 --- a/src/aaa_ue_fsm.erl +++ b/src/aaa_ue_fsm.erl @@ -111,10 +111,10 @@ {error, Err} end. -ev_rx_s6b_aar(Pid, Apn) -> - lager:info("ue_fsm ev_rx_s6b_aar: ~p~n", [Apn]), +ev_rx_s6b_aar(Pid, {Apn, AgentInfoOpt}) -> + lager:info("ue_fsm ev_rx_s6b_aar: ~p ~p~n", [Apn, AgentInfoOpt]), try - gen_statem:call(Pid, {rx_s6b_aar, Apn}) + gen_statem:call(Pid, {rx_s6b_aar, Apn, AgentInfoOpt}) catch exit:Err -> {error, Err} @@ -164,7 +164,7 @@ state_new({call, From}, {swm_auth_compl, Apn}, Data) -> lager:info("ue_fsm state_new event=swm_auth_compl, ~p~n", [Data]), - case aaa_diameter_swx:server_assignment_request(Data#ue_fsm_data.imsi, 1, Apn) of + case aaa_diameter_swx:server_assignment_request(Data#ue_fsm_data.imsi, 1, Apn, []) of ok -> {next_state, state_wait_swx_saa, Data, [{reply,From,ok}]}; {error, Err} -> {keep_state, Data, [{reply,From,{error, Err}}]} end. @@ -197,11 +197,11 @@ Data1 = Data#ue_fsm_data{epdg_sess_active = true}, {keep_state, Data1}; -state_authenticated({call, {Pid, _Tag} = From}, {rx_s6b_aar, Apn}, Data) -> - lager:info("ue_fsm state_authenticated event=rx_s6b_aar Apn=~p, ~p~n", [Apn, Data]), +state_authenticated({call, {Pid, _Tag} = From}, {rx_s6b_aar, Apn, AgentInfoOpt}, Data) -> + lager:info("ue_fsm state_authenticated event=rx_s6b_aar Apn=~p AgentInfo=~p, ~p~n", [Apn, AgentInfoOpt, Data]), case aaa_diameter_swx:server_assignment_request(Data#ue_fsm_data.imsi, ?'DIAMETER_CX_SERVER-ASSIGNMENT-TYPE_PGW_UPDATE', - Apn) of + Apn, AgentInfoOpt) of ok -> Data1 = Data#ue_fsm_data{s6b_resp_pid = Pid, apn = Apn}, {next_state, state_authenticated_wait_swx_saa, Data1, [{reply,From,ok}]}; {error, Err} -> {keep_state, Data, [{reply,From,{error, Err}}]} @@ -220,7 +220,7 @@ {true, false} -> %% All sessions will now be gone, trigger SAR Type=USER_DEREGISTRATION case aaa_diameter_swx:server_assignment_request(Data#ue_fsm_data.imsi, ?'DIAMETER_CX_SERVER-ASSIGNMENT-TYPE_USER_DEREGISTRATION', - Data#ue_fsm_data.apn) of + Data#ue_fsm_data.apn, []) of ok -> {next_state, state_authenticated_wait_swx_saa, Data, [{reply,From,ok}]}; {error, _Err} -> DiaRC = 5002, %% UNKNOWN_SESSION_ID @@ -241,7 +241,7 @@ {true, false} -> %% All sessions will now be gone, trigger SAR Type=USER_DEREGISTRATION case aaa_diameter_swx:server_assignment_request(Data#ue_fsm_data.imsi, ?'DIAMETER_CX_SERVER-ASSIGNMENT-TYPE_USER_DEREGISTRATION', - Data#ue_fsm_data.apn) of + Data#ue_fsm_data.apn, []) of ok -> Data1 = Data#ue_fsm_data{s6b_resp_pid = Pid}, {next_state, state_authenticated_wait_swx_saa, Data1, [{reply,From,ok}]}; {error, _Err} -> -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36171?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Ia99442487fef56c16c4be2fb7f36221d016e55e0 Gerrit-Change-Number: 36171 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 0

[S] Change in ...osmo-epdg[master]: diameter_3gpp_ts29_273_swx.dia: Fix missing dependency RFC4004

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36170?usp=email ) Change subject: diameter_3gpp_ts29_273_swx.dia: Fix missing dependency RFC4004 ...................................................................... diameter_3gpp_ts29_273_swx.dia: Fix missing dependency RFC4004 TS 29.273 SAR contains MIP6-Agent-Info from RFC5447, which in turn contains MIP-Home-Agent-Address from RFC 4004. Related: ffe4e0b0842c75daf8d5c585bffb6bfeb0f75251 Related: OS#6045 Change-Id: Ifaea9ffaec1f50b5ec996a03f3addd70ccd2349f --- M dia/diameter_3gpp_ts29_273_swx.dia 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/70/36170/1 diff --git a/dia/diameter_3gpp_ts29_273_swx.dia b/dia/diameter_3gpp_ts29_273_swx.dia index 259e626..aee06d1 100644 --- a/dia/diameter_3gpp_ts29_273_swx.dia +++ b/dia/diameter_3gpp_ts29_273_swx.dia @@ -42,6 +42,7 @@ @inherits diameter_3gpp_ts29_273 @inherits diameter_3gpp_ts32_299 @inherits diameter_etsi_es283_034 +@inherits diameter_rfc4004 @inherits diameter_rfc4006_cc @inherits diameter_rfc5447 @inherits diameter_rfc5580 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36170?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Ifaea9ffaec1f50b5ec996a03f3addd70ccd2349f Gerrit-Change-Number: 36170 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 0

[M] Change in osmo-mgw[master]: migrate mgcp_client from osmo_wqueue to osmo_io

by dexter

Attention is currently required from: jolly, laforge. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/36142?usp=email ) Change subject: migrate mgcp_client from osmo_wqueue to osmo_io ...................................................................... Patch Set 1: Verified+1 Code-Review+1 (1 comment) Patchset: PS1: I gave this a try in my test network. Everything seems to work fine. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/36142?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I766224da4691695c023d4d08d042a4bbeba05e47 Gerrit-Change-Number: 36142 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 05 Mar 2024 16:24:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[L] Change in libosmo-sccp[master]: xua + ipa: Add support for I/O in OSMO_IO mode

by pespin

Attention is currently required from: arehbein, daniel, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35070?usp=email ) Change subject: xua + ipa: Add support for I/O in OSMO_IO mode ...................................................................... Patch Set 8: Code-Review-1 (3 comments) File src/osmo_ss7_asp.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/35070/comment/040b2000_09c23123 PS8, Line 657: osmo_stream_cli_set_segmentation_cb(asp->client, xua_segmentation_cb); Can we call this callback function "tcp_xua_segmentation_cb"? (prepend"tcp_"). We already have eg. "m3ua_tcp_cli_read_cb". https://gerrit.osmocom.org/c/libosmo-sccp/+/35070/comment/ef538979_90119f23 PS8, Line 663: osmo_stream_cli_set_read_cb2(asp->client, xua_cli_read_cb); You probably need to do "osmo_stream_cli_set_segmentation_cb(asp->client, NULL);" here too? https://gerrit.osmocom.org/c/libosmo-sccp/+/35070/comment/3cfe0e6a_8d800b83 PS8, Line 833: } so how are we now calling osmo_stream_srv_destroy() once the socket is detected as closed? I have the feeling you are missing a "if (msgb_length(msg) == 0) {" case here, like you added in the cli_ function. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/35070?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I7d02037990f4af405839309510dc6c04e36c3369 Gerrit-Change-Number: 35070 Gerrit-PatchSet: 8 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 05 Mar 2024 15:44:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in libosmo-sccp[master]: cosmetic: rename ss7_asp_*_conn_cb to ss7_asp_*_conn_rx_cb

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/36169?usp=email ) Change subject: cosmetic: rename ss7_asp_*_conn_cb to ss7_asp_*_conn_rx_cb ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/36169?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Iaaef8128d4a26ea75fbce7067a8ab935a319beb4 Gerrit-Change-Number: 36169 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 05 Mar 2024 15:35:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: epdg: Transmit MIP6-Agent-Info AVP in S6b SAR

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36168?usp=email ) Change subject: epdg: Transmit MIP6-Agent-Info AVP in S6b SAR ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36168/comment/8818bd8a_a397… PS1, Line 7: MIP6 > actually it's the non MIP6 (MobileIP 6) AVP that we transmit, as we use a normal GTP user plane? not sure what you mean, it's called like that, see TS 29.273 9.2.3.2.2 MIP6-Agent-Info. That's used for both PMIP and GTP user plane, same as MIP6-Feature-Vector which has flags for both. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36168?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia0f00a00b6474e19bb4cdc77724c75a55ef5c1f9 Gerrit-Change-Number: 36168 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 05 Mar 2024 15:34:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[L] Change in libosmo-sccp[master]: xua + ipa: Add support for I/O in OSMO_IO mode

by laforge

Attention is currently required from: arehbein, daniel, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35070?usp=email ) Change subject: xua + ipa: Add support for I/O in OSMO_IO mode ...................................................................... Patch Set 8: (1 comment) File src/osmo_ss7_asp.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/35070/comment/889c673a_a1c81d2e PS3, Line 904: xua_cli_close_and_reconnect(conn); > Not sure what needs to be done on disconnect, but you'll probably need to `osmo_stream_cli_set_disco […] yeah, I think the problem is that we are not using the disconnect_cb offered by libosmo-netif here. Likely for historical reasons, as when we did our own read/recv, we'd use the len == 0 indication. But now when transitioning to the osmo_io_fd mode of stream_cli, we should make use of that call-back. @jolly, please have a look into it. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/35070?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I7d02037990f4af405839309510dc6c04e36c3369 Gerrit-Change-Number: 35070 Gerrit-PatchSet: 8 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 05 Mar 2024 14:50:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2024