March 2024 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-netif[master]: osmo_stream_cli_write(): fix double-free of msgb

by pespin

Attention is currently required from: daniel, fixeria, jolly, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36159?usp=email ) Change subject: osmo_stream_cli_write(): fix double-free of msgb ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36159?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I954678acd90593e5311d22a10033c7741f280be3 Gerrit-Change-Number: 36159 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 05 Mar 2024 10:08:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in libosmo-netif[master]: osmo_stream_cli_write(): fix double-free of msgb

by fixeria

Attention is currently required from: daniel, jolly, laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36159?usp=email ) Change subject: osmo_stream_cli_write(): fix double-free of msgb ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > I guess it may be that we actually want to return at the end of that 'ret < 0' clause? not sure if r […] Done. I discussed with @andreas@eversberg.eu and according to him calling `osmo_fd_write_disable()` after `osmo_stream_cli_reconnect()` makes no sense because the later calls `osmo_stream_cli_close()`, which then unregisters the `fd`. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36159?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I954678acd90593e5311d22a10033c7741f280be3 Gerrit-Change-Number: 36159 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 05 Mar 2024 10:07:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in libosmo-netif[master]: osmo_stream_cli_write(): fix double-free of msgb

by fixeria

Attention is currently required from: daniel, fixeria, jolly, pespin. Hello Jenkins Builder, daniel, jolly, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/36159?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: osmo_stream_cli_write(): fix double-free of msgb ...................................................................... osmo_stream_cli_write(): fix double-free of msgb Change-Id: I954678acd90593e5311d22a10033c7741f280be3 Fixes: 48f9a3c2 "stream_cli: Proper handling of send() socket errors" --- M src/stream_cli.c 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/59/36159/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36159?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I954678acd90593e5311d22a10033c7741f280be3 Gerrit-Change-Number: 36159 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 5 months

1
0
0 0

[S] Change in libosmo-sccp[master]: ipa: Use pseudo-random number for SLS in IPA->M3UA direction

by pespin

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/36115?usp=email ) Change subject: ipa: Use pseudo-random number for SLS in IPA->M3UA direction ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/36115?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ia4e66d660b6057338f66a47fffc8a0d32759f733 Gerrit-Change-Number: 36115 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Mar 2024 21:49:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: epdg: Introduce test TC_mt_ipv4_echo_req

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36137?usp=email ) Change subject: epdg: Introduce test TC_mt_ipv4_echo_req ...................................................................... epdg: Introduce test TC_mt_ipv4_echo_req Change-Id: Ie5dc1bd995262f9253cc067c97a82c801b0080e1 --- M epdg/EPDG_Tests.ttcn A epdg/ICMP_Types.ttcn M epdg/gen_links.sh M epdg/regen_makefile.sh 4 files changed, 68 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved laforge: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/epdg/EPDG_Tests.ttcn b/epdg/EPDG_Tests.ttcn index 0d1b10f..fb9f98b 100644 --- a/epdg/EPDG_Tests.ttcn +++ b/epdg/EPDG_Tests.ttcn @@ -6,6 +6,9 @@ import from Osmocom_Types all; import from L3_Common all; import from DNS_Helpers all; +import from IP_Types all; +import from ICMP_Types all; +import from ICMP_Templates all; import from IPA_Emulation all; import from PCO_Types all; @@ -692,6 +695,31 @@ GTP2.send(ts_GTPU_PING(peer, seq := seq_nr)); GTP2.receive(tr_GTPU_PONG(peer)); } +private altstep as_GTPU_rx_icmp4(template (present) PDU_ICMP expected := ?) runs on EPDG_ConnHdlr { + var Gtp1uUnitdata rx_msg; + var template (value) Gtp1uPeer peer := ts_GtpPeerU(f_inet_addr(g_pars.bearer.gtpu_addr_remote)); + + [] GTP2.receive(tr_GTPU_GPDU(peer, g_pars.bearer.teid_local)) -> value rx_msg { + /*TODO: verify gtpu txseq: + if (f_verify_gtpu_txseq(ud.gtpu, use_gtpu_txseq) == false) { + setverdict(fail); + stop; + } + */ + var octetstring gpdu := rx_msg.gtpu.gtpu_IEs.g_PDU_IEs.data; + var IPv4_packet ip4 := f_IPv4_dec(gpdu); + if (ip4.header.ver != 4) { + repeat; + } + var PDU_ICMP icmp4 := f_dec_PDU_ICMP(ip4.payload); + if (not match(icmp4, expected)) { + repeat; + } + } + [] GTP2.receive(Gtp1uUnitdata:?) -> value rx_msg { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, log2str("Unexpected GTP msg rx: ", rx_msg)); + } +} /* GSUP AuthInfo Req + Resp, triggers SWx MAR + MAA. */ private function f_GSUP_AI_success() runs on EPDG_ConnHdlr { @@ -942,6 +970,24 @@ setverdict(pass); } +private function f_TC_mt_ipv4_echo_req(charstring id) runs on EPDG_ConnHdlr { + f_initial_attach(); + /* Dispatch Echo Resp to this component: */ + f_gtp2_register_teid('00000000'O); + var octetstring echo_req := f_gen_icmpv4_echo(f_inet_addr(mp_upf_gtpu_local_ip), f_inet_addr(g_pars.ue_ip)); + f_GTP1U_send(echo_req); + as_GTPU_rx_icmp4((tr_ICMPv4_ERP, tr_ICMPv4_DU)); + f_GSUP_PurgeMS_success(); +} +testcase TC_mt_ipv4_echo_req() runs on MTC_CT { + var EPDG_ConnHdlrPars pars := f_init_pars(); + var EPDG_ConnHdlr vc_conn; + f_init(); + vc_conn := f_start_handler(refers(f_TC_mt_ipv4_echo_req), pars); + vc_conn.done; + setverdict(pass); +} + control { execute ( TC_authinfo_normal() ); execute ( TC_ho_lte_to_wifi() ); @@ -950,6 +996,7 @@ execute ( TC_concurrent_ues2() ); execute ( TC_concurrent_ues100() ); execute ( TC_upf_echo_req() ); + execute ( TC_mt_ipv4_echo_req() ); } } diff --git a/epdg/ICMP_Types.ttcn b/epdg/ICMP_Types.ttcn new file mode 120000 index 0000000..361cad1 --- /dev/null +++ b/epdg/ICMP_Types.ttcn @@ -0,0 +1 @@ +../deps/titan.ProtocolModules.ICMP/src/ICMP_Types.ttcn \ No newline at end of file diff --git a/epdg/gen_links.sh b/epdg/gen_links.sh index ed4209c..7a4e60d 100755 --- a/epdg/gen_links.sh +++ b/epdg/gen_links.sh @@ -17,6 +17,14 @@ FILES="IPL4asp_Functions.ttcn IPL4asp_PT.cc IPL4asp_PT.hh IPL4asp_PortType.ttcn IPL4asp_Types.ttcn IPL4asp_discovery.cc IPL4asp_protocol_L234.hh" gen_links $DIR $FILES +DIR=$BASEDIR/titan.ProtocolModules.IP/src +FILES="IP_EncDec.cc IP_Types.ttcn" +gen_links $DIR $FILES + +DIR=$BASEDIR/titan.ProtocolModules.ICMP/src +FILES="ICMP_EncDec.cc ICMP_Types.ttcn" +gen_links $DIR $FILES + DIR=$BASEDIR/titan.TestPorts.TELNETasp/src FILES="TELNETasp_PT.cc TELNETasp_PT.hh TELNETasp_PortType.ttcn" gen_links $DIR $FILES @@ -54,6 +62,7 @@ FILES+="GTPv1U_CodecPort.ttcn GTPv1U_CodecPort_CtrlFunct.ttcn GTPv1U_CodecPort_CtrlFunctDef.cc GTPv1U_Templates.ttcn " FILES+="GTPv2_PrivateExtensions.ttcn GTPv2_Templates.ttcn " FILES+="GTPv2_CodecPort.ttcn GTPv2_CodecPort_CtrlFunctDef.cc GTPv2_CodecPort_CtrlFunct.ttcn GTPv2_Emulation.ttcn " +FILES+="ICMP_Templates.ttcn " gen_links $DIR $FILES ignore_pp_results diff --git a/epdg/regen_makefile.sh b/epdg/regen_makefile.sh index eb5935e..9aa83b4 100755 --- a/epdg/regen_makefile.sh +++ b/epdg/regen_makefile.sh @@ -9,6 +9,8 @@ IPL4asp_PT.cc IPL4asp_discovery.cc Native_FunctionDefs.cc + IP_EncDec.cc + ICMP_EncDec.cc TCCConversion.cc TCCEncoding.cc TCCInterface.cc -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36137?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie5dc1bd995262f9253cc067c97a82c801b0080e1 Gerrit-Change-Number: 36137 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: epdg: Introduce test TC_upf_echo_req

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36129?usp=email ) Change subject: epdg: Introduce test TC_upf_echo_req ...................................................................... epdg: Introduce test TC_upf_echo_req Change-Id: I3fd96f212175959cb113d2f6a362c0e77e5ca0d7 --- M epdg/EPDG_Tests.ttcn 1 file changed, 61 insertions(+), 6 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/epdg/EPDG_Tests.ttcn b/epdg/EPDG_Tests.ttcn index 92f49ff..0d1b10f 100644 --- a/epdg/EPDG_Tests.ttcn +++ b/epdg/EPDG_Tests.ttcn @@ -144,7 +144,9 @@ /* TEI (Data) local side */ OCT4 teid_local optional, /* TEI (Data) remote side */ - OCT4 teid_remote optional + OCT4 teid_remote optional, + /* GTP-U address of the peer (ePDG) */ + charstring gtpu_addr_remote optional }; type record EPDG_ConnHdlrPars { @@ -194,7 +196,8 @@ bearer := { ebi := omit, teid_local := omit, - teid_remote := omit + teid_remote := omit, + gtpu_addr_remote := omit }, vec := f_gen_auth_vec_3g() }; @@ -509,12 +512,21 @@ private function f_EPDG_ConnHdlr_parse_CreateSessionReq(PDU_GTPCv2 rx_msg) runs on EPDG_ConnHdlr { var BearerContextIEs rx_bctx_ies; + var FullyQualifiedTEID rx_fteid_gtpu; /* Parse TEIC and Bearer EBI and TEID and store it in g_pars */ g_pars.teic_remote := rx_msg.gtpcv2_pdu.createSessionRequest.fullyQualifiedTEID[0].tEID_GRE_Key; rx_bctx_ies := rx_msg.gtpcv2_pdu.createSessionRequest.bearerContextGrouped[0].bearerContextIEs; g_pars.bearer.ebi := rx_bctx_ies.ePS_Bearer_ID.ePS_Bearer_ID_Value; - g_pars.bearer.teid_remote := rx_bctx_ies.fullyQualifiedTEID[0].tEID_GRE_Key; + + rx_fteid_gtpu := rx_bctx_ies.fullyQualifiedTEID[0]; + g_pars.bearer.teid_remote := rx_fteid_gtpu.tEID_GRE_Key; + if (rx_fteid_gtpu.v4_Flag == '1'B) { + g_pars.bearer.gtpu_addr_remote := f_inet_ntoa(rx_fteid_gtpu.iPv4_Address); + } + /*if (rx_fteid_gtpu.v6_Flag == '1'B) { + g_gtpu6_remote := rx_fteid_gtpu.iPv6_Address; + }*/ /* allocate + register TEID-C on local side */ g_pars.teic_local := f_gtp2_allocate_teid(); @@ -666,6 +678,21 @@ as_GTP2C_DeleteBearer_success(); } +private template (value) Gtp1uPeer ts_GtpPeerU(octetstring ip) := { + connId := 1, + remName := f_inet_ntoa(ip), + remPort := GTP1U_PORT +} +private function f_GTP1U_send(octetstring payload) runs on EPDG_ConnHdlr { + var Gtp1uPeer peer := valueof(ts_GtpPeerU(f_inet_addr(g_pars.bearer.gtpu_addr_remote))); + GTP2.send(ts_GTP1U_GPDU(peer, 0 /*seq*/, g_pars.bearer.teid_remote, payload)); +} +private function f_GTP1U_echo_ping_pong(uint16_t seq_nr := 0) runs on EPDG_ConnHdlr { + var Gtp1uPeer peer := valueof(ts_GtpPeerU(f_inet_addr(g_pars.bearer.gtpu_addr_remote))); + GTP2.send(ts_GTPU_PING(peer, seq := seq_nr)); + GTP2.receive(tr_GTPU_PONG(peer)); +} + /* GSUP AuthInfo Req + Resp, triggers SWx MAR + MAA. */ private function f_GSUP_AI_success() runs on EPDG_ConnHdlr { var GSUP_PDU rx_gsup; @@ -710,7 +737,7 @@ /* GSUP TunnelEPDG Tunnel Req + Resp, triggers S2b CreateSession Req + Response. */ private function f_GSUP_EPDGTunnel_success() runs on EPDG_ConnHdlr { var GSUP_PDU rx_gsup; - var template (value) PCO_DATA pco := ts_PCO({ ts_PCO_P_DNS_IPv4, ts_PCO_P_PCSCF_IPv4 }); + var template (value) PCO_DATA pco := PCO_Types.ts_PCO({ ts_PCO_P_DNS_IPv4, ts_PCO_P_PCSCF_IPv4 }); GSUP.send(ts_GSUP_EPDGTunnel_REQ(g_pars.imsi, pco)); as_GTP2C_CreateSession_success(); /* Expect a positive response back to the translator; */ @@ -721,7 +748,7 @@ tr_GSUP_IE_PDP_QOS(?), tr_GSUP_IE_Charging_Characteristics(?) }; - var template (present) PCO_DATA exp_pco := tr_PCO({ + var template (present) PCO_DATA exp_pco := PCO_Types.tr_PCO({ tr_PCO_P_DNS_IPv4(f_inet_addr(mp_s2b_dns_ipv4)), tr_PCO_P_PCSCF_IPv4(f_inet_addr(mp_s2b_pcscf_ipv4)) }); @@ -738,7 +765,7 @@ /* GSUP TunnelEPDG Tunnel Req + Resp, triggers S2b CreateSession Req + Response (rejected). */ private function f_GSUP_EPDGTunnel_error() runs on EPDG_ConnHdlr { var GSUP_PDU rx_gsup; - var template (value) PCO_DATA pco := ts_PCO({ ts_PCO_P_DNS_IPv4, ts_PCO_P_PCSCF_IPv4 }); + var template (value) PCO_DATA pco := PCO_Types.ts_PCO({ ts_PCO_P_DNS_IPv4, ts_PCO_P_PCSCF_IPv4 }); GSUP.send(ts_GSUP_EPDGTunnel_REQ(g_pars.imsi, pco)); as_GTP2C_CreateSession_error(APN_access_denied__no_subscription); alt { @@ -897,6 +924,24 @@ f_TC_concurrent_ues_MTC(100) } +private function f_TC_upf_echo_req(charstring id) runs on EPDG_ConnHdlr { + f_initial_attach(); + /* Dispatch Echo Resp to this component: */ + f_gtp2_register_teid('00000000'O); + f_GTP1U_echo_ping_pong(seq_nr := 0); + /* Send one again, to validate it works several times: */ + f_GTP1U_echo_ping_pong(seq_nr := 1); + f_GSUP_PurgeMS_success(); +} +testcase TC_upf_echo_req() runs on MTC_CT { + var EPDG_ConnHdlrPars pars := f_init_pars(); + var EPDG_ConnHdlr vc_conn; + f_init(); + vc_conn := f_start_handler(refers(f_TC_upf_echo_req), pars); + vc_conn.done; + setverdict(pass); +} + control { execute ( TC_authinfo_normal() ); execute ( TC_ho_lte_to_wifi() ); @@ -904,6 +949,7 @@ execute ( TC_s2b_CreateSession_rejected() ); execute ( TC_concurrent_ues2() ); execute ( TC_concurrent_ues100() ); + execute ( TC_upf_echo_req() ); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36129?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3fd96f212175959cb113d2f6a362c0e77e5ca0d7 Gerrit-Change-Number: 36129 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: ggsn_tests: Split out generic ICMP(v6) related templates and functions

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36130?usp=email ) Change subject: ggsn_tests: Split out generic ICMP(v6) related templates and functions ...................................................................... ggsn_tests: Split out generic ICMP(v6) related templates and functions Change-Id: I53a5da05caeef4cdd59778840a6f4eed489f1b93 --- M ggsn_tests/GGSN_Tests.ttcn M ggsn_tests/gen_links.sh A library/ICMP_Templates.ttcn A library/ICMPv6_Templates.ttcn 4 files changed, 346 insertions(+), 308 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified pespin: Looks good to me, approved laforge: Looks good to me, but someone else must approve diff --git a/ggsn_tests/GGSN_Tests.ttcn b/ggsn_tests/GGSN_Tests.ttcn index 68157f3..55720ee 100644 --- a/ggsn_tests/GGSN_Tests.ttcn +++ b/ggsn_tests/GGSN_Tests.ttcn @@ -31,6 +31,8 @@ import from IP_Types all; import from ICMP_Types all; import from ICMPv6_Types all; + import from ICMP_Templates all; + import from ICMPv6_Templates all; import from Native_Functions all; import from Osmocom_VTY_Functions all; import from TELNETasp_PortType all; @@ -819,285 +821,6 @@ T_default.stop; } - /* IPv6 router solicitation fe80::2 -> ff02::2 from 02:88:b5:1f:25:59 */ - const octetstring c_router_solicit := '6000000000103afffe800000000000000000000000000002ff02000000000000000000000000000285009f2b0000000001010288b51f2559'O; - /* IPv6 neighbor solicitation fe80::2 -> ff02::1:ff00:2 from 02:88:b5:1f:25:59 */ - const octetstring c_neigh_solicit:= '6000000000203afffe800000000000000000000000000002ff0200000000000000000001ff00000287009f9600000000fe80000000000000000000000000000201010288b51f2559'O; - - /* template for sending an ICMPv4 echo request */ - template (value) PDU_ICMP ts_ICMPv4_ERQ(octetstring data := ''O) := { - echo := { - type_field := 8, - code := 0, - checksum := '0000'O, - identifier := '0345'O, - sequence_number := '0001'O, - data := data - } - } - - /* template for receiving/matching an ICMPv4 echo request */ - template (present) PDU_ICMP tr_ICMPv4_ERQ := { - echo := { - type_field := 8, - code := 0, - checksum := ?, - identifier := ?, - sequence_number := ?, - data := ? - } - } - - /* template for receiving/matching an ICMPv4 echo reply */ - template (present) PDU_ICMP tr_ICMPv4_ERP(template octetstring data := *) := { - echo_reply := { - type_field := 0, - code := 0, - checksum := ?, - identifier := ?, - sequence_number := ?, - data := data - } - } - - /* template for receiving/matching an ICMPv6 Destination Unreachable */ - template (present) PDU_ICMP tr_ICMPv4_DU := { - destination_unreachable := { - type_field := 1, - code := ?, - checksum := ?, - unused := ?, - original_ip_msg := ? - } - } - - /* template to construct IPv4_packet from input arguments, ready for use in f_IPv4_enc() */ - template (value) IPv4_packet ts_IP4(OCT4 srcaddr, OCT4 dstaddr, LIN1 proto, LIN2_BO_LAST tlen, octetstring payload) := { - header := { - ver := 4, - hlen := 5, - tos := 0, - tlen := tlen, - id := 35902, - res := '0'B, - dfrag := '1'B, - mfrag := '0'B, - foffset := 0, - ttl := 64, - proto := proto, - cksum := 0, - srcaddr := srcaddr, - dstaddr := dstaddr - }, - ext_headers := omit, - payload := payload - } - - /* template to generate a 'Prefix Information' ICMPv6 option */ - template (value) OptionField ts_ICMP6_OptPrefix(OCT16 prefix, INT1 prefix_len) := { - prefixInformation := { - typeField := 3, - lengthIndicator := 8, - prefixLength := prefix_len, - reserved1 := '000000'B, - a_Bit := '0'B, - l_Bit := '0'B, - validLifetime := oct2int('FFFFFFFF'O), - preferredLifetime := oct2int('FFFFFFFF'O), - reserved2 := '00000000'O, - prefix := prefix - } - } - - /* template for sending an ICMPv6 echo request */ - template (value) PDU_ICMPv6 ts_ICMPv6_ERQ := { - echoRequest := { - typeField := 128, - code := 0, - checksum := '0000'O, - identifier := 0, - sequenceNr := 0, - data := ''O - } - } - - /* template for sending an ICMPv6 router solicitation */ - template (value) PDU_ICMPv6 ts_ICMPv6_RS := { - routerSolicitation := { - typeField := 133, - code := 0, - checksum := '0000'O, - reserved := '00000000'O, - /* TODO: do we need 'Source link-layer address' ? */ - options := omit - } - } - - /* template for sending an ICMPv6 router advertisement */ - template (value) PDU_ICMPv6 ts_ICMPv6_RA(OCT16 prefix, INT1 prefix_len) := { - routerAdvertisement := { - typeField := 134, - code := 0, - checksum := '0000'O, - curHopLimit := 0, - reserved := '000000'B, - o_Bit := '0'B, - m_Bit := '0'B, - routerLifetime := oct2int('FFFF'O), - reachableTime := oct2int('FFFFFFFF'O), - retransTimer := oct2int('FFFFFFFF'O), - options := { - ts_ICMP6_OptPrefix(prefix, prefix_len) - } - } - } - - /* template for sending an ICMPv6 neighbor solicitation */ - template (value) PDU_ICMPv6 ts_ICMPv6_NS(OCT16 target_addr) := { - neighborSolicitation := { - typeField := 135, - code := 0, - checksum := '0000'O, - reserved := '00000000'O, - targetAddress := target_addr, - /* TODO: do we need 'Source link-layer address' ? */ - options := omit - } - } - - /* derive ICMPv6 link-local address from lower 64bit of link_id */ - /* template for receiving/matching an ICMPv6 'Prefix Information' option */ - template (present) OptionField tr_ICMP6_OptPrefix(template (present) OCT16 prefix, template (present) INT1 prefix_len) := { - prefixInformation := { - typeField := 3, - lengthIndicator := 4, - prefixLength := prefix_len, - reserved1 := ?, - a_Bit := ?, - l_Bit := ?, - validLifetime := ?, - preferredLifetime := ?, - reserved2 := ?, - prefix := prefix - } - } - - /* template for receiving/matching an ICMPv6 'MTU' option, rfc4861 4.6.4 */ - template (present) OptionField tr_ICMP6_OptMTU(template (present) integer mtu := ?) := { - mTU := { - typeField := 5, - lengthIndicator := 1, - reserved := ?, - mTU_Value := mtu - } - } - - /* template for receiving/matching an ICMPv6 router advertisement */ - template (present) PDU_ICMPv6 tr_ICMPv6_RA(template (present) OCT16 prefix, template (present) INT1 prefix_len) := { - routerAdvertisement := { - typeField := 134, - code := 0, - checksum := ?, - curHopLimit := ?, - reserved := ?, - o_Bit := '0'B, - m_Bit := '0'B, - routerLifetime := ?, - reachableTime := ?, - retransTimer := ?, - options := ({ tr_ICMP6_OptPrefix(prefix, prefix_len) }, - { tr_ICMP6_OptPrefix(prefix, prefix_len), tr_ICMP6_OptMTU } - ) - } - } - - /* template for receiving/matching an ICMPv6 Destination Unreachable */ - template (present) PDU_ICMPv6 tr_ICMPv6_DU := { - destinationUnreachable := { - typeField := 1, - code := ?, - checksum := ?, - unused := ?, - originalIpMsg := ? - } - } - - /* template for receiving/matching an ICMPv6 echo request */ - template (present) PDU_ICMPv6 tr_ICMPv6_ERQ := { - echoRequest := { - typeField := 128, - code := 0, - checksum := ?, - identifier := ?, - sequenceNr := ?, - data := ? - } - } - - /* template for receiving/matching an ICMPv6 echo reply */ - template (present) PDU_ICMPv6 tr_ICMPv6_ERP(template octetstring data := *) := { - echoReply := { - typeField := 129, - code := 0, - checksum := ?, - identifier := ?, - sequenceNr := ?, - data := data - } - } - - /* template to construct IPv6_packet from input arguments, ready for use in f_IPv6_enc() */ - template (value) IPv6_packet ts_IP6(OCT16 srcaddr, OCT16 dstaddr, LIN1 nexthead, octetstring payload, LIN1 hlim := 255) := { - header := { - ver := 6, - trclass := 0, - flabel := 0, - plen := 0, - nexthead := nexthead, - hlim := hlim, - srcaddr := srcaddr, - dstaddr := dstaddr - }, - ext_headers := omit, - payload := payload - } - - function f_ipv6_link_local(in OCT16 link_id) return OCT16 { - return 'FE80000000000000'O & substr(link_id, 8, 8); - } - - function f_ipv6_global(in OCT16 link_id) return OCT16 { - return substr(link_id, 0, 8) & '1234123412341234'O; - } - - /* Create a new different IPv6 addr from input. Starts mangling at byte prefix. */ - function f_ipv6_mangle(in OCT16 addr, in integer prefix := 0) return OCT16 { - var integer i; - var octetstring res := substr(addr, 0, prefix); - for (i := prefix; i < lengthof(addr); i := i + 1) { - var octetstring a := addr[i] xor4b '11'O; - res := res & a; - } - return res; - } - - /* Compute solicited-node multicast address as per RFC4291 2.7.1 */ - function f_ipv6_sol_node_mcast(in OCT16 addr) return OCT16 { - return 'FF0200000000000000000001FF'O & substr(addr, 13, 3); - } - - /* generate and encode ICMPv6 router solicitation */ - function f_gen_icmpv6_router_solicitation(in OCT16 link_id) return octetstring { - const OCT16 c_ip6_all_router_mcast := 'FF020000000000000000000000000002'O; - var OCT16 saddr := f_ipv6_link_local(link_id); - - var octetstring tmp; - tmp := f_enc_PDU_ICMPv6(valueof(ts_ICMPv6_RS), saddr, c_ip6_all_router_mcast); - var IPv6_packet ip6 := valueof(ts_IP6(saddr, c_ip6_all_router_mcast, 58, tmp)); - - return f_IPv6_enc(ip6); - } - /* Get link-id from PDP Context EUA */ function f_ctx_get_ipv6_interface_id(in PdpContext ctx) return OCT16 { var OCT16 interface_id; @@ -1117,14 +840,6 @@ return f_gen_icmpv6_router_solicitation(interface_id); } - /* generate and encode ICMPv6 neighbor solicitation */ - function f_gen_icmpv6_neigh_solicit(in OCT16 saddr, in OCT16 daddr, in OCT16 tgt_addr) return octetstring { - var octetstring tmp; - tmp := f_enc_PDU_ICMPv6(valueof(ts_ICMPv6_NS(tgt_addr)), saddr, daddr); - var IPv6_packet ip6 := valueof(ts_IP6(saddr, daddr, 58, tmp)); - return f_IPv6_enc(ip6); - } - /* generate and encode ICMPv6 neighbor solicitation for PDP Context */ function f_gen_icmpv6_neigh_solicit_for_pdp(in PdpContext ctx) return octetstring { var OCT16 interface_id := f_ctx_get_ipv6_interface_id(ctx); @@ -1134,25 +849,6 @@ return f_gen_icmpv6_neigh_solicit(link_local, daddr, link_local); } - /* Send an ICMPv4 echo msg through GTP given pdp ctx, and ip src and dst addr */ - function f_gen_icmpv4_echo(OCT4 saddr, OCT4 daddr, octetstring pl := ''O) return octetstring { - var octetstring tmp := f_enc_PDU_ICMP(valueof(ts_ICMPv4_ERQ(pl))); - var IPv4_packet ip4 := valueof(ts_IP4(saddr, daddr, 1, 50, tmp)); - var octetstring data := f_IPv4_enc(ip4); - var OCT2 cksum := f_IPv4_checksum(data); - data[10] := cksum[0]; - data[11] := cksum[1]; - return data; - } - - /* Send an ICMPv6 echo msg through GTP given pdp ctx, and ip src and dst addr */ - function f_gen_icmpv6_echo(OCT16 saddr, OCT16 daddr) return octetstring { - var octetstring tmp := f_enc_PDU_ICMPv6(valueof(ts_ICMPv6_ERQ), saddr, daddr); - var IPv6_packet ip6 := valueof(ts_IP6(saddr, daddr, 58, tmp)); - var octetstring data := f_IPv6_enc(ip6); - return data; - } - /* Wait for ICMPv4 from GTP */ function f_wait_icmp4(PdpContext ctx, template PDU_ICMP expected) runs on GT_CT { var Gtp1uUnitdata ud; @@ -1340,8 +1036,6 @@ f_pdp_ctx_act(ctx); f_PCO_ensure_no_duplicates(ctx.pco_neg); - //f_send_gtpu(ctx, c_router_solicit); - //f_send_gtpu(ctx, c_neigh_solicit); f_send_gtpu(ctx, f_icmpv6_rs_for_pdp(ctx)); f_wait_rtr_adv(ctx); diff --git a/ggsn_tests/gen_links.sh b/ggsn_tests/gen_links.sh index ebeb94b..c79e4a8 100755 --- a/ggsn_tests/gen_links.sh +++ b/ggsn_tests/gen_links.sh @@ -63,6 +63,7 @@ FILES+="GTPv1U_CodecPort.ttcn GTPv1U_CodecPort_CtrlFunct.ttcn GTPv1U_CodecPort_CtrlFunctDef.cc GTPv1U_Templates.ttcn " FILES+="DIAMETER_Types.ttcn DIAMETER_CodecPort.ttcn DIAMETER_CodecPort_CtrlFunct.ttcn DIAMETER_CodecPort_CtrlFunctDef.cc DIAMETER_Emulation.ttcn " FILES+="DIAMETER_Templates.ttcn DIAMETER_ts29_212_Templates.ttcn DIAMETER_ts29_272_Templates.ttcn DIAMETER_ts32_299_Templates.ttcn " +FILES+="ICMP_Templates.ttcn ICMPv6_Templates.ttcn " FILES+="Osmocom_VTY_Functions.ttcn " gen_links $DIR $FILES diff --git a/library/ICMP_Templates.ttcn b/library/ICMP_Templates.ttcn new file mode 100644 index 0000000..cf88e93 --- /dev/null +++ b/library/ICMP_Templates.ttcn @@ -0,0 +1,96 @@ +/* ICMP Templates in TTCN-3 + * (C) 2024 by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> + * All rights reserved. + * + * Released under the terms of GNU General Public License, Version 2 or + * (at your option) any later version. + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +module ICMP_Templates { + + import from General_Types all; + import from IP_Types all; + import from ICMP_Types all; + + /* template for sending an ICMPv4 echo request */ + template (value) PDU_ICMP ts_ICMPv4_ERQ(octetstring data := ''O) := { + echo := { + type_field := 8, + code := 0, + checksum := '0000'O, + identifier := '0345'O, + sequence_number := '0001'O, + data := data + } + } + + /* template for receiving/matching an ICMPv4 echo request */ + template (present) PDU_ICMP tr_ICMPv4_ERQ := { + echo := { + type_field := 8, + code := 0, + checksum := ?, + identifier := ?, + sequence_number := ?, + data := ? + } + } + + /* template for receiving/matching an ICMPv4 echo reply */ + template (present) PDU_ICMP tr_ICMPv4_ERP(template octetstring data := *) := { + echo_reply := { + type_field := 0, + code := 0, + checksum := ?, + identifier := ?, + sequence_number := ?, + data := data + } + } + + /* template for receiving/matching an ICMPv6 Destination Unreachable */ + template (present) PDU_ICMP tr_ICMPv4_DU := { + destination_unreachable := { + type_field := 1, + code := ?, + checksum := ?, + unused := ?, + original_ip_msg := ? + } + } + + /* template to construct IPv4_packet from input arguments, ready for use in f_IPv4_enc() */ + template (value) IPv4_packet ts_IP4(OCT4 srcaddr, OCT4 dstaddr, LIN1 proto, LIN2_BO_LAST tlen, octetstring payload) := { + header := { + ver := 4, + hlen := 5, + tos := 0, + tlen := tlen, + id := 35902, + res := '0'B, + dfrag := '1'B, + mfrag := '0'B, + foffset := 0, + ttl := 64, + proto := proto, + cksum := 0, + srcaddr := srcaddr, + dstaddr := dstaddr + }, + ext_headers := omit, + payload := payload + } + + /* Send an ICMPv4 echo msg through GTP given pdp ctx, and ip src and dst addr */ + function f_gen_icmpv4_echo(OCT4 saddr, OCT4 daddr, octetstring pl := ''O) return octetstring { + var octetstring tmp := f_enc_PDU_ICMP(valueof(ts_ICMPv4_ERQ(pl))); + var IPv4_packet ip4 := valueof(ts_IP4(saddr, daddr, 1, 50, tmp)); + var octetstring data := f_IPv4_enc(ip4); + var OCT2 cksum := f_IPv4_checksum(data); + data[10] := cksum[0]; + data[11] := cksum[1]; + return data; + } +} \ No newline at end of file diff --git a/library/ICMPv6_Templates.ttcn b/library/ICMPv6_Templates.ttcn new file mode 100644 index 0000000..687aad4 --- /dev/null +++ b/library/ICMPv6_Templates.ttcn @@ -0,0 +1,238 @@ +/* ICMPv6 Templates in TTCN-3 + * (C) 2024 by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> + * All rights reserved. + * + * Released under the terms of GNU General Public License, Version 2 or + * (at your option) any later version. + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +module ICMPv6_Templates { + + import from General_Types all; + import from IP_Types all; + import from ICMPv6_Types all; + + /* template to generate a 'Prefix Information' ICMPv6 option */ + template (value) OptionField ts_ICMP6_OptPrefix(OCT16 prefix, INT1 prefix_len) := { + prefixInformation := { + typeField := 3, + lengthIndicator := 8, + prefixLength := prefix_len, + reserved1 := '000000'B, + a_Bit := '0'B, + l_Bit := '0'B, + validLifetime := oct2int('FFFFFFFF'O), + preferredLifetime := oct2int('FFFFFFFF'O), + reserved2 := '00000000'O, + prefix := prefix + } + } + + /* template for sending an ICMPv6 echo request */ + template (value) PDU_ICMPv6 ts_ICMPv6_ERQ := { + echoRequest := { + typeField := 128, + code := 0, + checksum := '0000'O, + identifier := 0, + sequenceNr := 0, + data := ''O + } + } + + /* template for sending an ICMPv6 router solicitation */ + template (value) PDU_ICMPv6 ts_ICMPv6_RS := { + routerSolicitation := { + typeField := 133, + code := 0, + checksum := '0000'O, + reserved := '00000000'O, + /* TODO: do we need 'Source link-layer address' ? */ + options := omit + } + } + + /* template for sending an ICMPv6 router advertisement */ + template (value) PDU_ICMPv6 ts_ICMPv6_RA(OCT16 prefix, INT1 prefix_len) := { + routerAdvertisement := { + typeField := 134, + code := 0, + checksum := '0000'O, + curHopLimit := 0, + reserved := '000000'B, + o_Bit := '0'B, + m_Bit := '0'B, + routerLifetime := oct2int('FFFF'O), + reachableTime := oct2int('FFFFFFFF'O), + retransTimer := oct2int('FFFFFFFF'O), + options := { + ts_ICMP6_OptPrefix(prefix, prefix_len) + } + } + } + + /* template for sending an ICMPv6 neighbor solicitation */ + template (value) PDU_ICMPv6 ts_ICMPv6_NS(OCT16 target_addr) := { + neighborSolicitation := { + typeField := 135, + code := 0, + checksum := '0000'O, + reserved := '00000000'O, + targetAddress := target_addr, + /* TODO: do we need 'Source link-layer address' ? */ + options := omit + } + } + + /* derive ICMPv6 link-local address from lower 64bit of link_id */ + /* template for receiving/matching an ICMPv6 'Prefix Information' option */ + template (present) OptionField tr_ICMP6_OptPrefix(template (present) OCT16 prefix, template (present) INT1 prefix_len) := { + prefixInformation := { + typeField := 3, + lengthIndicator := 4, + prefixLength := prefix_len, + reserved1 := ?, + a_Bit := ?, + l_Bit := ?, + validLifetime := ?, + preferredLifetime := ?, + reserved2 := ?, + prefix := prefix + } + } + + /* template for receiving/matching an ICMPv6 'MTU' option, rfc4861 4.6.4 */ + template (present) OptionField tr_ICMP6_OptMTU(template (present) integer mtu := ?) := { + mTU := { + typeField := 5, + lengthIndicator := 1, + reserved := ?, + mTU_Value := mtu + } + } + + /* template for receiving/matching an ICMPv6 router advertisement */ + template (present) PDU_ICMPv6 tr_ICMPv6_RA(template (present) OCT16 prefix, template (present) INT1 prefix_len) := { + routerAdvertisement := { + typeField := 134, + code := 0, + checksum := ?, + curHopLimit := ?, + reserved := ?, + o_Bit := '0'B, + m_Bit := '0'B, + routerLifetime := ?, + reachableTime := ?, + retransTimer := ?, + options := ({ tr_ICMP6_OptPrefix(prefix, prefix_len) }, + { tr_ICMP6_OptPrefix(prefix, prefix_len), tr_ICMP6_OptMTU } + ) + } + } + + /* template for receiving/matching an ICMPv6 Destination Unreachable */ + template (present) PDU_ICMPv6 tr_ICMPv6_DU := { + destinationUnreachable := { + typeField := 1, + code := ?, + checksum := ?, + unused := ?, + originalIpMsg := ? + } + } + + /* template for receiving/matching an ICMPv6 echo request */ + template (present) PDU_ICMPv6 tr_ICMPv6_ERQ := { + echoRequest := { + typeField := 128, + code := 0, + checksum := ?, + identifier := ?, + sequenceNr := ?, + data := ? + } + } + + /* template for receiving/matching an ICMPv6 echo reply */ + template (present) PDU_ICMPv6 tr_ICMPv6_ERP(template octetstring data := *) := { + echoReply := { + typeField := 129, + code := 0, + checksum := ?, + identifier := ?, + sequenceNr := ?, + data := data + } + } + + /* template to construct IPv6_packet from input arguments, ready for use in f_IPv6_enc() */ + template (value) IPv6_packet ts_IP6(OCT16 srcaddr, OCT16 dstaddr, LIN1 nexthead, octetstring payload, LIN1 hlim := 255) := { + header := { + ver := 6, + trclass := 0, + flabel := 0, + plen := 0, + nexthead := nexthead, + hlim := hlim, + srcaddr := srcaddr, + dstaddr := dstaddr + }, + ext_headers := omit, + payload := payload + } + + function f_ipv6_link_local(in OCT16 link_id) return OCT16 { + return 'FE80000000000000'O & substr(link_id, 8, 8); + } + + function f_ipv6_global(in OCT16 link_id) return OCT16 { + return substr(link_id, 0, 8) & '1234123412341234'O; + } + + /* Create a new different IPv6 addr from input. Starts mangling at byte prefix. */ + function f_ipv6_mangle(in OCT16 addr, in integer prefix := 0) return OCT16 { + var integer i; + var octetstring res := substr(addr, 0, prefix); + for (i := prefix; i < lengthof(addr); i := i + 1) { + var octetstring a := addr[i] xor4b '11'O; + res := res & a; + } + return res; + } + + /* Send an ICMPv6 echo msg through GTP given pdp ctx, and ip src and dst addr */ + function f_gen_icmpv6_echo(OCT16 saddr, OCT16 daddr) return octetstring { + var octetstring tmp := f_enc_PDU_ICMPv6(valueof(ts_ICMPv6_ERQ), saddr, daddr); + var IPv6_packet ip6 := valueof(ts_IP6(saddr, daddr, 58, tmp)); + var octetstring data := f_IPv6_enc(ip6); + return data; + } + + /* Compute solicited-node multicast address as per RFC4291 2.7.1 */ + function f_ipv6_sol_node_mcast(in OCT16 addr) return OCT16 { + return 'FF0200000000000000000001FF'O & substr(addr, 13, 3); + } + + /* generate and encode ICMPv6 router solicitation */ + function f_gen_icmpv6_router_solicitation(in OCT16 link_id) return octetstring { + const OCT16 c_ip6_all_router_mcast := 'FF020000000000000000000000000002'O; + var OCT16 saddr := f_ipv6_link_local(link_id); + + var octetstring tmp; + tmp := f_enc_PDU_ICMPv6(valueof(ts_ICMPv6_RS), saddr, c_ip6_all_router_mcast); + var IPv6_packet ip6 := valueof(ts_IP6(saddr, c_ip6_all_router_mcast, 58, tmp)); + + return f_IPv6_enc(ip6); + } + + /* generate and encode ICMPv6 neighbor solicitation */ + function f_gen_icmpv6_neigh_solicit(in OCT16 saddr, in OCT16 daddr, in OCT16 tgt_addr) return octetstring { + var octetstring tmp; + tmp := f_enc_PDU_ICMPv6(valueof(ts_ICMPv6_NS(tgt_addr)), saddr, daddr); + var IPv6_packet ip6 := valueof(ts_IP6(saddr, daddr, 58, tmp)); + return f_IPv6_enc(ip6); + } + +} \ No newline at end of file -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36130?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I53a5da05caeef4cdd59778840a6f4eed489f1b93 Gerrit-Change-Number: 36130 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: epdg: Introduce test TC_mt_ipv4_echo_req

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36137?usp=email ) Change subject: epdg: Introduce test TC_mt_ipv4_echo_req ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36137?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie5dc1bd995262f9253cc067c97a82c801b0080e1 Gerrit-Change-Number: 36137 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Mar 2024 21:47:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: ggsn_tests: Split out generic ICMP(v6) related templates and functions

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36130?usp=email ) Change subject: ggsn_tests: Split out generic ICMP(v6) related templates and functions ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36130?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I53a5da05caeef4cdd59778840a6f4eed489f1b93 Gerrit-Change-Number: 36130 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Mar 2024 21:47:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: epdg: Introduce test TC_upf_echo_req

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36129?usp=email ) Change subject: epdg: Introduce test TC_upf_echo_req ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Patchset: PS3: Merging now since the related docker-playground patch was merged. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36129?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3fd96f212175959cb113d2f6a362c0e77e5ca0d7 Gerrit-Change-Number: 36129 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 04 Mar 2024 21:47:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2024