March 2024 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-netif[master]: stream_cli: Correctly setup and free osmo_io client instance

by daniel

Attention is currently required from: jolly, pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/35979?usp=email ) Change subject: stream_cli: Correctly setup and free osmo_io client instance ...................................................................... Patch Set 7: Code-Review-1 (1 comment) Patchset: PS7: Can you explain why you need to free the iofd? There seems to (now) be a memory leak in osmo_stream_cli_open(). The old code I'm looking at locally has this in the open function to guard against: ```c if (!cli->iofd) cli->iofd = osmo_iofd_setup(cli, fd, cli->name, OSMO_IO_FD_MODE_READ_WRITE, &osmo_stream_cli_ioops, cli); if (!cli->iofd) goto error_close_socket; ``` It seems it was removed in commit 7e6d2e0f99ff095f4714f03b1ed991d6c9cb9c61 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/35979?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I91a6a76b9ff96034a7b333edf87af27490202932 Gerrit-Change-Number: 35979 Gerrit-PatchSet: 7 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Mar 2024 16:47:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in libosmo-netif[master]: stream_cli: Do not try to send msg, if socket is disconnected

by daniel

Attention is currently required from: jolly, laforge, pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36123?usp=email ) Change subject: stream_cli: Do not try to send msg, if socket is disconnected ...................................................................... Patch Set 6: (1 comment) File src/stream_cli.c: https://gerrit.osmocom.org/c/libosmo-netif/+/36123/comment/c06b8dc7_cedf02db PS4, Line 998: if (cli->state != STREAM_CLI_STATE_CONNECTED) { > I'm not sure if this breaks some assumptions user code makes while in STREAM_STATE_CLI_WAIT_RECONNE […] Ok, I now see that https://gerrit.osmocom.org/c/libosmo-netif/+/35979 gets rid of the iofd on close so there's no (osmo_io) tx-queue to access then. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36123?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I9e5f5db9b45615dacb05115c4de8ff3f715815c8 Gerrit-Change-Number: 36123 Gerrit-PatchSet: 6 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Mar 2024 16:37:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andreas(a)eversberg.eu> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in libosmo-netif[master]: stream_cli: Call read callback even if connection failed

by daniel

Attention is currently required from: jolly, laforge, pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36020?usp=email ) Change subject: stream_cli: Call read callback even if connection failed ...................................................................... Patch Set 6: Code-Review-1 (1 comment) File src/stream_cli.c: https://gerrit.osmocom.org/c/libosmo-netif/+/36020/comment/5ac09234_6c6e0296 PS6, Line 448: /* Forward message to read callback, also if the connection failed. */ Not sure why this is necessary - cli->disconnect_cb() called by osmo_stream_cli_reconnect() above already notifies the client of the disconnect. The read/msgb will be empty anyway. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36020?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ie2335987c38863bad5de1d2d4dbdf4c8373f927f Gerrit-Change-Number: 36020 Gerrit-PatchSet: 6 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Mar 2024 16:27:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: stp: add and use f_m3ua_{cli,srv}_config() helpers

by fixeria

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36148?usp=email ) Change subject: stp: add and use f_m3ua_{cli,srv}_config() helpers ...................................................................... Patch Set 1: (1 comment) File stp/STP_Tests_M3UA.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36148/comment/e6b1d78a_113a… PS1, Line 110: mtc.stop; > f_shutdown() I am not entirely sure if we really need it here. This API is not used in the STP testsuite, I guess because there is simply no complex component hierarchy that would require graceful shutdown. If we still want to use `f_shutdown()` here (e.g. for logging `filename:line`), then the whole STP testsuite needs to me migrated to it (in a separate patch). The `mtc.stop` approach is consistent with the existing code. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36148?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9788f52c20574f4f9d015d2de11b5e42bb03d15f Gerrit-Change-Number: 36148 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Mar 2024 16:19:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: stp: prepare for testing M3UA-over-TCP

by fixeria

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36149?usp=email ) Change subject: stp: prepare for testing M3UA-over-TCP ...................................................................... Patch Set 1: (1 comment) File stp/STP_Tests_M3UA.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36149/comment/e71d6125_c57b… PS1, Line 285: if (not Misc_Helpers.f_osmo_repo_is("nightly")) { > I don't see why do we want to add this code here, what's the benefit? There is no benefit. It's needed because doing this unconditionally would make **all** testcases fail for the -latest osmo-stp, because it does not support M3UA-over-TCP. > we then need to maintain and remove this at some point Just like any other IUT version specific quirks, right? Nothing new here. > Just let it fail below if running against some other version. No, we don't want to let all testcases fail for the -latest. Just to make it clear, this testsuite is written in a way that for each testcase we establish connections with all ASPs configured in `mp_m3ua_configs[]` (even if a testcase talks to one or two of them). In this patch I am adding new ASPs using TCP, so here I simply skip those for `!= "nightly"` and ensure that the existing testcases are still passing for the -latest. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36149?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5d0b05aa434c057ad379125ac293f5fc9a240b6f Gerrit-Change-Number: 36149 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Mar 2024 16:15:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: stp: Add expected-results.xml

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36156?usp=email ) Change subject: stp: Add expected-results.xml ...................................................................... stp: Add expected-results.xml Somehow we didn't yet have this file at all for the stp test suite Change-Id: I3346f7c50f332136380d184b43fe173c28cad778 --- A stp/expected-results.xml 1 file changed, 60 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/56/36156/1 diff --git a/stp/expected-results.xml b/stp/expected-results.xml new file mode 100644 index 0000000..0f6073b --- /dev/null +++ b/stp/expected-results.xml @@ -0,0 +1,49 @@ +<?xml version="1.0"?> +<testsuite name='STP_Tests' tests='46' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'> + <testcase classname='STP_Tests_M3UA' name='TC_connect_asp_up' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_beat' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_beat_payload' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_asp_act' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_asp_act_override' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_asp_act_loadshare' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_asp_act_broadcast' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_tmt_override' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_tmt_loadshare' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_tmt_broadcast' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_act_rctx_data_no_rctx' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_rkm_reg_static_notpermitted' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_rkm_reg_static_permitted' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_rkm_reg_dynamic_permitted' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_rkm_unreg_never_registered' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_rkm_unreg_invalid' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_rkm_unreg_registered' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_rkm_unreg_active' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_clnt_connect_asp_up' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_clnt_asp_act' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_clnt_sg_to_asp' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_clnt_asp_to_sg' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_clnt_sg_to_asp_norctx' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_clnt_asp_to_sg_norctx' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_clnt_quirk_no_notify_asp_act' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_clnt_no_daud_in_asp' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_clnt_quirk_daud_in_asp' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_clnt_no_snm_inactive' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_clnt_quirk_snm_inactive' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_ssnm_aspac_dava_aspia_duna' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_ssnm_distribution_dava_duna' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_ssnm_distribution_dava_duna_multipc' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_ssnm_distribution_dupu' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_ssnm_distribution_scon' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_clnt_asp_act_tmt_loadshare' time='MASKED'/> + <testcase classname='STP_Tests_IPA' name='TC_unknown_client_nodynamic' time='MASKED'/> + <testcase classname='STP_Tests_IPA' name='TC_known_client_nodynamic' time='MASKED'/> + <testcase classname='STP_Tests_IPA' name='TC_unknown_client_dynamic' time='MASKED'/> + <testcase classname='STP_Tests_IPA' name='TC_tmt_override' time='MASKED'/> + <testcase classname='STP_Tests_IPA' name='TC_unknown_client_dynamic_tmt_override' time='MASKED'/> + <testcase classname='STP_Tests_IPA' name='TC_tmt_loadshare' time='MASKED'/> + <testcase classname='STP_Tests_IPA' name='TC_unknown_client_dynamic_tmt_loadshare' time='MASKED'/> + <testcase classname='STP_Tests' name='TC_m3ua_to_ipa' time='MASKED'/> + <testcase classname='STP_Tests' name='TC_ipa_to_m3ua' time='MASKED'/> + <testcase classname='STP_Tests' name='TC_ipa_to_m3ua_ni' time='MASKED'/> + <testcase classname='STP_Tests' name='TC_ipa_to_m3ua_patch_sccp' time='MASKED'/> +</testsuite> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36156?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3346f7c50f332136380d184b43fe173c28cad778 Gerrit-Change-Number: 36156 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: various: update expected-results.xml

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36157?usp=email ) Change subject: various: update expected-results.xml ...................................................................... various: update expected-results.xml Change-Id: I21052636bf892e5da86ef736d16035ec324aedbe --- M bsc/expected-results.xml M hlr/expected-results.xml M hnbgw/expected-results.xml M mgw/expected-results.xml M pcu/expected-results.xml M pgw/expected-results.xml M sgsn/expected-results.xml M sip/expected-results.xml M upf/expected-results.xml 9 files changed, 74 insertions(+), 17 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/57/36157/1 diff --git a/bsc/expected-results.xml b/bsc/expected-results.xml index eaa863b..2d69eee 100644 --- a/bsc/expected-results.xml +++ b/bsc/expected-results.xml @@ -1,5 +1,5 @@ <?xml version="1.0"?> -<testsuite name='BSC_Tests' tests='297' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'> +<testsuite name='BSC_Tests' tests='317' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'> <testcase classname='BSC_Tests' name='TC_ctrl_msc_connection_status' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_ctrl_msc0_connection_status' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_stat_num_msc_connected_1' time='MASKED'/> @@ -24,6 +24,7 @@ <testcase classname='BSC_Tests' name='TC_si2quater_49_earfcns' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_si_acc_rotate' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_si_acc_ramp_rotate' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_si2_ncc_permitted' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_chan_act_noreply' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_chan_act_counter' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_chan_act_ack_noest' time='MASKED'/> @@ -219,6 +220,8 @@ <testcase classname='BSC_Tests' name='TC_mscpool_paging_and_response_tmsi' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_mscpool_no_allow_attach_round_robin' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_mscpool_no_allow_attach_valid_nri' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_mscpool_sccp_n_pcstate_detaches_msc' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_mscpool_sccp_n_pcstate_attaches_msc' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_early_conn_fail' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_late_conn_fail' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_stats_conn_fail' time='MASKED'/> @@ -264,10 +267,12 @@ <testcase classname='BSC_Tests' name='TC_chan_alloc_algo_ass_dynamic' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_mgwpool_all_used' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_mgwpool_blocked_not_used' time='MASKED'/> - <testcase classname='BSC_Tests' name='TC_mgwpool_keepalive_down_not_used' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_mgwpool_pin_bts' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_mgwpool_keepalive_down_not_used' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_ho_meas_rep_multi_band' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_ho_out_of_this_bsc' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_unbreak_lchan_after_missing_rel_ack_1' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_unbreak_lchan_after_missing_rel_ack_2' time='MASKED'/> <testcase classname='BSC_Tests_LCLS' name='TC_lcls_gcr_only' time='MASKED'/> <testcase classname='BSC_Tests_LCLS' name='TC_lcls_gcr_bway_connect' time='MASKED'/> <testcase classname='BSC_Tests_LCLS' name='TC_lcls_gcr_bway_connect_hr' time='MASKED'/> diff --git a/hlr/expected-results.xml b/hlr/expected-results.xml index 2175a81..0ed9798 100644 --- a/hlr/expected-results.xml +++ b/hlr/expected-results.xml @@ -1,11 +1,12 @@ <?xml version="1.0"?> -<testsuite name='Titan' tests='37' failures='5' errors='0' skipped='0' inconc='0' time='MASKED'> +<testsuite name='Titan' tests='38' failures='3' errors='2' skipped='0' inconc='0' time='MASKED'> <testcase classname='HLR_Tests' name='TC_gsup_sai_err_invalid_imsi' time='MASKED'/> <testcase classname='HLR_Tests' name='TC_gsup_sai' time='MASKED'/> <testcase classname='HLR_Tests' name='TC_gsup_sai_num_auth_vectors' time='MASKED'/> <testcase classname='HLR_Tests' name='TC_gsup_sai_eps' time='MASKED'/> <testcase classname='HLR_Tests' name='TC_gsup_ul_unknown_imsi' time='MASKED'/> <testcase classname='HLR_Tests' name='TC_gsup_ul_unknown_imsi_via_proxy' time='MASKED'/> + <testcase classname='HLR_Tests' name='TC_gsup_ul_unknown_imsi_roaming_not_allowed' time='MASKED'/> <testcase classname='HLR_Tests' name='TC_gsup_sai_err_unknown_imsi' time='MASKED'/> <testcase classname='HLR_Tests' name='TC_gsup_ul' time='MASKED'/> <testcase classname='HLR_Tests' name='TC_gsup_ul_via_proxy' time='MASKED'/> diff --git a/hnbgw/expected-results.xml b/hnbgw/expected-results.xml index fb86108..a48c232 100644 --- a/hnbgw/expected-results.xml +++ b/hnbgw/expected-results.xml @@ -1,8 +1,8 @@ <?xml version="1.0"?> -<testsuite name='Titan' tests='13' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'> +<testsuite name='Titan' tests='42' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'> <testcase classname='HNBGW_Tests' name='TC_hnb_register' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_hnb_register_duplicate' time='MASKED'/> - <testcase classname='HNBGW_Tests' name='TC_hnb_register_duplicate_reuse_sctp_assoc' time='MASKED' + <testcase classname='HNBGW_Tests' name='TC_hnb_register_duplicate_reuse_sctp_assoc' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_ranap_cs_initial_ue' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_ranap_ps_initial_ue' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_ranap_cs_initial_ue_empty_cr' time='MASKED'/> @@ -17,5 +17,29 @@ <testcase classname='HNBGW_Tests' name='TC_ranap_cs_mo_disconnect' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_ranap_ps_mo_disconnect' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_ps_rab_assignment_without_pfcp' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_mscpool_L3Compl_on_1_cnlink' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_mscpool_L3Complete_by_imsi_round_robin' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_mscpool_LU_by_tmsi_null_nri_0_round_robin' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_mscpool_LU_by_tmsi_null_nri_1_round_robin' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_mscpool_L3Complete_by_tmsi_unassigned_nri_round_robin' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_mscpool_L3Complete_by_tmsi_valid_nri_msc_not_connected_round_robin' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_mscpool_L3Complete_by_tmsi_valid_nri_1' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_mscpool_L3Complete_by_tmsi_valid_nri_2' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_mscpool_LU_by_tmsi_from_other_PLMN' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_mscpool_paging_imsi' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_mscpool_paging_tmsi' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_mscpool_no_allow_attach_round_robin' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_mscpool_no_allow_attach_valid_nri' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_mscpool_sccp_n_pcstate_detaches_cnlink' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_mscpool_sccp_n_pcstate_attaches_cnlink' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_sgsnpool_L3Compl_on_1_cnlink' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_sgsnpool_L3Complete_no_nri_round_robin' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_sgsnpool_L3Complete_valid_nri_1' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_sgsnpool_L3Complete_valid_nri_2' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_sgsnpool_nri_from_other_PLMN' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_sgsnpool_sccp_n_pcstate_detaches_cnlink' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_sgsnpool_sccp_n_pcstate_attaches_cnlink' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_second_rab_assignment' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_hnb_reregister_reuse_sctp_assoc' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_apply_sccp' time='MASKED'/> </testsuite> diff --git a/mgw/expected-results.xml b/mgw/expected-results.xml index 3c438bd..d9b9a15 100644 --- a/mgw/expected-results.xml +++ b/mgw/expected-results.xml @@ -1,5 +1,5 @@ <?xml version="1.0"?> -<testsuite name='Titan' tests='71' failures='8' errors='0' skipped='0' inconc='0' time='MASKED'> +<testsuite name='Titan' tests='84' failures='5' errors='0' skipped='0' inconc='0' time='MASKED'> <testcase classname='MGCP_Test' name='TC_selftest' time='MASKED'/> <testcase classname='MGCP_Test' name='TC_auep_null' time='MASKED'/> <testcase classname='MGCP_Test' name='TC_crcx' time='MASKED'/> @@ -35,6 +35,7 @@ <testcase classname='MGCP_Test' name='TC_one_crcx_loopback_osmux' time='MASKED'/> <testcase classname='MGCP_Test' name='TC_two_crcx_and_rtp_osmux' time='MASKED'/> <testcase classname='MGCP_Test' name='TC_two_crcx_and_rtp_osmux_bidir' time='MASKED'/> + <testcase classname='MGCP_Test' name='TC_two_crcx_and_rtp_osmux_bidir_amr_bwe' time='MASKED'/> <testcase classname='MGCP_Test' name='TC_two_crcx_mdcx_and_rtp_osmux_wildcard' time='MASKED'/> <testcase classname='MGCP_Test' name='TC_two_crcx_mdcx_and_rtp_osmux_fixed' time='MASKED'/> <testcase classname='MGCP_Test' name='TC_crcx_dlcx_30ep' time='MASKED'/> @@ -49,10 +50,16 @@ <testcase classname='MGCP_Test' name='TC_two_crcx_mdcx_and_rtp' time='MASKED'/> <testcase classname='MGCP_Test' name='TC_two_crcx_and_unsolicited_rtp' time='MASKED'/> <testcase classname='MGCP_Test' name='TC_two_crcx_and_one_mdcx_rtp_ho' time='MASKED'/> + <testcase classname='MGCP_Test' name='TC_two_crcx_confecho_sendonly_rtp' time='MASKED'/> <testcase classname='MGCP_Test' name='TC_ts101318_rfc5993_rtp_conversion' time='MASKED'/> + <testcase classname='MGCP_Test' name='TC_ts101318_rfc5993_rtp_conversion_fmtp' time='MASKED'/> <testcase classname='MGCP_Test' name='TC_amr_oa_bwe_rtp_conversion' time='MASKED'/> <testcase classname='MGCP_Test' name='TC_amr_oa_oa_rtp_conversion' time='MASKED'/> <testcase classname='MGCP_Test' name='TC_amr_bwe_bwe_rtp_conversion' time='MASKED'/> + <testcase classname='MGCP_Test' name='TC_amr_oa_oa_no_bwe_rtp_conversion' time='MASKED'/> + <testcase classname='MGCP_Test' name='TC_amr_oa_no_bwe_oa_rtp_conversion' time='MASKED'/> + <testcase classname='MGCP_Test' name='TC_amr_bwe_bwe_no_oa_rtp_conversion' time='MASKED'/> + <testcase classname='MGCP_Test' name='TC_amr_bwe_no_oa_bwe_rtp_conversion' time='MASKED'/> <testcase classname='MGCP_Test' name='TC_conn_timeout' time='MASKED'/> <testcase classname='MGCP_Test' name='TC_e1_crcx_and_dlcx_ep' time='MASKED'> <failure type='fail-verdict'>Response didn't match template @@ -82,15 +89,15 @@ <testcase classname='MGCP_Test' name='TC_crcx_mdcx_ip6' time='MASKED'/> <testcase classname='MGCP_Test' name='TC_two_crcx_mdcx_and_rtp_ipv4_ipv6' time='MASKED'/> <testcase classname='MGCP_Test' name='TC_two_crcx_mdcx_and_rtp_ipv6' time='MASKED'/> - <testcase classname='MGCP_Test' name='TC_two_crcx_and_rtp_osmux_bidir_ipv6' time='MASKED' /> - <testcase classname='MGCP_Test' name='TC_two_crcx_and_rtp_osmux_bidir_ipv4_ipv6' time='MASKED' /> + <testcase classname='MGCP_Test' name='TC_two_crcx_and_rtp_osmux_bidir_ipv6' time='MASKED'/> + <testcase classname='MGCP_Test' name='TC_two_crcx_and_rtp_osmux_bidir_ipv4_ipv6' time='MASKED'/> <testcase classname='MGCP_Test' name='TC_two_crcx_and_rtp_osmux_bidir_ipv6_ipv4' time='MASKED'/> - <testcase classname='MGCP_Test' name='TC_two_crcx_mdcx_and_rtp_osmux_ipv6' time='MASKED' /> - <testcase classname='MGCP_Test' name='TC_two_crcx_mdcx_and_rtp_osmux_ipv4_ipv6' time='MASKED' /> + <testcase classname='MGCP_Test' name='TC_two_crcx_mdcx_and_rtp_osmux_ipv6' time='MASKED'/> + <testcase classname='MGCP_Test' name='TC_two_crcx_mdcx_and_rtp_osmux_ipv4_ipv6' time='MASKED'/> <testcase classname='MGCP_Test' name='TC_two_crcx_mdcx_and_rtp_osmux_ipv6_ipv4' time='MASKED'/> <testcase classname='MGCP_Test' name='TC_two_crcx_mdcx_and_iuup' time='MASKED'/> - <testcase classname='MGCP_Test' name='TC_two_crcx_mdcx_and_iuup_mdcx_recvonly' time='MASKED'/> <testcase classname='MGCP_Test' name='TC_two_crcx_mdcx_and_iuup_rfci_unordered' time='MASKED'/> + <testcase classname='MGCP_Test' name='TC_two_crcx_mdcx_and_iuup_mdcx_recvonly' time='MASKED'/> <testcase classname='MGCP_Test' name='TC_two_crcx_mdcx_and_iuup_rtp' time='MASKED'/> <testcase classname='MGCP_Test' name='TC_two_crcx_mdcx_and_iuup_rtp_rfci_unordered' time='MASKED'/> <testcase classname='MGCP_Test' name='TC_two_crcx_mdcx_and_iuup_rtp_mdcx_recvonly' time='MASKED'/> diff --git a/pcu/expected-results.xml b/pcu/expected-results.xml index 2a25934..17d95cc 100644 --- a/pcu/expected-results.xml +++ b/pcu/expected-results.xml @@ -1,5 +1,5 @@ <?xml version="1.0"?> -<testsuite name='Titan' tests='110' failures='4' errors='0' skipped='0' inconc='0' time='MASKED'> +<testsuite name='Titan' tests='117' failures='5' errors='0' skipped='0' inconc='0' time='MASKED'> <testcase classname='PCU_Tests' name='TC_pcuif_suspend' time='MASKED'/> <testcase classname='PCU_Tests' name='TC_pcuif_suspend_active_tbf' time='MASKED'/> <testcase classname='PCU_Tests' name='TC_ta_ptcch_idle' time='MASKED'/> @@ -108,6 +108,8 @@ <testcase classname='PCU_Tests' name='TC_multiplex_dl_gprs_egprs' time='MASKED'/> <testcase classname='PCU_Tests' name='TC_pcuif_info_ind_subsequent' time='MASKED'/> <testcase classname='PCU_Tests' name='TC_nacc_outbound_success' time='MASKED'/> + <testcase classname='PCU_Tests' name='TC_nacc_outbound_success_utran' time='MASKED'/> + <testcase classname='PCU_Tests' name='TC_nacc_outbound_success_eutran' time='MASKED'/> <testcase classname='PCU_Tests' name='TC_nacc_outbound_success_no_ctrl_ack' time='MASKED'/> <testcase classname='PCU_Tests' name='TC_nacc_outbound_success_twice' time='MASKED'/> <testcase classname='PCU_Tests' name='TC_nacc_outbound_success_twice_nocache' time='MASKED'/> diff --git a/pgw/expected-results.xml b/pgw/expected-results.xml index 35d0ce9..20c073b 100644 --- a/pgw/expected-results.xml +++ b/pgw/expected-results.xml @@ -1,5 +1,5 @@ <?xml version="1.0"?> -<testsuite name='Titan' tests='7' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'> +<testsuite name='Titan' tests='9' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'> <testcase classname='PGW_Tests' name='TC_tx_echo' time='MASKED'/> <testcase classname='PGW_Tests' name='TC_createSession' time='MASKED'/> <testcase classname='PGW_Tests' name='TC_createSession_ping4' time='MASKED'/> diff --git a/sgsn/expected-results.xml b/sgsn/expected-results.xml index 35b2926..bef13dc 100644 --- a/sgsn/expected-results.xml +++ b/sgsn/expected-results.xml @@ -1,5 +1,5 @@ <?xml version="1.0"?> -<testsuite name='Titan' tests='73' failures='4' errors='0' skipped='0' inconc='0' time='MASKED'> +<testsuite name='Titan' tests='74' failures='4' errors='0' skipped='0' inconc='0' time='MASKED'> <testcase classname='SGSN_Tests' name='TC_attach' time='MASKED'/> <testcase classname='SGSN_Tests' name='TC_attach_mnc3' time='MASKED'/> <testcase classname='SGSN_Tests' name='TC_attach_umts_aka_umts_res' time='MASKED'/> diff --git a/sip/expected-results.xml b/sip/expected-results.xml index 87895ba..1d2b670 100644 --- a/sip/expected-results.xml +++ b/sip/expected-results.xml @@ -1,5 +1,5 @@ <?xml version="1.0"?> -<testsuite name='Titan' tests='7' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'> +<testsuite name='Titan' tests='9' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'> <testcase classname='SIP_Tests' name='TC_mt_success_rel_gsm' time='MASKED'/> <testcase classname='SIP_Tests' name='TC_mt_success_rel_gsm_ipv6' time='MASKED'/> <testcase classname='SIP_Tests' name='TC_mt_success_rel_sip' time='MASKED'/> @@ -7,4 +7,6 @@ <testcase classname='SIP_Tests' name='TC_mo_success_rel_gsm_ipv6' time='MASKED'/> <testcase classname='SIP_Tests' name='TC_mo_success_rel_sip' time='MASKED'/> <testcase classname='SIP_Tests' name='TC_mo_setup_disc_late_rtp' time='MASKED'/> + <testcase classname='SIP_Tests' name='TC_mt_with_sdp' time='MASKED'/> + <testcase classname='SIP_Tests' name='TC_mo_with_sdp' time='MASKED'/> </testsuite> diff --git a/upf/expected-results.xml b/upf/expected-results.xml index 3504126..78f0103 100644 --- a/upf/expected-results.xml +++ b/upf/expected-results.xml @@ -1,4 +1,11 @@ <?xml version="1.0"?> -<testsuite name='UPF_Tests' tests='0' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'> - +<testsuite name='UPF_Tests' tests='8' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'> + <testcase classname='UPF_Tests' name='TC_assoc_node_id_v4' time='MASKED'/> + <testcase classname='UPF_Tests' name='TC_assoc_node_id_fqdn' time='MASKED'/> + <testcase classname='UPF_Tests' name='TC_session_est_tunend' time='MASKED'/> + <testcase classname='UPF_Tests' name='TC_session_term_by_assoc_rel' time='MASKED'/> + <testcase classname='UPF_Tests' name='TC_session_est_noop' time='MASKED'/> + <testcase classname='UPF_Tests' name='TC_session_est_tunmap' time='MASKED'/> + <testcase classname='UPF_Tests' name='TC_session_est_mod_tunmap' time='MASKED'/> + <testcase classname='UPF_Tests' name='TC_session_est_mod_tunmap2' time='MASKED'/> </testsuite> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36157?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I21052636bf892e5da86ef736d16035ec324aedbe Gerrit-Change-Number: 36157 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 0

[S] Change in libosmo-netif[master]: stream_{client,server} example: Cleanup on exit

by daniel

Attention is currently required from: jolly, pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36124?usp=email ) Change subject: stream_{client,server} example: Cleanup on exit ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36124?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I9dbb7f46b2a798e88ad4df8ff73c6ee40c07b843 Gerrit-Change-Number: 36124 Gerrit-PatchSet: 6 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Mar 2024 16:06:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[M] Change in docker-playground[master]: ttcn3-epdg: Test GTP-U userplane

by daniel

Attention is currently required from: laforge, pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36138?usp=email ) Change subject: ttcn3-epdg: Test GTP-U userplane ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36138?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Icc5710b42e5a5374aade6b952e1c543565ffad2e Gerrit-Change-Number: 36138 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Mar 2024 16:05:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in libosmo-netif[master]: stream_cli: Do not try to send msg, if socket is disconnected

by daniel

Attention is currently required from: jolly, laforge, pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36123?usp=email ) Change subject: stream_cli: Do not try to send msg, if socket is disconnected ...................................................................... Patch Set 6: (1 comment) File src/stream_cli.c: https://gerrit.osmocom.org/c/libosmo-netif/+/36123/comment/29fa167e_f567a65a PS4, Line 998: if (cli->state != STREAM_CLI_STATE_CONNECTED) { > Yes, it is possible to send messages before the socket is connected. I'm not sure if this breaks some assumptions user code makes while in STREAM_STATE_CLI_WAIT_RECONNECT which would now reject messages. IIRC osmo_io has always used the tx_queue for sending -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36123?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I9e5f5db9b45615dacb05115c4de8ff3f715815c8 Gerrit-Change-Number: 36123 Gerrit-PatchSet: 6 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Mar 2024 15:55:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andreas(a)eversberg.eu> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2024