Attention is currently required from: pespin.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36136?usp=email )
Change subject: ttcn3-epdg: Set up params to get GTP-U echo working
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36136?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I5cd9dcd6188227baed71823b0cbceb77dc771011
Gerrit-Change-Number: 36136
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 04 Mar 2024 11:31:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: fixeria, osmith.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36134?usp=email )
Change subject: ttcn3-ggsn-test: tweak log options
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Patchset:
PS2:
I have compared this to some of the other config files. In the config for the BSC I still find lots of logging levels set to notice. In the config for the HNBGW there is even set-all debug on stderr.
I think it is a very good idea. Having set-all debug for gsmtap and set-all info for stderr. Also log categories may come and go and with the generic set-all we won't run into problems when log categories change. Maybe you should tweak the configs of the other testsuites as well?
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36134?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I6c3095f4d3378d2026d3720bc32e27ce4c8345b3
Gerrit-Change-Number: 36134
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 04 Mar 2024 11:20:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/36153?usp=email )
Change subject: Add clear error for kernel not supporting IPv6
......................................................................
Add clear error for kernel not supporting IPv6
Make it clear to the user, that if adding a tunnel fails with kernel GTP
and IPv6: the reason is that the kernel doesn't support IPv6 yet.
Related: OS#6096
Change-Id: I1d3c8cbb51212c91136292347dad9529a5c58a31
---
M ggsn/ggsn.c
1 file changed, 15 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
osmith: Looks good to me, approved
dexter: Looks good to me, but someone else must approve
pespin: Looks good to me, but someone else must approve
diff --git a/ggsn/ggsn.c b/ggsn/ggsn.c
index 0cd0feb..0603773 100644
--- a/ggsn/ggsn.c
+++ b/ggsn/ggsn.c
@@ -534,6 +534,8 @@
if (apn->cfg.gtpu_mode == APN_GTPU_MODE_KERNEL_GTP) {
if (gtp_kernel_tunnel_add(pdp, apn->tun.cfg.dev_name) < 0) {
LOGPPDP(LOGL_ERROR, pdp, "Cannot add tunnel to kernel: %s\n", strerror(errno));
+ if (addrv6 && errno == EINVAL)
+ LOGPPDP(LOGL_ERROR, pdp, "Maybe your kernel does not support GTP-U with IPv6 yet?\n");
gtp_create_context_resp(gsn, pdp, GTPCAUSE_SYS_FAIL);
return 0;
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36153?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: I1d3c8cbb51212c91136292347dad9529a5c58a31
Gerrit-Change-Number: 36153
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged
Attention is currently required from: dexter.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/36153?usp=email )
Change subject: Add clear error for kernel not supporting IPv6
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File ggsn/ggsn.c:
https://gerrit.osmocom.org/c/osmo-ggsn/+/36153/comment/95e58475_fd0a5da9
PS2, Line 538: LOGPPDP(LOGL_ERROR, pdp, "Maybe your kernel does not support GTP-U with IPv6 yet?\n");
> Maybe something like "Check GTP-U kernel support for IPv6" sounds more clear. […]
thanks for the suggestion. but without instructions on how to check it, I don't think it is more helpful than the current message (which at least indicates that newer kernel versions will likely have this).
--
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36153?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: I1d3c8cbb51212c91136292347dad9529a5c58a31
Gerrit-Change-Number: 36153
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 04 Mar 2024 11:08:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: osmith.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/36153?usp=email )
Change subject: Add clear error for kernel not supporting IPv6
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File ggsn/ggsn.c:
https://gerrit.osmocom.org/c/osmo-ggsn/+/36153/comment/ba55e5a4_3dc91e1f
PS2, Line 538: LOGPPDP(LOGL_ERROR, pdp, "Maybe your kernel does not support GTP-U with IPv6 yet?\n");
Maybe something like "Check GTP-U kernel support for IPv6" sounds more clear. (just an idea)
--
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36153?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: I1d3c8cbb51212c91136292347dad9529a5c58a31
Gerrit-Change-Number: 36153
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 04 Mar 2024 11:07:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: laforge, pespin.
jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36123?usp=email )
Change subject: stream_cli: Do not try to send msg, if not connected
......................................................................
Patch Set 5:
(1 comment)
File src/stream_cli.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/36123/comment/ddd3ef4a_bc783b61
PS4, Line 998: if (cli->state != STREAM_CLI_STATE_CONNECTED) {
> But this is really breaking the behavior of the API, and it may have undesired consequences. […]
There is a TX queue (iofd->tx_queue). Maybe we can use that one and don't need this patch.
I had a crash when the example client is unconnected and I typed something. I need to check why this happens.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36123?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I9e5f5db9b45615dacb05115c4de8ff3f715815c8
Gerrit-Change-Number: 36123
Gerrit-PatchSet: 5
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 04 Mar 2024 10:56:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: pespin.
jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36124?usp=email )
Change subject: stream_{client,server} example: Cleanup on exit
......................................................................
Patch Set 5:
(1 comment)
File examples/stream-client.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/36124/comment/bfb207c4_97cd35a1
PS4, Line 176: signal(SIGINT, SIG_DFL);
> you probably want to do this inside the sig_handler, to kill the program quickly if CTRL+C is presse […]
General a good idea! If exit hangs for some reason, a second CTRL+C will end the application.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36124?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I9dbb7f46b2a798e88ad4df8ff73c6ee40c07b843
Gerrit-Change-Number: 36124
Gerrit-PatchSet: 5
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 04 Mar 2024 10:45:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: pespin.
jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/35979?usp=email )
Change subject: stream_cli: Correctly setup and free osmo_io client instance
......................................................................
Patch Set 7:
(1 comment)
File src/stream_cli.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/35979/comment/e88338a7_7dafd830
PS6, Line 960: osmo_iofd_notify_connected(cli->iofd);
> is this triggering any callback which could do undersired stuff to due segmentation not yet set belo […]
It does not perform any notification at this point. It only enables notification. The callback is called later, when the socket is connected or failed.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/35979?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I91a6a76b9ff96034a7b333edf87af27490202932
Gerrit-Change-Number: 35979
Gerrit-PatchSet: 7
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 04 Mar 2024 10:45:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment