Attention is currently required from: laforge, osmith.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36129?usp=email )
Change subject: epdg: Introduce test TC_upf_echo_req
......................................................................
Patch Set 3:
(1 comment)
File epdg/EPDG_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36129/comment/5b8e802a_9b94…
PS3, Line 686: private function f_GTP1U_send(octetstring payload) runs on EPDG_ConnHdlr {
> this function is unused? otherwise LGTM
Yeah it's actually used in the next 2 patches, not a big problem though imho.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36129?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I3fd96f212175959cb113d2f6a362c0e77e5ca0d7
Gerrit-Change-Number: 36129
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 04 Mar 2024 10:27:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: laforge, pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36129?usp=email )
Change subject: epdg: Introduce test TC_upf_echo_req
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File epdg/EPDG_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36129/comment/add1b03f_6950…
PS3, Line 686: private function f_GTP1U_send(octetstring payload) runs on EPDG_ConnHdlr {
> this function is unused? otherwise LGTM
ah I see it gets used in a later patch.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36129?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I3fd96f212175959cb113d2f6a362c0e77e5ca0d7
Gerrit-Change-Number: 36129
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 04 Mar 2024 10:26:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36130?usp=email )
Change subject: ggsn_tests: Split out generic ICMP(v6) related templates and functions
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36130?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I53a5da05caeef4cdd59778840a6f4eed489f1b93
Gerrit-Change-Number: 36130
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 04 Mar 2024 10:24:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: laforge, pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36129?usp=email )
Change subject: epdg: Introduce test TC_upf_echo_req
......................................................................
Patch Set 3:
(1 comment)
File epdg/EPDG_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36129/comment/1be19864_84d4…
PS3, Line 686: private function f_GTP1U_send(octetstring payload) runs on EPDG_ConnHdlr {
this function is unused? otherwise LGTM
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36129?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I3fd96f212175959cb113d2f6a362c0e77e5ca0d7
Gerrit-Change-Number: 36129
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 04 Mar 2024 10:24:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment