Attention is currently required from: laforge, pespin.
jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36020?usp=email )
Change subject: stream_cli: Call read callback even if connection failed
......................................................................
Patch Set 6:
(1 comment)
File src/stream_cli.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/36020/comment/dc2c6213_4d7c5f2a
PS5, Line 447: /* Forward message to read callback, also if the connection failed. */
> I already though on the previous patch: Shouldn't this callback happen *before* reconnecting? Or it' […]
Yes, it is called at the end to prevent a use-after-free bug. The user may decide to destroy the cli instance.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36020?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Ie2335987c38863bad5de1d2d4dbdf4c8373f927f
Gerrit-Change-Number: 36020
Gerrit-PatchSet: 6
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 04 Mar 2024 10:45:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: jolly.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-netif/+/36124?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: stream_{client,server} example: Cleanup on exit
......................................................................
stream_{client,server} example: Cleanup on exit
In order to detect memory leaks while debugging, stream server/client
and keyboard is closed on exit.
Related: OS#5753
Change-Id: I9dbb7f46b2a798e88ad4df8ff73c6ee40c07b843
---
M examples/stream-client.c
M examples/stream-server.c
2 files changed, 34 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/24/36124/5
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36124?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I9dbb7f46b2a798e88ad4df8ff73c6ee40c07b843
Gerrit-Change-Number: 36124
Gerrit-PatchSet: 5
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-MessageType: newpatchset
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36145?usp=email )
Change subject: cbsp: Add osmo_cbsp_segmentation_cb for message segmentation
......................................................................
cbsp: Add osmo_cbsp_segmentation_cb for message segmentation
This call-back can for example be used as segmentation call-back
for libosmo-netif stream_cli/stream_srv or directly for osmo_io.
Related: OS#5755
Change-Id: I5e922c54b3431d759b38e81e55076125c5a34008
---
M include/osmocom/gsm/cbsp.h
M src/gsm/cbsp.c
M src/gsm/libosmogsm.map
3 files changed, 35 insertions(+), 0 deletions(-)
Approvals:
fixeria: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/include/osmocom/gsm/cbsp.h b/include/osmocom/gsm/cbsp.h
index 536c54d..efa4ce6 100644
--- a/include/osmocom/gsm/cbsp.h
+++ b/include/osmocom/gsm/cbsp.h
@@ -312,3 +312,4 @@
struct osmo_cbsp_decoded *osmo_cbsp_decoded_alloc(void *ctx, enum cbsp_msg_type msg_type);
int osmo_cbsp_recv_buffered(void *ctx, int fd, struct msgb **rmsg, struct msgb **tmp_msg);
+int osmo_cbsp_segmentation_cb(struct msgb *msg);
diff --git a/src/gsm/cbsp.c b/src/gsm/cbsp.c
index 28852f6..a5e58f4 100644
--- a/src/gsm/cbsp.c
+++ b/src/gsm/cbsp.c
@@ -1567,6 +1567,26 @@
return rc;
}
+/*! call-back function to segment the data at message boundaries.
+ * Returns the size of the next message. If it returns -EAGAIN or a value larger than msgb_length() (message
+ * is incomplete), the caller (e.g. osmo_io) has to wait for more data to be read. */
+int osmo_cbsp_segmentation_cb(struct msgb *msg)
+{
+ const struct cbsp_header *h;
+ int len;
+
+ if (msgb_length(msg) < sizeof(*h))
+ return -EAGAIN;
+
+ h = (const struct cbsp_header *) msg->data;
+ msg->l1h = msg->data;
+ msg->l2h = msg->data + sizeof(*h);
+ /* then read the length as specified in the header */
+ len = h->len[0] << 16 | h->len[1] << 8 | h->len[2];
+
+ return sizeof(*h) + len;
+}
+
/*! value_string[] for enum osmo_cbsp_cause. */
const struct value_string osmo_cbsp_cause_names[] = {
{ OSMO_CBSP_CAUSE_PARAM_NOT_RECOGNISED, "Parameter-not-recognised" },
diff --git a/src/gsm/libosmogsm.map b/src/gsm/libosmogsm.map
index db2dbcb..2c4c621 100644
--- a/src/gsm/libosmogsm.map
+++ b/src/gsm/libosmogsm.map
@@ -793,6 +793,7 @@
osmo_cbsp_decode;
osmo_cbsp_recv_buffered;
osmo_cbsp_errstr;
+osmo_cbsp_segmentation_cb;
osmo_i460_demux_in;
osmo_i460_mux_enqueue;
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36145?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I5e922c54b3431d759b38e81e55076125c5a34008
Gerrit-Change-Number: 36145
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged
Attention is currently required from: dexter.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36154?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: library: add SGP.32 and SGP.22 ASN.1 specification, encoder and templates
......................................................................
library: add SGP.32 and SGP.22 ASN.1 specification, encoder and templates
This patch adds the eUICC related SGP.32 and SGP.22 ASN.1 specification
along with templates and related encoder/decoders (_EncDec.cc).
The collection of templates is not comprehensive, which means that there
are only templates available for a subset needed to implement testcases
for an IPAd.
Related: SYS#6563
Change-Id: I9df8caa98aeb6953a738660a758c92249832d780
---
A library/euicc/PEDefinitions.asn
A library/euicc/PKIX1Explicit88.asn
A library/euicc/PKIX1Explicit88_EncDec.cc
A library/euicc/PKIX1Explicit88_Templates.ttcn
A library/euicc/PKIX1Explicit88_Types.ttcn
A library/euicc/PKIX1Implicit88.asn
A library/euicc/PKIX1Implicit88_EncDec.cc
A library/euicc/PKIX1Implicit88_Templates.ttcn
A library/euicc/PKIX1Implicit88_Types.ttcn
A library/euicc/RSPDefinitions.asn
A library/euicc/RSPDefinitions_EncDec.cc
A library/euicc/RSPDefinitions_Templates.ttcn
A library/euicc/RSPDefinitions_Types.ttcn
A library/euicc/SGP32Definitions.asn
A library/euicc/SGP32Definitions_EncDec.cc
A library/euicc/SGP32Definitions_Templates.ttcn
A library/euicc/SGP32Definitions_Types.ttcn
17 files changed, 7,157 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/54/36154/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36154?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9df8caa98aeb6953a738660a758c92249832d780
Gerrit-Change-Number: 36154
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: osmith.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36137?usp=email )
Change subject: epdg: Introduce test TC_mt_ipv4_echo_req
......................................................................
Patch Set 1:
(1 comment)
File epdg/EPDG_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36137/comment/f1bb22c0_d2d2…
PS1, Line 703: /*TODO: verify gtpu txseq:
> do you want to keep this?
Yes, it's left for later. I'm actually still getting this test to work in docker setup right now, almost there hopefully. :)
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36137?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie5dc1bd995262f9253cc067c97a82c801b0080e1
Gerrit-Change-Number: 36137
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 04 Mar 2024 10:29:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: laforge, pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36129?usp=email )
Change subject: epdg: Introduce test TC_upf_echo_req
......................................................................
Patch Set 3:
(1 comment)
File epdg/EPDG_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36129/comment/db4a59ee_4100…
PS3, Line 686: private function f_GTP1U_send(octetstring payload) runs on EPDG_ConnHdlr {
> Yeah it's actually used in the next 2 patches, not a big problem though imho.
Ack
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36129?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I3fd96f212175959cb113d2f6a362c0e77e5ca0d7
Gerrit-Change-Number: 36129
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 04 Mar 2024 10:28:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: dexter.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36154?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: library: add SGP.32 and SGP.22 ASN.1 specification, encoder and templates
......................................................................
library: add SGP.32 and SGP.22 ASN.1 specification, encoder and templates
This patch adds the eUICC related SGP.32 and SGP.22 ASN.1 specification
along with templates and related encoder/decoders (_EncDec.cc).
The collection of templates is not comprehensive, which means that there
are only templates available for a subset needed to implement testcases
for an IPAd.
Related: SYS#6563
Change-Id: I9df8caa98aeb6953a738660a758c92249832d780
---
A library/euicc/PEDefinitions.asn
A library/euicc/PKIX1Explicit88.asn
A library/euicc/PKIX1Explicit88_EncDec.cc
A library/euicc/PKIX1Explicit88_Templates.ttcn
A library/euicc/PKIX1Explicit88_Types.ttcn
A library/euicc/PKIX1Implicit88.asn
A library/euicc/PKIX1Implicit88_EncDec.cc
A library/euicc/PKIX1Implicit88_Templates.ttcn
A library/euicc/PKIX1Implicit88_Types.ttcn
A library/euicc/RSPDefinitions.asn
A library/euicc/RSPDefinitions_EncDec.cc
A library/euicc/RSPDefinitions_Templates.ttcn
A library/euicc/RSPDefinitions_Types.ttcn
A library/euicc/SGP32Definitions.asn
A library/euicc/SGP32Definitions_EncDec.cc
A library/euicc/SGP32Definitions_Templates.ttcn
A library/euicc/SGP32Definitions_Types.ttcn
17 files changed, 7,157 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/54/36154/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36154?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9df8caa98aeb6953a738660a758c92249832d780
Gerrit-Change-Number: 36154
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: newpatchset