dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32752 )
Change subject: l1sap: cosmetic: rename payload_len to rtp_pl_len
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
Now suddenly everything appears to be correct again - so we can restore this and abandon the patch that I have just re-pushed.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32752
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I8a0e0357aab2a78e25811f66b1b870e8c6ebffe9
Gerrit-Change-Number: 32752
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 14 Jun 2023 08:32:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
dexter has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33309 )
Change subject: l1sap: cosmetic: rename payload_len to rtp_pl_len
......................................................................
Abandoned
This is a duplicate
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33309
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I07c589246d0b116710b1587ff1f8cc285ebe240a
Gerrit-Change-Number: 33309
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-MessageType: abandon
dexter has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32752 )
Change subject: l1sap: cosmetic: rename payload_len to rtp_pl_len
......................................................................
Abandoned
This looks messed up in gerrit (even though the patch is correct). Re-pushed this under: I07c589246d0b116710b1587ff1f8cc285ebe240a
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32752
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I8a0e0357aab2a78e25811f66b1b870e8c6ebffe9
Gerrit-Change-Number: 32752
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: abandon
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/33309 )
Change subject: l1sap: cosmetic: rename payload_len to rtp_pl_len
......................................................................
l1sap: cosmetic: rename payload_len to rtp_pl_len
The function signature of rtppayload_is_octet_aligned has a parameter
rtp_pl for the payload and a parameter payload_len for the length of the
payload, while other functions use rtp_pl and rtp_pl_len.
Change-Id: I07c589246d0b116710b1587ff1f8cc285ebe240a
---
M src/common/rtp_input_preen.c
1 file changed, 15 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/09/33309/1
diff --git a/src/common/rtp_input_preen.c b/src/common/rtp_input_preen.c
index c418e80..d42d24f 100644
--- a/src/common/rtp_input_preen.c
+++ b/src/common/rtp_input_preen.c
@@ -34,7 +34,7 @@
#include <osmo-bts/logging.h>
#include <osmo-bts/rtp_input_preen.h>
-static bool amr_is_octet_aligned(const uint8_t *rtp_pl, unsigned payload_len)
+static bool amr_is_octet_aligned(const uint8_t *rtp_pl, unsigned rtp_pl_len)
{
/*
* Logic: If 1st bit padding is not zero, packet is either:
@@ -55,7 +55,7 @@
#define AMR_PADDING1(rtp_pl) (rtp_pl[0] & 0x0f)
#define AMR_PADDING2(rtp_pl) (rtp_pl[1] & 0x03)
- if (payload_len < 2 || AMR_PADDING1(rtp_pl) || AMR_PADDING2(rtp_pl))
+ if (rtp_pl_len < 2 || AMR_PADDING1(rtp_pl) || AMR_PADDING2(rtp_pl))
return false;
return true;
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33309
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I07c589246d0b116710b1587ff1f8cc285ebe240a
Gerrit-Change-Number: 33309
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: newchange
Attention is currently required from: dexter.
Hello Jenkins Builder, fixeria, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-bts/+/32752
to look at the new patch set (#4).
Change subject: l1sap: cosmetic: rename payload_len to rtp_pl_len
......................................................................
l1sap: cosmetic: rename payload_len to rtp_pl_len
The function signature of rtppayload_is_octet_aligned has a parameter
rtp_pl for the payload and a parameter payload_len for the length of the
payload, while other functions use rtp_pl and rtp_pl_len.
Change-Id: I8a0e0357aab2a78e25811f66b1b870e8c6ebffe9
---
M src/common/rtp_input_preen.c
1 file changed, 15 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/52/32752/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32752
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I8a0e0357aab2a78e25811f66b1b870e8c6ebffe9
Gerrit-Change-Number: 32752
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: daniel, lynxis lazus.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33253 )
Change subject: stream: Factor out reconnection handling
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
Patchset:
PS3:
The code was just moved, I think this should be all fine.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33253
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I418377eabd465ee4ffce9b4440e96287c7734924
Gerrit-Change-Number: 33253
Gerrit-PatchSet: 3
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Wed, 14 Jun 2023 08:00:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment