March 2022 - gerrit-log - lists.osmocom.org

Change in osmo-pcu[master]: Fix assert hit if connecting to SGSN fails

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/27613 ) Change subject: Fix assert hit if connecting to SGSN fails ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/27613 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I36dc64fa807091bf2b565417c1185c4cb399932b Gerrit-Change-Number: 27613 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Mar 2022 20:55:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-cbc[master]: VTY: cosmetic: use VTY_IPV46_CMD in the command string

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-cbc/+/27615 ) Change subject: VTY: cosmetic: use VTY_IPV46_CMD in the command string ...................................................................... VTY: cosmetic: use VTY_IPV46_CMD in the command string Change-Id: I3088aed936b936d36a550f766031328143481064 --- M src/cbc_vty.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-cbc refs/changes/15/27615/1 diff --git a/src/cbc_vty.c b/src/cbc_vty.c index 9a36aa4..24ca1a9 100644 --- a/src/cbc_vty.c +++ b/src/cbc_vty.c @@ -347,7 +347,7 @@ } DEFUN(cfg_cbsp_local_ip, cfg_cbsp_local_ip_cmd, - "local-ip (A.B.C.D|X:X::X:X)", + "local-ip " VTY_IPV46_CMD, "Local IP address for CBSP\n" "Local IPv4 address for CBSP\n" "Local IPv6 address for CBSP\n") { @@ -383,7 +383,7 @@ } DEFUN(cfg_ecbe_local_ip, cfg_ecbe_local_ip_cmd, - "local-ip (A.B.C.D|X:X::X:X)", + "local-ip " VTY_IPV46_CMD, "Local IP address for CBSP\n" "Local IPv4 address for ECBE REST Interface\n" "Local IPv6 address for ECBE REST Interface\n") @@ -469,7 +469,7 @@ DEFUN(cfg_peer_remote_ip, cfg_peer_remote_ip_cmd, - "remote-ip (A.B.C.D|X:X::X:X)", + "remote-ip " VTY_IPV46_CMD, "Configure remote IP of peer\n" "Remote IP address of peer\n") { -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/27615 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I3088aed936b936d36a550f766031328143481064 Gerrit-Change-Number: 27615 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 3 months

1
0
0 0

Change in osmo-cbc[master]: VTY: fix incomplete 'remote-ip' command description

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-cbc/+/27616 ) Change subject: VTY: fix incomplete 'remote-ip' command description ...................................................................... VTY: fix incomplete 'remote-ip' command description Change-Id: I2f98285bda4a482ac1af04f71eafa19daee5137f --- M src/cbc_vty.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-cbc refs/changes/16/27616/1 diff --git a/src/cbc_vty.c b/src/cbc_vty.c index 24ca1a9..f0c34d6 100644 --- a/src/cbc_vty.c +++ b/src/cbc_vty.c @@ -471,7 +471,7 @@ DEFUN(cfg_peer_remote_ip, cfg_peer_remote_ip_cmd, "remote-ip " VTY_IPV46_CMD, "Configure remote IP of peer\n" - "Remote IP address of peer\n") + "IPv4 address of peer\n" "IPv6 address of peer\n") { struct cbc_peer *peer = (struct cbc_peer *) vty->index; osmo_talloc_replace_string(peer, &peer->remote_host, argv[0]); -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/27616 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I2f98285bda4a482ac1af04f71eafa19daee5137f Gerrit-Change-Number: 27616 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 3 months

1
0
0 0

Change in osmo-cbc[master]: doc/examples: make osmo-cbc.cfg file more informative

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-cbc/+/27614 ) Change subject: doc/examples: make osmo-cbc.cfg file more informative ...................................................................... doc/examples: make osmo-cbc.cfg file more informative This example is not any better than just using '-c /dev/null'. Add some default parameters taken from 'show running-config'. Change-Id: I6dca38a2220c32fad96237d7522a300f12b4469e --- M doc/examples/osmo-cbc/osmo-cbc.cfg 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-cbc refs/changes/14/27614/1 diff --git a/doc/examples/osmo-cbc/osmo-cbc.cfg b/doc/examples/osmo-cbc/osmo-cbc.cfg index dae31e3..0b66996 100644 --- a/doc/examples/osmo-cbc/osmo-cbc.cfg +++ b/doc/examples/osmo-cbc/osmo-cbc.cfg @@ -1,3 +1,11 @@ log stderr logging level cbsp debug +cbc + unknown-peers reject + cbsp + local-ip 127.0.0.1 + local-port 48049 + ecbe + local-ip 127.0.0.1 + local-port 12345 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/27614 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I6dca38a2220c32fad96237d7522a300f12b4469e Gerrit-Change-Number: 27614 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 3 months

1
0
0 0

Change in osmo-pcu[master]: Fix assert hit if connecting to SGSN fails

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/27613 ) Change subject: Fix assert hit if connecting to SGSN fails ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/27613 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I36dc64fa807091bf2b565417c1185c4cb399932b Gerrit-Change-Number: 27613 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Mar 2022 20:12:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-pcu[master]: Fix assert hit if connecting to SGSN fails

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/27613 ) Change subject: Fix assert hit if connecting to SGSN fails ...................................................................... Fix assert hit if connecting to SGSN fails """ DLBSSGP ERROR gprs_bssgp_pcu.c:1278 Failed to connect! DL1IF ERROR pcu_l1_if.cpp:827 No NSVC available to connect to the SGSN! DRLCMAC INFO pdch.cpp:185 PDCH(bts=0,trx=0,ts=0) PDCH state: disabled => disabled Assert failed m_is_enabled == 1 pdch.cpp:186 """ Change-Id: I36dc64fa807091bf2b565417c1185c4cb399932b --- M src/pcu_l1_if.cpp 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/13/27613/1 diff --git a/src/pcu_l1_if.cpp b/src/pcu_l1_if.cpp index d5672e5..d0698d9 100644 --- a/src/pcu_l1_if.cpp +++ b/src/pcu_l1_if.cpp @@ -731,7 +731,8 @@ for (trx_nr = 0; trx_nr < ARRAY_SIZE(bts->trx); trx_nr++) { bts->trx[trx_nr].arfcn = info_ind->trx[trx_nr].arfcn; for (ts_nr = 0; ts_nr < ARRAY_SIZE(bts->trx[0].pdch); ts_nr++) - bts->trx[trx_nr].pdch[ts_nr].disable(); + if (bts->trx[trx_nr].pdch[ts_nr].is_enabled()) + bts->trx[trx_nr].pdch[ts_nr].disable(); } gprs_bssgp_destroy(bts); exit(0); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/27613 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I36dc64fa807091bf2b565417c1185c4cb399932b Gerrit-Change-Number: 27613 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 3 months

1
0
0 0

Change in osmo-dev[master]: Add missing osmo-pcu to sanitize.opts

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/27611 ) Change subject: Add missing osmo-pcu to sanitize.opts ...................................................................... Add missing osmo-pcu to sanitize.opts Change-Id: I8afe1a5fdcbd6d356d104cb7be3b9be4b508a97c --- M sanitize.opts 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved; Verified diff --git a/sanitize.opts b/sanitize.opts index 5f42da8..94bb855 100644 --- a/sanitize.opts +++ b/sanitize.opts @@ -13,6 +13,7 @@ osmo-sgsn --enable-sanitize openbsc --enable-sanitize osmo-sip-connector --enable-sanitize +osmo-pcu --enable-sanitize osmo-bts --enable-sanitize osmo-smlc --enable-sanitize osmo-pcu --enable-sanitize -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/27611 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I8afe1a5fdcbd6d356d104cb7be3b9be4b508a97c Gerrit-Change-Number: 27611 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 3 months

1
0
0 0

Change in osmo-dev[master]: Add missing osmo-cbc to all.deps and {sanitize,werror}.opts

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/27612 ) Change subject: Add missing osmo-cbc to all.deps and {sanitize,werror}.opts ...................................................................... Add missing osmo-cbc to all.deps and {sanitize,werror}.opts Change-Id: I39e2067f5d93e648e05ee0f949145d31af43e6d7 --- M all.deps M sanitize.opts M werror.opts 3 files changed, 3 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, approved; Verified diff --git a/all.deps b/all.deps index 75c2b96..988d1ee 100644 --- a/all.deps +++ b/all.deps @@ -26,6 +26,7 @@ osmo-bsc-nat libosmo-sccp libgtpnl osmo-upf libosmocore libgtpnl +osmo-cbc libosmo-netif # can only clone these docker-playground diff --git a/sanitize.opts b/sanitize.opts index 94bb855..34f27af 100644 --- a/sanitize.opts +++ b/sanitize.opts @@ -18,3 +18,4 @@ osmo-smlc --enable-sanitize osmo-pcu --enable-sanitize osmo-upf --enable-sanitize +osmo-cbc --enable-sanitize diff --git a/werror.opts b/werror.opts index 7f2ee6c..c5daa23 100644 --- a/werror.opts +++ b/werror.opts @@ -14,3 +14,4 @@ osmo-bts --enable-werror osmo-bsc-nat --enable-werror osmo-upf --enable-werror +osmo-cbc --enable-werror -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/27612 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I39e2067f5d93e648e05ee0f949145d31af43e6d7 Gerrit-Change-Number: 27612 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 3 months

1
0
0 0

Change in osmo-dev[master]: Add missing osmo-cbc to all.deps and {sanitize,werror}.opts

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/27612 ) Change subject: Add missing osmo-cbc to all.deps and {sanitize,werror}.opts ...................................................................... Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/27612 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I39e2067f5d93e648e05ee0f949145d31af43e6d7 Gerrit-Change-Number: 27612 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Mar 2022 19:47:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-dev[master]: Add missing osmo-pcu to sanitize.opts

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/27611 ) Change subject: Add missing osmo-pcu to sanitize.opts ...................................................................... Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/27611 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I8afe1a5fdcbd6d356d104cb7be3b9be4b508a97c Gerrit-Change-Number: 27611 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Mar 2022 19:42:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2022