Re: libgtp API strategy for Gn (SGSN <> MME)

Hi, On 10/22/24 3:22 PM, Alexander 'lynxis' Couzens wrote: IMHO the right direction is to have a libosmo-gtp.git repository which contains: libosmo-gtpv1c.so libosmo-gtpv2c.so It should be pretty similar to what nowadays you can find in https://github.com/open5gs/open5gs/tree/main/lib/gtp/ . As in there, I really really vote for generating the TLVs as it's done in there, parsing the 3GPP docx (I actually wrote the script to generate the v1 subdir structs there iirc). See https://github.com/open5gs/open5gs/tree/main/lib/gtp/v1/support/ . Then, on top/aside of that add some APIs to have some data domain with some structs (private structs, public APIs!) to handle peers, retransmission state, etc. like done in path.c and xact.c. Also add some VTY to declare and configure nodes like done in eg. libosmo-sigtran. There's already a ticket to do this btw, see https://osmocom.org/issues/6518 . We should really end up dropping libgtp, that's really a dead end and will only cause us many many problems as we try to improve it imho. So I'm all in favour of a new libosmo-gtp as mentioned above. I think it's fine for first develop the library inside a subdir of osmo-sgsn.git or osmo-ggsn.git as a independent static library and later on once used properly make it a public shared object inside its own git repository. Start by taking the python script, putting it eg. in osmo-sgsn.git/libosmo-gtp/support/ and generating code using libosmocore dependencies. Regards, Pau -- - Pau Espin Pedrol &lt;pespin(a)sysmocom.de&gt; http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Siemensstr. 26a * 10551 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschaeftsfuehrer / Managing Director: Harald Welte