osmocom-commitlog January 2015

osmocom-commitlog@lists.osmocom.org

1 participants
99 discussions

openbsc.git branch master updated. 0.13.0-919-g4e13a8f
by gitosis＠osmocom.org 31 Jan '15

31 Jan '15

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, master has been updated via 4e13a8f9f9d40e5d62c9cee7d76348ef8b558981 (commit) from b8c204cb929a8455bfa6006a95a958d57274ab08 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=4e13a8f9f9d40e5d62c9cee7d76348ef… commit 4e13a8f9f9d40e5d62c9cee7d76348ef8b558981 Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Sat Jan 31 22:16:00 2015 +0100 bsc/nitb: Allow to set the GPRS mode through the ctrl command Create a control command to read and modify the gprs mode. Use the get_string_value to indicate if the value was found or not. This is useful for the ctrl interface where I didn't want to replicate "none", "gprs" and "egprs". Share code to verify that a BTS supports the mode. Related: SYS#591 ----------------------------------------------------------------------- Summary of changes: openbsc/include/openbsc/gsm_data.h | 3 ++- openbsc/src/libbsc/bsc_ctrl_commands.c | 44 ++++++++++++++++++++++++++++++++-- openbsc/src/libbsc/bsc_vty.c | 11 ++------- openbsc/src/libcommon/gsm_data.c | 23 ++++++++++++++++-- openbsc/tests/ctrl_test_runner.py | 19 +++++++++++++++ 5 files changed, 86 insertions(+), 14 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

1 0

openbsc.git branch master updated. 0.13.0-918-gb8c204c
by gitosis＠osmocom.org 31 Jan '15

31 Jan '15

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, master has been updated via b8c204cb929a8455bfa6006a95a958d57274ab08 (commit) from 7af5f8130f7282e98d0dcf11c4a058a66c2617a6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=b8c204cb929a8455bfa6006a95a958d5… commit b8c204cb929a8455bfa6006a95a958d57274ab08 Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Sat Jan 31 19:42:42 2015 +0100 ctrl/bsc: Fix copy and paste error and update text 30f1f376383df3ae8d85e96542bf14d174c25d89 introduced new channel combinations but had a copy and paste error in the description. The jenkins system didn't run the external tests so this issue and others were not noticed until now. Fix the copy and paste and update the test result. ----------------------------------------------------------------------- Summary of changes: openbsc/src/libbsc/bsc_ctrl_commands.c | 2 ++ openbsc/src/libcommon/gsm_data_shared.c | 4 ++-- openbsc/tests/ctrl_test_runner.py | 2 +- 3 files changed, 5 insertions(+), 3 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

1 0

osmo-python-tests.git branch master updated. b819b57a98d142ba004d9dbc6c786c1cd9f1c76c
by gitosis＠osmocom.org 31 Jan '15

31 Jan '15

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, master has been updated via b819b57a98d142ba004d9dbc6c786c1cd9f1c76c (commit) from 4e98c266b77d0629db2e313ab527b5180b16eaa9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/python/osmo-python-tests/commit/?id=b819b57a98d142b… commit b819b57a98d142ba004d9dbc6c786c1cd9f1c76c Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Sat Jan 31 21:15:06 2015 +0100 testconfig: Do not fail due wrong numbers Fix the script and don't fail ----------------------------------------------------------------------- Summary of changes: osmopy/osmotestconfig.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) hooks/post-receive -- UNNAMED PROJECT

1 0

openbsc.git branch master updated. 0.13.0-917-g7af5f81
by gitosis＠osmocom.org 31 Jan '15

31 Jan '15

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, master has been updated via 7af5f8130f7282e98d0dcf11c4a058a66c2617a6 (commit) via 8657326093b6e1eed8cc24fe62039d70aa27d47d (commit) via a07e38d4bf4298be0f3f9676f8de0c0f8ee534b6 (commit) from 4b2d02d0372ae5dc88d97b06f5cfa92841cbf036 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=7af5f8130f7282e98d0dcf11c4a058a6… commit 7af5f8130f7282e98d0dcf11c4a058a66c2617a6 Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Sat Jan 31 12:36:07 2015 +0100 rsl: Remove unused code for channel activation The code has been unused for a long time. Let's remove it. http://cgit.osmocom.org/openbsc/commit/?id=8657326093b6e1eed8cc24fe62039d70… commit 8657326093b6e1eed8cc24fe62039d70aa27d47d Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Sat Jan 31 09:47:37 2015 +0100 meas: Install the scenario command and test it http://cgit.osmocom.org/openbsc/commit/?id=a07e38d4bf4298be0f3f9676f8de0c0f… commit a07e38d4bf4298be0f3f9676f8de0c0f8ee534b6 Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Sat Jan 31 09:26:20 2015 +0100 meas: Add VTY documentation for the measurement commands Document the parameters that can be passed on. ----------------------------------------------------------------------- Summary of changes: openbsc/src/libbsc/abis_rsl.c | 35 ------------------------------- openbsc/src/libmsc/vty_interface_layer3.c | 11 ++++++++-- openbsc/tests/vty_test_runner.py | 19 +++++++++++++++++ 3 files changed, 28 insertions(+), 37 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

1 0

openbsc.git branch master updated. 0.13.0-914-g4b2d02d
by gitosis＠osmocom.org 30 Jan '15

30 Jan '15

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, master has been updated via 4b2d02d0372ae5dc88d97b06f5cfa92841cbf036 (commit) via baf0f94a7dd858eba37548253959747838b1cc16 (commit) via 9ff82892da2b58ba344b2f6e70256d08947b9c34 (commit) via 85ba655788b49dc83e33109368f81b7c3ea0b090 (commit) via 466cedd052427254d5f90b4bd02795129b2c60a4 (commit) via 07f6e36ab42380f9a4c1af058c3021cb0e945dc4 (commit) via 8000e0ea509c5a4488a5d1878f465418d32b7fdb (commit) via 929acdf6bf4ef25c8cc587a6aa48651696348881 (commit) via e988ae471d8e699a4045d77048986570349203fa (commit) via e671d254cbc294f87620c2938eb6fa2883253fcb (commit) via 555b2e5ac128211edffa34a586fe5f548eb3acba (commit) from 925c57fb545b072159a831bff852c92795704dfe (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=4b2d02d0372ae5dc88d97b06f5cfa928… commit 4b2d02d0372ae5dc88d97b06f5cfa92841cbf036 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Fri Jan 30 11:57:25 2015 +0100 sgsn/test: Fix memory leak in test_subscriber_gsup Currently the MM context is not deleted when a GSUP location cancellation message is processed, because the real sgsn_update_subscriber_data function has been wrapped to a dummy implementation. This commit adds an explicit call to sgsn_mm_ctx_cleanup_free which also unassigns the LLME, so the call to gprs_llgmm_assign is removed. It also adds an assertion to check that there are no talloc'ed blocks left in tall_bsc_ctx. Addresses: == 372 bytes in 1 blocks are possibly lost in loss record 7 of 9 == at 0x402A17C: malloc (in /usr/lib/valgrind/vgpreload_memcheck-x86-linux.so) == by 0x4059FB8: _talloc_zero (talloc.c:354) == by 0x8055B82: sgsn_mm_ctx_alloc (gprs_sgsn.c:167) == by 0x804A336: alloc_mm_ctx (sgsn_test.c:140) == by 0x804B24D: test_subscriber_gsup (sgsn_test.c:503) == by 0x804EC99: main (sgsn_test.c:1853) Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=baf0f94a7dd858eba375482539597478… commit baf0f94a7dd858eba37548253959747838b1cc16 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Thu Jan 29 14:55:34 2015 +0100 sgsn/test: Add checks for subscr->error_cause This commits adds a few asserts that check the value of subscr->error_cause after a GSUP message has been received. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=9ff82892da2b58ba344b2f6e70256d08… commit 9ff82892da2b58ba344b2f6e70256d08947b9c34 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Thu Jan 29 14:17:51 2015 +0100 gprs: Use 'Network failure' as default cause This commit adds a check after a GSUP message has been decoded whether it is an error message and does not contain a cause value. If his is the case, the cause value is set to 'Network failure', so that this cause if effectively the default value for error messages. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=85ba655788b49dc83e33109368f81b7c… commit 85ba655788b49dc83e33109368f81b7c3ea0b090 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Thu Jan 29 14:15:54 2015 +0100 gprs/test: Fix GSUP Purge MS response messages Currently the message types for these message types are wrong. This patch inserts the correct message types. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=466cedd052427254d5f90b4bd0279512… commit 466cedd052427254d5f90b4bd02795129b2c60a4 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Thu Jan 29 14:12:29 2015 +0100 sgsn/test: Add tests for PurgeMs responses Currently there are not any test cases for PurgeMS GSUP messages in test_subscriber_gsup. This commit adds tests for incoming PurgeMSResult and -Error messages. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=07f6e36ab42380f9a4c1af058c3021cb… commit 07f6e36ab42380f9a4c1af058c3021cb0e945dc4 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Thu Jan 29 14:00:28 2015 +0100 gprs: Send GSUP error reply for requests without IMSI Currently gprs_subscr_rx_gsup_message returns immediately after it detects that an IMSI has not been given in the received GSUP message. While this is ok for responses (result or error), a request should always be answered. This commit adds code to reply with a corresponding error message ("Invalid mandatory information") when it receives a request without an IMSI. Note that the generated error message will not contain an IMSI either. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=8000e0ea509c5a4488a5d1878f465418… commit 8000e0ea509c5a4488a5d1878f465418d32b7fdb Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Jan 27 14:56:40 2015 +0100 gprs: Support cancellation type The cancellation type that is part of the UpdateCancellation message is currently ignored. This patch adds the missing glue between the existing GSUP and GMM support. If the type is not present or has the value updateProcedure the subcriber and MM context are siliently removed. Otherwise, a message with cause 'implicitly detached' is sent to the MS. Since the real cause is not known (the specification neither added a cause IE nor defined a static cause value), the MS may get the real cause in the following AttachRej. Added VTY commands: - update-subscriber imsi IMSI cancel update-procedure - update-subscriber imsi IMSI cancel subscription-withdraw the old form without the cause is no longer supported. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=929acdf6bf4ef25c8cc587a6aa486516… commit 929acdf6bf4ef25c8cc587a6aa48651696348881 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Jan 27 13:47:24 2015 +0100 gprs: Handle PURGE MS ERR/RES without subscr Currently the subscr entry is no longer present, when PURGE MS ERROR/RESULT arrives. In this case, an unspecific notice is logged ('unknown IMSI'). This clutters up the logfile with notices even in perfectly normal operation. This commit changes the code path that is used when a subscr cannot be found for an incoming GSUP message. A check for PURGE MS RESULT and ERROR is added and gprs_subscr_handle_gsup_purge_no_subscr is called for these messages instead of gprs_subscr_handle_unknown_imsi. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=e988ae471d8e699a4045d77048986570… commit e988ae471d8e699a4045d77048986570349203fa Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Jan 27 12:41:19 2015 +0100 gprs: Don't use subscr->keep_in_ram in normal operation Currently the keep_in_ram flag is explicitely reset in gprs_subscr_cleanup to cover the case, that the VTY 'create' sub-command has been used to create the subscriber entry. This commit completely removes keep_in_ram handling from gprs_subscriber.c and adds a VTY 'destroy' sub-command to reset the flag and remove the entry. So 'create' and 'destroy' can be used to manager sticky entries that are kept even when a location cancellation is done. Added VTY command: - update-subscriber imsi IMSI destroy Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=e671d254cbc294f87620c2938eb6fa28… commit e671d254cbc294f87620c2938eb6fa2883253fcb Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Jan 26 14:43:07 2015 +0100 sgsn: Add sgsn_mm_ctx_cleanup_free for safe shutdown Currently the MM context cleanup code is distributed over several functions. sgsn_mm_ctx_free not only frees data structure but also eventually stops the timer and does the subscriber clean-up. mm_ctx_cleanup_free (gprs_gmm.c) cleans up the PDP contexts and unassign the TLLI. This commit moves the cleanup code from both functions into a new unifying function sgsn_mm_ctx_cleanup_free that cares about the clean-up of all related sub-systems. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=555b2e5ac128211edffa34a586fe5f54… commit 555b2e5ac128211edffa34a586fe5f548eb3acba Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Jan 26 13:52:42 2015 +0100 sgsn: Don't allow mmctx == NULL in sgsn_update_subscriber_data Currently, sgsn_update_subscriber_data can be called with mmctx == NULL and will find and associate the right context (if present) based on the subscriber's IMSI. This will not happen in regular use any more, since sgsn_update_subscriber_data will only be called when subscribers are used (auth mode 'remote') and in this case gprs_subscr_get_or_create_by_mmctx will already be called by sgsn_auth_request. Therefore, MM context and subscriber are always associated except for some test cases and experimental VTY usage. The current implementation of sgsn_update_subscriber_data also causes additional complexity for the deletion on MM contexts to avoid a ipossible double-free MM contexts. This commit removes the MM context <-> subscriber association code from sgsn_update_subscriber_data. That function must always be called with mmctx != NULL, now. To avoid problems with VTY and test usage, the calling subscriber function now only call sgsn_update_subscriber_data when mmctx != NULL, since the purpose of that function is to update that state of an existing MM context after subscriber data has been changed. Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: openbsc/include/openbsc/gprs_sgsn.h | 4 +- openbsc/src/gprs/gprs_gmm.c | 24 +--------- openbsc/src/gprs/gprs_sgsn.c | 60 +++++++++++++------------ openbsc/src/gprs/gprs_subscriber.c | 65 +++++++++++++++++++++++---- openbsc/src/gprs/sgsn_vty.c | 40 ++++++++++++++++- openbsc/tests/gprs/gprs_test.c | 4 +- openbsc/tests/sgsn/sgsn_test.c | 90 +++++++++++++++++++++++++++---------- openbsc/tests/vty_test_runner.py | 5 ++- 8 files changed, 202 insertions(+), 90 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

1 0

openbsc.git branch jerlbeck/wip/gprs-patching updated. 0.13.0-918-g8b77456
by gitosis＠osmocom.org 30 Jan '15

30 Jan '15

1 0

osmo-gmr.git branch sylvain/gr updated. v0.2-86-g93b2ce9
by gitosis＠osmocom.org 30 Jan '15

30 Jan '15

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Software for ETSI GMR (GEO Mobile Radio)". The branch, sylvain/gr has been updated via 93b2ce91b037b3369edcd6e480c2271ff088418e (commit) via 5ec66c633738d86043cc9c34347cf839710a6763 (commit) via 6ea35456ea7b2b7e7e548a62568d679c8ed08ef0 (commit) from ce3c94735cf8cfb832868e73bca6ccae178548be (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-gmr/commit/?id=93b2ce91b037b3369edcd6e480c2271… commit 93b2ce91b037b3369edcd6e480c2271ff088418e Author: Sylvain Munaut <tnt(a)246tNt.com> Date: Fri Jan 30 10:11:02 2015 +0100 Make use of the new delimited burst feature Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com> http://cgit.osmocom.org/osmo-gmr/commit/?id=5ec66c633738d86043cc9c34347cf83… commit 5ec66c633738d86043cc9c34347cf839710a6763 Author: Sylvain Munaut <tnt(a)246tNt.com> Date: Fri Jan 30 10:07:22 2015 +0100 Import new burst_to_tagged_stream logic Note that this cheats a little since I use the output buffer as temporary storage (i.e. writing samples to it and not telling GR until later ...) Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com> http://cgit.osmocom.org/osmo-gmr/commit/?id=6ea35456ea7b2b7e7e548a62568d679… commit 6ea35456ea7b2b7e7e548a62568d679c8ed08ef0 Author: Sylvain Munaut <tnt(a)246tNt.com> Date: Thu Jan 29 10:51:09 2015 +0100 Improvement to the FFT detection to prevent false positives ----------------------------------------------------------------------- Summary of changes: gr-gmr1/apps/gmr_rach_scan.grc | 264 ++++++++++----------- gr-gmr1/grc/CMakeLists.txt | 1 + .../{rach_demod.xml => burst_to_tagged_stream.xml} | 21 +- gr-gmr1/include/gnuradio/gmr1/CMakeLists.txt | 1 + .../{gsmtap_sink.h => burst_to_tagged_stream.h} | 18 +- gr-gmr1/lib/CMakeLists.txt | 1 + gr-gmr1/lib/burst_to_tagged_stream_impl.cc | 192 +++++++++++++++ ...t_core_impl.h => burst_to_tagged_stream_impl.h} | 38 +-- gr-gmr1/lib/rach_detect_fft_impl.cc | 65 ++++- gr-gmr1/lib/rach_detect_fft_impl.h | 10 +- gr-gmr1/swig/gmr1_swig.i | 4 + 11 files changed, 415 insertions(+), 200 deletions(-) copy gr-gmr1/grc/{rach_demod.xml => burst_to_tagged_stream.xml} (51%) copy gr-gmr1/include/gnuradio/gmr1/{gsmtap_sink.h => burst_to_tagged_stream.h} (67%) create mode 100644 gr-gmr1/lib/burst_to_tagged_stream_impl.cc copy gr-gmr1/lib/{rach_detect_core_impl.h => burst_to_tagged_stream_impl.h} (55%) hooks/post-receive -- Software for ETSI GMR (GEO Mobile Radio)

1 0

openbsc.git branch jerlbeck/wip/gprs-patching updated. 0.13.0-917-g0ee763f
by gitosis＠osmocom.org 29 Jan '15

29 Jan '15

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, jerlbeck/wip/gprs-patching has been updated discards 70992b3369bb8922d92aabdbd54a33d3a52d8c05 (commit) discards 0153212b910a6c01103e1f4dc914457ac733bd9c (commit) discards 7d08477daa44919b65bbbaa794947e70bc88e407 (commit) discards 8f4a1762c82e25093de13c30fd58d0b3645c8e9f (commit) discards 78198111ebf1f60fb369a9788b5f8045d9b0beb8 (commit) discards c3f158e84846fc1fbd58aa0e377acd12a78d29ab (commit) discards 3b928ed5ed7e93144714fbe4e332ef04769d0b08 (commit) discards 34287fbf01125845844f84de7e6111e77d137775 (commit) via 0ee763fe1b99390f23eb62cc86d1848e89cdbeb4 (commit) via 97113dccfc7af33e7443e1086932306718f87554 (commit) via b2186d39d547280a73ff24cc0a4d657301cd0cc4 (commit) via 367e17ab4fac2388bba6329101fce721fcec28ca (commit) via 5bb5439eaf769bc63159df1875e11da158695f69 (commit) via 5d2620dd4a233dafcf1c8e170a0934521e3ae8ba (commit) via 01a346c7320c9f9eceae8245d75700242cf65151 (commit) via 09283010307a88941f1c47746bbdce29e0e3b783 (commit) via 612ecee1666fc6d42eebbeda73e21bd86740023b (commit) via 90a5ed8f6b53e8a3f84e4d80d74ef5a308ec0ec2 (commit) via fdb18e8c191648abe1b9f1393157b106d8d03c1b (commit) via c735ef9a098d94bd2a3451f7004855bcf973fe91 (commit) via d5d594fcc93a7719bd1a64d51e9c10e331f2a43d (commit) via a1f0dd1e5193556b9cdfb57dead27457230f4415 (commit) via 925c57fb545b072159a831bff852c92795704dfe (commit) via 1ba0730a7109b06e4043e7b17c11d8d2c34358c5 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (70992b3369bb8922d92aabdbd54a33d3a52d8c05) \ N -- N -- N (0ee763fe1b99390f23eb62cc86d1848e89cdbeb4) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=0ee763fe1b99390f23eb62cc86d1848e… commit 0ee763fe1b99390f23eb62cc86d1848e89cdbeb4 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Sep 30 13:53:26 2014 +0200 sgsn: Added TODOs (TODO) TODO: - fix and remove TODOs - add test cases for Detach(reattach) - add test cases for PDP context deletion (OW#1311) - add test cases for Cancel pending timer in sgsn_mm_ctx_free - remove this commit Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=97113dccfc7af33e7443e10869323067… commit 97113dccfc7af33e7443e1086932306718f87554 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Wed Dec 17 14:03:35 2014 +0100 sgsn: Add PDP info to subscriber data (TODO) TODO: - commit message - raw binary representation ??? - tests Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=b2186d39d547280a73ff24cc0a4d6573… commit b2186d39d547280a73ff24cc0a4d657301cd0cc4 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Fri Dec 19 19:11:20 2014 +0100 sgsn: Add logging to connect_timer_cb (TODO) TODO: - LOGLevel ? Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=367e17ab4fac2388bba6329101fce721… commit 367e17ab4fac2388bba6329101fce721fcec28ca Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Thu Jan 29 14:55:34 2015 +0100 sgsn/test: Add checks for subscr->error_cause This commits adds a few asserts that check the value of subscr->error_cause after a GSUP message has been received. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=5bb5439eaf769bc63159df1875e11da1… commit 5bb5439eaf769bc63159df1875e11da158695f69 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Thu Jan 29 14:17:51 2015 +0100 gprs: Use 'Network failure' as default cause This commit adds a check after a GSUP message has been decoded whether it is an error message and does not contain a cause value. If his is the case, the cause value is set to 'Network failure', so that this cause if effectively the default value for error messages. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=5d2620dd4a233dafcf1c8e170a093452… commit 5d2620dd4a233dafcf1c8e170a0934521e3ae8ba Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Thu Jan 29 14:15:54 2015 +0100 gprs/test: Fix GSUP Purge MS response messages Currently the message types for these message types are wrong. This patch inserts the correct message types. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=01a346c7320c9f9eceae8245d7570024… commit 01a346c7320c9f9eceae8245d75700242cf65151 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Thu Jan 29 14:12:29 2015 +0100 sgsn/test: Add tests for PurgeMs responses Currently there are not any test cases for PurgeMS GSUP messages in test_subscriber_gsup. This commit adds tests for incoming PurgeMSResult and -Error messages. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=09283010307a88941f1c47746bbdce29… commit 09283010307a88941f1c47746bbdce29e0e3b783 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Thu Jan 29 14:00:28 2015 +0100 gprs: Send GSUP error reply for requests without IMSI (TODO) Currently gprs_subscr_rx_gsup_message returns immediately after it detects that an IMSI has not been given in the received GSUP message. While this is ok for responses (result or error), a request should always be answered. This commit adds code to reply with a corresponding error message ("Invalid mandatory information") when it receives a request without an IMSI. Note that the generated error message will not contain an IMSI, too. TODO: - add logging Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=612ecee1666fc6d42eebbeda73e21bd8… commit 612ecee1666fc6d42eebbeda73e21bd86740023b Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Thu Jan 29 11:36:35 2015 +0100 gprs: Extend specification of GSUP cause values (TODO) Currently, every error message contains a mandantory Cause IE just referring to GSM 04.08 for further details. This leaves the mapping from MAP User Errors to GMM Cause values undefined. It is also not specified, which GMM Cause to assume, if no User Error has been included in the MAP message. This commit makes the Cause IE conditional, it is only required if the MAP message contained a User Error. A mapping from User Errors to GMM Causes is also added. The default value for GMM Causes in GSUP error messages is now 'Network failure' to keep the impact low. TODO: - the mapping is not finished, it needs review and some values are not yet specified. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=90a5ed8f6b53e8a3f84e4d80d74ef5a3… commit 90a5ed8f6b53e8a3f84e4d80d74ef5a308ec0ec2 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Jan 27 14:56:40 2015 +0100 gprs: Support cancellation type The cancellation type that is part of the UpdateCancellation message is currently ignored. This patch adds the missing glue between the existing GSUP and GMM support. If the type is not present or has the value updateProcedure the subcriber and MM context are siliently removed. Otherwise, a message with cause 'implicitly detached' is sent to the MS. Since the real cause is not known (the specification neither added a cause IE nor defined a static cause value), the MS may get the real cause in the following AttachRej. Added VTY commands: - update-subscriber imsi IMSI cancel update-procedure - update-subscriber imsi IMSI cancel subscription-withdraw the old form without the cause is no longer supported. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=fdb18e8c191648abe1b9f1393157b106… commit fdb18e8c191648abe1b9f1393157b106d8d03c1b Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Jan 27 13:47:24 2015 +0100 gprs: Handle PURGE MS ERR/RES without subscr Currently the subscr entry is no longer present, when PURGE MS ERROR/RESULT arrives. In this case, an unspecific notice is logged ('unknown IMSI'). This clutters up the logfile with notices even in perfectly normal operation. This commit changes the code path that is used when a subscr cannot be found for an incoming GSUP message. A check for PURGE MS RESULT and ERROR is added and gprs_subscr_handle_gsup_purge_no_subscr is called for these messages instead of gprs_subscr_handle_unknown_imsi. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=c735ef9a098d94bd2a3451f7004855bc… commit c735ef9a098d94bd2a3451f7004855bcf973fe91 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Jan 27 12:41:19 2015 +0100 gprs: Don't use subscr->keep_in_ram in normal operation Currently the keep_in_ram flag is explicitely reset in gprs_subscr_cleanup to cover the case, that the VTY 'create' sub-command has been used to create the subscriber entry. This commit completely removes keep_in_ram handling from gprs_subscriber.c and adds a VTY 'destroy' sub-command to reset the flag and remove the entry. So 'create' and 'destroy' can be used to manager sticky entries that are kept even when a location cancellation is done. Added VTY command: - update-subscriber imsi IMSI destroy Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=d5d594fcc93a7719bd1a64d51e9c10e3… commit d5d594fcc93a7719bd1a64d51e9c10e331f2a43d Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Jan 26 14:43:07 2015 +0100 sgsn: Add sgsn_mm_ctx_cleanup_free for safe shutdown Currently the MM context cleanup code is distributed over several functions. sgsn_mm_ctx_free not only frees data structure but also eventually stops the timer and does the subscriber clean-up. mm_ctx_cleanup_free (gprs_gmm.c) cleans up the PDP contexts and unassign the TLLI. This commit moves the cleanup code from both functions into a new unifying function sgsn_mm_ctx_cleanup_free that cares about the clean-up of all related sub-systems. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=a1f0dd1e5193556b9cdfb57dead27457… commit a1f0dd1e5193556b9cdfb57dead27457230f4415 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Jan 26 13:52:42 2015 +0100 sgsn: Don't allow mmctx == NULL in sgsn_update_subscriber_data Currently, sgsn_update_subscriber_data can be called with mmctx == NULL and will find and associate the right context (if present) based on the subscriber's IMSI. This will not happen in regular use any more, since sgsn_update_subscriber_data will only be called when subscribers are used (auth mode 'remote') and in this case gprs_subscr_get_or_create_by_mmctx will already be called by sgsn_auth_request. Therefore, MM context and subscriber are always associated except for some test cases and experimental VTY usage. The current implementation of sgsn_update_subscriber_data also causes additional complexity for the deletion on MM contexts to avoid a ipossible double-free MM contexts. This commit removes the MM context <-> subscriber association code from sgsn_update_subscriber_data. That function must always be called with mmctx != NULL, now. To avoid problems with VTY and test usage, the calling subscriber function now only call sgsn_update_subscriber_data when mmctx != NULL, since the purpose of that function is to update that state of an existing MM context after subscriber data has been changed. Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: openbsc/doc/sgsn-remote-protocol.txt | 77 +++++++++++++++++++++++++++---- openbsc/include/openbsc/gsm_data.h | 1 + openbsc/include/openbsc/vty.h | 1 + openbsc/src/gprs/gprs_subscriber.c | 11 ++++- openbsc/src/libbsc/net_init.c | 2 + openbsc/src/libcommon/common_vty.c | 1 + openbsc/src/libmsc/gsm_04_08.c | 29 ++++++++---- openbsc/src/libmsc/vty_interface_layer3.c | 47 +++++++++++++++++++ openbsc/tests/gprs/gprs_test.c | 4 +- openbsc/tests/sgsn/sgsn_test.c | 37 +++++++++++++++ 10 files changed, 187 insertions(+), 23 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

1 0

openbsc.git branch jerlbeck/wip/gprs-patching updated. 0.13.0-909-g70992b3
by gitosis＠osmocom.org 27 Jan '15

27 Jan '15

1 0

openbsc.git branch master updated. 0.13.0-903-g925c57f
by gitosis＠osmocom.org 27 Jan '15

27 Jan '15

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, master has been updated via 925c57fb545b072159a831bff852c92795704dfe (commit) via 1ba0730a7109b06e4043e7b17c11d8d2c34358c5 (commit) from 120250ad6fe8d2b641b716d5b37d48b125db23ca (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=925c57fb545b072159a831bff852c927… commit 925c57fb545b072159a831bff852c92795704dfe Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Tue Jan 27 10:58:29 2015 +0100 nitb: Make the last change configurable Introduce a NITB node and add the subscriber creation as config name in there. http://cgit.osmocom.org/openbsc/commit/?id=1ba0730a7109b06e4043e7b17c11d8d2… commit 1ba0730a7109b06e4043e7b17c11d8d2c34358c5 Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Tue Jan 27 10:27:53 2015 +0100 nitb: Allow the network to decide if a subscriber should be created ----------------------------------------------------------------------- Summary of changes: openbsc/include/openbsc/gsm_data.h | 1 + openbsc/include/openbsc/vty.h | 1 + openbsc/src/libbsc/net_init.c | 2 ++ openbsc/src/libcommon/common_vty.c | 1 + openbsc/src/libmsc/gsm_04_08.c | 29 +++++++++++++------ openbsc/src/libmsc/vty_interface_layer3.c | 47 +++++++++++++++++++++++++++++++ 6 files changed, 72 insertions(+), 9 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

osmocom-commitlog January 2015