This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Osmocom BTS-side code (Abis, scheduling, ...)".
The branch, zecke/sysmobts-calibration has been updated
discards bc7b625afb3e5cf88e3e4e1320a5415bd48a9606 (commit)
discards e121a761baaa2414de4a744392cacdc35db0d324 (commit)
discards 02f2ded39e9ae83c89017b9036a6c6cd5bafd0b0 (commit)
discards 3d75cb056d4b67b6cd3aeb6c786a201c4f9a6638 (commit)
discards 2048b09a6443fab269ee2da55c32c4813482cad4 (commit)
discards 814ec0773161fb9d4074cf35edef2ab2c8b2ac65 (commit)
discards 1716cb479cfe1ddaa240e7ed1dc6a47f00bdc234 (commit)
via 83a549a153a30b8bc7122e0ca2f99ea6fcb1ea44 (commit)
via a70c8f1c8ae5b222008888d98bdf7deee411d2e3 (commit)
via 0ae0c43883fa3c60ed3adf9703236db873b4229f (commit)
via 3bf0b4382a75cf8a36fe2eeed9d8ff7085c92125 (commit)
via 84f21fbcb5b4b8677f6c20f73bb38430dbde0a48 (commit)
via f2fbdcff6b49bab3f9f202d8f7212bfc63145ce7 (commit)
via 553db72509fb6936e782a75cd04d1ed91d00f12c (commit)
via d81b78b524c823122d569fc09f4a764b7a2e13f2 (commit)
via 8fc2630dd4884ffeb4c5fc93457c8c06e6dbf918 (commit)
via bd988f6ad3624ae0be3bdc19143d4db0290744f5 (commit)
via 1e245336ecfe6cbdf3c4253ca5557146d493126d (commit)
via 4457c0d9ba73a0f8f9e95bb24dd3f33f469b4fe3 (commit)
via 660116fb9d7b382808377274ae4aed7c45e980e3 (commit)
via b15d2c9d2f8ebe56672ab2191a4dc39d22fa0ab8 (commit)
via 50dc96507caba9480938eb3d9d0db9236f877b49 (commit)
This update added new revisions after undoing existing revisions. That is
to say, the old revision is not a strict subset of the new revision. This
situation occurs when you --force push a change and generate a repository
containing something like this:
* -- * -- B -- O -- O -- O (bc7b625afb3e5cf88e3e4e1320a5415bd48a9606)
\
N -- N -- N (83a549a153a30b8bc7122e0ca2f99ea6fcb1ea44)
When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmo-bts/commit/?id=83a549a153a30b8bc7122e0ca2f99ea…
commit 83a549a153a30b8bc7122e0ca2f99ea6fcb1ea44
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Tue Dec 23 11:47:28 2014 +0100
sysmobts: Create a calibration loop that will be run
Continously run the calibration process. Everytime we call the
reset function classify the outcome. In case of a failure schedule
the next command soon and otherwise wait several hours.
Remember if the process was started through the VTY or the run
loop. In case it can't be started immediately reset and schedule
a new run.
http://cgit.osmocom.org/osmo-bts/commit/?id=a70c8f1c8ae5b222008888d98bdf7de…
commit a70c8f1c8ae5b222008888d98bdf7deee411d2e3
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Tue Dec 23 09:45:55 2014 +0100
sysmobts: Start the calibration the first time the link is up
After a reboot the system might have been off for a long time
and the currently used value might be wrong. Remember that we
never ran the calibration and execute it on start.
http://cgit.osmocom.org/osmo-bts/commit/?id=0ae0c43883fa3c60ed3adf9703236db…
commit 0ae0c43883fa3c60ed3adf9703236db873b4229f
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Mon Dec 22 18:24:57 2014 +0100
sysmobts: Initial version to use libgps to determine FIX state
We should only calibrate the clock if there is a GPS fix. Start
gpsd to determine if there is a fix or not. Work around trimble
decoding issues (sent an email upstream). We need to gain some
more experience to see if there memory leaks. We also need to
re-schedule the calibration depending on the outcome.
http://cgit.osmocom.org/osmo-bts/commit/?id=3bf0b4382a75cf8a36fe2eeed9d8ff7…
commit 3bf0b4382a75cf8a36fe2eeed9d8ff7085c92125
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Tue Jan 6 19:11:49 2015 +0100
sysmobts: The correction for GPS is in the reverse direction
Change the sign before passing it as correction value. The error
is the difference between the TCXO and GPS. We need to correct by
the reverse of the error. This seems to be different depending on
the clock source we have.
This is a last minute untested change.
http://cgit.osmocom.org/osmo-bts/commit/?id=84f21fbcb5b4b8677f6c20f73bb3843…
commit 84f21fbcb5b4b8677f6c20f73bb38430dbde0a48
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Fri Dec 12 21:54:43 2014 +0100
sysmobts: Use the ctrl interface for calibration
This runs the entire procedure for calibration with reasonable
error and success checking. It can be triggered from the VTY
of the sysmobts-mgr right now.
What is missing is to hook up with GPSD to check if the system
has a fix and provide a mode that will continously run the
calibration command.
http://cgit.osmocom.org/osmo-bts/commit/?id=f2fbdcff6b49bab3f9f202d8f7212bf…
commit f2fbdcff6b49bab3f9f202d8f7212bfc63145ce7
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Fri Dec 12 19:20:17 2014 +0100
sysmobts: Copy more of l1if_rf_clock_info_reset into the CTRL code
The CTRL code should have used/extended the l1_if calibration
code. The sysmobts-mgr code first needs to determine if the
clock adjustment is necessary at all. This is done by first
resetting the counters, then waiting, then asking for the diff
and then applying the correction value. But the reference clock
is only set by the application comand.
Copy more code of l1if_rf_clock_info_reset to set the reference
clock as value. This is leaving some todos inside the code that
will be resolved as part of SYS#835.
Related: SYS#835
http://cgit.osmocom.org/osmo-bts/commit/?id=553db72509fb6936e782a75cd04d1ed…
commit 553db72509fb6936e782a75cd04d1ed91d00f12c
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Fri Dec 12 16:59:41 2014 +0100
sysmobts: Begin with calib control from the sysmobts manager
In the long run we will connect to GPSD and wait for a fix and
then run the calibration. The first step is to open (and re-open)
the control connection to the BTS.
As the connection is on localhost there should not be a computation
overhead to always have the connection open. When connecting assume
that the ASYNC connect worked directly as otherwise we get no
notification of the failure.
This looks like a "bug" of libosmo-abis that should check if the
socket has been connected or not.
http://cgit.osmocom.org/osmo-bts/commit/?id=d81b78b524c823122d569fc09f4a764…
commit d81b78b524c823122d569fc09f4a764b7a2e13f2
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Fri Dec 12 16:54:08 2014 +0100
msg: Generalize the message structure test
This was taken out of LaF0rge's OML router branch and is now
used by the extended calibration feature.
-----------------------------------------------------------------------
Summary of changes:
include/osmo-bts/Makefile.am | 2 +-
include/osmo-bts/cbch.h | 16 +++
include/osmo-bts/gsm_data.h | 6 +
src/common/Makefile.am | 3 +-
src/common/bts.c | 2 +
src/common/cbch.c | 196 +++++++++++++++++++++++++++
src/common/measurement.c | 4 +
src/common/oml.c | 18 ++-
src/common/rsl.c | 33 ++++-
src/common/support.c | 4 +
src/common/vty.c | 15 +-
src/osmo-bts-sysmo/l1_if.c | 5 +
src/osmo-bts-sysmo/misc/sysmobts_mgr_calib.c | 21 ++-
src/osmo-bts-sysmo/misc/sysmobts_mgr_nl.c | 11 +-
src/osmo-bts-sysmo/oml.c | 17 +++
15 files changed, 340 insertions(+), 13 deletions(-)
create mode 100644 include/osmo-bts/cbch.h
create mode 100644 src/common/cbch.c
hooks/post-receive
--
Osmocom BTS-side code (Abis, scheduling, ...)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, jerlbeck/wip/gprs-patching has been updated
via ab5820d6dbbe322de617aaf8a5ccaf0ad0a2bffc (commit)
from a43e25b50c1ad30a597e336c8f47e274a9911186 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=ab5820d6dbbe322de617aaf8a5ccaf0a…
commit ab5820d6dbbe322de617aaf8a5ccaf0ad0a2bffc
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Jan 6 16:32:41 2015 +0100
gprs: Add expiry timeout for subscriber entries (TODO)
Set the expiry delay after the subscriber has been deleted (e.g. by
freeing the MM context). If cancelled, the subscriber will be deleted
immediately and no timeout will be set. If the expiry time is unset,
the subscriber entry will be kept but no timer will be started.
- [no] subscriber-expiry-time <0-999999>
TODO:
- commit message
- fix test
- send PURGE MS (other commit)
- expire ununsed MM contexts (other commit)
- which default timeout ???
Ticket: OW#????
Sponsored-by: On-Waves ehf
-----------------------------------------------------------------------
Summary of changes:
openbsc/include/openbsc/gprs_sgsn.h | 1 +
openbsc/include/openbsc/sgsn.h | 4 ++++
openbsc/src/gprs/gprs_subscriber.c | 48 +++++++++++++++++++++++++++++++++++--
openbsc/src/gprs/sgsn_vty.c | 35 +++++++++++++++++++++++++++
4 files changed, 86 insertions(+), 2 deletions(-)
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, jerlbeck/wip/gprs-patching has been updated
discards 13713264aa539ce1343ad6c7dd0f8308b242a892 (commit)
discards f30d7455f17f8488b03d8727f33dfaa39e812107 (commit)
discards 917d8e33aa0f6f14d459124ab63961a1876b7379 (commit)
discards b0f9aae0e08b65ce2636218379853f88f33134fa (commit)
discards 033dacd0be40045485ce85fe6d736dad56277b97 (commit)
discards df41492476d1134f907c9eeaa8da592223012e30 (commit)
discards d255302af01073748213504bd65692941b30c01c (commit)
discards 9230f1a7537821dff9b5cd6f65fd77cf5a0a16f8 (commit)
via a43e25b50c1ad30a597e336c8f47e274a9911186 (commit)
via 6a3dab12333b610ca35622d943647b17585f8871 (commit)
via f2cde608fc40b767e540073c575fbd0479c1c0a7 (commit)
via 156c91bc2e564894aa09b5ebe7f2ff13923cd8da (commit)
via 1e3bc33ed38ed2f9fca27f19e4197abb559b1cf8 (commit)
via 76a917b02cff735d1bf7eaa4685462ab631dce76 (commit)
via 93d39583080a58fb16597ecc341a1ce32ad38d7a (commit)
via f8f8fba629ed6b861dacb1f997c9f28d83a162e0 (commit)
This update added new revisions after undoing existing revisions. That is
to say, the old revision is not a strict subset of the new revision. This
situation occurs when you --force push a change and generate a repository
containing something like this:
* -- * -- B -- O -- O -- O (13713264aa539ce1343ad6c7dd0f8308b242a892)
\
N -- N -- N (a43e25b50c1ad30a597e336c8f47e274a9911186)
When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=a43e25b50c1ad30a597e336c8f47e274…
commit a43e25b50c1ad30a597e336c8f47e274a9911186
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Sep 30 13:53:26 2014 +0200
sgsn: Added TODOs (TODO)
TODO:
- fix and remove TODOs
- add test cases for Detach(reattach)
- add test cases for PDP context deletion (OW#1311)
- add test cases for Cancel pending timer in sgsn_mm_ctx_free
- remove this commit
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=6a3dab12333b610ca35622d943647b17…
commit 6a3dab12333b610ca35622d943647b17585f8871
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Oct 17 10:08:02 2014 +0200
sgsn: Do not die in _bssgp_tx_dl_ud on TLLI mismatch (TODO)
Currently an OSMO_ASSERT fails, if the message's and the mmctx's
TLLIs do not match.
This commit turns the assertion into an ERROR log message and uses
the default values for IMSI, DRX, and RA CAP instead of the MM
context values in this case.
TODO:
- find the real source for the problem
- add test cases derived from what is being described in the ticket
Ticket: OW#1322
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=f2cde608fc40b767e540073c575fbd04…
commit f2cde608fc40b767e540073c575fbd0479c1c0a7
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Wed Dec 17 14:03:35 2014 +0100
sgsn: Add PDP info to subscriber data (TODO)
TODO:
- commit message
- raw binary representation ???
- tests
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=156c91bc2e564894aa09b5ebe7f2ff13…
commit 156c91bc2e564894aa09b5ebe7f2ff13923cd8da
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Dec 19 19:11:20 2014 +0100
sgsn: Add logging to connect_timer_cb (TODO)
TODO:
- LOGLevel ?
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=1e3bc33ed38ed2f9fca27f19e4197abb…
commit 1e3bc33ed38ed2f9fca27f19e4197abb559b1cf8
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Jan 5 16:20:47 2015 +0100
gprs: Pass GMM causes related to the MSC connection
Currently the error causes MSC_TEMP_NOTREACH, NET_FAIL, and
CONGESTION are silently dropped to force the MS to continue. On the
other hand, GSM 04.08/24.008, 4.7.3.1.4 in combination with 4.7.3.1.5,
require the MS to retry the attachment procedure for cause codes
above 15 instead of disabling GPRS. All of the mentioned GMM causes
have codes above 15, so using a REJECT message including the cause
code is a better choice. This way, the retry algorithm based on T3311
(15s, 5 times) and T3302 (default 12min) could be used.
This patch modifies gprs_subscr_handle_gsup_auth_err and
gprs_subscr_handle_gsup_upd_loc_err to proceed like when the access
has beed denied, except that the corresponding subscriber's
information fields are not cleared.
This has been successfully tested which an iphone which enters a
retry loop as it is being described in the specification.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=76a917b02cff735d1bf7eaa4685462ab…
commit 76a917b02cff735d1bf7eaa4685462ab631dce76
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Dec 23 14:24:16 2014 +0100
gprs: Use LOGMMCTX for logging in gprs_susbcriber.c
To unify the layout of the logging messages, this patch replaces some
calls to LOGP by calls to LOGMMCTXP.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=93d39583080a58fb16597ecc341a1ce3…
commit 93d39583080a58fb16597ecc341a1ce32ad38d7a
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Jan 5 18:57:32 2015 +0100
gprs: Let GSUP parser functions return GMM causes on errors
Currently the GSUP message handling function in gprs_subscriber.c and
the functions in gprs_gsup_messages.c are not consistent with respect
to the return codes if an error happens. Albeit all error return
codes are negative, the semantics of the absolute value are not
clearly defined. In addition, some return codes are not passed to the
calling function.
This path changes these functions to always return a negated GMM
cause value in case of errors. Return values of called parser
functions are not longer ignored.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=f8f8fba629ed6b861dacb1f997c9f28d…
commit f8f8fba629ed6b861dacb1f997c9f28d83a162e0
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Jan 5 18:38:41 2015 +0100
gprs: Use the cause value in GSUP error messages
Currently always a cause with the meaning of 'access denied' is
assumed. gprs_subscr_handle_gsup_auth_err just clears the auth
triplets and the authorized flag before calling the update function.
gprs_subscr_handle_gsup_upd_loc_err only clears the authorized flag
and calls the update function. This means, that an MS will not retry
to attach even on temporary network errors.
This patch changes these functions to use the GSUP error cause value
to decide, whether to clear the corresponding subscriber fields, to
just continue with the corresponding update function, or to log,
ignore and not pass the cause to the MS in case the error is directly
related to the GSUP protocol. The subscriber's error_cause field is
updated, if the update function is going to be called. The
error_cause fielt is reset on non-error GSUP messages.
Sponsored-by: On-Waves ehf
-----------------------------------------------------------------------
Summary of changes:
openbsc/src/gprs/gprs_subscriber.c | 30 ++++++++++++++++++++----------
1 file changed, 20 insertions(+), 10 deletions(-)
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, jerlbeck/wip/gprs-patching has been updated
discards 0b1caf7da499d1cbce53795cf9deee4643636327 (commit)
discards 7cfbae6fc6168148f937cf781bed962ed8ec1a32 (commit)
discards c6d308f59292adc572b680065192e9ed55ea19e9 (commit)
discards ba59d61d98064219b7618ffa254027b009201d80 (commit)
discards 7c2a048c2be60ea3e30bc755939503299b720904 (commit)
via 13713264aa539ce1343ad6c7dd0f8308b242a892 (commit)
via f30d7455f17f8488b03d8727f33dfaa39e812107 (commit)
via 917d8e33aa0f6f14d459124ab63961a1876b7379 (commit)
via b0f9aae0e08b65ce2636218379853f88f33134fa (commit)
via 033dacd0be40045485ce85fe6d736dad56277b97 (commit)
via df41492476d1134f907c9eeaa8da592223012e30 (commit)
via d255302af01073748213504bd65692941b30c01c (commit)
via 9230f1a7537821dff9b5cd6f65fd77cf5a0a16f8 (commit)
via 67014fd5657394534326c99554f89ec85970e509 (commit)
via e8978ac39c5e96877960f0df07644efc8a0bc321 (commit)
This update added new revisions after undoing existing revisions. That is
to say, the old revision is not a strict subset of the new revision. This
situation occurs when you --force push a change and generate a repository
containing something like this:
* -- * -- B -- O -- O -- O (0b1caf7da499d1cbce53795cf9deee4643636327)
\
N -- N -- N (13713264aa539ce1343ad6c7dd0f8308b242a892)
When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=13713264aa539ce1343ad6c7dd0f8308…
commit 13713264aa539ce1343ad6c7dd0f8308b242a892
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Sep 30 13:53:26 2014 +0200
sgsn: Added TODOs (TODO)
TODO:
- fix and remove TODOs
- add test cases for Detach(reattach)
- add test cases for PDP context deletion (OW#1311)
- add test cases for Cancel pending timer in sgsn_mm_ctx_free
- remove this commit
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=f30d7455f17f8488b03d8727f33dfaa3…
commit f30d7455f17f8488b03d8727f33dfaa39e812107
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Oct 17 10:08:02 2014 +0200
sgsn: Do not die in _bssgp_tx_dl_ud on TLLI mismatch (TODO)
Currently an OSMO_ASSERT fails, if the message's and the mmctx's
TLLIs do not match.
This commit turns the assertion into an ERROR log message and uses
the default values for IMSI, DRX, and RA CAP instead of the MM
context values in this case.
TODO:
- find the real source for the problem
- add test cases derived from what is being described in the ticket
Ticket: OW#1322
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=917d8e33aa0f6f14d459124ab63961a1…
commit 917d8e33aa0f6f14d459124ab63961a1876b7379
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Wed Dec 17 14:03:35 2014 +0100
sgsn: Add PDP info to subscriber data (TODO)
TODO:
- commit message
- raw binary representation ???
- tests
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=b0f9aae0e08b65ce2636218379853f88…
commit b0f9aae0e08b65ce2636218379853f88f33134fa
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Dec 19 19:11:20 2014 +0100
sgsn: Add logging to connect_timer_cb (TODO)
TODO:
- LOGLevel ?
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=033dacd0be40045485ce85fe6d736dad…
commit 033dacd0be40045485ce85fe6d736dad56277b97
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Jan 5 16:20:47 2015 +0100
gprs: Pass GMM causes related to the MSC connection
Currently the error causes MSC_TEMP_NOTREACH, NET_FAIL, and
CONGESTION are silently dropped to force the MS to continue. On the
other hand, GSM 04.08/24.008, 4.7.3.1.4 in combination with 4.7.3.1.5,
require the MS to retry the attachment procedure for cause codes
above 15 instead of disabling GPRS. All of the mentioned GMM causes
have codes above 15, so using a REJECT message including the cause
code is a better choice. This way, the retry algorithm based on T3311
(15s, 5 times) and T3302 (default 12min) could be used.
This patch modifies gprs_subscr_handle_gsup_auth_err and
gprs_subscr_handle_gsup_upd_loc_err to proceed like when the access
has beed denied, except that the corresponding subscriber's
information fields are not cleared.
This has been successfully tested which an iphone which enters a
retry loop as it is being described in the specification.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=df41492476d1134f907c9eeaa8da5922…
commit df41492476d1134f907c9eeaa8da592223012e30
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Dec 23 14:24:16 2014 +0100
sgsn: Use LOGMMCTX for logging
To unify the layout of the logging messages, this patch replaces some
calls to LOGP by calls to LOGMMCTXP.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=d255302af01073748213504bd6569294…
commit d255302af01073748213504bd65692941b30c01c
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Jan 5 18:57:32 2015 +0100
gprs: Let GSUP parser functions return GMM causes on errors
Currently the GSUP message handling function in gprs_subscriber.c and
the functions in gprs_gsup_messages.c are not consistent with respect
to the return codes if an error happens. Albeit all error return
codes are negative, the semantics of the absolute value are not
clearly defined. In addition, some return codes are not passed to the
calling function.
This path changes these functions to always return a negated GMM
cause value in case of errors. Return values of called parser
functions are not longer ignored.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=9230f1a7537821dff9b5cd6f65fd77cf…
commit 9230f1a7537821dff9b5cd6f65fd77cf5a0a16f8
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Jan 5 18:38:41 2015 +0100
gprs: Use the cause value in GSUP error messages
Currently always a cause with the meaning of 'access denied' is
assumed. gprs_subscr_handle_gsup_auth_err just clears the auth
triplets and the authorized flag before calling the update function.
gprs_subscr_handle_gsup_upd_loc_err only clears the authorized flag
and calls the update function. This means, that an MS will not retry
to attach even on temporary network errors.
This patch changes these functions to use the GSUP error cause value
to decide, whether to clear the corresponding subscriber fields, to
just continue with the corresponding update function, or to log,
ignore and not pass the cause to the MS in case the error is directly
related to the GSUP protocol. The subscriber's error_cause field is
updated, if the update function is going to be called. The
error_cause fielt is reset on non-error GSUP messages.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=67014fd5657394534326c99554f89ec8…
commit 67014fd5657394534326c99554f89ec85970e509
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Jan 5 17:51:17 2015 +0100
gprs: Pass subscriber error causes to the GMM layer
This patch extends gsm0408_gprs_access_denied and
gsm0408_gprs_access_cancelled to accept GMM cause codes. These are
then passed to the MS, unless gsm0408_gprs_access_cancelled is called
with cause 0 (no error -> updateProcedure).
Since gsm0408_gprs_access_denied uses GMM_CAUSE_GPRS_NOTALLOWED if
the cause is not set, and the subscriber's error_cause is never set
(and thus always 0), the SGSN's behaviour does not change with this
patch.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=e8978ac39c5e96877960f0df07644efc…
commit e8978ac39c5e96877960f0df07644efc8a0bc321
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Jan 5 17:30:02 2015 +0100
gprs: Move protocol value_strings to gsm_04_08_gprs.c
Currently the mapping between GSM 04.08 (GPRS) protocol specific
numbers and their textual description was put into gprs_gmm.c and not
exported.
This commit moves the mappings to a new file gsm_04_08_gprs.c,
renames some of them, and exports them via gsm_04_08_gprs.h.
The following identifiers are renamed to match the corresponding type
names:
- gmm_cause_names -> gsm48_gmm_cause_names
- gsm_cause_names -> gsm48_gsm_cause_names
Sponsored-by: On-Waves ehf
-----------------------------------------------------------------------
Summary of changes:
openbsc/include/openbsc/gsm_04_08_gprs.h | 11 +++
openbsc/src/gprs/Makefile.am | 3 +-
openbsc/src/gprs/gprs_gmm.c | 134 +++++------------------------
openbsc/src/gprs/gprs_gsup_messages.c | 4 +-
openbsc/src/gprs/gprs_subscriber.c | 20 ++++-
openbsc/src/gprs/gsm_04_08_gprs.c | 141 +++++++++++++++++++++++++++++++
openbsc/tests/sgsn/Makefile.am | 1 +
7 files changed, 192 insertions(+), 122 deletions(-)
create mode 100644 openbsc/src/gprs/gsm_04_08_gprs.c
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, jerlbeck/wip/gprs-patching has been updated
discards b392f1b1448b3eebf779457577fb439d533781c0 (commit)
discards 6888fef2394ec6e7cf9fa1667f6d990ea3323d6f (commit)
discards 4bddf37c8d4b54d94e2245250bdf44916f657ea2 (commit)
discards af31f22589327f0c4a13587ead4b0413af95f845 (commit)
discards 618dce764997e543cbe7e8b5c9313f981122f576 (commit)
discards 1793b8df0dda07fcf29baf31b3b08c748103887f (commit)
discards fa9af3fe29a549523a30e2af521f73b2f17819da (commit)
discards 00ae6ee4ed6677cfe3ac10aeea76c1b0ac125f8e (commit)
discards 50a3edc6c2cca52464c40dd24756365acf57680d (commit)
discards 4cb99aad4fa93be5e4381152ae3fb1583b429b75 (commit)
discards d0d5a90281f54b0ddcfa54a715b01a30045ede62 (commit)
discards a4b21b7f740defe76e70fcb459667436da8bc8fd (commit)
discards bcb60cccc36aa2b48abeec55081decdce623b9a1 (commit)
discards cde63d0a32b7610ed077c7831b960c009e024b77 (commit)
discards 95961dd1282789ddd55cbf1c32ea2ce62bec61f0 (commit)
discards 694aad91d4b1bf658cfac767871ddffdcceb45d3 (commit)
discards 4fe374421b460a0f023a4fd7fda048d675d793d1 (commit)
discards 84c734570291d7e240ee473a614ac8f3af14771a (commit)
discards 65f625f2283553497d7cc0d15a4c9ca8e6656442 (commit)
discards 0163dbcc30575ee6953222183f2cbbd0741486b5 (commit)
discards e14a5903e5d1c9fce9d13f91e9a08eeade42a541 (commit)
discards 21aa2a90ea2f5cf10fb9db75c597b8fe572c51cd (commit)
discards 5ca5699e61b2395fd822027c425be5f26bd33ac2 (commit)
via 0b1caf7da499d1cbce53795cf9deee4643636327 (commit)
via 7cfbae6fc6168148f937cf781bed962ed8ec1a32 (commit)
via c6d308f59292adc572b680065192e9ed55ea19e9 (commit)
via ba59d61d98064219b7618ffa254027b009201d80 (commit)
via 7c2a048c2be60ea3e30bc755939503299b720904 (commit)
via 5428ff90b1260769cc918a585abdb1c292d67f7f (commit)
via 4cd6d2a4763b2b6a2d8aa0ea73ee9e692e2ce4b0 (commit)
via 6231ed289064f453b5d2bb56d70afe7a992dfe77 (commit)
via 26f2c6a6846ab959d9e6f8fdf6f229ddd9ec71f7 (commit)
via 65f35a28038ec7ed310a2fca5015b3018c5455e8 (commit)
via 8f4fa5fc5f8225a5fb55fa2c4b12eace56b14df7 (commit)
via 45292a23631fdb943c7aaec0dc1d1af2ce013792 (commit)
via 424d584f82f8240c1325ca25ed186f446997de58 (commit)
via 5c455ae7a7326c19545258a6e247fe2f6b4c3e01 (commit)
via 3d0895483f0d543af485413dedb40294b0efd9b4 (commit)
via 79571191f2c526e18dc1257a3273a7235582d2a6 (commit)
via ed3d6a6020fee411cca3cb7564a4b0cbf6d8b587 (commit)
via 9f2e178f07b7d15733e862fca7c140b1475899ee (commit)
via 847bf670e354fbd11bedbadf63deb0577a0a380b (commit)
via 62068f8848f5c851a06053265b311dca9042b103 (commit)
via 2ad5544bee5062301797a86a6adb44513abe27d2 (commit)
via 5636470b9fa12827e190f3f38386f2824edfcf61 (commit)
via 4e8a698c1173d71f9e0ee6eef182f5884c181493 (commit)
via a67704753a6328f725d38d61af8bfbe29012fcbc (commit)
via 0c4e400d2fdd6445da4dc24851945119517d8083 (commit)
via c598e6e0a6d00827c2c974010d582815d66d0f14 (commit)
via a9e420e93dca43b92b608a819ea782445eef52e0 (commit)
via 1dcc2603e9f06e8be3769a2b1f93e3b761f87c52 (commit)
via e5d2c60ae661e801b7049a2c9526712ded895cc1 (commit)
This update added new revisions after undoing existing revisions. That is
to say, the old revision is not a strict subset of the new revision. This
situation occurs when you --force push a change and generate a repository
containing something like this:
* -- * -- B -- O -- O -- O (b392f1b1448b3eebf779457577fb439d533781c0)
\
N -- N -- N (0b1caf7da499d1cbce53795cf9deee4643636327)
When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=0b1caf7da499d1cbce53795cf9deee46…
commit 0b1caf7da499d1cbce53795cf9deee4643636327
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Dec 23 14:24:16 2014 +0100
sgsn: Handle GSUP errors (WIP)
Ticket: OW#????
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=7cfbae6fc6168148f937cf781bed962e…
commit 7cfbae6fc6168148f937cf781bed962ed8ec1a32
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Sep 30 13:53:26 2014 +0200
sgsn: Added TODOs (TODO)
TODO:
- fix and remove TODOs
- add test cases for Detach(reattach)
- add test cases for PDP context deletion (OW#1311)
- add test cases for Cancel pending timer in sgsn_mm_ctx_free
- remove this commit
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=c6d308f59292adc572b680065192e9ed…
commit c6d308f59292adc572b680065192e9ed55ea19e9
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Oct 17 10:08:02 2014 +0200
sgsn: Do not die in _bssgp_tx_dl_ud on TLLI mismatch (TODO)
Currently an OSMO_ASSERT fails, if the message's and the mmctx's
TLLIs do not match.
This commit turns the assertion into an ERROR log message and uses
the default values for IMSI, DRX, and RA CAP instead of the MM
context values in this case.
TODO:
- find the real source for the problem
- add test cases derived from what is being described in the ticket
Ticket: OW#1322
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=ba59d61d98064219b7618ffa254027b0…
commit ba59d61d98064219b7618ffa254027b009201d80
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Wed Dec 17 14:03:35 2014 +0100
sgsn: Add PDP info to subscriber data (TODO)
TODO:
- commit message
- raw binary representation ???
- tests
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=7c2a048c2be60ea3e30bc75593950329…
commit 7c2a048c2be60ea3e30bc755939503299b720904
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Dec 19 19:11:20 2014 +0100
sgsn: Add logging to connect_timer_cb (TODO)
TODO:
- LOGLevel ?
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=5428ff90b1260769cc918a585abdb1c2…
commit 5428ff90b1260769cc918a585abdb1c292d67f7f
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Dec 19 19:19:46 2014 +0100
sgsn: Show GSUP client info on 'show sgsn'
This commit adds a line to the output of 'show sgsn' if the GSUP
client has been initialized:
- Remote authorization: [not] connected to HOST:PORT via GSUP
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=4cd6d2a4763b2b6a2d8aa0ea73ee9e69…
commit 4cd6d2a4763b2b6a2d8aa0ea73ee9e692e2ce4b0
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Dec 19 19:18:54 2014 +0100
sgsn: Send PING and eventually reconnect
Currently, the reconnect mechanism relies on gsup_client_updown_cb
which in turn gets called based on the OS' view of connection state.
This patch adds a timer based PING mechanism that regularly sends
PING messages and forces a reconnect if a PONG message won't be
received until the next PING message is scheduled. The current ping
interval is 20s.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=6231ed289064f453b5d2bb56d70afe7a…
commit 6231ed289064f453b5d2bb56d70afe7a992dfe77
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Dec 19 19:15:55 2014 +0100
sgsn: Handle incoming IPA CCM message in gsup_client_read_cb
Currently the IPA CCM messages are not handled by the GSUP client.
This means, that the client doesn't answer to PING and ID_GET and
logs notices when receiving PONG or ID_ACK. At least the PING
functionality (remotely originated PING) shall be supported.
This patch extends gsup_client_read_cb by a call to
ipaccess_bts_handle_ccm. Only when the return code is 0, the message
is processed further and checked for an OSMO/GSUP message. ID_GET
messages are answered by a dummy description, where only the
unit_name is set to 'SGSN'.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=26f2c6a6846ab959d9e6f8fdf6f229dd…
commit 26f2c6a6846ab959d9e6f8fdf6f229ddd9ec71f7
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Dec 19 19:00:56 2014 +0100
sgsn: Handle return code of ipa_client_conn_open correctly
The ipa_client_conn_open function does not distinguish between a
connection being already established or waiting for establishment.
In either case, the application gets informed about the connection
state via the updown_cb. The 'up' parameter is only set, if
poll/select consider the socket as writable.
This patch handles both cases equally and fully relies on the
updown_cb to adjust the gsupc obejct state.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=65f35a28038ec7ed310a2fca5015b301…
commit 65f35a28038ec7ed310a2fca5015b3018c5455e8
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Dec 19 18:50:05 2014 +0100
sgsn: Avoid sending stale GSUP requests after reconnect
Currently, messages are added to the tx queue even if the connection
is down for some reason and all of these messages are eventually sent
after a re-connect. The MS has probably sent several Attach Requests
while the connection was down and will continue doing so. Therefore
these stored messages could be dropped.
This patch clears the queue before re-connecting and also extends
gprs_gsup_client_send to return immediately, when the connection is
not established instead of calling ipa_client_conn_send.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=8f4fa5fc5f8225a5fb55fa2c4b12eace…
commit 8f4fa5fc5f8225a5fb55fa2c4b12eace56b14df7
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Dec 18 15:00:29 2014 +0100
sgsn: Add automatic re-connect if the GSUP connection is down
Currently the GSUP connection to a server is not restarted if the
connection cannot be established or is terminated during operation.
This commit adds a timer based connection mechanism, basically
consisting of a timer callback that calls gsup_client_connect. The
timer is eventually triggered (up == 0) or cleared (up != 0) by
gsup_client_updown_cb. It adds calls to osmo_timer_del() to
gsup_client_connect and gprs_gsup_client_destroy. The latter is now
called instead of talloc_free in gprs_gsup_client_create on error to
be on the safe side.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=45292a23631fdb943c7aaec0dc1d1af2…
commit 45292a23631fdb943c7aaec0dc1d1af2ce013792
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Dec 19 18:30:41 2014 +0100
sgsn/test: Extend tests to simulate lost GSUP requests
This patch extends test_gmm_attach to optionally resend Attach
Requests until the SGSN responds to it instead of calling
OSMO_ASSERT at a few places. The test_gmm_attach_subscr_gsup_auth
test optionally uses this feature. It is called once in either mode.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=424d584f82f8240c1325ca25ed186f44…
commit 424d584f82f8240c1325ca25ed186f446997de58
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Dec 19 18:26:09 2014 +0100
sgsn/test: Add GMM test for a GSUP based attach procedure
This test calls test_gmm_attach() where the mocked subscriber
functions insert GSUP messages instead of manipulating the
subscriber structure directly.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=5c455ae7a7326c19545258a6e247fe2f…
commit 5c455ae7a7326c19545258a6e247fe2f6b4c3e01
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Dec 19 18:19:50 2014 +0100
sgsn/test: Add wrapper for gprs_subscr_rx_gsup_message
Currently, several lines of boiler plate are needed around a call to
gprs_subscr_rx_gsup_message.
This patch puts all of this (including the call to
gprs_subscr_rx_gsup_message) into a separate function.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=3d0895483f0d543af485413dedb40294…
commit 3d0895483f0d543af485413dedb40294b0efd9b4
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Dec 19 18:08:48 2014 +0100
sgsn: Add global require_update_location flag
This flag is used to determine, whether the Update Location procedure
shall be invoked. This is currently only set, when the 'remote'
authorization policy is set. When the flag is set, sgsn_auth_update
will not never be called directly by sgsn_auth_request, if an Attach
Request procedure is pending, even if the remote connection fails for
some reason.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=79571191f2c526e18dc1257a3273a723…
commit 79571191f2c526e18dc1257a3273a7235582d2a6
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Wed Dec 17 13:20:08 2014 +0100
sgsn: Replace subscr.authenticate by global require_authentication flag
Currently the flag 'authenticate' is managed per subscriber.
This patch replaces that flag by a global cfg.require_authentication
flag that enables/disables the use of the Auth & Ciph procedure for
every subscriber. The flag is set by the VTY, if and only if the
authorization policy is 'remote'.
The VTY command
- update-subscriber imsi IMSI insert authenticate <0-1>
is removed.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=ed3d6a6020fee411cca3cb7564a4b0cb…
commit ed3d6a6020fee411cca3cb7564a4b0cbf6d8b587
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Dec 18 12:46:47 2014 +0100
sgsn: Integrate the GSUP client into the SGSN
This commit adds GSUP client configuration (via VTY), connection set
up, and real message sending.
The following configuration commands are added:
- gsup remote-ip A.B.C.D set server IP address
- gsup remote-port PORT set server TCP port
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=9f2e178f07b7d15733e862fca7c140b1…
commit 9f2e178f07b7d15733e862fca7c140b1475899ee
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Dec 18 12:28:21 2014 +0100
sgsn: Add GSUP client
This commit adds the client code to get subscriber information from a
remote server. It provides an IPA over TCP connection to transmit and
receive GSUP messages.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=847bf670e354fbd11bedbadf63deb057…
commit 847bf670e354fbd11bedbadf63deb0577a0a380b
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Dec 15 10:16:02 2014 +0100
sgsn/doc: Add IPA default parameters
This commit adds the default protocol identifiers that should be used
for GSUP by the IPA protocol.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=62068f8848f5c851a06053265b311dca…
commit 62068f8848f5c851a06053265b311dca9042b103
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Dec 12 15:01:37 2014 +0100
gprs: Add subscriber functions to create/handle GSUP messages
This patch extends gprs_subscr_query_auth_info and
gprs_subscr_location_update to create GSUP messages with the help of
a static gprs_subscr_tx_gsup_message function. A corresponding
gprs_subscr_rx_gsup_message is added which takes a messages, gets the
subscr, and updates it accordingly.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=2ad5544bee5062301797a86a6adb4451…
commit 2ad5544bee5062301797a86a6adb44513abe27d2
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Dec 11 16:54:14 2014 +0100
gprs: Add encoder/decoder for the Subscriber Update Protocol
This patch adds functions to encode and decode GSUP messages. This
does not include the layer 1 framing (IPA). The messages so far
supported are: send_auth_info_*, update_location_*,
location_cancellation_*.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=5636470b9fa12827e190f3f38386f282…
commit 5636470b9fa12827e190f3f38386f2824edfcf61
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Dec 11 15:14:14 2014 +0100
sgsn/doc: Add protocol specification for remote subscriber update
This is the first version of the specification for the GPRS
Subscriber Update Protocol.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=4e8a698c1173d71f9e0ee6eef182f588…
commit 4e8a698c1173d71f9e0ee6eef182f5884c181493
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Jan 5 09:43:51 2015 +0100
sgsn: Fix VTY command error handling (Coverity)
Currently the result of the osmo_hexparse function in
update_subscr_insert_auth_triplet is not handled correctly. There is
a misplaced leading exclamation mark in a few conditional
expressions. This effectively disables the error checks, as it is
noticed by Coverity ("Missing parentheses" followed by "Logically
dead code").
This patch removes the exclamation marks.
Fixes: Coverity CID 1260435 and CID 1260434
Sponsored-by: On-Waves ehf
-----------------------------------------------------------------------
Summary of changes:
openbsc/src/libbsc/abis_rsl.c | 4 ++--
openbsc/src/libmsc/sms_queue.c | 2 +-
openbsc/src/utils/meas_pcap2db.c | 2 --
3 files changed, 3 insertions(+), 5 deletions(-)
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, master has been updated
via a67704753a6328f725d38d61af8bfbe29012fcbc (commit)
from 0c4e400d2fdd6445da4dc24851945119517d8083 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=a67704753a6328f725d38d61af8bfbe2…
commit a67704753a6328f725d38d61af8bfbe29012fcbc
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Mon Jan 5 14:15:16 2015 +0100
Revert "debug.c: use new libosmocore features to print and save log filter"
This reverts commit c598e6e0a6d00827c2c974010d582815d66d0f14.
It introduced a dependency from libcommon to libosmovty, which we don't
want
-----------------------------------------------------------------------
Summary of changes:
openbsc/src/libcommon/debug.c | 46 -------------------------------------------
1 file changed, 46 deletions(-)
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, master has been updated
via 0c4e400d2fdd6445da4dc24851945119517d8083 (commit)
via c598e6e0a6d00827c2c974010d582815d66d0f14 (commit)
via a9e420e93dca43b92b608a819ea782445eef52e0 (commit)
via 1dcc2603e9f06e8be3769a2b1f93e3b761f87c52 (commit)
via e5d2c60ae661e801b7049a2c9526712ded895cc1 (commit)
from 6995f24831b70ef64bd08976f2aecc5314fe9862 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=0c4e400d2fdd6445da4dc24851945119…
commit 0c4e400d2fdd6445da4dc24851945119517d8083
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Mon Jan 5 14:13:16 2015 +0100
meas_pcap2db.c: Fix build without CDK
Spotted by Jacob Erlbeck.
http://cgit.osmocom.org/openbsc/commit/?id=c598e6e0a6d00827c2c974010d582815…
commit c598e6e0a6d00827c2c974010d582815d66d0f14
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Thu Jun 6 07:30:29 2013 +0200
debug.c: use new libosmocore features to print and save log filter
http://cgit.osmocom.org/openbsc/commit/?id=a9e420e93dca43b92b608a819ea78244…
commit a9e420e93dca43b92b608a819ea782445eef52e0
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Tue Nov 13 04:26:22 2012 +0100
RSL: Change "... is back in operation" to an INFO level message
http://cgit.osmocom.org/openbsc/commit/?id=1dcc2603e9f06e8be3769a2b1f93e3b7…
commit 1dcc2603e9f06e8be3769a2b1f93e3b761f87c52
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Tue Nov 13 04:46:03 2012 +0100
Don't return an error to caller if we are out of lchan on CHAN RQD
This is a normal situation under high load: The BTS is out of resources
and the BSC cannot allocate any dedicated channel. We may send an IMM
ASS REJECT back to the MS. All well within normal parameters, not an
error that needs to be reported back to the caller, who propagates it
all the way up to libosmo-abis.
http://cgit.osmocom.org/openbsc/commit/?id=e5d2c60ae661e801b7049a2c9526712d…
commit e5d2c60ae661e801b7049a2c9526712ded895cc1
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Tue Nov 13 06:52:42 2012 +0100
SMS: Attempting to send SMS is not a NOTICEable event
-----------------------------------------------------------------------
Summary of changes:
openbsc/src/libbsc/abis_rsl.c | 4 ++--
openbsc/src/libcommon/debug.c | 46 ++++++++++++++++++++++++++++++++++++++++
openbsc/src/libmsc/sms_queue.c | 2 +-
openbsc/src/utils/meas_pcap2db.c | 2 --
4 files changed, 49 insertions(+), 5 deletions(-)
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, jerlbeck/fixes/ussd-messages has been deleted
was 62ed0af0499477c6b768a51a9ae52ef247ec072d
-----------------------------------------------------------------------
62ed0af0499477c6b768a51a9ae52ef247ec072d debian: Add a new changelog entry (0.9.14~z11)
-----------------------------------------------------------------------
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, jerlbeck/wip/rtp-keepalive-and-disable-output has been deleted
was 07c89dabe517aad357a08ddb521902a3e0441553
-----------------------------------------------------------------------
07c89dabe517aad357a08ddb521902a3e0441553 mgcp: TODO RTP keepalive
-----------------------------------------------------------------------
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, jerlbeck/features/mgcp-get-info-from-sdp has been deleted
was 82691a415f0e835664989274ea8236af7a5555dd
-----------------------------------------------------------------------
82691a415f0e835664989274ea8236af7a5555dd mgcp: Optionally send ptime in SDP
-----------------------------------------------------------------------
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)