osmocom-commitlog January 2015

osmocom-commitlog@lists.osmocom.org

1 participants
99 discussions

libosmocore.git branch master updated. 0.8.0-3-g879acef

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via 879acef39465bb978f9a3bcb349594b818aec442 (commit) via 19d00517af53261523b35e14b14de7b87ea8d669 (commit) from f6a0ceb92fcdb9c8f496f6efeb385850dbc33d0b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=879acef39465bb978f9a3bcb3495… commit 879acef39465bb978f9a3bcb349594b818aec442 Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Tue Jan 27 11:06:51 2015 +0100 vty: Fix typo in the state creation This got introduced in 2d6ad13d8daf860595e6d4025861e122ce574871 and I thought that our vty tests would have caught such mistakes. http://cgit.osmocom.org/libosmocore/commit/?id=19d00517af53261523b35e14b14d… commit 19d00517af53261523b35e14b14de7b87ea8d669 Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Sun Jan 18 21:23:16 2015 +0100 debian: Add pcsc build depends and pkg-config for the m4 macro ----------------------------------------------------------------------- Summary of changes: debian/control | 2 +- src/vty/logging_vty.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- An utility library for Open Source Mobile Communications

9 years, 8 months

openbsc.git branch jerlbeck/wip/gprs-patching updated. 0.13.0-906-g1789a16

by gitosis＠osmocom.org

9 years, 8 months

openbsc.git branch master updated. 0.13.0-901-g120250a

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, master has been updated via 120250ad6fe8d2b641b716d5b37d48b125db23ca (commit) via 306bb993aab07f115ff6cbc89d81f862e08f7c32 (commit) via 3e4e58f349c201a2ed02971ef95051773fcef39b (commit) via 3ee67ff5c2f9da513c77b8ab9dfc0067296dadec (commit) via abb347853317427a227592c4fa4b38e99f9e7152 (commit) from 496aee7cb809069133fe37f39ccac7607ec6c9b3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=120250ad6fe8d2b641b716d5b37d48b1… commit 120250ad6fe8d2b641b716d5b37d48b125db23ca Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Jan 20 09:25:43 2015 +0100 gbproxy: Remove dummy definition of subscr_put The definition of subscr_put in gb_proxy_main.c will break linking if symbols from libcommon are used. Since subscr_put is in libcommon, there is no need for this dummy definition anymore. This patch removes the dummy definition. Adresses: ../../src/libcommon/libcommon.a(gsm_subscriber_base.o): In function `subscr_put': /home/jerlbeck/git/build/openbsc/openbsc/src/libcommon/gsm_subscriber_base.c:90: multiple definition of `subscr_put' gb_proxy_main.o:/home/jerlbeck/git/build/openbsc/openbsc/src/gprs/gb_proxy_main.c:56: first defined here Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=306bb993aab07f115ff6cbc89d81f862… commit 306bb993aab07f115ff6cbc89d81f862e08f7c32 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Jan 26 13:41:11 2015 +0100 sgsn: Don't reset mm->subscr manually in sgsn_mm_ctx_free Currently the sgsn_mm_ctx_free contains code to reset the mm->subscr field that is also present in gprs_subscr_cleanup, which is called directly afterwards. This commit modifies the code path, so that the cleanup is done by the gprs_subscr_cleanup function. The additional reference counter increment is needed, since mm->subscr->mm->subscr (which is the same like mm->subscr) will be reset (and unref'd) within gprs_subscr_cleanup. Because the local variable subscr in sgsn_mm_ctx_free is an additional pointer to the subscriber object, it is consequent to adjust the reference counter when the assignment is done. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=3e4e58f349c201a2ed02971ef9505177… commit 3e4e58f349c201a2ed02971ef95051773fcef39b Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Jan 26 11:07:24 2015 +0100 gprs: Rename gprs_subscr_delete to gprs_subscr_cleanup The old name is somewhat misleading. The function is rather preparing the subscriber for a subsequent subscr_free, that is possibly invoked by a subscr_put. It detaches the subscriber from the MM context and optionally invokes a PURGE_MS procedure. Therefore the _cleanup suffix is chosen (see mm_ctx_cleanup_free). Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=3ee67ff5c2f9da513c77b8ab9dfc0067… commit 3ee67ff5c2f9da513c77b8ab9dfc0067296dadec Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Jan 26 09:22:39 2015 +0100 gprs: Don't check for EINPROGRESS in gprs_gsup_client_create Currently, the return value of gsup_client_connect is checked whether it is < 0 and != -EINPROGESS. Since gsup_client_connect will only return a negative value on a few permanent errors (not including EINPROGRESS), rc is always != EINPROGRESS. This patch removes the explicit check againt -EINPROGRESS and just leaves the check rc < 0. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=abb347853317427a227592c4fa4b38e9… commit abb347853317427a227592c4fa4b38e99f9e7152 Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Mon Jan 26 10:26:36 2015 +0100 gb_proxy: No need to copy optarg Fixes: Coverity CID 1206578 ----------------------------------------------------------------------- Summary of changes: openbsc/include/openbsc/gprs_sgsn.h | 2 +- openbsc/src/gprs/gb_proxy_main.c | 5 +---- openbsc/src/gprs/gprs_gsup_client.c | 2 +- openbsc/src/gprs/gprs_sgsn.c | 6 ++---- openbsc/src/gprs/gprs_subscriber.c | 4 ++-- openbsc/tests/sgsn/sgsn_test.c | 6 +++--- 6 files changed, 10 insertions(+), 15 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

9 years, 8 months

openbsc.git branch shared/packages/testing created. 0.13.0-910-g9d77901

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, shared/packages/testing has been created at 9d77901f9870d923c558cb321ad1f8f5e87b4c8b (commit) - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=9d77901f9870d923c558cb321ad1f8f5… commit 9d77901f9870d923c558cb321ad1f8f5e87b4c8b Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Jan 26 15:42:27 2015 +0100 debian: Prepare testing release 0.13.2+j4 http://cgit.osmocom.org/openbsc/commit/?id=5c43716b7edd13e23c536d675841b339… commit 5c43716b7edd13e23c536d675841b339ec6a2b39 Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Wed Jan 21 17:01:53 2015 +0100 debian: Create a new package http://cgit.osmocom.org/openbsc/commit/?id=2714c2fe33ec702964ad234e9da3a0e3… commit 2714c2fe33ec702964ad234e9da3a0e302b85fc5 Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Wed Jan 21 12:58:49 2015 +0100 debian: Add current changelog entry http://cgit.osmocom.org/openbsc/commit/?id=7a58220410b96a6b38ec6b9455bab806… commit 7a58220410b96a6b38ec6b9455bab806971edafa Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Jan 20 09:15:40 2015 +0100 debian: Prepare testing release 0.13.2+j1 http://cgit.osmocom.org/openbsc/commit/?id=95d04b804f62515f8f04038000ea0031… commit 95d04b804f62515f8f04038000ea0031de1fd601 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Fri Oct 17 10:08:02 2014 +0200 sgsn: Do not die in _bssgp_tx_dl_ud on TLLI mismatch (TODO) Currently an OSMO_ASSERT fails, if the message's and the mmctx's TLLIs do not match. This commit turns the assertion into an ERROR log message and uses the default values for IMSI, DRX, and RA CAP instead of the MM context values in this case. TODO: - find the real source for the problem - add test cases derived from what is being described in the ticket Ticket: OW#1322 Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

9 years, 8 months

openbsc.git branch jerlbeck/wip/gprs-patching updated. 0.13.0-905-gc11f614

by gitosis＠osmocom.org

9 years, 8 months

openbsc.git branch jerlbeck/wip/gprs-patching updated. 0.13.0-904-g4a16998

by gitosis＠osmocom.org

9 years, 8 months

openbsc.git branch jerlbeck/wip/gprs-patching updated. 0.13.0-905-gc58270a

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, jerlbeck/wip/gprs-patching has been updated discards 5a8a00afe6f037a39b407bcacdcd35bd6b399f76 (commit) discards 3cf9a0dc5126198f9e94cb7104fb75b96afa4c6b (commit) discards 4c200652f7c54ff2e7e1708d93adf75be9f86712 (commit) discards b6d0eaa0da84758fad88d213bb42fd00f1e030be (commit) discards 99ad4ec4a2261c3e1cda14c7fed6d7252ade7b96 (commit) discards b10b16f9bdc4d916035313b68a7eeb6f55499c78 (commit) discards 7113c90e8476cc97271aeec7b2bb345474c95d64 (commit) discards f5aebcac2c25d44a0a84a1ac71c7aedb23630e2d (commit) discards ce8de7ab10ed34f29123d8723b13cacf00c7bf46 (commit) discards c0a9bf36067363696814bf72fc3edf553e00290f (commit) discards 3fe133576ccdcd09b475296de01ad49aa93f3aef (commit) discards b2426e6af78d6fc057e45696168c7c3d56b86584 (commit) via c58270ab5fcc634839ad69b427ad4d9d34be1d1c (commit) via f312b96b9c734e03de1222379a4a0305725192c2 (commit) via 4c0f08b58407ca8b2ca3d9502ca50212d330af63 (commit) via a51b777ce0f2c178833fba4bd33cfda75a99f7a8 (commit) via cf1c80f0db0b431d7cc2afe2bda4ee43d596df11 (commit) via 200b4689c90841ac18cc0754c7a3a95d3c4e4de4 (commit) via d272b4c7c8c9e2d8a510c85896a661c312d96c0a (commit) via 09695de8c253ab5ee271c372ea21fd84f7377b99 (commit) via fa11430d857f006459664e7314a6be79e21a20dd (commit) via 496aee7cb809069133fe37f39ccac7607ec6c9b3 (commit) via 37139e5933337e3e24f4bd83955c3492123e9ed0 (commit) via 1d778fdce3bc4aab16dc203463d0067f2f063d16 (commit) via e47d4f6d1187d453b846ea48f95ee75a42efc23b (commit) via 81ffb740f78ccdada8ece786cfab852bc10172e8 (commit) via 841d95f86701b9e813402c65a7b1f88d132593fb (commit) via 8de9c48c997a84f1afbfd3306435403bdbfd9f6a (commit) via 79af67d7c02a25e36146369b60f7f25c9655c862 (commit) via 37184900e7f4f8566fbd71914f55b3cc8c0196e9 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (5a8a00afe6f037a39b407bcacdcd35bd6b399f76) \ N -- N -- N (c58270ab5fcc634839ad69b427ad4d9d34be1d1c) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=c58270ab5fcc634839ad69b427ad4d9d… commit c58270ab5fcc634839ad69b427ad4d9d34be1d1c Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Sep 30 13:53:26 2014 +0200 sgsn: Added TODOs (TODO) TODO: - fix and remove TODOs - add test cases for Detach(reattach) - add test cases for PDP context deletion (OW#1311) - add test cases for Cancel pending timer in sgsn_mm_ctx_free - remove this commit Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=f312b96b9c734e03de1222379a4a0305… commit f312b96b9c734e03de1222379a4a0305725192c2 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Fri Oct 17 10:08:02 2014 +0200 sgsn: Do not die in _bssgp_tx_dl_ud on TLLI mismatch (TODO) Currently an OSMO_ASSERT fails, if the message's and the mmctx's TLLIs do not match. This commit turns the assertion into an ERROR log message and uses the default values for IMSI, DRX, and RA CAP instead of the MM context values in this case. TODO: - find the real source for the problem - add test cases derived from what is being described in the ticket Ticket: OW#1322 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=4c0f08b58407ca8b2ca3d9502ca50212… commit 4c0f08b58407ca8b2ca3d9502ca50212d330af63 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Wed Dec 17 14:03:35 2014 +0100 sgsn: Add PDP info to subscriber data (TODO) TODO: - commit message - raw binary representation ??? - tests Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=a51b777ce0f2c178833fba4bd33cfda7… commit a51b777ce0f2c178833fba4bd33cfda75a99f7a8 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Fri Dec 19 19:11:20 2014 +0100 sgsn: Add logging to connect_timer_cb (TODO) TODO: - LOGLevel ? Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=cf1c80f0db0b431d7cc2afe2bda4ee43… commit cf1c80f0db0b431d7cc2afe2bda4ee43d596df11 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Jan 26 14:43:07 2015 +0100 sgsn: Add sgsn_mm_ctx_cleanup_free for safe shutdown Currently the MM context cleanup code is distributed over several functions. sgsn_mm_ctx_free not only frees data structure but also eventually stops the timer and does the subscriber clean-up. mm_ctx_cleanup_free (gprs_gmm.c) cleans up the PDP contexts and unassign the TLLI. This commit moves the cleanup code from both functions into a new unifying function sgsn_mm_ctx_cleanup_free that cares about the clean-up of all related sub-systems. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=200b4689c90841ac18cc0754c7a3a95d… commit 200b4689c90841ac18cc0754c7a3a95d3c4e4de4 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Jan 26 13:52:42 2015 +0100 sgsn: Don't allow mmctx == NULL in sgsn_update_subscriber_data Currently, sgsn_update_subscriber_data can be called with mmctx == NULL and will find and associate the right context (if present) based on the subscriber's IMSI. This will not happen in regular use any more, since sgsn_update_subscriber_data will only be called when subscribers are used (auth mode 'remote') and in this case gprs_subscr_get_or_create_by_mmctx will already be called by sgsn_auth_request. Therefore, MM context and subscriber are always associated except for some test cases and experimental VTY usage. The current implementation of sgsn_update_subscriber_data also causes additional complexity for the deletion on MM contexts to avoid a ipossible double-free MM contexts. This commit removes the MM context <-> subscriber association code from sgsn_update_subscriber_data. That function must always be called with mmctx != NULL, now. To avoid problems with VTY and test usage, the calling subscriber function now only call sgsn_update_subscriber_data when mmctx != NULL, since the purpose of that function is to update that state of an existing MM context after subscriber data has been changed. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=d272b4c7c8c9e2d8a510c85896a661c3… commit d272b4c7c8c9e2d8a510c85896a661c312d96c0a Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Jan 26 13:41:11 2015 +0100 sgsn: Don't reset mm->subscr manually in sgsn_mm_ctx_free Currently the sgsn_mm_ctx_free contains code to reset the mm->subscr field that is also present in gprs_subscr_cleanup, which is called directly afterwards. This commit modifies the code path, so that the cleanup is done by the gprs_subscr_cleanup function. The additional reference counter increment is needed, since mm->subscr->mm->subscr (which is the same like mm->subscr) will be reset (and unref'd) within gprs_subscr_cleanup. Because the local variable subscr in sgsn_mm_ctx_free is an additional pointer to the subscriber object, it is consequent to adjust the reference counter when the assignment is done. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=09695de8c253ab5ee271c372ea21fd84… commit 09695de8c253ab5ee271c372ea21fd84f7377b99 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Jan 26 11:07:24 2015 +0100 gprs: Rename gprs_subscr_delete to gprs_subscr_cleanup The old name is somewhat misleading. The function is rather preparing the subscriber for a subsequent subscr_free, that is possibly invoked by a subscr_put. It detaches the subscriber from the MM context and optionally invokes a PURGE_MS procedure. Therefore the _cleanup suffix is chosen (see mm_ctx_cleanup_free). Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=fa11430d857f006459664e7314a6be79… commit fa11430d857f006459664e7314a6be79e21a20dd Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Jan 26 09:22:39 2015 +0100 gprs: Don't check for EINPROGRESS in gprs_gsup_client_create Currently, the return value of gsup_client_connect is checked whether it is < 0 and != -EINPROGESS. Since gsup_client_connect will only return a negative value on a few permanent errors (not including EINPROGRESS), rc is always != EINPROGRESS. This patch removes the explicit check againt -EINPROGRESS and just leaves the check rc < 0. Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: openbsc/include/openbsc/gprs_sgsn.h | 6 ++-- openbsc/include/openbsc/sgsn.h | 2 +- openbsc/src/gprs/gprs_gmm.c | 30 +++-------------- openbsc/src/gprs/gprs_gsup_client.c | 2 +- openbsc/src/gprs/gprs_sgsn.c | 66 +++++++++++++++++++------------------ openbsc/src/gprs/gprs_subscriber.c | 10 +++--- openbsc/src/gprs/sgsn_auth.c | 2 +- openbsc/tests/sgsn/sgsn_test.c | 37 +++++++++------------ 8 files changed, 66 insertions(+), 89 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

9 years, 8 months

openbsc.git branch master updated. 0.13.0-896-g496aee7

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, master has been updated via 496aee7cb809069133fe37f39ccac7607ec6c9b3 (commit) from 37139e5933337e3e24f4bd83955c3492123e9ed0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=496aee7cb809069133fe37f39ccac760… commit 496aee7cb809069133fe37f39ccac7607ec6c9b3 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Jan 26 10:38:12 2015 +0100 sgsn: Ensure 0-terminated imsi strings (Coverity) Currently the size argument of strncpy is set to sizeof(mm->imsi) in some places. If the source IMSI string is too long, the terminating NUL byte in the static mm->imsi field gets overwritten. This patch limits the size to sizeof(mm->imsi)-1, so that the last byte of the buffer (that has been initialized to 0) is not overwritten. Fixes: Coverity CID 12065751, 12065754, 1206575 Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: openbsc/src/gprs/gprs_gmm.c | 6 +++--- openbsc/src/gprs/sgsn_auth.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

9 years, 8 months

openbsc.git branch master updated. 0.13.0-895-g37139e5

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, master has been updated via 37139e5933337e3e24f4bd83955c3492123e9ed0 (commit) via 1d778fdce3bc4aab16dc203463d0067f2f063d16 (commit) via e47d4f6d1187d453b846ea48f95ee75a42efc23b (commit) via 81ffb740f78ccdada8ece786cfab852bc10172e8 (commit) via 841d95f86701b9e813402c65a7b1f88d132593fb (commit) via 8de9c48c997a84f1afbfd3306435403bdbfd9f6a (commit) via 79af67d7c02a25e36146369b60f7f25c9655c862 (commit) via 37184900e7f4f8566fbd71914f55b3cc8c0196e9 (commit) from 9d1a17e15f6902bc9591680da3375b2d14db16ab (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=37139e5933337e3e24f4bd83955c3492… commit 37139e5933337e3e24f4bd83955c3492123e9ed0 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Fri Jan 23 13:52:55 2015 +0100 gprs: Do not put the subscr in gprs_subscr_delete Currently gprs_subscr_delete implicitely calls subscr_put, which makes the code more complex than necessary (additional subscr_get) in a few places. It also makes it more difficult to see, whether get/put are balanced within a function. In addition, the functions are not named consistently (gprs_subscr_delete vs. gprs_subscr_put_and_cancel). This commit changes the semantics of gprs_subscr_delete and indirectly of gprs_subscr_put_and_cancel to not call subscr_put on their argument, but to leave that for the caller to do it explicitely. It renames gprs_subscr_put_and_cancel to gprs_subscr_cancel to reflect that change in the name, too. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=1d778fdce3bc4aab16dc203463d0067f… commit 1d778fdce3bc4aab16dc203463d0067f2f063d16 Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Tue Jan 20 21:14:03 2015 +0100 sgsn: Remove the "permanent" subscriber cache The subscriber cache would help in case: * GPRS DETACH, GPRS ATTACH. In that case we might still have some cached authentication tuples we avoid another sendAuthenticationInfo request. * After a detach the cache expiry would make sure to eventually send a purgeMS to the HLR (which might be ignored). At the same time to make the cache work we will need to make sure to start and stop timers. In case we don't start we might accumulate subscribers. I am afraid that the above two benefits do not outweight the complexity of this implementation. http://cgit.osmocom.org/openbsc/commit/?id=e47d4f6d1187d453b846ea48f95ee75a… commit e47d4f6d1187d453b846ea48f95ee75a42efc23b Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Tue Jan 20 21:14:03 2015 +0100 sgsn: Remove MM from the list before gprs_subscr_delete is called Modify sgsn_mm_ctx_free to remove the entry from the list as otherwise we might double free the context from within gprs_subscriber_delete. http://cgit.osmocom.org/openbsc/commit/?id=81ffb740f78ccdada8ece786cfab852b… commit 81ffb740f78ccdada8ece786cfab852bc10172e8 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Fri Jan 23 11:33:51 2015 +0100 sgsn: Remove inactive LLME/MM after inactivity timeout Currently old LLMEs and MM contexts that haven't been explicitly detached or cancelled are not removed until another request with the same IMSI is made. These stale entries may accumulate over time and severely compromise the operation of the SGSN. This patch implements age based LLME expiry, when the maximum age has been reached, the corresponding MM context is cancelled. If such an MM context doesn't exist, the LLME is unassigned directly. The implementation works as follows. - llme->age_timestamp is reset on each received PTP LLC message - sgsn_llme_check_cb is invoked periodically (each 30s) - sgsn_llme_check_cb sets the age_timestamp to the current time if it has been reset - sgsn_llme_check_cb computes the age and expires the LLME if it exceeds gprs_max_time_to_idle() Ticket: OW#1364 Sponsored-by: On-Waves ehf [hfreyther: Fix typo in comment LMME -> LLME] http://cgit.osmocom.org/openbsc/commit/?id=841d95f86701b9e813402c65a7b1f88d… commit 841d95f86701b9e813402c65a7b1f88d132593fb Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Fri Jan 23 12:32:38 2015 +0100 gprs: Use a macro value to set the 'Periodic RA update timer' Currently the T3312 timer is directly set as encoded value when generating the Attach/RAU Accept messages. This patch adds GSM0408_T3312_SECS and uses it to set the information element's value. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=8de9c48c997a84f1afbfd3306435403b… commit 8de9c48c997a84f1afbfd3306435403bdbfd9f6a Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Fri Jan 23 11:44:39 2015 +0100 gprs: Add 'Negotiated READY timer value' IE to Attach/RAU Accept Currently this optional IE is omitted, so that the optional 'Requested READY timer value' of the corresponding Request message is used by the MS (or the default value if this IE is not used). This patch extends gsm48_tx_gmm_att_ack and gsm48_tx_gmm_ra_upd_ack to always include the IE set to the default value of T3312 (44s, see GSM 04.08, table 11.4a). Ticket: OW#1364 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=79af67d7c02a25e36146369b60f7f25c… commit 79af67d7c02a25e36146369b60f7f25c9655c862 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Jan 19 08:27:34 2015 +0100 gprs: Add GPRS timer conversion functions Currently, all GPRS timer values are hard-coded. To make these values configurable in seconds and to show them, conversion functions from and to seconds are needed. This patch adds gprs_tmr_to_secs and gprs_secs_to_tmr_floor. Due to the limited number of bits used to encode GPRS timer values, only a few durations can be represented. gprs_secs_to_tmr_floor therefore always returns the timer value that represents either the exact number (if an exact representation exists) or the next lower number for that an exact representation exists. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=37184900e7f4f8566fbd71914f55b3cc… commit 37184900e7f4f8566fbd71914f55b3cc8c0196e9 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Jan 19 10:56:15 2015 +0100 gprs: Return 0 from gsup_client_connect if ok or retry timer enabled Currently the gsup_client_connect return 0 if the call to ipa_client_conn_open was successful and -errno otherwise. This makes it difficult for the caller to determine, whether the the whole operation has been cancelled (currently on EBADF, ENOTSOCK, EAFNOSUPPORT, EINVAL) or whether the GSUP client will retry to connect after a timeout. This will cause gprs_gsup_client_create to destroy the GSUP client object, even if the error might be temporary. This patch changes the function to return 0 if (and only if) ipa_client_conn_open was successful or the retry timer has been started. Since the return value 0 doesn't guarantee, that a subsequent call to gprs_gsup_client_send will succeed, this shouldn't break anything. Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: openbsc/include/openbsc/gprs_gmm.h | 2 + openbsc/include/openbsc/gprs_llc.h | 5 ++ openbsc/include/openbsc/gprs_sgsn.h | 5 +- openbsc/include/openbsc/gprs_utils.h | 5 ++ openbsc/include/openbsc/gsm_04_08_gprs.h | 5 +- openbsc/include/openbsc/sgsn.h | 6 +-- openbsc/src/gprs/Makefile.am | 2 +- openbsc/src/gprs/gprs_gmm.c | 27 ++++++++-- openbsc/src/gprs/gprs_gsup_client.c | 5 +- openbsc/src/gprs/gprs_llc.c | 4 ++ openbsc/src/gprs/gprs_llc_vty.c | 7 ++- openbsc/src/gprs/gprs_sgsn.c | 70 ++++++++++++++++++++++-- openbsc/src/gprs/gprs_subscriber.c | 91 +++----------------------------- openbsc/src/gprs/gprs_utils.c | 45 ++++++++++++++++ openbsc/src/gprs/sgsn_main.c | 1 + openbsc/src/gprs/sgsn_vty.c | 40 +------------- openbsc/tests/gprs/gprs_test.c | 68 ++++++++++++++++++++++++ openbsc/tests/gprs/gprs_test.ok | 1 + openbsc/tests/sgsn/Makefile.am | 2 +- openbsc/tests/sgsn/sgsn_test.c | 83 +++++------------------------ 20 files changed, 264 insertions(+), 210 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

9 years, 8 months

openbsc.git branch jerlbeck/wip/gprs-patching updated. 0.13.0-899-g5a8a00a

by gitosis＠osmocom.org

9 years, 8 months

← Newer
1
2
3
4
5
6
7
8
9
10
Older →

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

osmocom-commitlog January 2015