This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, master has been updated via 37139e5933337e3e24f4bd83955c3492123e9ed0 (commit) via 1d778fdce3bc4aab16dc203463d0067f2f063d16 (commit) via e47d4f6d1187d453b846ea48f95ee75a42efc23b (commit) via 81ffb740f78ccdada8ece786cfab852bc10172e8 (commit) via 841d95f86701b9e813402c65a7b1f88d132593fb (commit) via 8de9c48c997a84f1afbfd3306435403bdbfd9f6a (commit) via 79af67d7c02a25e36146369b60f7f25c9655c862 (commit) via 37184900e7f4f8566fbd71914f55b3cc8c0196e9 (commit) from 9d1a17e15f6902bc9591680da3375b2d14db16ab (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=37139e5933337e3e24f4bd83955c3492… commit 37139e5933337e3e24f4bd83955c3492123e9ed0 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Fri Jan 23 13:52:55 2015 +0100 gprs: Do not put the subscr in gprs_subscr_delete Currently gprs_subscr_delete implicitely calls subscr_put, which makes the code more complex than necessary (additional subscr_get) in a few places. It also makes it more difficult to see, whether get/put are balanced within a function. In addition, the functions are not named consistently (gprs_subscr_delete vs. gprs_subscr_put_and_cancel). This commit changes the semantics of gprs_subscr_delete and indirectly of gprs_subscr_put_and_cancel to not call subscr_put on their argument, but to leave that for the caller to do it explicitely. It renames gprs_subscr_put_and_cancel to gprs_subscr_cancel to reflect that change in the name, too. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=1d778fdce3bc4aab16dc203463d0067f… commit 1d778fdce3bc4aab16dc203463d0067f2f063d16 Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Tue Jan 20 21:14:03 2015 +0100 sgsn: Remove the "permanent" subscriber cache The subscriber cache would help in case: * GPRS DETACH, GPRS ATTACH. In that case we might still have some cached authentication tuples we avoid another sendAuthenticationInfo request. * After a detach the cache expiry would make sure to eventually send a purgeMS to the HLR (which might be ignored). At the same time to make the cache work we will need to make sure to start and stop timers. In case we don't start we might accumulate subscribers. I am afraid that the above two benefits do not outweight the complexity of this implementation. http://cgit.osmocom.org/openbsc/commit/?id=e47d4f6d1187d453b846ea48f95ee75a… commit e47d4f6d1187d453b846ea48f95ee75a42efc23b Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Tue Jan 20 21:14:03 2015 +0100 sgsn: Remove MM from the list before gprs_subscr_delete is called Modify sgsn_mm_ctx_free to remove the entry from the list as otherwise we might double free the context from within gprs_subscriber_delete. http://cgit.osmocom.org/openbsc/commit/?id=81ffb740f78ccdada8ece786cfab852b… commit 81ffb740f78ccdada8ece786cfab852bc10172e8 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Fri Jan 23 11:33:51 2015 +0100 sgsn: Remove inactive LLME/MM after inactivity timeout Currently old LLMEs and MM contexts that haven't been explicitly detached or cancelled are not removed until another request with the same IMSI is made. These stale entries may accumulate over time and severely compromise the operation of the SGSN. This patch implements age based LLME expiry, when the maximum age has been reached, the corresponding MM context is cancelled. If such an MM context doesn't exist, the LLME is unassigned directly. The implementation works as follows. - llme->age_timestamp is reset on each received PTP LLC message - sgsn_llme_check_cb is invoked periodically (each 30s) - sgsn_llme_check_cb sets the age_timestamp to the current time if it has been reset - sgsn_llme_check_cb computes the age and expires the LLME if it exceeds gprs_max_time_to_idle() Ticket: OW#1364 Sponsored-by: On-Waves ehf [hfreyther: Fix typo in comment LMME -> LLME] http://cgit.osmocom.org/openbsc/commit/?id=841d95f86701b9e813402c65a7b1f88d… commit 841d95f86701b9e813402c65a7b1f88d132593fb Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Fri Jan 23 12:32:38 2015 +0100 gprs: Use a macro value to set the 'Periodic RA update timer' Currently the T3312 timer is directly set as encoded value when generating the Attach/RAU Accept messages. This patch adds GSM0408_T3312_SECS and uses it to set the information element's value. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=8de9c48c997a84f1afbfd3306435403b… commit 8de9c48c997a84f1afbfd3306435403bdbfd9f6a Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Fri Jan 23 11:44:39 2015 +0100 gprs: Add 'Negotiated READY timer value' IE to Attach/RAU Accept Currently this optional IE is omitted, so that the optional 'Requested READY timer value' of the corresponding Request message is used by the MS (or the default value if this IE is not used). This patch extends gsm48_tx_gmm_att_ack and gsm48_tx_gmm_ra_upd_ack to always include the IE set to the default value of T3312 (44s, see GSM 04.08, table 11.4a). Ticket: OW#1364 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=79af67d7c02a25e36146369b60f7f25c… commit 79af67d7c02a25e36146369b60f7f25c9655c862 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Jan 19 08:27:34 2015 +0100 gprs: Add GPRS timer conversion functions Currently, all GPRS timer values are hard-coded. To make these values configurable in seconds and to show them, conversion functions from and to seconds are needed. This patch adds gprs_tmr_to_secs and gprs_secs_to_tmr_floor. Due to the limited number of bits used to encode GPRS timer values, only a few durations can be represented. gprs_secs_to_tmr_floor therefore always returns the timer value that represents either the exact number (if an exact representation exists) or the next lower number for that an exact representation exists. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=37184900e7f4f8566fbd71914f55b3cc… commit 37184900e7f4f8566fbd71914f55b3cc8c0196e9 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Jan 19 10:56:15 2015 +0100 gprs: Return 0 from gsup_client_connect if ok or retry timer enabled Currently the gsup_client_connect return 0 if the call to ipa_client_conn_open was successful and -errno otherwise. This makes it difficult for the caller to determine, whether the the whole operation has been cancelled (currently on EBADF, ENOTSOCK, EAFNOSUPPORT, EINVAL) or whether the GSUP client will retry to connect after a timeout. This will cause gprs_gsup_client_create to destroy the GSUP client object, even if the error might be temporary. This patch changes the function to return 0 if (and only if) ipa_client_conn_open was successful or the retry timer has been started. Since the return value 0 doesn't guarantee, that a subsequent call to gprs_gsup_client_send will succeed, this shouldn't break anything. Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: openbsc/include/openbsc/gprs_gmm.h | 2 + openbsc/include/openbsc/gprs_llc.h | 5 ++ openbsc/include/openbsc/gprs_sgsn.h | 5 +- openbsc/include/openbsc/gprs_utils.h | 5 ++ openbsc/include/openbsc/gsm_04_08_gprs.h | 5 +- openbsc/include/openbsc/sgsn.h | 6 +-- openbsc/src/gprs/Makefile.am | 2 +- openbsc/src/gprs/gprs_gmm.c | 27 ++++++++-- openbsc/src/gprs/gprs_gsup_client.c | 5 +- openbsc/src/gprs/gprs_llc.c | 4 ++ openbsc/src/gprs/gprs_llc_vty.c | 7 ++- openbsc/src/gprs/gprs_sgsn.c | 70 ++++++++++++++++++++++-- openbsc/src/gprs/gprs_subscriber.c | 91 +++----------------------------- openbsc/src/gprs/gprs_utils.c | 45 ++++++++++++++++ openbsc/src/gprs/sgsn_main.c | 1 + openbsc/src/gprs/sgsn_vty.c | 40 +------------- openbsc/tests/gprs/gprs_test.c | 68 ++++++++++++++++++++++++ openbsc/tests/gprs/gprs_test.ok | 1 + openbsc/tests/sgsn/Makefile.am | 2 +- openbsc/tests/sgsn/sgsn_test.c | 83 +++++------------------------ 20 files changed, 264 insertions(+), 210 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)