This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, jerlbeck/wip/gprs-patching has been updated
via e0169171146427b06d6c20759a6f3046cfb11f70 (commit)
via a3e82404e23458222d2ef9209a2e0dfcd645bc99 (commit)
via 266b34c4f1fe97c9547c5290f0351b18ed476e2a (commit)
from dc30dedcb857c9cfa9efb451a725ed83c0774def (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=e0169171146427b06d6c20759a6f3046…
commit e0169171146427b06d6c20759a6f3046cfb11f70
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Nov 28 14:55:25 2014 +0100
sgsn: Work on 2 phase authorization (WIP)
This implements the MAP way of subscriber validation when the MS
tries an Attach Request:
1. perform authentication (optionally invoke the sendAuthInfo
procedure), starts the AuthAndCiph procedure
2. perform update location
3. insert subscriber data
4. finish the update location
5. Attach Accept / Attach Reject
This is currently accessible via the VTY interface.
TODO:
- Apply this to (periodic) RA Update Req
- Delete Subscriber Data
- Improve on procedure collisions (repeated Attach Req is sometimes
not handled properly)
- PDP info
- Commit cleanup
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=a3e82404e23458222d2ef9209a2e0dfc…
commit a3e82404e23458222d2ef9209a2e0dfcd645bc99
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Nov 27 14:27:10 2014 +0100
sgsn: Refactored and fixed authentication (TODO)
TODO:
- Merge with previous patch
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=266b34c4f1fe97c9547c5290f0351b18…
commit 266b34c4f1fe97c9547c5290f0351b18ed476e2a
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Nov 27 11:00:19 2014 +0100
sgsn: Auth and Ciph (WIP)
TODO:
- split this commit into several smaller ones (fixes, integration,
triplet management, ...)
- tests
Sponsored-by: On-Waves ehf
-----------------------------------------------------------------------
Summary of changes:
openbsc/include/openbsc/gprs_gmm.h | 1 +
openbsc/include/openbsc/gprs_sgsn.h | 45 +++++++-
openbsc/include/openbsc/gsm_subscriber.h | 2 +
openbsc/src/gprs/gprs_gmm.c | 83 ++++++++++++--
openbsc/src/gprs/gprs_sgsn.c | 3 +-
openbsc/src/gprs/gprs_subscriber.c | 130 +++++++++++++++++-----
openbsc/src/gprs/sgsn_auth.c | 118 +++++++++++++++++++-
openbsc/src/gprs/sgsn_vty.c | 178 +++++++++++++++++++++++++++++--
8 files changed, 504 insertions(+), 56 deletions(-)
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNURadio hardware abstraction block".
The branch, master has been updated
via 20fd6a8c34339125dc509dc33ae7c3b1ed6e1959 (commit)
via 163cad2e96195745c76631eec3a32197f20c787c (commit)
from 13114b78301ac4fb716ce79b41934ee897726a4b (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/gr-osmosdr/commit/?id=20fd6a8c34339125dc509dc33ae7c…
commit 20fd6a8c34339125dc509dc33ae7c3b1ed6e1959
Author: Dimitri Stolnikov <horiz0n(a)gmx.net>
Date: Thu Nov 27 16:38:25 2014 +0100
airspy: implement DC bias control
use with -a "airspy,bias=1" to enable DC bias on antenna input
http://cgit.osmocom.org/gr-osmosdr/commit/?id=163cad2e96195745c76631eec3a32…
commit 163cad2e96195745c76631eec3a32197f20c787c
Author: Dimitri Stolnikov <horiz0n(a)gmx.net>
Date: Thu Nov 27 16:28:30 2014 +0100
airspy: remove deprecated init/exit calls
-----------------------------------------------------------------------
Summary of changes:
grc/gen_osmosdr_blocks.py | 2 +-
lib/airspy/airspy_source_c.cc | 46 +++++++------------------------------------
lib/airspy/airspy_source_c.h | 3 ---
3 files changed, 8 insertions(+), 43 deletions(-)
hooks/post-receive
--
GNURadio hardware abstraction block
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNURadio hardware abstraction block".
The branch, master has been updated
via 13114b78301ac4fb716ce79b41934ee897726a4b (commit)
from aa4094b3fd103a5b7fbcd3b8a0e225cfe70a6c6f (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/gr-osmosdr/commit/?id=13114b78301ac4fb716ce79b41934…
commit 13114b78301ac4fb716ce79b41934ee897726a4b
Author: Dimitri Stolnikov <horiz0n(a)gmx.net>
Date: Thu Nov 27 16:22:27 2014 +0100
airspy: add support for 2.5MSPS rate (requires production firmware)
-----------------------------------------------------------------------
Summary of changes:
lib/airspy/airspy_source_c.cc | 25 ++++++++++++++++++-------
1 file changed, 18 insertions(+), 7 deletions(-)
hooks/post-receive
--
GNURadio hardware abstraction block
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNURadio hardware abstraction block".
The branch, sync has been deleted
was 22ee0e3123af66e48e75445451c120b4d46ad372
-----------------------------------------------------------------------
22ee0e3123af66e48e75445451c120b4d46ad372 introduce time & clock synchronisation APIs
-----------------------------------------------------------------------
hooks/post-receive
--
GNURadio hardware abstraction block
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNURadio hardware abstraction block".
The branch, master has been updated
via aa4094b3fd103a5b7fbcd3b8a0e225cfe70a6c6f (commit)
from da27f3fb0a614c2cb9f5f867be8df77f53058f28 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/gr-osmosdr/commit/?id=aa4094b3fd103a5b7fbcd3b8a0e22…
commit aa4094b3fd103a5b7fbcd3b8a0e225cfe70a6c6f
Author: Dimitri Stolnikov <horiz0n(a)gmx.net>
Date: Sat May 3 22:25:23 2014 +0200
introduce time & clock synchronisation APIs
-----------------------------------------------------------------------
Summary of changes:
grc/gen_osmosdr_blocks.py | 97 +++++++++++++++++++++++-
include/osmosdr/CMakeLists.txt | 1 +
include/osmosdr/ranges.h | 6 ++
include/osmosdr/sink.h | 98 +++++++++++++++++++++++++
include/osmosdr/source.h | 98 +++++++++++++++++++++++++
include/osmosdr/time_spec.h | 141 +++++++++++++++++++++++++++++++++++
lib/CMakeLists.txt | 62 ++++++++++++++++
lib/sink_iface.h | 110 +++++++++++++++++++++++++++
lib/sink_impl.cc | 101 ++++++++++++++++++++++++-
lib/sink_impl.h | 14 ++++
lib/source_iface.h | 110 +++++++++++++++++++++++++++
lib/source_impl.cc | 101 ++++++++++++++++++++++++-
lib/source_impl.h | 14 ++++
lib/time_spec.cc | 163 +++++++++++++++++++++++++++++++++++++++++
lib/uhd/uhd_sink_c.cc | 67 +++++++++++++++++
lib/uhd/uhd_sink_c.h | 14 ++++
lib/uhd/uhd_source_c.cc | 67 +++++++++++++++++
lib/uhd/uhd_source_c.h | 14 ++++
swig/osmosdr_swig.i | 27 +++++++
19 files changed, 1302 insertions(+), 3 deletions(-)
create mode 100644 include/osmosdr/time_spec.h
create mode 100644 lib/time_spec.cc
hooks/post-receive
--
GNURadio hardware abstraction block
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNURadio hardware abstraction block".
The branch, master has been updated
via da27f3fb0a614c2cb9f5f867be8df77f53058f28 (commit)
from 8d9e6b58bb8dac8a92603feb8804c42ecc1e5945 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/gr-osmosdr/commit/?id=da27f3fb0a614c2cb9f5f867be8df…
commit da27f3fb0a614c2cb9f5f867be8df77f53058f28
Author: Dimitri Stolnikov <horiz0n(a)gmx.net>
Date: Tue Nov 25 20:03:26 2014 +0100
apps: fix named gain access on osmocom_siggen_base.py
-----------------------------------------------------------------------
Summary of changes:
apps/osmocom_siggen_base.py | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
hooks/post-receive
--
GNURadio hardware abstraction block
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, jerlbeck/wip/gprs-patching has been updated
discards 4193f174dd6cdaabf2d4319faec463261a37d5af (commit)
discards 95f84db2402d458fd5b3d899f08cb33ec9cd3212 (commit)
discards 7518cdd42e257e70d9ec52ebb3567ab2df1472d6 (commit)
discards dd9645c9e2cf910bd30abedecc086e7207bdce92 (commit)
discards aa5dd818449d27659cb9e8b10d69ba3e9f875097 (commit)
discards 6e8c0bd7c97273f0ab171471a4725447ade17ae3 (commit)
discards a374e69d392dc4cfccf7a367c74961b2786bbc90 (commit)
discards 4cc973bce2eded371712ec73475d6d62c4aa91e7 (commit)
discards 9cc7a20c65bc881ea8e0f4084efac7180266b239 (commit)
discards e99d24e9f00bc55e3c215fb3c0380171ccacebfd (commit)
discards 744c7874f51c98c1ccf33814b2a88e0aeab34472 (commit)
discards 2b35c1709abf42c9d250e280a18eb7886a3f4b37 (commit)
discards 5465f915bf4dcebb89171a9cf9f78a9e1b7c4f7f (commit)
discards ad30d8d3b3af86a789e42ab3804f14aba98c43e0 (commit)
discards 49ac6fcf3bd39aa6f1fa19fb199de6e45bf1e2f6 (commit)
discards c11c6b97f6c20739a39edc10cf5988c2583b951e (commit)
discards 40415c5655d5f5b67c557f733f0c47b2d60eae88 (commit)
discards be35395defcd81d7661365b97c072711e0e55d23 (commit)
discards a00c3bd090b024f116c6e134b668cade04b535c1 (commit)
discards 62a432c7db59c3004a9fc3272d46a6cc9c4269aa (commit)
discards 584bf98d87497381ea30526d73899d3a5542eb61 (commit)
discards b8242b0c2422a948fdce005558fc8e5738555ff0 (commit)
discards acc28f5fa7b9c1ad607bddb47429a04a068c14ef (commit)
via dc30dedcb857c9cfa9efb451a725ed83c0774def (commit)
via aa78094b4bc11caff7b3c3c90366448a75269d84 (commit)
via 4d1f467f4b78c5d630dc5aa0da847d7124e5b645 (commit)
via 2b8b8aeb85f20782be66e7968b63f0bb94139483 (commit)
via e920272bb4ef66dbc662c81ef852dec03bf3c124 (commit)
via 230c37ff165ee2cff7d9098fd15c7989861421df (commit)
via a464776f1513218645c5b4284c0b1fc1e1a17b59 (commit)
via 51ad560afe535d4c7528eca2aebb9e9de8a12df7 (commit)
via deddfdb54f878e64df11a8151239efd70b975015 (commit)
via 95617192e94c178ac36f3f379cbbcbfbaadb9939 (commit)
via 175a240285897317fff4a94e4f9b62408797b4b6 (commit)
via a49b2c010e05eeaa979c76c9a277bb5aaea31968 (commit)
via b92a538d236ccffe97803279ecbaa242f8faa66a (commit)
via 8a64141a533c0b090bbeb756bb8eac2eee457ad4 (commit)
via b1461152e6945a747ef2d65ee5908cc5d59acbbd (commit)
via b1edf7b64f6c05932c83b4d31b1127f2a833601e (commit)
via 619b014d3aacea1b33b70432af01e80eb2252af0 (commit)
via 02ab91e6a73e16da51918b52548a0f4be4c6a0f6 (commit)
via a0b6efb3685ea90190cfbd9423a74c181ea4f12f (commit)
via f951a01bb227e524eb369051c95fbebace7570d0 (commit)
via f6e7d99d54cc75fdc19433011afb5eaaa8a2a002 (commit)
via c4f9bf3142f54b63174f653b07103dd6ab36b1ae (commit)
via 80d07e30c76f2bd72ee382b4b7941262c1d5865d (commit)
via 106f547733450afda1ddbd7e886dc8c902fed4d4 (commit)
via 144b8b1ca77f628ea4cf87ff903b7e79f0abf9dd (commit)
via 423f8bfa027d544867dcf7afc188a8ea5221e2bc (commit)
via 0c06f98ced2b70801147eb52d6596079e473dfc9 (commit)
via b1c074f62c1d04138b751f71e3b07fbb0a521898 (commit)
via abdf02b9b988a816201b4530f36f709ca4c146ac (commit)
via a790456f1b826ea204f47c4aa4973dc777d00d2a (commit)
via 0074a77424c95d2d7d0608dc0dfabc1948e62fe0 (commit)
via 93eae8ec78d145cf87b7858ebee60c72da7a2d20 (commit)
This update added new revisions after undoing existing revisions. That is
to say, the old revision is not a strict subset of the new revision. This
situation occurs when you --force push a change and generate a repository
containing something like this:
* -- * -- B -- O -- O -- O (4193f174dd6cdaabf2d4319faec463261a37d5af)
\
N -- N -- N (dc30dedcb857c9cfa9efb451a725ed83c0774def)
When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=dc30dedcb857c9cfa9efb451a725ed83…
commit dc30dedcb857c9cfa9efb451a725ed83c0774def
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Sep 30 13:53:26 2014 +0200
sgsn: Added TODOs (TODO)
TODO:
- fix and remove TODOs
- add test cases for Detach(reattach)
- add test cases for PDP context deletion (OW#1311)
- add test cases for Cancel pending timer in sgsn_mm_ctx_free
- remove this commit
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=aa78094b4bc11caff7b3c3c90366448a…
commit aa78094b4bc11caff7b3c3c90366448a75269d84
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Nov 4 12:44:15 2014 +0100
sgsn: Notify an affected MM context if an ACL rule is removed (TODO)
Currently if an ACL access rule is removed, MS already attached are
not affected until they try to reattach to the SGSN.
This patch adds sgsn_auth_update_all() that iterates through allMM
contexts and calls sgsn_auth_update() on each of them. This function
is then called when 'imsi-acl del IMSI' is executed after the ACL has
been removed.
TODO:
- decide, whether ito replace that by a dedicated update command in
the VTY ENABLE node
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=4d1f467f4b78c5d630dc5aa0da847d71…
commit 4d1f467f4b78c5d630dc5aa0da847d7124e5b645
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Oct 17 10:08:02 2014 +0200
sgsn: Do not die in _bssgp_tx_dl_ud on TLLI mismatch (TODO)
Currently an OSMO_ASSERT fails, if the message's and the mmctx's
TLLIs do not match.
This commit turns the assertion into an ERROR log message and uses
the default values for IMSI, DRX, and RA CAP instead of the MM
context values in this case.
TODO:
- find the real source for the problem
- add test cases derived from what is being described in the ticket
Ticket: OW#1322
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=2b8b8aeb85f20782be66e7968b63f0bb…
commit 2b8b8aeb85f20782be66e7968b63f0bb94139483
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Nov 11 14:01:48 2014 +0100
sgsn: Add VTY commands to manage subscriber cache
This adds the following commands to the ENABLE node:
- show subscriber cache
- update-subscriber imsi IMSI insert authorized (0|1)
- update-subscriber imsi IMSI cancel
These commands are mainly testing tools and maintenance helpers. The
update commands work asynchronously and can be used to complete a
pending update request or to terminate an existing connection.
Note that the subscriber cache is not stored persistently and will
always be empty after an SGSN restart.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=e920272bb4ef66dbc662c81ef852dec0…
commit e920272bb4ef66dbc662c81ef852dec03bf3c124
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Nov 11 14:47:38 2014 +0100
sgsn: Add gsm0408_gprs_access_cancelled (TODO)
This function is called to delete an established MM context
without invoking a detach procedure that could disable the GPRS
functionality of the MS until the next power cycle.
It is called when a subscriber is cancelled.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=230c37ff165ee2cff7d9098fd15c7989…
commit 230c37ff165ee2cff7d9098fd15c7989861421df
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Wed Nov 12 10:18:09 2014 +0100
sgsn: Integrate subscriber handling into the SGSN (TODO)
This commit adds a new authorization policy 'remote' and uses
the subscriber cache for authorization when this policy is being used.
Note that there is no remote backend implemented yet.
TODO:
- tests
- decide, whether 'remote' could be named better, e.g. sth based on
'subscriber'
Ticket: OW#????
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=a464776f1513218645c5b4284c0b1fc1…
commit a464776f1513218645c5b4284c0b1fc1e1a17b59
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Wed Nov 12 10:12:11 2014 +0100
sgsn: Add gprs_subscriber.c
This patch adds GPRS specific functions for gsm_subscriber objects
(allocation, retrieval, deletion) and subscriber data
requests/updates. The sgsn_update_subscriber_data callback is used to
notify the sgsn about updates and is extended by a parameter that
passes a reference to a gsm_subscriber.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=51ad560afe535d4c7528eca2aebb9e9d…
commit 51ad560afe535d4c7528eca2aebb9e9de8a12df7
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Nov 24 15:04:15 2014 +0100
sgsn/test: Add test case for unexpected Detach Accepts
The commit "sgsn: Don't send XID reset after Detach Accept" fixed the
SGSN to not respond to a Detach Accept message when there is no MM
context.
This patch adds a test case to verify, that there is really no
message sent in that case.
The test fails when the commit mentioned aboved is reverted.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=deddfdb54f878e64df11a8151239efd7…
commit deddfdb54f878e64df11a8151239efd70b975015
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Nov 24 14:40:28 2014 +0100
sgsn/test: Don't rely on the actual PRNG sequence
Currently the expected P-TMSI generated by the SGSN is hard-coded
into the test. This adds a dependency on the implementation of rand()
and thus the libc used. This breaks the test e.g. on FreeBSD.
This patch modifies test_gmm_attach() to srand(1) first, generate the
P-TMSI, and finally srand(1) again before starting the test.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=95617192e94c178ac36f3f379cbbcbfb…
commit 95617192e94c178ac36f3f379cbbcbfbaadb9939
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Oct 30 17:15:43 2014 +0100
gbproxy: Reset TLLIs when the link_info is found by IMSI/P-TMSI
Currently when the MS does a re-attach without doing a proper detach
first, the gbproxy uses the old local TLLI if patching and the keep
mode are enabled. This leads to a failing attachment procedure when
TLLI patching is also enabled.
This patch changes gbproxy_update_link_state_ul to reset all TLLIs
within the link_info if the message contains an unknown TLLI and an
MI. This is generally the case with Attach Request messages.
The gbproxy_get_link_info_ul gets an additional tlli_is_valid
output parameter that is set, when a TLLI was present and found.
This flag is then used instead of checking tlli.current == 0 to
set TLLI/P-TMSI e.g. Attach Requests when a link_info was already
present for the P-TMSI/IMSI used in such a request.
Ticket: OW#1324
Sponsored-by: On-Waves ehf
-----------------------------------------------------------------------
Summary of changes:
openbsc/include/openbsc/gprs_sgsn.h | 4 +-
openbsc/include/openbsc/gsm_data.h | 1 +
openbsc/include/openbsc/gsm_data_shared.h | 3 +-
openbsc/include/openbsc/gsm_subscriber.h | 1 +
openbsc/include/openbsc/mgcp.h | 1 +
openbsc/src/gprs/gb_proxy_tlli.c | 13 +++---
openbsc/src/gprs/gprs_subscriber.c | 2 +-
openbsc/src/libbsc/bsc_ctrl_commands.c | 73 ++++++++++++++++++++++++++++++-
openbsc/src/libbsc/bsc_init.c | 4 +-
openbsc/src/libbsc/system_information.c | 3 ++
openbsc/src/libcommon/gsm_data_shared.c | 3 ++
openbsc/src/libmgcp/mgcp_protocol.c | 5 ++-
openbsc/src/libmgcp/mgcp_vty.c | 50 +++++++++++++++++++++
openbsc/tests/ctrl_test_runner.py | 59 +++++++++++++++++++++++++
openbsc/tests/mgcp/mgcp_test.c | 58 ++++++++++++++++++++++++
openbsc/tests/mgcp/mgcp_test.ok | 1 +
openbsc/tests/sgsn/sgsn_test.c | 45 ++++++++++++++++++-
openbsc/tests/sgsn/sgsn_test.ok | 1 +
openbsc/tests/vty_test_runner.py | 15 +++++++
19 files changed, 326 insertions(+), 16 deletions(-)
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNURadio block for spectrum visualization using GPU".
The branch, master has been updated
via 36ce5e78430bcf87e219a97219051a9d62d1d834 (commit)
from f16d0ffafb29f5004c70d7fde85e7366d2024c8e (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/gr-fosphor/commit/?id=36ce5e78430bcf87e219a97219051…
commit 36ce5e78430bcf87e219a97219051a9d62d1d834
Author: Sylvain Munaut <tnt(a)246tNt.com>
Date: Sun Nov 23 15:33:10 2014 +0100
gr-fosphor/qt: Explicitely set a size policy on the QGLSurface
Without it, some layout don't work and the widget ends up being zero sized
Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com>
-----------------------------------------------------------------------
Summary of changes:
lib/QGLSurface.cc | 1 +
1 file changed, 1 insertion(+)
hooks/post-receive
--
GNURadio block for spectrum visualization using GPU
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, master has been updated
via 175a240285897317fff4a94e4f9b62408797b4b6 (commit)
via a49b2c010e05eeaa979c76c9a277bb5aaea31968 (commit)
via b92a538d236ccffe97803279ecbaa242f8faa66a (commit)
via 8a64141a533c0b090bbeb756bb8eac2eee457ad4 (commit)
via b1461152e6945a747ef2d65ee5908cc5d59acbbd (commit)
from b1edf7b64f6c05932c83b4d31b1127f2a833601e (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=175a240285897317fff4a94e4f9b6240…
commit 175a240285897317fff4a94e4f9b62408797b4b6
Author: Holger Hans Peter Freyther <zecke(a)selfish.org>
Date: Wed Jan 9 19:55:04 2013 +0100
bsc: Add ctrl command to set the TRX ARFCN
http://cgit.osmocom.org/openbsc/commit/?id=a49b2c010e05eeaa979c76c9a277bb5a…
commit a49b2c010e05eeaa979c76c9a277bb5aaea31968
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Fri Nov 21 11:18:45 2014 +0100
bsc: Allow to generate new system information online
Increase the bcch_change_mark and generate a new copy of the
system information. Make the method public, add a small test
case. Manually verified using the FakeBTS. I don't know if
the MS will re-read these SIs.
Related: SYS#739
http://cgit.osmocom.org/openbsc/commit/?id=b92a538d236ccffe97803279ecbaa242…
commit b92a538d236ccffe97803279ecbaa242f8faa66a
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Fri Nov 21 10:00:39 2014 +0100
bts: Store the bcch_change_mark in the bts structure
Store the BCCH change mark inside the BTS structure. This will
allow us increment the number and re-generate the SIs.
Related: SYS#739
http://cgit.osmocom.org/openbsc/commit/?id=8a64141a533c0b090bbeb756bb8eac2e…
commit 8a64141a533c0b090bbeb756bb8eac2eee457ad4
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Fri Nov 21 10:54:42 2014 +0100
bsc: Allow to set the call-identity
Allow to set the cell-identity through the control interface
and add a small test for it.
Related: SYS#739
http://cgit.osmocom.org/openbsc/commit/?id=b1461152e6945a747ef2d65ee5908cc5…
commit b1461152e6945a747ef2d65ee5908cc5d59acbbd
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Fri Nov 21 10:20:29 2014 +0100
bsc: Allow to apply configuration for an individual BTS
This will drop a specific IP based BTS. It will lead to a
re-connect of the BTS and the new settings will be applied
then.
Fixes: SYS#737
-----------------------------------------------------------------------
Summary of changes:
openbsc/include/openbsc/gsm_data.h | 1 +
openbsc/include/openbsc/gsm_data_shared.h | 3 +-
openbsc/src/libbsc/bsc_ctrl_commands.c | 73 ++++++++++++++++++++++++++++++-
openbsc/src/libbsc/bsc_init.c | 4 +-
openbsc/src/libbsc/system_information.c | 3 ++
openbsc/src/libcommon/gsm_data_shared.c | 3 ++
openbsc/tests/ctrl_test_runner.py | 59 +++++++++++++++++++++++++
7 files changed, 141 insertions(+), 5 deletions(-)
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, master has been updated
via b1edf7b64f6c05932c83b4d31b1127f2a833601e (commit)
from 619b014d3aacea1b33b70432af01e80eb2252af0 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=b1edf7b64f6c05932c83b4d31b1127f2…
commit b1edf7b64f6c05932c83b4d31b1127f2a833601e
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Thu Nov 20 23:17:32 2014 +0100
mgcp/sdp: Session name must not be empty pick an empty one
The session name must be present in a SDP file. The RFC proposes
to use a space for it but the other equipment is using the dash
so I have picked that as well.
RFC 4566:
The "s=" field is the textual session name. There MUST be one and
only one "s=" field per session description. The "s=" field MUST NOT
be empty and SHOULD contain ISO 10646 characters (but see also the
"a=charset" attribute). If a session has no meaningful name, the
alue "s= " SHOULD be used (i.e., a single space as the session
name).
Fixes: RT#2196
-----------------------------------------------------------------------
Summary of changes:
openbsc/src/libmgcp/mgcp_protocol.c | 1 +
openbsc/tests/mgcp/mgcp_test.c | 7 +++++++
2 files changed, 8 insertions(+)
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, master has been updated
via 619b014d3aacea1b33b70432af01e80eb2252af0 (commit)
from 02ab91e6a73e16da51918b52548a0f4be4c6a0f6 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=619b014d3aacea1b33b70432af01e80e…
commit 619b014d3aacea1b33b70432af01e80eb2252af0
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Wed Nov 19 16:04:45 2014 +0100
mgcp: Allow to omit sending the audio name at all
Equipment like AudioCode appears to get upset when we use a
builtin type and then assign a name to it. Allow to completely
omit the name.
-----------------------------------------------------------------------
Summary of changes:
openbsc/include/openbsc/mgcp.h | 1 +
openbsc/src/libmgcp/mgcp_protocol.c | 4 ++-
openbsc/src/libmgcp/mgcp_vty.c | 50 ++++++++++++++++++++++++++++++++++++
openbsc/tests/mgcp/mgcp_test.c | 51 +++++++++++++++++++++++++++++++++++++
openbsc/tests/mgcp/mgcp_test.ok | 1 +
openbsc/tests/vty_test_runner.py | 15 +++++++++++
6 files changed, 121 insertions(+), 1 deletion(-)
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "An utility library for Open Source Mobile Communications".
The branch, laforge/nuttx has been updated
via 7711ef73f32c1eaaa20b4fd5ba1a7b3d9bdcd25d (commit)
from d41f44875385717cb665059a9ab0d5a632cff0bf (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/libosmocore/commit/?id=7711ef73f32c1eaaa20b4fd5ba1a…
commit 7711ef73f32c1eaaa20b4fd5ba1a7b3d9bdcd25d
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Mon Nov 17 14:44:25 2014 +0100
msgb/embedded: Do not depend on talloc for allocations
We don't want to run talloc on the embedded platform. Use
"EMBEDDED" as we don't seem to export TALLOC handling.
-----------------------------------------------------------------------
Summary of changes:
src/msgb.c | 9 +++++++++
1 file changed, 9 insertions(+)
hooks/post-receive
--
An utility library for Open Source Mobile Communications
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, ciaby/rhizomatica-token has been updated
discards b52338d4a9ef6442b2e23228f24cb62e49f8d978 (commit)
via b33b50fdbc44f1d22584383df1018b28e80f50d8 (commit)
via cc4f017034bce80516c09bf2347a094d36954500 (commit)
This update added new revisions after undoing existing revisions. That is
to say, the old revision is not a strict subset of the new revision. This
situation occurs when you --force push a change and generate a repository
containing something like this:
* -- * -- B -- O -- O -- O (b52338d4a9ef6442b2e23228f24cb62e49f8d978)
\
N -- N -- N (b33b50fdbc44f1d22584383df1018b28e80f50d8)
When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=b33b50fdbc44f1d22584383df1018b28…
commit b33b50fdbc44f1d22584383df1018b28e80f50d8
Author: Ciaby <ciaby(a)rhizomatica.org>
Date: Sun Nov 16 23:07:55 2014 -0600
Updated changelog, bumped version to +rhizo3.
http://cgit.osmocom.org/openbsc/commit/?id=cc4f017034bce80516c09bf2347a094d…
commit cc4f017034bce80516c09bf2347a094d36954500
Author: Ciaby <ciaby(a)rhizomatica.org>
Date: Sun Nov 16 23:06:47 2014 -0600
Handover fix, needs to be tested.
-----------------------------------------------------------------------
Summary of changes:
debian/changelog | 3 ++-
openbsc/src/libbsc/handover_logic.c | 4 ++++
2 files changed, 6 insertions(+), 1 deletion(-)
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, ciaby/rhizomatica-token has been created
at b52338d4a9ef6442b2e23228f24cb62e49f8d978 (commit)
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=b52338d4a9ef6442b2e23228f24cb62e…
commit b52338d4a9ef6442b2e23228f24cb62e49f8d978
Author: Ciaby <ciaby(a)rhizomatica.org>
Date: Sun Nov 16 17:12:50 2014 -0600
Updated changelog, bumped version to +rhizo3.
http://cgit.osmocom.org/openbsc/commit/?id=0c0453c74165f49439a952787496d4c7…
commit 0c0453c74165f49439a952787496d4c7dfe8f3dc
Author: Ruben Pollan <meskio(a)sindominio.net>
Date: Sun Nov 16 13:04:01 2014 -0600
Configure the auth token sms text in the database
http://cgit.osmocom.org/openbsc/commit/?id=8ba3e2e27b5063304679077aa851cb02…
commit 8ba3e2e27b5063304679077aa851cb02fad6850a
Author: Ciaby <ciaby(a)autistici.org>
Date: Sun May 4 20:04:11 2014 +0200
Revert MNCC_SOCK_VERSION to 2 (from 4), otherwise there is no know LCR version which can work with it :) Also mentioned at: https://gitorious.org/sysmocom-openembedded/meta-telephony/commit/4da2963d8…http://cgit.osmocom.org/openbsc/commit/?id=9a1742f1e78d85d2e9ae1685cafb3db1…
commit 9a1742f1e78d85d2e9ae1685cafb3db1e3c6a380
Author: Ciaby <ciaby(a)autistici.org>
Date: Sat Mar 8 20:25:48 2014 +0100
Disable the gbproxy test (failing). Bump the debian version in the changelog.
http://cgit.osmocom.org/openbsc/commit/?id=4ea053240bd0b720351d1b118f233a33…
commit 4ea053240bd0b720351d1b118f233a33a73e64c4
Author: Ciaby <ciaby(a)autistici.org>
Date: Fri Mar 7 15:50:51 2014 +0100
DIRTY HACK: Force all SMSs to SMPP.
http://cgit.osmocom.org/openbsc/commit/?id=d884ddcaafad17931c9dbb679408fe67…
commit d884ddcaafad17931c9dbb679408fe678bcb6b10
Author: Ciaby <ciaby(a)autistici.org>
Date: Fri Mar 7 15:36:22 2014 +0100
Added SMPP support in the debian build, include libsmpp34-dev as a dependency.
-----------------------------------------------------------------------
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "An utility library for Open Source Mobile Communications".
The branch, laforge/nuttx has been updated
via d41f44875385717cb665059a9ab0d5a632cff0bf (commit)
from 93a5b9110d896d8500edc8448148a1024768cdef (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/libosmocore/commit/?id=d41f44875385717cb665059a9ab0…
commit d41f44875385717cb665059a9ab0d5a632cff0bf
Author: Daniel Laszlo Sitzer <dlsitzer(a)sysmocom.de>
Date: Mon Jul 7 15:51:40 2014 +0200
tlv/msgb: Be able to generate and parse TLV as used by LLDP
The Link Layer Discovery Protocol is using a Tag Length Value (TLV)
structure. What is different is that the tag and length do not stop
at byte boundaries.
This commit introduces methods to msgb and tlv to be able to create
such a tag/length header and a way to parse it using the tlv_parse
routine. When it comes to parsing we have an issue that the new
TLV_TYPE_T7L9V should not be mixed with the other types inside the
same tlv definition. This is due the bitshifting required to
identify the tag.
The code likely requires work on big-endian machines but so does
most of the other code as well.
-----------------------------------------------------------------------
Summary of changes:
.gitignore | 1 +
include/osmocom/gsm/tlv.h | 14 ++++
src/gsm/tlv_parser.c | 19 +++++
tests/Makefile.am | 8 +-
tests/testsuite.at | 6 ++
tests/tlv/tlv_test.c | 205 ++++++++++++++++++++++++++++++++++++++++++++++
tests/tlv/tlv_test.ok | 8 ++
7 files changed, 259 insertions(+), 2 deletions(-)
create mode 100644 tests/tlv/tlv_test.c
create mode 100644 tests/tlv/tlv_test.ok
hooks/post-receive
--
An utility library for Open Source Mobile Communications
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "An utility library for Open Source Mobile Communications".
The branch, master has been updated
via 20144f7bc5c04e57da36cd7d7883f576510f0298 (commit)
via 78a870ed0fc7ec03d0eb24241d9772470e4a78ae (commit)
via 7b74dda31bc05a7210bbbcb382b78d6f9cde5b15 (commit)
via b592ab71a7e3d49d62ea986401f0902953375057 (commit)
via 9e166e8e0815a5b429738614025fc2beb96473d4 (commit)
from 18bcc8ab6214e92539370eb3c5b601f18def4dde (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/libosmocore/commit/?id=20144f7bc5c04e57da36cd7d7883…
commit 20144f7bc5c04e57da36cd7d7883f576510f0298
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Tue Mar 11 10:47:08 2014 +0100
vty/vector.c: Use string.h, not memory.h
http://cgit.osmocom.org/libosmocore/commit/?id=78a870ed0fc7ec03d0eb24241d97…
commit 78a870ed0fc7ec03d0eb24241d9772470e4a78ae
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Tue Mar 11 10:45:38 2014 +0100
remove references to u_long type, use 'unsigned long' instead
.. Nuttx doesn't know u_long
http://cgit.osmocom.org/libosmocore/commit/?id=7b74dda31bc05a7210bbbcb382b7…
commit 7b74dda31bc05a7210bbbcb382b78d6f9cde5b15
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Tue Mar 11 10:31:19 2014 +0100
remove references to u_char type, use 'unsigned char' instead
... u_char not being defined on Nuttx.
http://cgit.osmocom.org/libosmocore/commit/?id=b592ab71a7e3d49d62ea986401f0…
commit b592ab71a7e3d49d62ea986401f0902953375057
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Mon Mar 10 18:12:17 2014 +0100
strrb.c: Use string.h, not strings.h
Not all systems have strings.h
http://cgit.osmocom.org/libosmocore/commit/?id=9e166e8e0815a5b429738614025f…
commit 9e166e8e0815a5b429738614025fc2beb96473d4
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Mon Mar 10 17:28:33 2014 +0100
select.c: Add missing #include lines for string.h and sys/select.h
This is needed on Nuttx.
-----------------------------------------------------------------------
Summary of changes:
include/osmocom/vty/buffer.h | 2 +-
include/osmocom/vty/command.h | 2 +-
src/select.c | 2 ++
src/strrb.c | 2 +-
src/vty/buffer.c | 4 ++--
src/vty/vector.c | 2 +-
src/vty/vty.c | 6 +++---
7 files changed, 11 insertions(+), 9 deletions(-)
hooks/post-receive
--
An utility library for Open Source Mobile Communications
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "An utility library for Open Source Mobile Communications".
The branch, master has been updated
via 18bcc8ab6214e92539370eb3c5b601f18def4dde (commit)
from 8497b0a78671e09015ec2cb40f0a21cae7baf5ad (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/libosmocore/commit/?id=18bcc8ab6214e92539370eb3c5b6…
commit 18bcc8ab6214e92539370eb3c5b601f18def4dde
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Fri Nov 14 15:06:09 2014 +0100
pcsc: Allow to disable the PCSC dependency
* PCSC is enabled by default
* --enable-pcsc is enabling it
* --disable-pcscis disabling it
* Fix the makefile of the utilities to not build pcsc and
use the right header files/libraries.
-----------------------------------------------------------------------
Summary of changes:
configure.ac | 10 ++++++----
utils/Makefile.am | 8 +++++---
2 files changed, 11 insertions(+), 7 deletions(-)
hooks/post-receive
--
An utility library for Open Source Mobile Communications
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, master has been updated
via 02ab91e6a73e16da51918b52548a0f4be4c6a0f6 (commit)
via a0b6efb3685ea90190cfbd9423a74c181ea4f12f (commit)
via f951a01bb227e524eb369051c95fbebace7570d0 (commit)
via f6e7d99d54cc75fdc19433011afb5eaaa8a2a002 (commit)
via c4f9bf3142f54b63174f653b07103dd6ab36b1ae (commit)
via 80d07e30c76f2bd72ee382b4b7941262c1d5865d (commit)
via 106f547733450afda1ddbd7e886dc8c902fed4d4 (commit)
via 144b8b1ca77f628ea4cf87ff903b7e79f0abf9dd (commit)
via 423f8bfa027d544867dcf7afc188a8ea5221e2bc (commit)
via 0c06f98ced2b70801147eb52d6596079e473dfc9 (commit)
via b1c074f62c1d04138b751f71e3b07fbb0a521898 (commit)
via abdf02b9b988a816201b4530f36f709ca4c146ac (commit)
via a790456f1b826ea204f47c4aa4973dc777d00d2a (commit)
via 0074a77424c95d2d7d0608dc0dfabc1948e62fe0 (commit)
via 93eae8ec78d145cf87b7858ebee60c72da7a2d20 (commit)
from 3911880b68ddd92c9dd89d6ac20c26807e33f905 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=02ab91e6a73e16da51918b52548a0f4b…
commit 02ab91e6a73e16da51918b52548a0f4be4c6a0f6
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Wed Nov 12 09:53:45 2014 +0100
sgsn: Cross-link gsm_subscriber and sgsn_mm_ctx
To implement subscriber based authorization a data structure is
needed that keeps the subscriber data. The MSC already uses a similar
struct named gsm_subscriber whose implementation is split into a
generic part (allocation, retrieval, reference counting, list
maintenance) and MSC related parts. For GPRS, only the generic part
will be used and specific fields may be added when needed.
This patch adds a field mm to struct gsm_subscriber that will be used
by the SGSN to store a reference to the current MM context (or NULL
if there is none). This also adds a field subscr to struct
sgsn_mm_ctx that reversely points to a gsm_subscriber (or NULL if
there is none). Either both fields are NULL or both fields are
non-NULL. Note that subscr is being reference counted.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=a0b6efb3685ea90190cfbd9423a74c18…
commit a0b6efb3685ea90190cfbd9423a74c181ea4f12f
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Nov 13 10:48:39 2014 +0100
sgsn: Remove explicit sgsn_instance parameters
Currently the function in sgsn_auth.c either have an sgsn_config or
an sgsn_instance parameter. Since then global sgsn variable is
already being used in that file and since other parts of the SGSN
related code also rely on a global sgsn singleton, these parameters
pretend to provide a flexibility that is not really supported.
Therefore this patch removes these parameters except for the ACL
related functions, which do not call code that uses the sgsn
variable.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=f951a01bb227e524eb369051c95fbeba…
commit f951a01bb227e524eb369051c95fbebace7570d0
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Nov 7 14:17:44 2014 +0100
sgsn: Refactor sgsn_auth to separate request and authorization
Currently the authorization is done in sgsn_auth_request for ACL
based authorization. This doesn't match the way remote authorization
would work, so that there is a second call to sgsn_auth_state already
present in sgsn_auth_update.
This patch removes the autorization check completely from
sgsn_auth_request which in turn calls sgsn_auth_update directly now.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=f6e7d99d54cc75fdc19433011afb5eaa…
commit f6e7d99d54cc75fdc19433011afb5eaaa8a2a002
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Nov 6 15:43:10 2014 +0100
sgsn: Don't assign a new P-TMSI if one is pending
Currently every time an RA Update Req or an Attach Req is processed, a
new P-TMSI is allocated. When an MS issues another of these messages
before it has completed the first procedure, old_ptmsi is replaced by
ptmsi (and thus lost) and ptmsi is replaced by the newly allocated
P-TMSI. This can confuse the gbproxy, which can loose track of the
logical link then. At least a Blackberry emits a double set of RA Upd
Req messages from time to time which may be just 20ms apart.
This patch adds a check whether mm->ptmsi or mm->old_ptmsi are set.
If both are set, the P-TMSI is not re-allocated. This is only the
case, when the Complete message has not been received yet, since that
message will reset old_ptmsi.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=c4f9bf3142f54b63174f653b07103dd6…
commit c4f9bf3142f54b63174f653b07103dd6ab36b1ae
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Nov 11 08:55:13 2014 +0100
sgsn: Don't send XID reset after Detach Accept
Currently when a Detach Accept is received for an unknown TLLI (which
is in general the case afer the SGSN has requested the detachment),
an XID reset is sent to the BSS, causing a BSSGP Status message. This
happens in gsm0408_rcv_gmm.
This patch moves the corresponding call to gprs_llgmm_reset downwards
so that it is not being called in that case.
Addresses:
SGSN->BSS TLLI: 0xd75b91d9 SAPI: LLGMM, UI (DTAP) (GMM) Detach Request
BSS->SGSN TLLI: 0xd75b91d9 SAPI: LLGMM, UI (DTAP) (GMM) Detach Accept
SGSN->BSS TLLI: 0xd75b91d9 SAPI: LLGMM, U, XID (Reset, IOV-UI)
BSS->SGSN TLLI: --- BSSGP STATUS (Unknown MS)
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=80d07e30c76f2bd72ee382b4b7941262…
commit 80d07e30c76f2bd72ee382b4b7941262c1d5865d
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Nov 6 13:43:41 2014 +0100
sgsn: Cleanup after RA Update Reject / Attach Reject
Currently, the LLME is not cleaned up after sending an RA Update
Reject. This happens after entering a routing area from outside,
since in that case the SGSN sends an RA Update Reject (implicitly
detached) which causes the MS to restart the attach procedure.
The LLME is also not updated if an Attach Request with message errors
(encoding, invalid MI type) is received or if an MM context cannot be
allocated.
This patch changes gsm48_rx_gmm_ra_upd_req and gsm48_rx_gmm_att_req
to unassign the LLME or free the MM context (if available) after a
Reject message has been sent.
Ticket: OW#1324
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=106f547733450afda1ddbd7e886dc8c9…
commit 106f547733450afda1ddbd7e886dc8c902fed4d4
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Nov 4 10:08:37 2014 +0100
sgsn: Add 'acl-only' authentication policy
Currently the VTY 'auth-policy' command results in setting or clearing
the acl_enabled flag. This also enables the matching of the MCC/MNC
prefix of the IMSI.
This patch adds an additional policy 'acl-only' which disables the
MCC/MNC matching and relies on the ACL only.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=144b8b1ca77f628ea4cf87ff903b7e79…
commit 144b8b1ca77f628ea4cf87ff903b7e79f0abf9dd
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Nov 4 11:15:01 2014 +0100
sgsn/test: Add VTY tests for the SGSN
This patch adds some basic SGSN tests to vty_test_runner.py:
- check for config tree nodes
- check specific show commands
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=423f8bfa027d544867dcf7afc188a8ea…
commit 423f8bfa027d544867dcf7afc188a8ea5221e2bc
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Oct 24 18:09:54 2014 +0200
sgsn: Make authorization asynchronous
Currently the authorization of an IMSI is done by checking ACLs
synchronously which is not feasible when the subscriber data has to
be retrieved from an external source.
This patch changes this by using a callback when the information is
available. This is also done when only ACL are checked, in this case
the callback is invoked from within sgsn_auth_request(). The callback
function sgsn_update_subscriber_data calls sgsn_auth_update which
in turn calls either gsm0408_gprs_access_granted or
gsm0408_gprs_access_denied. gsm48_gmm_authorize is extended by a call
to sgsn_auth_request when IMSI and IMEI are available but the
auth_state is unknown.
The change has been successfully tested with single phones (E71 and
IPhone 5c).
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=0c06f98ced2b70801147eb52d6596079…
commit 0c06f98ced2b70801147eb52d6596079e473dfc9
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Wed Oct 29 22:12:20 2014 +0100
sgsn: Move IMSI authorization to gsm48_gmm_authorize
Currently the IMSI is only checked immediately when an Attach Request
is received that contains an IMSI IE. If it contains a P-TMSI
instead, access is always granted.
This commit moves the IMSI check to gsm48_gmm_authorize where it is
applied when IMSI and IMEI have been acquired. This fixes the
authorization when the Attach Accept doesn't contain an IMSI.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=b1c074f62c1d04138b751f71e3b07fbb…
commit b1c074f62c1d04138b751f71e3b07fbb0a521898
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Oct 31 12:27:11 2014 +0100
sgsn: Fix LLME leak when forcing a reattach
Currently when forceing a reattach by sending a Detach
Request (reattach), the SGSN waits for the Detach Accept until it
frees the MM context (if present) and the LLME. If that message gets
lost or isn't sent by the MS, the LLME is never freed if it isn't
bound to an MM context.
This patch adds code to free the MM context/LLME when forcing a
reattachment.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=abdf02b9b988a816201b4530f36f709c…
commit abdf02b9b988a816201b4530f36f709ca4c146ac
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Oct 31 12:20:49 2014 +0100
sgsn: Split gsm0408_gprs_force_reattach into 2 functions
This patch replaces gsm0408_gprs_force_reattach(msg, mmctx) by two
functions
- gsm0408_gprs_force_reattach(mmctx)
- gsm0408_gprs_force_reattach_oldmsg(msg)
The old function basically consists of the code of the two new
functions, where the code path selected depends on mmctx == NULL,
which is harder to maintain, less obvious to use, and not consistent
with many other SGSN functions.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=a790456f1b826ea204f47c4aa4973dc7…
commit a790456f1b826ea204f47c4aa4973dc777d00d2a
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Nov 3 10:12:52 2014 +0100
sgsn: Call mm_ctx_cleanup_free to deregister MM context
Currently the MM context isn't always removed when it is
de-registered (mmctx_timer_cb), mm_state is set to GMM_DEREGISTERED
instead. This can lead to left-over MM contexts which are only
cleaned up if the MS reattaches.
This patch replaces all of these assignments by a call to
mm_ctx_cleanup_free.
Ticket: OW#1324
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=0074a77424c95d2d7d0608dc0dfabc19…
commit 0074a77424c95d2d7d0608dc0dfabc1948e62fe0
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Oct 28 16:23:46 2014 +0100
sgsn: Cleanup GMM state transitions
Currently the GMM state is set to GMM-REGISTERED when an Attach
Accept or a RA Update Accept message is sent, even if a new P-TMSI is
included. In this case 04.08 requires (see 4.7.3.1.3 and 4.7.5.1.3),
that the state is set to GMM-COMMON-PROCEDURE-INITIATED when the
Accept is sent. When the Complete is received, the SGSN shall set
the state to GMM-REGISTERED.
This patch modifies the state updates accordingly.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=93eae8ec78d145cf87b7858ebee60c72…
commit 93eae8ec78d145cf87b7858ebee60c72da7a2d20
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Oct 28 12:23:29 2014 +0100
sgsn: Reorganize and fix gsm48_gmm_authorize
Currently the order of the 'if' clauses in gsm48_gmm_authorize
doesn't match the order in which the conditional parts are entered.
This makes it difficult to maintain. In addition the t3350_mode is
not stored in every path, so that this information is lost when the
identification procedure is started. Since the default value
coincidentally is GMM_T3350_MODE_ATT, this doesn't hurt for Attach
Requests which are the only messages that initially trigger the
authentication yet.
This patch changes the order of the 'if' clause to match the
processing order, it removes the t3350_mode parameter entirely and
introduces a mm->pending_req field. The latter must be set when the
request that causes the authorization before calling
gsm48_gmm_authorize. The gprs_t3350_mode enum is extended by
GMM_T3350_MODE_NONE (value 0, which is the default) to make it
possible to detect related initialisation errors or race conditions.
Sponsored-by: On-Waves ehf
-----------------------------------------------------------------------
Summary of changes:
openbsc/include/openbsc/gprs_gmm.h | 5 +-
openbsc/include/openbsc/gprs_sgsn.h | 35 ++-
openbsc/include/openbsc/gsm_subscriber.h | 4 +
openbsc/include/openbsc/sgsn.h | 8 +-
openbsc/src/gprs/gprs_gmm.c | 264 +++++++++++++++++------
openbsc/src/gprs/gprs_sgsn.c | 8 +-
openbsc/src/gprs/sgsn_auth.c | 102 ++++++++-
openbsc/src/gprs/sgsn_main.c | 4 +-
openbsc/src/gprs/sgsn_vty.c | 25 ++-
openbsc/tests/sgsn/sgsn_test.c | 352 ++++++++++++++++++++++++++++++-
openbsc/tests/sgsn/sgsn_test.ok | 10 +
openbsc/tests/vty_test_runner.py | 69 ++++++
12 files changed, 792 insertions(+), 94 deletions(-)
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, jerlbeck/wip/gprs-patching has been updated
discards dd15d7cf6c51f254c8356fca8dd47af000bc8cab (commit)
discards 0a9dcc451a7183976acbb002e18a5c4df49ceccc (commit)
discards df18ef6a8274e2fcc6a535330a8c597c80c961ae (commit)
discards 7c608eeffca7293723716fd0d96733f869a064ae (commit)
discards 0c35de23f88097264deba8348224dfe9afeba156 (commit)
discards c177731fae604a3b59add47541d124144311e034 (commit)
discards 817d01a640fdd8ad0a27d77832f3609d720cfa15 (commit)
via 4193f174dd6cdaabf2d4319faec463261a37d5af (commit)
via 95f84db2402d458fd5b3d899f08cb33ec9cd3212 (commit)
via 7518cdd42e257e70d9ec52ebb3567ab2df1472d6 (commit)
via dd9645c9e2cf910bd30abedecc086e7207bdce92 (commit)
via aa5dd818449d27659cb9e8b10d69ba3e9f875097 (commit)
via 6e8c0bd7c97273f0ab171471a4725447ade17ae3 (commit)
via a374e69d392dc4cfccf7a367c74961b2786bbc90 (commit)
This update added new revisions after undoing existing revisions. That is
to say, the old revision is not a strict subset of the new revision. This
situation occurs when you --force push a change and generate a repository
containing something like this:
* -- * -- B -- O -- O -- O (dd15d7cf6c51f254c8356fca8dd47af000bc8cab)
\
N -- N -- N (4193f174dd6cdaabf2d4319faec463261a37d5af)
When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=4193f174dd6cdaabf2d4319faec46326…
commit 4193f174dd6cdaabf2d4319faec463261a37d5af
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Sep 30 13:53:26 2014 +0200
sgsn: Added TODOs (TODO)
TODO:
- fix and remove TODOs
- add test cases for Detach(reattach)
- add test cases for PDP context deletion (OW#1311)
- add test cases for Cancel pending timer in sgsn_mm_ctx_free
- remove this commit
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=95f84db2402d458fd5b3d899f08cb33e…
commit 95f84db2402d458fd5b3d899f08cb33ec9cd3212
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Nov 4 12:44:15 2014 +0100
sgsn: Notify an affected MM context if an ACL rule is removed (TODO)
Currently if an ACL access rule is removed, MS already attached are
not affected until they try to reattach to the SGSN.
This patch adds sgsn_auth_update_all() that iterates through allMM
contexts and calls sgsn_auth_update() on each of them. This function
is then called when 'imsi-acl del IMSI' is executed after the ACL has
been removed.
TODO:
- decide, whether ito replace that by a dedicated update command in
the VTY ENABLE node
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=7518cdd42e257e70d9ec52ebb3567ab2…
commit 7518cdd42e257e70d9ec52ebb3567ab2df1472d6
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Oct 17 10:08:02 2014 +0200
sgsn: Do not die in _bssgp_tx_dl_ud on TLLI mismatch (TODO)
Currently an OSMO_ASSERT fails, if the message's and the mmctx's
TLLIs do not match.
This commit turns the assertion into an ERROR log message and uses
the default values for IMSI, DRX, and RA CAP instead of the MM
context values in this case.
TODO:
- find the real source for the problem
- add test cases derived from what is being described in the ticket
Ticket: OW#1322
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=dd9645c9e2cf910bd30abedecc086e72…
commit dd9645c9e2cf910bd30abedecc086e7207bdce92
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Nov 11 14:01:48 2014 +0100
sgsn: Add VTY commands to manage subscriber cache
This adds the following commands to the ENABLE node:
- show subscriber cache
- update-subscriber imsi IMSI insert authorized (0|1)
- update-subscriber imsi IMSI cancel
These commands are mainly testing tools and maintenance helpers. The
update commands work asynchronously and can be used to complete a
pending update request or to terminate an existing connection.
Note that the subscriber cache is not stored persistently and will
always be empty after an SGSN restart.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=aa5dd818449d27659cb9e8b10d69ba3e…
commit aa5dd818449d27659cb9e8b10d69ba3e9f875097
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Nov 11 14:47:38 2014 +0100
sgsn: Add gsm0408_gprs_access_cancelled (TODO)
This function is called to delete an established MM context
without invoking a detach procedure that could disable the GPRS
functionality of the MS until the next power cycle.
It is called when a subscriber is cancelled.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=6e8c0bd7c97273f0ab171471a4725447…
commit 6e8c0bd7c97273f0ab171471a4725447ade17ae3
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Wed Nov 12 10:18:09 2014 +0100
sgsn: Integrate subscriber handling into the SGSN (TODO)
This commit adds a new authorization policy 'remote' and uses
the subscriber cache for authorization when this policy is being used.
Note that there is no remote backend implemented yet.
TODO:
- tests
- decide, whether 'remote' could be named better, e.g. sth based on
'subscriber'
Ticket: OW#????
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=a374e69d392dc4cfccf7a367c74961b2…
commit a374e69d392dc4cfccf7a367c74961b2786bbc90
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Wed Nov 12 10:12:11 2014 +0100
sgsn: Add gprs_subscriber.c
This patch adds GPRS specific functions for gsm_subscriber objects
(allocation, retrieval, deletion) and subscriber data
requests/updates. The sgsn_update_subscriber_data callback is used to
notify the sgsn about updates and is extended by a parameter that
passes a reference to a gsm_subscriber.
Sponsored-by: On-Waves ehf
-----------------------------------------------------------------------
Summary of changes:
openbsc/tests/sgsn/Makefile.am | 3 +++
openbsc/tests/sgsn/sgsn_test.c | 47 ++++++++++++++++++++++++++++++++++++++++++
2 files changed, 50 insertions(+)
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, jerlbeck/wip/gprs-patching has been updated
discards 24b1a8bf002583822cae8726e7ae2c3574421f35 (commit)
discards 7cef2c1fa8c7a59ea46781166d2fd067b44b6f8d (commit)
discards 170b60d84192ccc65ed480490220d2f829212b99 (commit)
discards 7158c0d5c7ecb5a3fe45704dd0adf932e492fecb (commit)
discards 83aba155f4bbab37aa9e5036018feb33fb780f1f (commit)
discards cea90341104665f67680d262ea49a4e7e34f5fb4 (commit)
discards 97e2eb3ad1305d35c59be88ce544684386a19998 (commit)
discards e981df3e20d9ec9f7c83b0b359b5f093df42a8fa (commit)
via dd15d7cf6c51f254c8356fca8dd47af000bc8cab (commit)
via 0a9dcc451a7183976acbb002e18a5c4df49ceccc (commit)
via df18ef6a8274e2fcc6a535330a8c597c80c961ae (commit)
via 7c608eeffca7293723716fd0d96733f869a064ae (commit)
via 0c35de23f88097264deba8348224dfe9afeba156 (commit)
via c177731fae604a3b59add47541d124144311e034 (commit)
via 817d01a640fdd8ad0a27d77832f3609d720cfa15 (commit)
via 4cc973bce2eded371712ec73475d6d62c4aa91e7 (commit)
This update added new revisions after undoing existing revisions. That is
to say, the old revision is not a strict subset of the new revision. This
situation occurs when you --force push a change and generate a repository
containing something like this:
* -- * -- B -- O -- O -- O (24b1a8bf002583822cae8726e7ae2c3574421f35)
\
N -- N -- N (dd15d7cf6c51f254c8356fca8dd47af000bc8cab)
When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=dd15d7cf6c51f254c8356fca8dd47af0…
commit dd15d7cf6c51f254c8356fca8dd47af000bc8cab
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Sep 30 13:53:26 2014 +0200
sgsn: Added TODOs (TODO)
TODO:
- fix and remove TODOs
- add test cases for Detach(reattach)
- add test cases for PDP context deletion (OW#1311)
- add test cases for Cancel pending timer in sgsn_mm_ctx_free
- remove this commit
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=0a9dcc451a7183976acbb002e18a5c4d…
commit 0a9dcc451a7183976acbb002e18a5c4df49ceccc
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Nov 4 12:44:15 2014 +0100
sgsn: Notify an affected MM context if an ACL rule is removed (TODO)
Currently if an ACL access rule is removed, MS already attached are
not affected until they try to reattach to the SGSN.
This patch adds sgsn_auth_update_all() that iterates through allMM
contexts and calls sgsn_auth_update() on each of them. This function
is then called when 'imsi-acl del IMSI' is executed after the ACL has
been removed.
TODO:
- decide, whether ito replace that by a dedicated update command in
the VTY ENABLE node
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=df18ef6a8274e2fcc6a535330a8c597c…
commit df18ef6a8274e2fcc6a535330a8c597c80c961ae
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Oct 17 10:08:02 2014 +0200
sgsn: Do not die in _bssgp_tx_dl_ud on TLLI mismatch (TODO)
Currently an OSMO_ASSERT fails, if the message's and the mmctx's
TLLIs do not match.
This commit turns the assertion into an ERROR log message and uses
the default values for IMSI, DRX, and RA CAP instead of the MM
context values in this case.
TODO:
- find the real source for the problem
- add test cases derived from what is being described in the ticket
Ticket: OW#1322
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=7c608eeffca7293723716fd0d96733f8…
commit 7c608eeffca7293723716fd0d96733f869a064ae
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Nov 11 14:01:48 2014 +0100
sgsn: Add VTY commands to manage subscriber cache
This adds the following commands to the ENABLE node:
- show subscriber cache
- update-subscriber imsi IMSI insert authorized (0|1)
- update-subscriber imsi IMSI cancel
These commands are mainly testing tools and maintenance helpers. The
update commands work asynchronously and can be used to complete a
pending update request or to terminate an existing connection.
Note that the subscriber cache is not stored persistently and will
always be empty after an SGSN restart.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=0c35de23f88097264deba8348224dfe9…
commit 0c35de23f88097264deba8348224dfe9afeba156
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Nov 11 14:47:38 2014 +0100
sgsn: Add gsm0408_gprs_access_cancelled (TODO)
This function is called to delete an established MM context
without invoking a detach procedure that could disable the GPRS
functionality of the MS until the next power cycle.
It is called when a subscriber is cancelled.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=c177731fae604a3b59add47541d12414…
commit c177731fae604a3b59add47541d124144311e034
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Wed Nov 12 10:18:09 2014 +0100
sgsn: Integrate subscriber handling into the SGSN (TODO)
This commit adds a new authorization policy 'remote' and uses
the subscriber cache for authorization when this policy is being used.
Note that there is no remote backend implemented yet.
TODO:
- tests
- decide, whether 'remote' could be named better, e.g. sth based on
'subscriber'
Ticket: OW#????
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=817d01a640fdd8ad0a27d77832f3609d…
commit 817d01a640fdd8ad0a27d77832f3609d720cfa15
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Wed Nov 12 10:12:11 2014 +0100
sgsn: Add gprs_subscriber.c
This patch adds GPRS specific functions for gsm_subscriber objects
(allocation, retrieval, deletion) and subscriber data
requests/updates. The sgsn_update_subscriber_data callback is used to
notify the sgsn about updates and is extended by a parameter that
passes a reference to a gsm_subscriber.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=4cc973bce2eded371712ec73475d6d62…
commit 4cc973bce2eded371712ec73475d6d62c4aa91e7
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Wed Nov 12 09:53:45 2014 +0100
sgsn: Cross-link gsm_subscriber and sgsn_mm_ctx
To implement subscriber based authorization a data structure is
needed that keeps the subscriber data. The MSC already uses a similar
struct named gsm_subscriber whose implementation is split into a
generic part (allocation, retrieval, reference counting, list
maintenance) and MSC related parts. For GPRS, only the generic part
will be used and specific fields may be added when needed.
This patch adds a field mm to struct gsm_subscriber that will be used
by the SGSN to store a reference to the current MM context (or NULL
if there is none). This also adds a field subscr to struct
sgsn_mm_ctx that reversely points to a gsm_subscriber (or NULL if
there is none). Either both fields are NULL or both fields are
non-NULL. Note that subscr is being reference counted.
Sponsored-by: On-Waves ehf
-----------------------------------------------------------------------
Summary of changes:
openbsc/tests/sgsn/sgsn_test.c | 49 ++++++++++++++++++++++++++++++++++++++++-
openbsc/tests/sgsn/sgsn_test.ok | 1 +
2 files changed, 49 insertions(+), 1 deletion(-)
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, jerlbeck/wip/gprs-patching has been updated
discards f61013282c9aee2287bc901261c025f55cc34399 (commit)
discards d568ce8d2e751553edb2e39c101a813572720b5b (commit)
discards 90a1647f413b5113f9e3e0fd8dabf78a00e984c9 (commit)
discards a14c0882329fbb1bf139bc5d9945758c3d06d575 (commit)
discards 56f869d67f8ae3160a5821df28b688f8b16beace (commit)
discards 25a2b945cee417df29ce14d8b92744416db2611b (commit)
discards b7def117ed68d8e99e1488bab2dbcb80ea60b2e6 (commit)
discards 42ae521031e8d705baf5132471d51780310fb787 (commit)
discards 66789456de5982e1caa053a59037cc45cd853d8a (commit)
discards 6d65e861ac5d955ed3746ea513b41a4600bd6ed7 (commit)
discards e4537ac238e033dc04606139489ee94571fcb991 (commit)
discards 6a41825bd4f3d222bae2bf34593c50dcda671882 (commit)
via 24b1a8bf002583822cae8726e7ae2c3574421f35 (commit)
via 7cef2c1fa8c7a59ea46781166d2fd067b44b6f8d (commit)
via 170b60d84192ccc65ed480490220d2f829212b99 (commit)
via 7158c0d5c7ecb5a3fe45704dd0adf932e492fecb (commit)
via 83aba155f4bbab37aa9e5036018feb33fb780f1f (commit)
via cea90341104665f67680d262ea49a4e7e34f5fb4 (commit)
via 97e2eb3ad1305d35c59be88ce544684386a19998 (commit)
via e981df3e20d9ec9f7c83b0b359b5f093df42a8fa (commit)
via 9cc7a20c65bc881ea8e0f4084efac7180266b239 (commit)
via e99d24e9f00bc55e3c215fb3c0380171ccacebfd (commit)
via 744c7874f51c98c1ccf33814b2a88e0aeab34472 (commit)
via 2b35c1709abf42c9d250e280a18eb7886a3f4b37 (commit)
via 5465f915bf4dcebb89171a9cf9f78a9e1b7c4f7f (commit)
This update added new revisions after undoing existing revisions. That is
to say, the old revision is not a strict subset of the new revision. This
situation occurs when you --force push a change and generate a repository
containing something like this:
* -- * -- B -- O -- O -- O (f61013282c9aee2287bc901261c025f55cc34399)
\
N -- N -- N (24b1a8bf002583822cae8726e7ae2c3574421f35)
When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=24b1a8bf002583822cae8726e7ae2c35…
commit 24b1a8bf002583822cae8726e7ae2c3574421f35
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Sep 30 13:53:26 2014 +0200
sgsn: Added TODOs (TODO)
TODO:
- fix and remove TODOs
- add test cases for Detach(reattach)
- add test cases for PDP context deletion (OW#1311)
- add test cases for Cancel pending timer in sgsn_mm_ctx_free
- remove this commit
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=7cef2c1fa8c7a59ea46781166d2fd067…
commit 7cef2c1fa8c7a59ea46781166d2fd067b44b6f8d
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Nov 4 12:44:15 2014 +0100
sgsn: Notify an affected MM context if an ACL rule is removed (TODO)
Currently if an ACL access rule is removed, MS already attached are
not affected until they try to reattach to the SGSN.
This patch adds sgsn_auth_update_all() that iterates through allMM
contexts and calls sgsn_auth_update() on each of them. This function
is then called when 'imsi-acl del IMSI' is executed after the ACL has
been removed.
TODO:
- decide, whether ito replace that by a dedicated update command in
the VTY ENABLE node
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=170b60d84192ccc65ed480490220d2f8…
commit 170b60d84192ccc65ed480490220d2f829212b99
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Oct 17 10:08:02 2014 +0200
sgsn: Do not die in _bssgp_tx_dl_ud on TLLI mismatch (TODO)
Currently an OSMO_ASSERT fails, if the message's and the mmctx's
TLLIs do not match.
This commit turns the assertion into an ERROR log message and uses
the default values for IMSI, DRX, and RA CAP instead of the MM
context values in this case.
TODO:
- find the real source for the problem
- add test cases derived from what is being described in the ticket
Ticket: OW#1322
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=7158c0d5c7ecb5a3fe45704dd0adf932…
commit 7158c0d5c7ecb5a3fe45704dd0adf932e492fecb
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Nov 11 14:01:48 2014 +0100
sgsn: Add VTY commands to manage subscriber cache
This adds the following commands to the ENABLE node:
- show subscriber cache
- update-subscriber imsi IMSI insert authorized (0|1)
- update-subscriber imsi IMSI cancel
These commands are mainly testing tools and maintenance helpers. The
update commands work asynchronously and can be used to complete a
pending update request or to terminate an existing connection.
Note that the subscriber cache is not stored persistently and will
always be empty after an SGSN restart.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=83aba155f4bbab37aa9e5036018feb33…
commit 83aba155f4bbab37aa9e5036018feb33fb780f1f
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Nov 11 14:47:38 2014 +0100
sgsn: Add gsm0408_gprs_access_cancelled (TODO)
This function is called to delete an established MM context
without invoking a detach procedure that could disable the GPRS
functionality of the MS until the next power cycle.
It is called when a subscriber is cancelled.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=cea90341104665f67680d262ea49a4e7…
commit cea90341104665f67680d262ea49a4e7e34f5fb4
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Wed Nov 12 10:18:09 2014 +0100
sgsn: Integrate subscriber handling into the SGSN (TODO)
This commit adds a new authorization policy 'remote' and uses
the subscriber cache for authorization when this policy is being used.
Note that there is no remote backend implemented yet.
TODO:
- tests
- decide, whether 'remote' could be named better, e.g. sth based on
'subscriber'
Ticket: OW#????
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=97e2eb3ad1305d35c59be88ce5446843…
commit 97e2eb3ad1305d35c59be88ce544684386a19998
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Wed Nov 12 10:12:11 2014 +0100
sgsn: Add gprs_subscriber.c (TODO)
This adds GPRS specific functions for gsm_subscriber objects. The
sgsn_update_subscriber_data callback is extended by a parameter that passes a reference to a gsm_subscriber.
TODO:
- tests
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=e981df3e20d9ec9f7c83b0b359b5f093…
commit e981df3e20d9ec9f7c83b0b359b5f093df42a8fa
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Wed Nov 12 09:53:45 2014 +0100
sgsn: Extend gsm_subscriber and sgsn_mm_ctx by references
This adds a field mm to struct gsm_subscriber that will be used by
the SGSN to store a reference to the current MM context (or NULL if
there is none). This also adds a field subscr to struct sgsn_mm_ctx
that reversely points to a gsm_subscriber (or NULL if there is none).
Either both fields are NULL or both fields are non-NULL. Note that
subscr is being reference counted.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=9cc7a20c65bc881ea8e0f4084efac718…
commit 9cc7a20c65bc881ea8e0f4084efac7180266b239
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Nov 13 10:48:39 2014 +0100
sgsn: Remove explicit sgsn_instance parameters
Currently the function in sgsn_auth.c either have an sgsn_config or
an sgsn_instance parameter. Since then global sgsn variable is
already being used in that file and since other parts of the SGSN
related code also rely on a global sgsn singleton, these parameters
pretend to provide a flexibility that is not really supported.
Therefore this patch removes these parameters except for the ACL
related functions, which do not call code that uses the sgsn
variable.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=e99d24e9f00bc55e3c215fb3c0380171…
commit e99d24e9f00bc55e3c215fb3c0380171ccacebfd
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Nov 7 14:17:44 2014 +0100
sgsn: Refactor sgsn_auth to separate request and authorization
Currently the authorization is done in sgsn_auth_request for ACL
based authorization. This doesn't match the way remote authorization
would work, so that there is a second call to sgsn_auth_state already
present in sgsn_auth_update.
This patch removes the autorization check completely from
sgsn_auth_request which in turn calls sgsn_auth_update directly now.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=744c7874f51c98c1ccf33814b2a88e0a…
commit 744c7874f51c98c1ccf33814b2a88e0aeab34472
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Nov 6 15:43:10 2014 +0100
sgsn: Don't assign a new P-TMSI if one is pending
Currently every time an RA Update Req or an Attach Req is processed, a
new P-TMSI is allocated. When an MS issues another of these messages
before it has completed the first procedure, old_ptmsi is replaced by
ptmsi (and thus lost) and ptmsi is replaced by the newly allocated
P-TMSI. This can confuse the gbproxy, which can loose track of the
logical link then. At least a Blackberry emits a double set of RA Upd
Req messages from time to time which may be just 20ms apart.
This patch adds a check whether mm->ptmsi or mm->old_ptmsi are set.
If both are set, the P-TMSI is not re-allocated. This is only the
case, when the Complete message has not been received yet, since that
message will reset old_ptmsi.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=2b35c1709abf42c9d250e280a18eb788…
commit 2b35c1709abf42c9d250e280a18eb7886a3f4b37
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Nov 11 08:55:13 2014 +0100
sgsn: Don't send XID reset after Detach Accept
Currently when a Detach Accept is received for an unknown TLLI (which
is in general the case afer the SGSN has requested the detachment),
an XID reset is sent to the BSS, causing a BSSGP Status message. This
happens in gsm0408_rcv_gmm.
This patch moves the corresponding call to gprs_llgmm_reset downwards
so that it is not being called in that case.
Addresses:
SGSN->BSS TLLI: 0xd75b91d9 SAPI: LLGMM, UI (DTAP) (GMM) Detach Request
BSS->SGSN TLLI: 0xd75b91d9 SAPI: LLGMM, UI (DTAP) (GMM) Detach Accept
SGSN->BSS TLLI: 0xd75b91d9 SAPI: LLGMM, U, XID (Reset, IOV-UI)
BSS->SGSN TLLI: --- BSSGP STATUS (Unknown MS)
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=5465f915bf4dcebb89171a9cf9f78a9e…
commit 5465f915bf4dcebb89171a9cf9f78a9e1b7c4f7f
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Nov 6 13:43:41 2014 +0100
sgsn: Cleanup after RA Update Reject / Attach Reject
Currently, the LLME is not cleanup up after sending an RA Update
Reject. This happens after entering a routing area from outside,
since in that case the SGSN sends an RA Update Reject (implicitly
detached) which causes the MS to restart the attach procedure.
The LLME is also not updated if an Attach Request with message errors
(encoding, invalid MI type) is received or if an MM context cannot be
allocated.
This patch changes gsm48_rx_gmm_ra_upd_req and gsm48_rx_gmm_att_req
to unassign the LLME or free the MM context (if available) after a
Reject message has been sent.
Ticket: OW#1324
Sponsored-by: On-Waves ehf
-----------------------------------------------------------------------
Summary of changes:
openbsc/include/openbsc/gprs_sgsn.h | 10 +-
openbsc/src/gprs/gprs_gmm.c | 6 +-
openbsc/src/gprs/gprs_sgsn.c | 2 +-
openbsc/src/gprs/sgsn_auth.c | 29 +++---
openbsc/src/gprs/sgsn_main.c | 2 +-
openbsc/src/gprs/sgsn_vty.c | 7 +-
openbsc/tests/sgsn/sgsn_test.c | 194 +++++++++++++++++++++++++++++++++++-
openbsc/tests/sgsn/sgsn_test.ok | 4 +
8 files changed, 224 insertions(+), 30 deletions(-)
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, jerlbeck/wip/gprs-patching has been updated
discards c93f898e6de4dfc3328b206cd2b8724c6c133215 (commit)
discards 6d1dc3c02f5a2839e998c7ec1275270d49b9db9e (commit)
discards d49b478c9b91a14daf37de826533fb793827939e (commit)
discards c09bee263d257e6f7ac574a542057c2181cd5da8 (commit)
discards 1fcb88a3db244830c07f28dcde6467ba3ac9239d (commit)
discards 5b98e682e5985fe60a9ebdaae8134a305021ff25 (commit)
discards 418c164fa36acbe33b2ec75eccbbba551f62a844 (commit)
discards f12e41de7dc441f8c2837f792853511a0e038ddb (commit)
discards 3191e00c847cd780d220aa7c9b50c2a5906217a4 (commit)
discards e0e0217321efd2d1103d9fa4e73a7a116fa83c6e (commit)
discards b460f57502f7a0cc21a5171f877d9528c144c7f7 (commit)
discards 3245dbc7a695da12e88991918f73dc8abea8c3fe (commit)
discards b88c41d64c2b2df18fc578f996f00cdd76f222af (commit)
discards 56e655632df54283b3634e2a2e2dac96710830ff (commit)
discards 79a481bfc005283221f300b01efdefad4dcdb9d3 (commit)
discards 8e2148ab0ec232b50484c01876316f1417822bde (commit)
discards a312c4bb27e6dd1fa03e78138370d583570380d6 (commit)
discards 81b6311deaaac6fe97ba11eee94dc922b6b16e14 (commit)
discards 5bc648f29af30528349aaabcce8c962210a7b50f (commit)
discards db483b72f1c8e2c397f88baa05b6b53f76362a04 (commit)
discards 7d8e8b9a13b3b2ea8404581f980869b711617e2e (commit)
discards 2c00b904bb31f807c501c26addcc046ca8496521 (commit)
discards f9330da55561d3cad6220e8c0a6dea53990309fc (commit)
via f61013282c9aee2287bc901261c025f55cc34399 (commit)
via d568ce8d2e751553edb2e39c101a813572720b5b (commit)
via 90a1647f413b5113f9e3e0fd8dabf78a00e984c9 (commit)
via a14c0882329fbb1bf139bc5d9945758c3d06d575 (commit)
via 56f869d67f8ae3160a5821df28b688f8b16beace (commit)
via 25a2b945cee417df29ce14d8b92744416db2611b (commit)
via b7def117ed68d8e99e1488bab2dbcb80ea60b2e6 (commit)
via 42ae521031e8d705baf5132471d51780310fb787 (commit)
via 66789456de5982e1caa053a59037cc45cd853d8a (commit)
via 6d65e861ac5d955ed3746ea513b41a4600bd6ed7 (commit)
via e4537ac238e033dc04606139489ee94571fcb991 (commit)
via 6a41825bd4f3d222bae2bf34593c50dcda671882 (commit)
via ad30d8d3b3af86a789e42ab3804f14aba98c43e0 (commit)
via 49ac6fcf3bd39aa6f1fa19fb199de6e45bf1e2f6 (commit)
via c11c6b97f6c20739a39edc10cf5988c2583b951e (commit)
via 40415c5655d5f5b67c557f733f0c47b2d60eae88 (commit)
via be35395defcd81d7661365b97c072711e0e55d23 (commit)
via a00c3bd090b024f116c6e134b668cade04b535c1 (commit)
via 62a432c7db59c3004a9fc3272d46a6cc9c4269aa (commit)
via 584bf98d87497381ea30526d73899d3a5542eb61 (commit)
via b8242b0c2422a948fdce005558fc8e5738555ff0 (commit)
via acc28f5fa7b9c1ad607bddb47429a04a068c14ef (commit)
via 3911880b68ddd92c9dd89d6ac20c26807e33f905 (commit)
via cdd4302c6dde84693a16b33362a75061480333cd (commit)
via 27cb4d57e049b173fb4cacc78b947f70c691c111 (commit)
via 94ef1c0da9a80869256e6a5966d1f1571955c813 (commit)
via 41108680293f703da976efe64ea8388ef7a2cd7e (commit)
via 0d8ac0eac0a919cb2620d94e661d60b2a96501d3 (commit)
via 054bc24e6dc700d4b8e8eec647cbead63454671e (commit)
via 74b2028167ddf04a867ae9f269bfa3435c93f252 (commit)
This update added new revisions after undoing existing revisions. That is
to say, the old revision is not a strict subset of the new revision. This
situation occurs when you --force push a change and generate a repository
containing something like this:
* -- * -- B -- O -- O -- O (c93f898e6de4dfc3328b206cd2b8724c6c133215)
\
N -- N -- N (f61013282c9aee2287bc901261c025f55cc34399)
When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=f61013282c9aee2287bc901261c025f5…
commit f61013282c9aee2287bc901261c025f55cc34399
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Nov 11 14:01:48 2014 +0100
sgsn: Add VTY commands to manage subscriber cache
This adds the following commands to the ENABLE node:
- show subscriber cache
- update-subscriber imsi IMSI insert authorized (0|1)
- update-subscriber imsi IMSI cancel
These commands are mainly testing tools and maintenance helpers. The
update commands work asynchronously and can be used to complete a
pending update request or to terminate an existing connection.
Note that the subscriber cache is not stored persistently and will
always be empty after an SGSN restart.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=d568ce8d2e751553edb2e39c101a8135…
commit d568ce8d2e751553edb2e39c101a813572720b5b
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Nov 11 14:47:38 2014 +0100
sgsn: Add gsm0408_gprs_access_cancelled (TODO)
This function is called to delete an established MM context
without invoking a detach procedure that could disable the GPRS
functionality of the MS until the next power cycle.
It is called when a subscriber is cancelled.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=90a1647f413b5113f9e3e0fd8dabf78a…
commit 90a1647f413b5113f9e3e0fd8dabf78a00e984c9
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Wed Nov 12 10:18:09 2014 +0100
sgsn: Integrate subscriber handling into the SGSN (TODO)
This commit adds a new authorization policy 'remote' and uses
the subscriber cache for authorization when this policy is being used.
Note that there is no remote backend implemented yet.
TODO:
- tests
Ticket: OW#????
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=a14c0882329fbb1bf139bc5d9945758c…
commit a14c0882329fbb1bf139bc5d9945758c3d06d575
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Wed Nov 12 10:12:11 2014 +0100
sgsn: Add gprs_subscriber.c (TODO)
This adds GPRS specific functions for gsm_subscriber objects. The
sgsn_update_subscriber_data callback is extended by a parameter that passes a reference to a gsm_subscriber.
TODO:
- tests
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=56f869d67f8ae3160a5821df28b688f8…
commit 56f869d67f8ae3160a5821df28b688f8b16beace
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Wed Nov 12 09:53:45 2014 +0100
sgsn: Extend gsm_subscriber and sgsn_mm_ctx by references
This adds a field mm to struct gsm_subscriber that will be used by
the SGSN to store a reference to the current MM context (or NULL if
there is none). This also adds a field subscr to struct sgsn_mm_ctx
that reversely points to a gsm_subscriber (or NULL if there is none).
Either both fields are NULL or both fields are non-NULL. Note that
subscr is being reference counted.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=25a2b945cee417df29ce14d8b9274441…
commit 25a2b945cee417df29ce14d8b92744416db2611b
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Nov 7 14:17:44 2014 +0100
sgsn: Refactor sgsn_auth to separate request and authorization (TODO)
Currently the authorization is done in sgsn_auth_request for ACL
based authorization. This doesn't match the way remote authorization
would work, so that there is a second call to sgsn_auth_state already
present in sgsn_auth_update.
This patch removes the autorization check completely from
sgsn_auth_request which in turn now calls sgsn_auth_update directly.
TODO:
- Use sgsn_instance instead of config as parameter
- more commit message text
Ticket: OW#????
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=b7def117ed68d8e99e1488bab2dbcb80…
commit b7def117ed68d8e99e1488bab2dbcb80ea60b2e6
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Nov 6 15:43:10 2014 +0100
sgsn: Don't assign a new P-TMSI if one is pending (TODO)
Currently every time a RA Update Req or an Attach Req is processed, a
new P-TMSI is alocated. When an MS issues another of these messages
before it has completed the first procedure, old_ptmsi is replaced by
ptmsi (and thus lost) and ptmsi is replaced by the newly allocated
P-TMSI. This can confuse the gbproxy, which can loose track of the
logical link then. At least a blackberry emits a double set of RA Upd
Req messages from time to time which may be just 20ms apart.
This patch adds a check whether mm->ptmsi or mm->old_ptmsi are not
both set. If both are set, the P-TMSI is not re-allocated. This is
only the case, if the Complete message has not been received since
that resets old_ptmsi.
TODO:
- Test case
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=42ae521031e8d705baf5132471d51780…
commit 42ae521031e8d705baf5132471d51780310fb787
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Sep 30 13:53:26 2014 +0200
sgsn: Added TODOs (TODO)
TODO:
- fix and remove TODOs
- add test cases for Detach(reattach)
- add test cases for PDP context deletion (OW#1311)
- add test cases for Cancel pending timer in sgsn_mm_ctx_free
- remove this commit
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=66789456de5982e1caa053a59037cc45…
commit 66789456de5982e1caa053a59037cc45cd853d8a
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Oct 17 10:08:02 2014 +0200
sgsn: Do not die in _bssgp_tx_dl_ud on TLLI mismatch (TODO)
Currently an OSMO_ASSERT fails, if the message's and the mmctx's
TLLIs do not match.
This commit turns the assertion into an ERROR log message and uses
the default values for IMSI, DRX, and RA CAP instead of the MM
context values in this case.
TODO:
- find the real source for the problem
- add test cases derived from what is being described in the ticket
Ticket: OW#1322
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=6d65e861ac5d955ed3746ea513b41a46…
commit 6d65e861ac5d955ed3746ea513b41a4600bd6ed7
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Nov 11 08:55:13 2014 +0100
sgsn: Don't send XID reset after Detach Accept
Currently when a Detach Accept is received for an unknown TLLI (which
is in general the case afer the SGSN has requested the detachment),
an XID reset is sent to the BSS, causing a BSSGP Status message. This
happens in gsm0408_rcv_gmm.
This patch moves the corresponding call to gprs_llgmm_reset downwards
so that it is not being called in that case.
Addresses:
SGSN->BSS TLLI: 0xd75b91d9 SAPI: LLGMM, UI (DTAP) (GMM) Detach Request
BSS->SGSN TLLI: 0xd75b91d9 SAPI: LLGMM, UI (DTAP) (GMM) Detach Accept
SGSN->BSS TLLI: 0xd75b91d9 SAPI: LLGMM, U, XID (Reset, IOV-UI)
BSS->SGSN TLLI: --- BSSGP STATUS (Unknown MS)
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=e4537ac238e033dc04606139489ee945…
commit e4537ac238e033dc04606139489ee94571fcb991
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Nov 6 13:43:41 2014 +0100
sgsn: Cleanup after RA Update Reject / Attach Reject
Currently, the LLME is not cleanup up after sending an RA Update
Reject. This happens after entering a routing area from outside,
since in that case the SGSN sends an RA Update Reject (implicitly
detached) which causes the MS to restart the attach procedure.
The LLME is also not updated if an Attach Request with message errors
(encoding, invalid MI type) is received or if an MM context cannot be
allocated.
This patch changes gsm48_rx_gmm_ra_upd_req and gsm48_rx_gmm_att_req
to unassign the LLME or free the MM context (if available) after a
Reject message has been sent.
Ticket: OW#1324
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=6a41825bd4f3d222bae2bf34593c50dc…
commit 6a41825bd4f3d222bae2bf34593c50dcda671882
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Nov 4 12:44:15 2014 +0100
sgsn: Notify an affected MM context if an ACL rule is removed
Currently if an ACL access rule is removed, MS already attached are
not affected until they try to reattach to the SGSN.
This patch extends sgsn_acl_del to re-authenticate an MM context if
it matches the IMSI.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=ad30d8d3b3af86a789e42ab3804f14ab…
commit ad30d8d3b3af86a789e42ab3804f14aba98c43e0
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Nov 4 10:08:37 2014 +0100
sgsn: Add 'acl-only' authentication policy
Currently the VTY 'auth-policy' command results in setting or clearing
the acl_enabled flag. This also enables the matching of the MCC/MNC
prefix of the IMSI.
This patch adds an additional policy 'acl-only' which disables the
MCC/MNC matching and relies on the ACL only.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=49ac6fcf3bd39aa6f1fa19fb199de6e4…
commit 49ac6fcf3bd39aa6f1fa19fb199de6e45bf1e2f6
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Nov 4 11:15:01 2014 +0100
sgsn/test: Add VTY tests for the SGSN
This patch adds some basic SGSN tests to vty_test_runner.py:
- check for config tree nodes
- check specific show commands
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=c11c6b97f6c20739a39edc10cf5988c2…
commit c11c6b97f6c20739a39edc10cf5988c2583b951e
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Oct 24 18:09:54 2014 +0200
sgsn: Make authorization asynchronous
Currently the authorization of an IMSI is done by checking ACLs
synchronously which is not feasible when the subscriber data has to
be retrieved from an external source.
This patch changes this by using a callback when the information is
available. This is also done when only ACL are checked, in this case
the callback is invoked from within sgsn_auth_request(). The callback
function sgsn_update_subscriber_data calls sgsn_auth_update which
in turn calls either gsm0408_gprs_access_granted or
gsm0408_gprs_access_denied. gsm48_gmm_authorize is extended by a call
to sgsn_auth_request when IMSI and IMEI are available but the
auth_state is unknown.
The change has been successfully tested with single phones (E71 and
IPhone 5c).
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=40415c5655d5f5b67c557f733f0c47b2…
commit 40415c5655d5f5b67c557f733f0c47b2d60eae88
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Wed Oct 29 22:12:20 2014 +0100
sgsn: Move IMSI authorization to gsm48_gmm_authorize
Currently the IMSI is only checked immediately when an Attach Request
is received that contains an IMSI IE. If it contains a P-TMSI
instead, access is always granted.
This commit moves the IMSI check to gsm48_gmm_authorize where it is
applied when IMSI and IMEI have been acquired. This fixes the
authorization when the Attach Accept doesn't contain an IMSI.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=be35395defcd81d7661365b97c072711…
commit be35395defcd81d7661365b97c072711e0e55d23
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Oct 31 12:27:11 2014 +0100
sgsn: Fix LLME leak when forcing a reattach
Currently when forceing a reattach by sending a Detach
Request (reattach), the SGSN waits for the Detach Accept until it
frees the MM context (if present) and the LLME. If that message gets
lost or isn't sent by the MS, the LLME is never freed if it isn't
bound to an MM context.
This patch adds code to free the MM context/LLME when forcing a
reattachment.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=a00c3bd090b024f116c6e134b668cade…
commit a00c3bd090b024f116c6e134b668cade04b535c1
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Oct 31 12:20:49 2014 +0100
sgsn: Split gsm0408_gprs_force_reattach into 2 functions
This patch replaces gsm0408_gprs_force_reattach(msg, mmctx) by two
functions
- gsm0408_gprs_force_reattach(mmctx)
- gsm0408_gprs_force_reattach_oldmsg(msg)
The old function basically consists of the code of the two new
functions, where the code patch selected depends on mmctx == NULL,
which is harder to maintain, less obvious to use, and not consistent
with many other SGSN functions.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=62a432c7db59c3004a9fc3272d46a6cc…
commit 62a432c7db59c3004a9fc3272d46a6cc9c4269aa
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Nov 3 10:12:52 2014 +0100
sgsn: Call mm_ctx_cleanup_free to deregister MM context
Currently the MM context isn't always removed when it is
de-registered (mmctx_timer_cb), mm_state is set to GMM_DEREGISTERED
instead. This can lead to left-over MM contexts which are only
cleaned up if the MS reattaches.
This patch replaces all of these assignments by a call to
mm_ctx_cleanup_free.
Ticket: OW#1324
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=584bf98d87497381ea30526d73899d3a…
commit 584bf98d87497381ea30526d73899d3a5542eb61
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Oct 28 16:23:46 2014 +0100
sgsn: Cleanup GMM state transitions
Currently the GMM state is set to GMM-REGISTERED when an Attach
Accept or a RA Update Accept message is sent, even if a new P-TMSI is
included. In this case 04.08 requires (see 4.7.3.1.3 and 4.7.5.1.3),
that the state is set to GMM-COMMON-PROCEDURE-INITIATED when the
Accept is sent. When the Complete is received, the SGSN shall set
the state to GMM-REGISTERED.
This patch modifies the state updates accordingly.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=b8242b0c2422a948fdce005558fc8e57…
commit b8242b0c2422a948fdce005558fc8e5738555ff0
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Oct 28 12:23:29 2014 +0100
sgsn: Reorganize and fix gsm48_gmm_authorize
Currently the order of the 'if' clauses in gsm48_gmm_authorize
doesn't match the order in which the conditional parts are entered.
This makes it difficult to maintain. In addition the t3350_mode is
not stored in every path, so that this information is lost when the
identification procedure is started. Since the default value
coincidentally is GMM_T3350_MODE_ATT, this doesn't hurt for Attach
Requests which are the only messages that initially trigger the
authentication yet.
This patch changes the order of the 'if' clause to match the
processing order, it removes the t3350_mode parameter entirely and
introduces a mm->pending_req field. The latter must be set when the
request that causes the authorization before calling
gsm48_gmm_authorize. The gprs_t3350_mode enum is extended by
GMM_T3350_MODE_NONE (value 0, which is the default) to make it
possible to detect related initialisation errors or race conditions.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=acc28f5fa7b9c1ad607bddb47429a04a…
commit acc28f5fa7b9c1ad607bddb47429a04a068c14ef
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Oct 30 17:15:43 2014 +0100
gbproxy: Reset TLLIs when the link_info is found by IMSI/P-TMSI
Currently when the MS does a re-attach without doing a proper detach
first, the gbproxy uses the old local TLLI if patching and the keep
mode are enabled. This leads to a failing attachment procedure when
TLLI patching is also enabled.
This patch changes gbproxy_update_link_state_ul to reset all TLLIs
within the link_info if the message contains an unknown TLLI and an
MI. This is generally the case with Attach Request messages.
The gbproxy_get_link_info_ul gets an additional tlli_is_invalid
output parameter that is set, when a TLLI was present but not found.
This value is then used instead of checking tlli.current == 0 to
handle e.g. Attach Requests when a link_info was already present for
the P-TMSI/IMSI used in such a request.
Ticket: OW#1324
Sponsored-by: On-Waves ehf
-----------------------------------------------------------------------
Summary of changes:
openbsc/contrib/systemd/osmo-bsc.service | 2 +-
openbsc/include/openbsc/gprs_gmm.h | 1 +
openbsc/include/openbsc/gprs_sgsn.h | 14 ++++
openbsc/src/gprs/gb_proxy_tlli.c | 27 ++++---
openbsc/src/gprs/gprs_gmm.c | 33 ++++++++-
openbsc/src/gprs/gprs_sgsn.c | 9 +--
openbsc/src/gprs/gprs_subscriber.c | 105 +++++++++++++++++++++++----
openbsc/src/gprs/sgsn_auth.c | 16 ++++-
openbsc/src/gprs/sgsn_vty.c | 120 +++++++++++++++++++++++++++++++
openbsc/src/libbsc/abis_nm.c | 4 +-
openbsc/src/libbsc/bsc_ctrl_commands.c | 5 ++
openbsc/tests/ctrl_test_runner.py | 20 ++++++
openbsc/tests/vty_test_runner.py | 3 +
13 files changed, 319 insertions(+), 40 deletions(-)
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, master has been updated
via 3911880b68ddd92c9dd89d6ac20c26807e33f905 (commit)
via cdd4302c6dde84693a16b33362a75061480333cd (commit)
via 27cb4d57e049b173fb4cacc78b947f70c691c111 (commit)
via 94ef1c0da9a80869256e6a5966d1f1571955c813 (commit)
via 41108680293f703da976efe64ea8388ef7a2cd7e (commit)
from 0d8ac0eac0a919cb2620d94e661d60b2a96501d3 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=3911880b68ddd92c9dd89d6ac20c2680…
commit 3911880b68ddd92c9dd89d6ac20c26807e33f905
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Nov 7 14:07:48 2014 +0100
bsc: Move gsm_subscriber_base.c to libcommon
Since it is planned to use struct gsm_subscriber to manage subscriber
data in the SGSN, this file which contains the generic subscriber
related methods is moved to libcommon.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=cdd4302c6dde84693a16b33362a75061…
commit cdd4302c6dde84693a16b33362a75061480333cd
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Nov 10 11:21:32 2014 +0100
bsc: Move gsm_network_init function to libbsc
Currently libcommon depends on libbsc, because gsm_network_init
(libcommon/gsm_data.c) directly calls gsm_net_update_ctype
(libbsc/gsm_04_08_utils.c).
This patch moves gsm_network_init to a new file libbsc/net_init.c.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=27cb4d57e049b173fb4cacc78b947f70…
commit 27cb4d57e049b173fb4cacc78b947f70c691c111
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Wed Oct 29 12:11:58 2014 +0100
sgsn/test: Add test_gmm_attach
This test checks the attach procedure until the Attach Complete is
received.
Note that authorization and GMM state updates are not working
properly yet.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=94ef1c0da9a80869256e6a5966d1f157…
commit 94ef1c0da9a80869256e6a5966d1f1571955c813
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Wed Oct 29 10:31:18 2014 +0100
sgsn/test: Move message sending to send_0408_message
This replaces serveral occurences of duplicated code for message
creation and sending (passing to gsm0408_gprs_rcvmsg) into a single
function. In addition, the sgsn_tx_counter is always reset within
send_0408_message to simplify the code that checks for the number of
messages sent.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=41108680293f703da976efe64ea8388e…
commit 41108680293f703da976efe64ea8388ef7a2cd7e
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Oct 31 10:47:29 2014 +0100
gbproxy: Honour the BSS TLLI type when creating an SGSN TLLI
Currently gbproxy_make_sgsn_tlli always returns a foreign TLLI when
it uses the (SGSN) P-TMSI to generate one.
This patch changes the implementation to return a SGSN TLLI of the
same type like the BSS TLLI in that case.
Sponsored-by: On-Waves ehf
-----------------------------------------------------------------------
Summary of changes:
openbsc/src/gprs/gb_proxy.c | 7 +-
openbsc/src/libbsc/Makefile.am | 4 +-
openbsc/src/libbsc/net_init.c | 102 ++++++++++++
openbsc/src/libcommon/Makefile.am | 4 +-
openbsc/src/libcommon/gsm_data.c | 80 ----------
.../{libbsc => libcommon}/gsm_subscriber_base.c | 0
openbsc/src/osmo-bsc_nat/Makefile.am | 3 +-
openbsc/src/utils/Makefile.am | 4 +-
openbsc/tests/channel/Makefile.am | 8 +-
openbsc/tests/sgsn/sgsn_test.c | 176 +++++++++++++++++----
openbsc/tests/sgsn/sgsn_test.ok | 1 +
11 files changed, 269 insertions(+), 120 deletions(-)
create mode 100644 openbsc/src/libbsc/net_init.c
rename openbsc/src/{libbsc => libcommon}/gsm_subscriber_base.c (100%)
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, master has been updated
via 0d8ac0eac0a919cb2620d94e661d60b2a96501d3 (commit)
from 054bc24e6dc700d4b8e8eec647cbead63454671e (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=0d8ac0eac0a919cb2620d94e661d60b2…
commit 0d8ac0eac0a919cb2620d94e661d60b2a96501d3
Author: Henning Heinold <henning(a)itconsulting-heinold.de>
Date: Tue Nov 11 17:11:41 2014 +0100
systemd: use Wants for the dependency btw. osmo-bsc-mgcp and osmo-bsc
* osmo-bsc and osmo-bsc-mgcp are needed to run
* with Wants, both are started but can be indepently
controlled via systemctl
Fixes: SYS#738
-----------------------------------------------------------------------
Summary of changes:
openbsc/contrib/systemd/osmo-bsc.service | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "An utility library for Open Source Mobile Communications".
The branch, master has been updated
via 8497b0a78671e09015ec2cb40f0a21cae7baf5ad (commit)
from 0673b70f7d6c608566da84410c58f2ad5f290027 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/libosmocore/commit/?id=8497b0a78671e09015ec2cb40f0a…
commit 8497b0a78671e09015ec2cb40f0a21cae7baf5ad
Author: Ciaby <ciaby(a)autistici.org>
Date: Mon Nov 10 12:33:35 2014 -0600
Fix debian packaging
- Added debian/libosmosim0.install
- Added libosmosim definition in debian/control
-----------------------------------------------------------------------
Summary of changes:
debian/control | 6 ++++++
debian/libosmosim0.install | 1 +
2 files changed, 7 insertions(+)
create mode 100644 debian/libosmosim0.install
hooks/post-receive
--
An utility library for Open Source Mobile Communications
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Osmocom BTS-side code (Abis, scheduling, ...)".
The branch, master has been updated
via 4d4dc2674252658330cdd581757d6168087ba4fb (commit)
via 48eb374a9640aab799958590ef35dc3d1bdebefb (commit)
via 2fa6ef26879607ab01795259720857091e76d852 (commit)
via 6d8bcbd192d6d5bfe5077fd675e12734b72fb2be (commit)
from b89a5fa55d712a257ee17bbaed41cdb1ee8d7f75 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmo-bts/commit/?id=4d4dc2674252658330cdd581757d616…
commit 4d4dc2674252658330cdd581757d6168087ba4fb
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Mon Nov 10 15:13:05 2014 +0100
bts: Move BTS and children into the enabled state after opstart
With "show bts 0" all objects were still listed as dependency.
Once the BTS has been started.. move all the other objects into
the enabled state. Our OpenBSC OML code doesn't care but people
using the VTY to inspect state will be more happy.
One day... we will create proper statemachines inside the BTS
and the BSC instead of changing the state in the BTS impl.
Fixes: ONW#1330
http://cgit.osmocom.org/osmo-bts/commit/?id=48eb374a9640aab799958590ef35dc3…
commit 48eb374a9640aab799958590ef35dc3d1bdebefb
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Mon Nov 10 15:09:52 2014 +0100
bts: Start with the site manager being enabled and available
We would never transition the sitemanager to anything. Our SW
does not support SW activation's so we are always ready.
Related: ONW#1330
http://cgit.osmocom.org/osmo-bts/commit/?id=2fa6ef26879607ab017952597208570…
commit 2fa6ef26879607ab01795259720857091e76d852
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Mon Nov 10 13:18:59 2014 +0100
bts: Mark NSVC1 as offline. We do not expose a second NSVC
OsmoBSC> show bts 0
...
GPRS NSVC1: Oper 'Disabled', Admin 'unknown 0x0', Avail 'Off line'
http://cgit.osmocom.org/osmo-bts/commit/?id=6d8bcbd192d6d5bfe5077fd675e1273…
commit 6d8bcbd192d6d5bfe5077fd675e12734b72fb2be
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Mon Nov 10 13:01:33 2014 +0100
bts: Fix typo in OML comment
-----------------------------------------------------------------------
Summary of changes:
src/common/bts.c | 7 +++++--
src/osmo-bts-sysmo/oml.c | 6 ++++++
2 files changed, 11 insertions(+), 2 deletions(-)
hooks/post-receive
--
Osmocom BTS-side code (Abis, scheduling, ...)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Osmocom BTS-side code (Abis, scheduling, ...)".
The branch, master has been updated
via b89a5fa55d712a257ee17bbaed41cdb1ee8d7f75 (commit)
from 9f0002b52bdc560587744e17243440951273a153 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmo-bts/commit/?id=b89a5fa55d712a257ee17bbaed41cdb…
commit b89a5fa55d712a257ee17bbaed41cdb1ee8d7f75
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Mon Nov 10 12:53:22 2014 +0100
bts: In case the line isn't created do not exit with code 1
The service file will prevent a re-launch of the sysmobts.service
in case the main process exits with '1'. In case the ethernet is
not available yet the routine would fail and the sysmobts process
will not be restarted.
unable to connect/bind socket: Network is unreachable
<000f> input/ipaccess.c:885 cannot open OML BTS link: Network is unreachable
unable to connect to BSC
root@sysmobts-v2:~# echo $?
2
Fixes: SYS#736
-----------------------------------------------------------------------
Summary of changes:
src/osmo-bts-sysmo/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
hooks/post-receive
--
Osmocom BTS-side code (Abis, scheduling, ...)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, master has been updated
via 054bc24e6dc700d4b8e8eec647cbead63454671e (commit)
from 74b2028167ddf04a867ae9f269bfa3435c93f252 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=054bc24e6dc700d4b8e8eec647cbead6…
commit 054bc24e6dc700d4b8e8eec647cbead63454671e
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Mon Nov 10 11:41:03 2014 +0100
bts: Allow to set the LAC through the CTRL interface
Allow to set the LAC of the BTS through the CTRL interface.
The change will not be effective immediately.
Fixes: SYS#738
-----------------------------------------------------------------------
Summary of changes:
openbsc/src/libbsc/bsc_ctrl_commands.c | 5 +++++
openbsc/tests/ctrl_test_runner.py | 20 ++++++++++++++++++++
2 files changed, 25 insertions(+)
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Osmocom BTS-side code (Abis, scheduling, ...)".
The branch, master has been updated
via 9f0002b52bdc560587744e17243440951273a153 (commit)
via 1cce69364dbbc5fd8ed6765063c84f415da7ce02 (commit)
via 8332e29c9f3f97cbe22f83673cac4e68c57959f1 (commit)
via be63f03254c036a8466c434b6391ad1a2c2a18bc (commit)
from 9f22fcfd367adbc88183079e27b1cd790a04a6f0 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmo-bts/commit/?id=9f0002b52bdc560587744e172434409…
commit 9f0002b52bdc560587744e17243440951273a153
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Mon Nov 10 12:04:48 2014 +0100
ctrl: Fix compiler warning
bts_ctrl_lookup.c: In function 'bts_controlif_setup':
bts_ctrl_lookup.c:97:2: warning: implicit declaration of function 'bts_ctrl_cmds_install' [-Wimplicit-function-declaration]
rc = bts_ctrl_cmds_install(bts);
^
http://cgit.osmocom.org/osmo-bts/commit/?id=1cce69364dbbc5fd8ed6765063c84f4…
commit 1cce69364dbbc5fd8ed6765063c84f415da7ce02
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Mon Nov 10 12:02:45 2014 +0100
abis: Fix compiler warning and remove const from syntax
libosmo-abis doesn't make it easy to have these parameters
as const.. just declare it non-const in the api. We pass
a static string but we know it will not be modified.
http://cgit.osmocom.org/osmo-bts/commit/?id=8332e29c9f3f97cbe22f83673cac4e6…
commit 8332e29c9f3f97cbe22f83673cac4e68c57959f1
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Mon Nov 10 11:59:53 2014 +0100
tch: Avoid compiler warnings when using the direct RTP mode
tch.c: In function 'l1_to_rtppayload_amr':
tch.c:247:29: warning: unused variable 'amr_mrc' [-Wunused-variable]
struct amr_multirate_conf *amr_mrc = &lchan->tch.amr_mr;
^
tch.c: In function 'rtppayload_to_l1_amr':
tch.c:335:10: warning: unused variable 'amr_if2_core_len' [-Wunused-variable]
uint8_t amr_if2_core_len = payload_len - 2;
http://cgit.osmocom.org/osmo-bts/commit/?id=be63f03254c036a8466c434b6391ad1…
commit be63f03254c036a8466c434b6391ad1a2c2a18bc
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Mon Nov 10 11:58:21 2014 +0100
sysmobts: Call the routine send and receive instead of get
-----------------------------------------------------------------------
Summary of changes:
include/osmo-bts/abis.h | 4 ++--
include/osmo-bts/control_if.h | 1 +
src/common/abis.c | 4 ++--
src/osmo-bts-sysmo/misc/sysmobts_mgr_2050.c | 8 ++++----
src/osmo-bts-sysmo/tch.c | 5 ++++-
5 files changed, 13 insertions(+), 9 deletions(-)
hooks/post-receive
--
Osmocom BTS-side code (Abis, scheduling, ...)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, jerlbeck/wip/gprs-patching has been updated
discards 8d570c15a946c8adf874db68ef12e046cfd98fd0 (commit)
discards 016051129a239d6a16bd06b93716f03c145aedbb (commit)
discards b915d5bb9726712a7e6c154559d205dc0591d393 (commit)
discards ffefe0e35f9b106ba11071c903f2b7e700990a58 (commit)
discards 6ebd49eaed937f62b42281281434a6031cfbe2c1 (commit)
discards 0c401f18259d6223fc417aefd3d088b20ce52542 (commit)
discards b0e9dd487f84254f0884dfba0af1237b82525734 (commit)
discards a6a499fc8174e77bc468c2f593fe86ca4b0363b5 (commit)
discards 3f2dfee7ca5769b351b2d2a9d6ecdd5903243e87 (commit)
discards 06e8cf5c76a900227f8ed32489ecfd4a683ee5f6 (commit)
discards 60e0f06e985106204be526b9a90f21e7c417a0b6 (commit)
discards e7308002c55da89a76f4b5db4cae2e4df5024375 (commit)
discards c2f6fab069d14382dc444753bd59f62d87623aeb (commit)
discards 41fde68761737c8590b68e4b1aed102b62b4c2e6 (commit)
discards 597583f635d377d24cf00c3ba93e303735cc270c (commit)
discards dd79c53aa6a7ea844852ca257f58a71aa422b747 (commit)
discards 7dc3f3cc4ec9067bbeb7c030f42396bd866efbb4 (commit)
discards f47bdf819239b9eb44350497e6c4f95ef31e7e25 (commit)
discards d0998fbe927ac54e0f50326b161773f8a5728b18 (commit)
via c93f898e6de4dfc3328b206cd2b8724c6c133215 (commit)
via 6d1dc3c02f5a2839e998c7ec1275270d49b9db9e (commit)
via d49b478c9b91a14daf37de826533fb793827939e (commit)
via c09bee263d257e6f7ac574a542057c2181cd5da8 (commit)
via 1fcb88a3db244830c07f28dcde6467ba3ac9239d (commit)
via 5b98e682e5985fe60a9ebdaae8134a305021ff25 (commit)
via 418c164fa36acbe33b2ec75eccbbba551f62a844 (commit)
via f12e41de7dc441f8c2837f792853511a0e038ddb (commit)
via 3191e00c847cd780d220aa7c9b50c2a5906217a4 (commit)
via e0e0217321efd2d1103d9fa4e73a7a116fa83c6e (commit)
via b460f57502f7a0cc21a5171f877d9528c144c7f7 (commit)
via 3245dbc7a695da12e88991918f73dc8abea8c3fe (commit)
via b88c41d64c2b2df18fc578f996f00cdd76f222af (commit)
via 56e655632df54283b3634e2a2e2dac96710830ff (commit)
via 79a481bfc005283221f300b01efdefad4dcdb9d3 (commit)
via 8e2148ab0ec232b50484c01876316f1417822bde (commit)
via a312c4bb27e6dd1fa03e78138370d583570380d6 (commit)
via 81b6311deaaac6fe97ba11eee94dc922b6b16e14 (commit)
via 5bc648f29af30528349aaabcce8c962210a7b50f (commit)
via db483b72f1c8e2c397f88baa05b6b53f76362a04 (commit)
via 7d8e8b9a13b3b2ea8404581f980869b711617e2e (commit)
via 2c00b904bb31f807c501c26addcc046ca8496521 (commit)
via f9330da55561d3cad6220e8c0a6dea53990309fc (commit)
via 33f2c4d898c59a05c8122fd9897cbd22f643b367 (commit)
This update added new revisions after undoing existing revisions. That is
to say, the old revision is not a strict subset of the new revision. This
situation occurs when you --force push a change and generate a repository
containing something like this:
* -- * -- B -- O -- O -- O (8d570c15a946c8adf874db68ef12e046cfd98fd0)
\
N -- N -- N (c93f898e6de4dfc3328b206cd2b8724c6c133215)
When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=c93f898e6de4dfc3328b206cd2b8724c…
commit c93f898e6de4dfc3328b206cd2b8724c6c133215
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Nov 10 10:35:51 2014 +0100
sgsn: Use gsm_subscriber (TODO)
TODO:
- commit message
- continue impl.
Ticket: OW#????
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=6d1dc3c02f5a2839e998c7ec1275270d…
commit 6d1dc3c02f5a2839e998c7ec1275270d49b9db9e
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Nov 7 14:17:44 2014 +0100
sgsn: Refactor sgsn_auth (TODO)
TODO:
- Commit title
- Commit message
- Use sgsn_instance instead of config as parameter
Ticket: OW#????
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=d49b478c9b91a14daf37de826533fb79…
commit d49b478c9b91a14daf37de826533fb793827939e
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Nov 6 15:43:10 2014 +0100
sgsn: Don't assign a new P-TMSI if one is pending (TODO)
Currently every time a RA Update Req or an Attach Req is processed, a
new P-TMSI is alocated. When an MS issues another of these messages
before it has completed the first procedure, old_ptmsi is replaced by
ptmsi (and thus lost) and ptmsi is replaced by the newly allocated
P-TMSI. This can confuse the gbproxy, which can loose track of the
logical link then. At least a blackberry emits a double set of RA Upd
Req messages from time to time which may be just 20ms apart.
This patch adds a check whether mm->ptmsi or mm->old_ptmsi are not
both set. If both are set, the P-TMSI is not re-allocated. This is
only the case, if the Complete message has not been received since
that resets old_ptmsi.
TODO:
- Test case
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=c09bee263d257e6f7ac574a542057c21…
commit c09bee263d257e6f7ac574a542057c2181cd5da8
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Sep 30 13:53:26 2014 +0200
sgsn: Added TODOs (TODO)
TODO:
- fix and remove TODOs
- add test cases for Detach(reattach)
- add test cases for PDP context deletion (OW#1311)
- add test cases for Cancel pending timer in sgsn_mm_ctx_free
- remove this commit
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=1fcb88a3db244830c07f28dcde6467ba…
commit 1fcb88a3db244830c07f28dcde6467ba3ac9239d
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Oct 17 10:08:02 2014 +0200
sgsn: Do not die in _bssgp_tx_dl_ud on TLLI mismatch (TODO)
Currently an OSMO_ASSERT fails, if the message's and the mmctx's
TLLIs do not match.
This commit turns the assertion into an ERROR log message and uses
the default values for IMSI, DRX, and RA CAP instead of the MM
context values in this case.
TODO:
- find the real source for the problem
- add test cases derived from what is being described in the ticket
Ticket: OW#1322
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=5b98e682e5985fe60a9ebdaae8134a30…
commit 5b98e682e5985fe60a9ebdaae8134a305021ff25
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Nov 7 14:07:48 2014 +0100
bsc: Move gsm_subscriber_base.c to libcommon
Since it is planned to use struct gsm_subscriber to manage subscriber
data in the SGSN, this file which contains the generic subscriber
related methods is moved to libcommon.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=418c164fa36acbe33b2ec75eccbbba55…
commit 418c164fa36acbe33b2ec75eccbbba551f62a844
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Nov 10 11:21:32 2014 +0100
bsc: Move gsm_network_init function to libbsc
Currently libcommon depends on libbsc, because gsm_network_init
(libcommon/gsm_data.c) directly calls gsm_net_update_ctype
(libbsc/gsm_04_08_utils.c).
This patch moves gsm_network_init to a new file libbsc/net_init.c.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=f12e41de7dc441f8c2837f792853511a…
commit f12e41de7dc441f8c2837f792853511a0e038ddb
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Nov 6 13:43:41 2014 +0100
sgsn: Cleanup after RA Update Reject / Attach Reject
Currently, the LLME is not cleanup up after sending an RA Update
Reject. This happens after entering a routing area from outside,
since in that case the SGSN sends an RA Update Reject (implicitly
detached) which causes the MS to restart the attach procedure.
The LLME is also not updated if an Attach Request with message errors
(encoding, invalid MI type) is received or if an MM context cannot be
allocated.
This patch changes gsm48_rx_gmm_ra_upd_req and gsm48_rx_gmm_att_req
to unassign the LLME or free the MM context (if available) after a
Reject message has been sent.
Ticket: OW#1324
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=3191e00c847cd780d220aa7c9b50c2a5…
commit 3191e00c847cd780d220aa7c9b50c2a5906217a4
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Nov 4 12:44:15 2014 +0100
sgsn: Notify an affected MM context if an ACL rule is removed
Currently if an ACL access rule is removed, MS already attached are
not affected until they try to reattach to the SGSN.
This patch extends sgsn_acl_del to re-authenticate an MM context if
it matches the IMSI.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=e0e0217321efd2d1103d9fa4e73a7a11…
commit e0e0217321efd2d1103d9fa4e73a7a116fa83c6e
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Nov 4 10:08:37 2014 +0100
sgsn: Add 'acl-only' authentication policy
Currently the VTY 'auth-policy' command results in setting or clearing
the acl_enabled flag. This also enables the matching of the MCC/MNC
prefix of the IMSI.
This patch adds an additional policy 'acl-only' which disables the
MCC/MNC matching and relies on the ACL only.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=b460f57502f7a0cc21a5171f877d9528…
commit b460f57502f7a0cc21a5171f877d9528c144c7f7
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Nov 4 11:15:01 2014 +0100
sgsn/test: Add VTY tests for the SGSN
This patch adds some basic SGSN tests to vty_test_runner.py:
- check for config tree nodes
- check specific show commands
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=3245dbc7a695da12e88991918f73dc8a…
commit 3245dbc7a695da12e88991918f73dc8abea8c3fe
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Oct 24 18:09:54 2014 +0200
sgsn: Make authorization asynchronous
Currently the authorization of an IMSI is done by checking ACLs
synchronously which is not feasible when the subscriber data has to
be retrieved from an external source.
This patch changes this by using a callback when the information is
available. This is also done when only ACL are checked, in this case
the callback is invoked from within sgsn_auth_request(). The callback
function sgsn_update_subscriber_data calls sgsn_auth_update which
in turn calls either gsm0408_gprs_access_granted or
gsm0408_gprs_access_denied. gsm48_gmm_authorize is extended by a call
to sgsn_auth_request when IMSI and IMEI are available but the
auth_state is unknown.
The change has been successfully tested with single phones (E71 and
IPhone 5c).
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=b88c41d64c2b2df18fc578f996f00cdd…
commit b88c41d64c2b2df18fc578f996f00cdd76f222af
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Nov 3 12:48:43 2014 +0100
bsc: Fix use-after-free on OML NM messages from the BTS
Currently the sign_link pointer is dereferenced after a call to
osmo_signal_dispatch, which can indirectly call
e1inp_sign_link_destroy. If that happens, accessing *sign_link is
illegal and can lead to a segmentation violation.
Since only the bts pointer is needed from sign_link after the call to
osmo_signal_dispatch, this patch changes abis_nm_rcvmsg_fom to save
that pointer to a local variable earlier.
Addresses:
<0019> input/ipa.c:250 accept()ed new link from 192.168.1.101 to port 3002
SET ATTR NACK CAUSE=Message cannot be performed
<0005> bsc_init.c:52 Got a NACK going to drop the OML links.
<001b> bsc_init.c:319 Lost some E1 TEI link: 1 0xb351a830
=================================================================
==13198== ERROR: AddressSanitizer: heap-use-after-free on address 0xb5d1bc70 at pc 0x80a6e3d bp 0xbfbb33d8 sp 0xbfbb33cc
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=56e655632df54283b3634e2a2e2dac96…
commit 56e655632df54283b3634e2a2e2dac96710830ff
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Wed Oct 29 22:12:20 2014 +0100
sgsn: Move IMSI authorization to gsm48_gmm_authorize
Currently the IMSI is only checked immediately when an Attach Request
is received that contains an IMSI IE. If it contains a P-TMSI
instead, access is always granted.
This commit moves the IMSI check to gsm48_gmm_authorize where it is
applied when IMSI and IMEI have been acquired. This fixes the
authorization when the Attach Accept doesn't contain an IMSI.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=79a481bfc005283221f300b01efdefad…
commit 79a481bfc005283221f300b01efdefad4dcdb9d3
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Oct 31 12:27:11 2014 +0100
sgsn: Fix LLME leak when forcing a reattach
Currently when forceing a reattach by sending a Detach
Request (reattach), the SGSN waits for the Detach Accept until it
frees the MM context (if present) and the LLME. If that message gets
lost or isn't sent by the MS, the LLME is never freed if it isn't
bound to an MM context.
This patch adds code to free the MM context/LLME when forcing a
reattachment.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=8e2148ab0ec232b50484c01876316f14…
commit 8e2148ab0ec232b50484c01876316f1417822bde
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Oct 31 12:20:49 2014 +0100
sgsn: Split gsm0408_gprs_force_reattach into 2 functions
This patch replaces gsm0408_gprs_force_reattach(msg, mmctx) by two
functions
- gsm0408_gprs_force_reattach(mmctx)
- gsm0408_gprs_force_reattach_oldmsg(msg)
The old function basically consists of the code of the two new
functions, where the code patch selected depends on mmctx == NULL,
which is harder to maintain, less obvious to use, and not consistent
with many other SGSN functions.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=a312c4bb27e6dd1fa03e78138370d583…
commit a312c4bb27e6dd1fa03e78138370d583570380d6
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Nov 3 10:12:52 2014 +0100
sgsn: Call mm_ctx_cleanup_free to deregister MM context
Currently the MM context isn't always removed when it is
de-registered (mmctx_timer_cb), mm_state is set to GMM_DEREGISTERED
instead. This can lead to left-over MM contexts which are only
cleaned up if the MS reattaches.
This patch replaces all of these assignments by a call to
mm_ctx_cleanup_free.
Ticket: OW#1324
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=81b6311deaaac6fe97ba11eee94dc922…
commit 81b6311deaaac6fe97ba11eee94dc922b6b16e14
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Oct 28 16:23:46 2014 +0100
sgsn: Cleanup GMM state transitions
Currently the GMM state is set to GMM-REGISTERED when an Attach
Accept or a RA Update Accept message is sent, even if a new P-TMSI is
included. In this case 04.08 requires (see 4.7.3.1.3 and 4.7.5.1.3),
that the state is set to GMM-COMMON-PROCEDURE-INITIATED when the
Accept is sent. When the Complete is received, the SGSN shall set
the state to GMM-REGISTERED.
This patch modifies the state updates accordingly.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=5bc648f29af30528349aaabcce8c9622…
commit 5bc648f29af30528349aaabcce8c962210a7b50f
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Wed Oct 29 12:11:58 2014 +0100
sgsn/test: Add test_gmm_attach
This test checks the attach procedure until the Attach Complete is
received.
Note that authorization and GMM state updates are not working
properly yet.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=db483b72f1c8e2c397f88baa05b6b53f…
commit db483b72f1c8e2c397f88baa05b6b53f76362a04
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Wed Oct 29 10:31:18 2014 +0100
sgsn/test: Move message sending to send_0408_message
This replaces serveral occurences of duplicated code for message
creation and sending (passing to gsm0408_gprs_rcvmsg) into a single
function. In addition, the sgsn_tx_counter is always reset within
send_0408_message to simplify the code that checks for the number of
messages sent.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=7d8e8b9a13b3b2ea8404581f980869b7…
commit 7d8e8b9a13b3b2ea8404581f980869b711617e2e
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Oct 28 12:23:29 2014 +0100
sgsn: Reorganize and fix gsm48_gmm_authorize
Currently the order of the 'if' clauses in gsm48_gmm_authorize
doesn't match the order in which the conditional parts are entered.
This makes it difficult to maintain. In addition the t3350_mode is
not stored in every path, so that this information is lost when the
identification procedure is started. Since the default value
coincidentally is GMM_T3350_MODE_ATT, this doesn't hurt for Attach
Requests which are the only messages that initially trigger the
authentication yet.
This patch changes the order of the 'if' clause to match the
processing order, it removes the t3350_mode parameter entirely and
introduces a mm->pending_req field. The latter must be set when the
request that causes the authorization before calling
gsm48_gmm_authorize. The gprs_t3350_mode enum is extended by
GMM_T3350_MODE_NONE (value 0, which is the default) to make it
possible to detect related initialisation errors or race conditions.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=2c00b904bb31f807c501c26addcc046c…
commit 2c00b904bb31f807c501c26addcc046ca8496521
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Oct 31 10:47:29 2014 +0100
gbproxy: Honour the BSS TLLI type when creating an SGSN TLLI
Currently gbproxy_make_sgsn_tlli always returns a foreign TLLI when
it uses the (SGSN) P-TMSI to generate one.
This patch changes the implementation to return a SGSN TLLI of the
same type like the BSS TLLI in that case.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=f9330da55561d3cad6220e8c0a6dea53…
commit f9330da55561d3cad6220e8c0a6dea53990309fc
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Oct 30 17:15:43 2014 +0100
gbproxy: Reset TLLIs when the link_info is found by IMSI/P-TMSI
Currently when the MS does a re-attach without doing a proper detach
first, the gbproxy uses the old local TLLI if patching and the keep
mode are enabled. This leads to a failing attachment procedure when
TLLI patching is also enabled.
This patch changes gbproxy_get_link_info_ul to reset all TLLIs within the
link_info if the message contains an unknown TLLI and an MI. This is
generally the case with Attach Request messages.
Ticket: OW#1324
Sponsored-by: On-Waves ehf
-----------------------------------------------------------------------
Summary of changes:
openbsc/include/openbsc/gprs_sgsn.h | 9 +-
openbsc/include/openbsc/gsm_subscriber.h | 4 +
openbsc/include/openbsc/sgsn.h | 3 +-
openbsc/src/gprs/Makefile.am | 2 +-
openbsc/src/gprs/gprs_sgsn.c | 31 ++++++-
openbsc/src/gprs/gprs_subscriber.c | 73 +++++++++++++++
openbsc/src/gprs/sgsn_auth.c | 52 ++++++++---
openbsc/src/gprs/sgsn_main.c | 3 -
openbsc/src/gprs/sgsn_vty.c | 8 +-
openbsc/src/libbsc/Makefile.am | 4 +-
openbsc/src/libbsc/bts_ipaccess_nanobts.c | 6 +-
openbsc/src/libbsc/net_init.c | 102 +++++++++++++++++++++
openbsc/src/libcommon/Makefile.am | 4 +-
openbsc/src/libcommon/gsm_data.c | 80 ----------------
.../{libbsc => libcommon}/gsm_subscriber_base.c | 0
openbsc/src/osmo-bsc_nat/Makefile.am | 3 +-
openbsc/src/utils/Makefile.am | 4 +-
openbsc/tests/channel/Makefile.am | 8 +-
openbsc/tests/sgsn/Makefile.am | 2 +
19 files changed, 280 insertions(+), 118 deletions(-)
create mode 100644 openbsc/src/gprs/gprs_subscriber.c
create mode 100644 openbsc/src/libbsc/net_init.c
rename openbsc/src/{libbsc => libcommon}/gsm_subscriber_base.c (100%)
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, master has been updated
via 74b2028167ddf04a867ae9f269bfa3435c93f252 (commit)
from 33f2c4d898c59a05c8122fd9897cbd22f643b367 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=74b2028167ddf04a867ae9f269bfa343…
commit 74b2028167ddf04a867ae9f269bfa3435c93f252
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Nov 10 08:30:31 2014 +0100
bsc: Fix use-after-free on OML NM messages from the BTS
Currently the sign_link pointer is dereferenced after a call to
osmo_signal_dispatch, which can indirectly call
e1inp_sign_link_destroy. If that happens, accessing *sign_link is
illegal and can lead to a segmentation violation.
Since only the bts pointer is needed from sign_link after the call to
osmo_signal_dispatch, this patch changes abis_nm_rcvmsg_fom to save
that pointer to a local variable earlier.
Addresses:
<0019> input/ipa.c:250 accept()ed new link from 192.168.1.101 to port 3002
SET ATTR NACK CAUSE=Message cannot be performed
<0005> bsc_init.c:52 Got a NACK going to drop the OML links.
<001b> bsc_init.c:319 Lost some E1 TEI link: 1 0xb351a830
=================================================================
==13198== ERROR: AddressSanitizer: heap-use-after-free on address 0xb5d1bc70 at pc 0x80a6e3d bp 0xbfbb33d8 sp 0xbfbb33cc
Sponsored-by: On-Waves ehf
-----------------------------------------------------------------------
Summary of changes:
openbsc/src/libbsc/abis_nm.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "An utility library for Open Source Mobile Communications".
The branch, master has been updated
via 0673b70f7d6c608566da84410c58f2ad5f290027 (commit)
from d6ec984c51ffa8c3185b1a0472b4aa0b522364fa (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/libosmocore/commit/?id=0673b70f7d6c608566da84410c58…
commit 0673b70f7d6c608566da84410c58f2ad5f290027
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Nov 10 08:27:15 2014 +0100
bssgp: Fix VTY command 'show bssgp nsei N'
Currently this command segfaults (at least when ASAN is enabled),
because when getting the NSEI the index to argv is wrong and out of
bounds.
This patch fixes the offset.
Sponsored-by: On-Waves ehf
-----------------------------------------------------------------------
Summary of changes:
src/gb/gprs_bssgp_vty.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
hooks/post-receive
--
An utility library for Open Source Mobile Communications
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Repository for OsmoSDR UI".
The branch, direct_sampling has been created
at 7117971eede2fa3755b750f68d2d4cc4fd8da933 (commit)
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/sdrangelove/commit/?id=7117971eede2fa3755b750f68d2d…
commit 7117971eede2fa3755b750f68d2d4cc4fd8da933
Author: Hoernchen <la(a)tfc-server.de>
Date: Fri Nov 7 19:55:56 2014 +0100
direct sampling support
http://cgit.osmocom.org/sdrangelove/commit/?id=f43c4f6ea2fb40cec5d27c3d3907…
commit f43c4f6ea2fb40cec5d27c3d390707144b7fc606
Author: Hoernchen <la(a)tfc-server.de>
Date: Fri Nov 7 19:55:38 2014 +0100
prepare all fftw plans during startup
http://cgit.osmocom.org/sdrangelove/commit/?id=372a35e22911e3c2b6dd487f88d3…
commit 372a35e22911e3c2b6dd487f88d3d9778731e868
Author: Hoernchen <la(a)tfc-server.de>
Date: Fri Nov 7 19:54:48 2014 +0100
msvc fix
-----------------------------------------------------------------------
hooks/post-receive
--
Repository for OsmoSDR UI
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, master has been updated
via 33f2c4d898c59a05c8122fd9897cbd22f643b367 (commit)
from 1464a121c02786b0b7a9ea7b92f33aeacf187c55 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=33f2c4d898c59a05c8122fd9897cbd22…
commit 33f2c4d898c59a05c8122fd9897cbd22f643b367
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Fri Nov 7 09:54:57 2014 +0100
bts: Fail OML in case the channel combination is wrong
In case a BTS is being bootstrapped and one TS can not be
activated prevent the whole BTS from coming up.
When the OML activation is not being done the rest of the BSC
code still assumes these logical channel(s) to be available
and one will see channel activation issues that might be hard
to debug.
Instead of having a half-configured system up and running,
keep the BTS offline.
-----------------------------------------------------------------------
Summary of changes:
openbsc/src/libbsc/bts_ipaccess_nanobts.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNURadio hardware abstraction block".
The branch, master has been updated
via 8d9e6b58bb8dac8a92603feb8804c42ecc1e5945 (commit)
from 9fd5b367c115c19402d35e3408daf45888918b43 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/gr-osmosdr/commit/?id=8d9e6b58bb8dac8a92603feb8804c…
commit 8d9e6b58bb8dac8a92603feb8804c42ecc1e5945
Author: Jon Szymaniak <jon.szymaniak(a)gmail.com>
Date: Tue Nov 4 21:52:23 2014 -0500
bladeRF: Fixed incorrectly placed 'else'
This addresses a defect introduced in 6e75abf which causes the
_consecutive_failures count to get reset with every failure, rather
then upon a successful return value.
-----------------------------------------------------------------------
Summary of changes:
lib/bladerf/bladerf_sink_c.cc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
hooks/post-receive
--
GNURadio hardware abstraction block
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, jerlbeck/packages/wip has been updated
via 0124751e6a91c1ab87b56a3f5db5cd7a98575511 (commit)
via d788a8ffe1bb353621312fda100af49163716f14 (commit)
from 29f399634aab15fc9b4d5e4dacb0c3dca9875fe2 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=0124751e6a91c1ab87b56a3f5db5cd7a…
commit 0124751e6a91c1ab87b56a3f5db5cd7a98575511
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Nov 6 17:00:19 2014 +0100
debian: Prepare new test release (0.13.1+z8f)
http://cgit.osmocom.org/openbsc/commit/?id=d788a8ffe1bb353621312fda100af491…
commit d788a8ffe1bb353621312fda100af49163716f14
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Nov 6 13:43:41 2014 +0100
sgsn: Cleanup after RA Update Reject / Attach Reject (TODO)
Currently, the LLME is not cleanup up after sending an RA Update
Reject. This happens after entering a routing area from outside,
since in that case the SGSN sends an RA Update Reject (implicitly
detached) which causes the MS to restart the attach procedure.
The LLME is also not updated if an Attach Request with message errors
(encoding, invalid MI type) is received or if an MM context cannot be
allocated.
This patch changes gsm48_rx_gmm_ra_upd_req and gsm48_rx_gmm_att_req
to unassign the LLME or free the MM context (if available) after a
Reject message has been sent.
TODO:
- test cases
Ticket: OW#1324
Sponsored-by: On-Waves ehf
-----------------------------------------------------------------------
Summary of changes:
debian/changelog | 3 ++-
openbsc/src/gprs/gprs_gmm.c | 52 +++++++++++++++++++++++++++++++++++++++------
2 files changed, 47 insertions(+), 8 deletions(-)
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, jerlbeck/wip/gprs-patching has been updated
discards 87767b2bf18fe9bcaf7954573d94dbb8547df1de (commit)
discards 95e67b7a58dd3ac5e4be9d51ccce32f0047cd721 (commit)
discards fab825a4637c1210187f05a93392be7072a87575 (commit)
discards f9947e70d3a0f6bc70a9d9767b988ceb15fa6266 (commit)
discards 9e80019b7c3389843ba2020c3ae0e64e6d83e8c9 (commit)
discards ec75ba6ffa901c81ab936f95a8b887fe2174019b (commit)
discards e444e3bb8a48bf751cb9286d80ddcdf7b101011b (commit)
discards c16741bf78ba1ac4586cefbff0f4c2508a2d8fed (commit)
discards 825eae2fa138e92d98d3b0d58cbf7c807c1ea491 (commit)
discards 194943609b16f88539edadd11a15d56080d06b29 (commit)
discards e2c08577a8c0ceae7c2c6f82c328d04d9086175c (commit)
discards b1751e0b0cb2b153d98d951fb46745d24d06b53d (commit)
discards b44a1895051b222c1aa0d1f1bce268a84a8c6116 (commit)
discards fd0b34a3fa0485eef7a8b7745d452ac7904a8111 (commit)
discards 7f416f4799814d179b5cbf9c272b8df45e646754 (commit)
discards b62b4af85781e2e17b4cee35ac129451bb8036b7 (commit)
discards f462d2ebbc68c36a511ae9ab7088e5ae0bd1dec1 (commit)
discards 843caa4a7f2a0d27378fe97f405c65b5899c61ca (commit)
discards d6964dc0113acd2ccc9b792d846dbd7e7aa24a14 (commit)
via 8d570c15a946c8adf874db68ef12e046cfd98fd0 (commit)
via 016051129a239d6a16bd06b93716f03c145aedbb (commit)
via b915d5bb9726712a7e6c154559d205dc0591d393 (commit)
via ffefe0e35f9b106ba11071c903f2b7e700990a58 (commit)
via 6ebd49eaed937f62b42281281434a6031cfbe2c1 (commit)
via 0c401f18259d6223fc417aefd3d088b20ce52542 (commit)
via b0e9dd487f84254f0884dfba0af1237b82525734 (commit)
via a6a499fc8174e77bc468c2f593fe86ca4b0363b5 (commit)
via 3f2dfee7ca5769b351b2d2a9d6ecdd5903243e87 (commit)
via 06e8cf5c76a900227f8ed32489ecfd4a683ee5f6 (commit)
via 60e0f06e985106204be526b9a90f21e7c417a0b6 (commit)
via e7308002c55da89a76f4b5db4cae2e4df5024375 (commit)
via c2f6fab069d14382dc444753bd59f62d87623aeb (commit)
via 41fde68761737c8590b68e4b1aed102b62b4c2e6 (commit)
via 597583f635d377d24cf00c3ba93e303735cc270c (commit)
via dd79c53aa6a7ea844852ca257f58a71aa422b747 (commit)
via 7dc3f3cc4ec9067bbeb7c030f42396bd866efbb4 (commit)
via f47bdf819239b9eb44350497e6c4f95ef31e7e25 (commit)
via d0998fbe927ac54e0f50326b161773f8a5728b18 (commit)
via 1464a121c02786b0b7a9ea7b92f33aeacf187c55 (commit)
This update added new revisions after undoing existing revisions. That is
to say, the old revision is not a strict subset of the new revision. This
situation occurs when you --force push a change and generate a repository
containing something like this:
* -- * -- B -- O -- O -- O (87767b2bf18fe9bcaf7954573d94dbb8547df1de)
\
N -- N -- N (8d570c15a946c8adf874db68ef12e046cfd98fd0)
When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=8d570c15a946c8adf874db68ef12e046…
commit 8d570c15a946c8adf874db68ef12e046cfd98fd0
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Nov 6 15:43:10 2014 +0100
sgsn: Don't assign a new P-TMSI if one is pending (TODO)
Currently every time a RA Update Req or an Attach Req is processed, a
new P-TMSI is alocated. When an MS issues another of these messages
before it has completed the first procedure, old_ptmsi is replaced by
ptmsi (and thus lost) and ptmsi is replaced by the newly allocated
P-TMSI. This can confuse the gbproxy, which can loose track of the
logical link then. At least a blackberry emits a double set of RA Upd
Req messages from time to time which may be just 20ms apart.
This patch adds a check whether mm->ptmsi or mm->old_ptmsi are not
both set. If both are set, the P-TMSI is not re-allocated. This is
only the case, if the Complete message has not been received since
that resets old_ptmsi.
TODO:
- Test case
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=016051129a239d6a16bd06b93716f03c…
commit 016051129a239d6a16bd06b93716f03c145aedbb
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Sep 30 13:53:26 2014 +0200
sgsn: Added TODOs (TODO)
TODO:
- fix and remove TODOs
- add test cases for Detach(reattach)
- add test cases for PDP context deletion (OW#1311)
- add test cases for Cancel pending timer in sgsn_mm_ctx_free
- remove this commit
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=b915d5bb9726712a7e6c154559d205dc…
commit b915d5bb9726712a7e6c154559d205dc0591d393
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Oct 17 10:08:02 2014 +0200
sgsn: Do not die in _bssgp_tx_dl_ud on TLLI mismatch (TODO)
Currently an OSMO_ASSERT fails, if the message's and the mmctx's
TLLIs do not match.
This commit turns the assertion into an ERROR log message and uses
the default values for IMSI, DRX, and RA CAP instead of the MM
context values in this case.
TODO:
- find the real source for the problem
- add test cases derived from what is being described in the ticket
Ticket: OW#1322
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=ffefe0e35f9b106ba11071c903f2b7e7…
commit ffefe0e35f9b106ba11071c903f2b7e700990a58
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Nov 6 13:43:41 2014 +0100
sgsn: Cleanup after RA Update Reject / Attach Reject
Currently, the LLME is not cleanup up after sending an RA Update
Reject. This happens after entering a routing area from outside,
since in that case the SGSN sends an RA Update Reject (implicitly
detached) which causes the MS to restart the attach procedure.
The LLME is also not updated if an Attach Request with message errors
(encoding, invalid MI type) is received or if an MM context cannot be
allocated.
This patch changes gsm48_rx_gmm_ra_upd_req and gsm48_rx_gmm_att_req
to unassign the LLME or free the MM context (if available) after a
Reject message has been sent.
Ticket: OW#1324
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=6ebd49eaed937f62b42281281434a603…
commit 6ebd49eaed937f62b42281281434a6031cfbe2c1
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Nov 4 12:44:15 2014 +0100
sgsn: Notify an affected MM context if an ACL rule is removed
Currently if an ACL access rule is removed, MS already attached are
not affected until they try to reattach to the SGSN.
This patch extends sgsn_acl_del to re-authenticate an MM context if
it matches the IMSI.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=0c401f18259d6223fc417aefd3d088b2…
commit 0c401f18259d6223fc417aefd3d088b20ce52542
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Nov 4 10:08:37 2014 +0100
sgsn: Add 'acl-only' authentication policy
Currently the VTY 'auth-policy' command results in setting or clearing
the acl_enabled flag. This also enables the matching of the MCC/MNC
prefix of the IMSI.
This patch adds an additional policy 'acl-only' which disables the
MCC/MNC matching and relies on the ACL only.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=b0e9dd487f84254f0884dfba0af1237b…
commit b0e9dd487f84254f0884dfba0af1237b82525734
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Nov 4 11:15:01 2014 +0100
sgsn/test: Add VTY tests for the SGSN
This patch adds some basic SGSN tests to vty_test_runner.py:
- check for config tree nodes
- check specific show commands
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=a6a499fc8174e77bc468c2f593fe86ca…
commit a6a499fc8174e77bc468c2f593fe86ca4b0363b5
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Oct 24 18:09:54 2014 +0200
sgsn: Make authorization asynchronous
Currently the authorization of an IMSI is done by checking ACLs
synchronously which is not feasible when the subscriber data has to
be retrieved from an external source.
This patch changes this by using a callback when the information is
available. This is also done when only ACL are checked, in this case
the callback is invoked from within sgsn_auth_request(). The callback
function sgsn_update_subscriber_data calls sgsn_auth_update which
in turn calls either gsm0408_gprs_access_granted or
gsm0408_gprs_access_denied. gsm48_gmm_authorize is extended by a call
to sgsn_auth_request when IMSI and IMEI are available but the
auth_state is unknown.
The change has been successfully tested with single phones (E71 and
IPhone 5c).
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=3f2dfee7ca5769b351b2d2a9d6ecdd59…
commit 3f2dfee7ca5769b351b2d2a9d6ecdd5903243e87
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Nov 3 12:48:43 2014 +0100
bsc: Fix use-after-free on OML NM messages from the BTS
Currently the sign_link pointer is dereferenced after a call to
osmo_signal_dispatch, which can indirectly call
e1inp_sign_link_destroy. If that happens, accessing *sign_link is
illegal and can lead to a segmentation violation.
Since only the bts pointer is needed from sign_link after the call to
osmo_signal_dispatch, this patch changes abis_nm_rcvmsg_fom to save
that pointer to a local variable earlier.
Addresses:
<0019> input/ipa.c:250 accept()ed new link from 192.168.1.101 to port 3002
SET ATTR NACK CAUSE=Message cannot be performed
<0005> bsc_init.c:52 Got a NACK going to drop the OML links.
<001b> bsc_init.c:319 Lost some E1 TEI link: 1 0xb351a830
=================================================================
==13198== ERROR: AddressSanitizer: heap-use-after-free on address 0xb5d1bc70 at pc 0x80a6e3d bp 0xbfbb33d8 sp 0xbfbb33cc
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=06e8cf5c76a900227f8ed32489ecfd4a…
commit 06e8cf5c76a900227f8ed32489ecfd4a683ee5f6
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Wed Oct 29 22:12:20 2014 +0100
sgsn: Move IMSI authorization to gsm48_gmm_authorize
Currently the IMSI is only checked immediately when an Attach Request
is received that contains an IMSI IE. If it contains a P-TMSI
instead, access is always granted.
This commit moves the IMSI check to gsm48_gmm_authorize where it is
applied when IMSI and IMEI have been acquired. This fixes the
authorization when the Attach Accept doesn't contain an IMSI.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=60e0f06e985106204be526b9a90f21e7…
commit 60e0f06e985106204be526b9a90f21e7c417a0b6
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Oct 31 12:27:11 2014 +0100
sgsn: Fix LLME leak when forcing a reattach
Currently when forceing a reattach by sending a Detach
Request (reattach), the SGSN waits for the Detach Accept until it
frees the MM context (if present) and the LLME. If that message gets
lost or isn't sent by the MS, the LLME is never freed if it isn't
bound to an MM context.
This patch adds code to free the MM context/LLME when forcing a
reattachment.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=e7308002c55da89a76f4b5db4cae2e4d…
commit e7308002c55da89a76f4b5db4cae2e4df5024375
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Oct 31 12:20:49 2014 +0100
sgsn: Split gsm0408_gprs_force_reattach into 2 functions
This patch replaces gsm0408_gprs_force_reattach(msg, mmctx) by two
functions
- gsm0408_gprs_force_reattach(mmctx)
- gsm0408_gprs_force_reattach_oldmsg(msg)
The old function basically consists of the code of the two new
functions, where the code patch selected depends on mmctx == NULL,
which is harder to maintain, less obvious to use, and not consistent
with many other SGSN functions.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=c2f6fab069d14382dc444753bd59f62d…
commit c2f6fab069d14382dc444753bd59f62d87623aeb
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Nov 3 10:12:52 2014 +0100
sgsn: Call mm_ctx_cleanup_free to deregister MM context
Currently the MM context isn't always removed when it is
de-registered (mmctx_timer_cb), mm_state is set to GMM_DEREGISTERED
instead. This can lead to left-over MM contexts which are only
cleaned up if the MS reattaches.
This patch replaces all of these assignments by a call to
mm_ctx_cleanup_free.
Ticket: OW#1324
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=41fde68761737c8590b68e4b1aed102b…
commit 41fde68761737c8590b68e4b1aed102b62b4c2e6
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Oct 28 16:23:46 2014 +0100
sgsn: Cleanup GMM state transitions
Currently the GMM state is set to GMM-REGISTERED when an Attach
Accept or a RA Update Accept message is sent, even if a new P-TMSI is
included. In this case 04.08 requires (see 4.7.3.1.3 and 4.7.5.1.3),
that the state is set to GMM-COMMON-PROCEDURE-INITIATED when the
Accept is sent. When the Complete is received, the SGSN shall set
the state to GMM-REGISTERED.
This patch modifies the state updates accordingly.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=597583f635d377d24cf00c3ba93e3037…
commit 597583f635d377d24cf00c3ba93e303735cc270c
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Wed Oct 29 12:11:58 2014 +0100
sgsn/test: Add test_gmm_attach
This test checks the attach procedure until the Attach Complete is
received.
Note that authorization and GMM state updates are not working
properly yet.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=dd79c53aa6a7ea844852ca257f58a71a…
commit dd79c53aa6a7ea844852ca257f58a71aa422b747
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Wed Oct 29 10:31:18 2014 +0100
sgsn/test: Move message sending to send_0408_message
This replaces serveral occurences of duplicated code for message
creation and sending (passing to gsm0408_gprs_rcvmsg) into a single
function. In addition, the sgsn_tx_counter is always reset within
send_0408_message to simplify the code that checks for the number of
messages sent.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=7dc3f3cc4ec9067bbeb7c030f42396bd…
commit 7dc3f3cc4ec9067bbeb7c030f42396bd866efbb4
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Oct 28 12:23:29 2014 +0100
sgsn: Reorganize and fix gsm48_gmm_authorize
Currently the order of the 'if' clauses in gsm48_gmm_authorize
doesn't match the order in which the conditional parts are entered.
This makes it difficult to maintain. In addition the t3350_mode is
not stored in every path, so that this information is lost when the
identification procedure is started. Since the default value
coincidentally is GMM_T3350_MODE_ATT, this doesn't hurt for Attach
Requests which are the only messages that initially trigger the
authentication yet.
This patch changes the order of the 'if' clause to match the
processing order, it removes the t3350_mode parameter entirely and
introduces a mm->pending_req field. The latter must be set when the
request that causes the authorization before calling
gsm48_gmm_authorize. The gprs_t3350_mode enum is extended by
GMM_T3350_MODE_NONE (value 0, which is the default) to make it
possible to detect related initialisation errors or race conditions.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=f47bdf819239b9eb44350497e6c4f95e…
commit f47bdf819239b9eb44350497e6c4f95ef31e7e25
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Oct 31 10:47:29 2014 +0100
gbproxy: Honour the BSS TLLI type when creating an SGSN TLLI
Currently gbproxy_make_sgsn_tlli always returns a foreign TLLI when
it uses the (SGSN) P-TMSI to generate one.
This patch changes the implementation to return a SGSN TLLI of the
same type like the BSS TLLI in that case.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=d0998fbe927ac54e0f50326b161773f8…
commit d0998fbe927ac54e0f50326b161773f8a5728b18
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Oct 30 17:15:43 2014 +0100
gbproxy: Reset TLLIs when the link_info is found by IMSI/P-TMSI
Currently when the MS does a re-attach without doing a proper detach
first, the gbproxy uses the old local TLLI if patching and the keep
mode are enabled. This leads to a failing attachment procedure when
TLLI patching is also enabled.
This patch changes gbproxy_get_link_info_ul to reset all TLLIs within the
link_info if the message contains an unknown TLLI and an MI. This is
generally the case with Attach Request messages.
Ticket: OW#1324
Sponsored-by: On-Waves ehf
-----------------------------------------------------------------------
Summary of changes:
openbsc/include/openbsc/ipaccess.h | 4 +-
openbsc/src/gprs/gprs_gmm.c | 6 +-
openbsc/tests/sgsn/sgsn_test.c | 143 +++++++++++++++++++++++++++++++++++++
openbsc/tests/sgsn/sgsn_test.ok | 6 ++
4 files changed, 155 insertions(+), 4 deletions(-)
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, jerlbeck/wip/gprs-patching has been updated
discards 798f3c247984a53ab8e5c68beff106b45a40b7ae (commit)
discards 41bfd4bc8731b7f6ce16f4b4097afb29b92e20bb (commit)
via 87767b2bf18fe9bcaf7954573d94dbb8547df1de (commit)
via 95e67b7a58dd3ac5e4be9d51ccce32f0047cd721 (commit)
This update added new revisions after undoing existing revisions. That is
to say, the old revision is not a strict subset of the new revision. This
situation occurs when you --force push a change and generate a repository
containing something like this:
* -- * -- B -- O -- O -- O (798f3c247984a53ab8e5c68beff106b45a40b7ae)
\
N -- N -- N (87767b2bf18fe9bcaf7954573d94dbb8547df1de)
When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=87767b2bf18fe9bcaf7954573d94dbb8…
commit 87767b2bf18fe9bcaf7954573d94dbb8547df1de
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Nov 6 15:43:10 2014 +0100
sgsn: Don't assign a new P-TMSI if one is pending (TODO)
Currently every time a RA Update Req or an Attach Req is processed, a
new P-TMSI is alocated. When an MS issues another of these messages
before it has completed the first procedure, old_ptmsi is replaced by
ptmsi (and thus lost) and ptmsi is replaced by the newly allocated
P-TMSI. This can confuse the gbproxy, which can loose track of the
logical link then. At least a blackberry emits a double set of RA Upd
Req messages from time to time which may be just 20ms apart.
This patch adds a check whether mm->ptmsi or mm->old_ptmsi are not
both set. If both are set, the P-TMSI is not re-allocated. This is
only the case, if the Complete message has not been received since
that resets old_ptmsi.
TODO:
- Test case
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=95e67b7a58dd3ac5e4be9d51ccce32f0…
commit 95e67b7a58dd3ac5e4be9d51ccce32f0047cd721
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Nov 6 13:43:41 2014 +0100
sgsn: Cleanup after RA Update Reject / Attach Reject (TODO)
Currently, the LLME is not cleanup up after sending an RA Update
Reject. This happens after entering a routing area from outside,
since in that case the SGSN sends an RA Update Reject (implicitly
detached) which causes the MS to restart the attach procedure.
The LLME is also not updated if an Attach Request with message errors
(encoding, invalid MI type) is received or if an MM context cannot be
allocated.
This patch changes gsm48_rx_gmm_ra_upd_req and gsm48_rx_gmm_att_req
to unassign the LLME or free the MM context (if available) after a
Reject message has been sent.
TODO:
- test cases
Ticket: OW#1324
Sponsored-by: On-Waves ehf
-----------------------------------------------------------------------
Summary of changes:
openbsc/src/gprs/gprs_gmm.c | 28 ++++++++++++++++++++++++----
1 file changed, 24 insertions(+), 4 deletions(-)
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, master has been updated
via 1464a121c02786b0b7a9ea7b92f33aeacf187c55 (commit)
from 9d0fb1e97adbf5d241b46d374c2aa9c3af6c1e6b (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=1464a121c02786b0b7a9ea7b92f33aea…
commit 1464a121c02786b0b7a9ea7b92f33aeacf187c55
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Thu Nov 6 16:32:57 2014 +0100
ipa: Correct the prototype of these functions
They return nothing and not int.
-----------------------------------------------------------------------
Summary of changes:
openbsc/include/openbsc/ipaccess.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, jerlbeck/wip/gprs-patching has been updated
discards 320360e2a5f79585c86b5b4260c8266b3ee18d31 (commit)
discards bfe6df93178cc46c317edb4aa53cd5643a30896b (commit)
discards 2d193dc608e8cd15482ca477f04fa24762136707 (commit)
discards a1f9bd765cda631ddcd7c0f6700b6ad013f5c31a (commit)
discards 3edce24bbad14d2c205678df1373e23d639eaf65 (commit)
discards d63d2bbe52d4cd789559cd18fa4d01548b8a6e3f (commit)
discards 642884c2d5e9563b108a4c75e44174941bdc405f (commit)
discards 6b9660f3d8e480f3fd245a1c449f1f65e0a95c99 (commit)
discards 645c3beddb25f94ef4172a112645df07613a75ff (commit)
discards ed7938ffd98223b708c1e03b8501e4e42821bc41 (commit)
discards f00eb01918336841a2ff6ee42f58c9da70ae5794 (commit)
discards 3490aaa13707d9455093cc208a227cdc578bd259 (commit)
discards 228463cbbfdfc4ea25f16a24cafebaebbe94a2c5 (commit)
discards 88090b017cc3b21ec1c8a3a4dfce603b7179b14f (commit)
discards 885f30b7491332f83a6fee9ea68347e355f7e5bc (commit)
discards 055477327eee5077628c0f6d08d79ec8f7a075c1 (commit)
discards 597027dec1f1d40c0060f522c4aa21c1c8c41504 (commit)
discards 2697b17b2a2a8911380f84bb2023178a417e4657 (commit)
discards e09e74115dcc16dd65d3c24b12ba8ab81ea43a6d (commit)
discards 0f3a27a5838097f1c919f25a6fe96dea408ee7fa (commit)
discards 6b28501dd45819354f76861e3920b9de72a9db95 (commit)
via 798f3c247984a53ab8e5c68beff106b45a40b7ae (commit)
via 41bfd4bc8731b7f6ce16f4b4097afb29b92e20bb (commit)
via fab825a4637c1210187f05a93392be7072a87575 (commit)
via f9947e70d3a0f6bc70a9d9767b988ceb15fa6266 (commit)
via 9e80019b7c3389843ba2020c3ae0e64e6d83e8c9 (commit)
via ec75ba6ffa901c81ab936f95a8b887fe2174019b (commit)
via e444e3bb8a48bf751cb9286d80ddcdf7b101011b (commit)
via c16741bf78ba1ac4586cefbff0f4c2508a2d8fed (commit)
via 825eae2fa138e92d98d3b0d58cbf7c807c1ea491 (commit)
via 194943609b16f88539edadd11a15d56080d06b29 (commit)
via e2c08577a8c0ceae7c2c6f82c328d04d9086175c (commit)
via b1751e0b0cb2b153d98d951fb46745d24d06b53d (commit)
via b44a1895051b222c1aa0d1f1bce268a84a8c6116 (commit)
via fd0b34a3fa0485eef7a8b7745d452ac7904a8111 (commit)
via 7f416f4799814d179b5cbf9c272b8df45e646754 (commit)
via b62b4af85781e2e17b4cee35ac129451bb8036b7 (commit)
via f462d2ebbc68c36a511ae9ab7088e5ae0bd1dec1 (commit)
via 843caa4a7f2a0d27378fe97f405c65b5899c61ca (commit)
via d6964dc0113acd2ccc9b792d846dbd7e7aa24a14 (commit)
via 9d0fb1e97adbf5d241b46d374c2aa9c3af6c1e6b (commit)
via de74e721b213c41a3b1837fabdd377deeeed9378 (commit)
via 14ae58206406b6cb78113f3460de44376bcd765d (commit)
via 70671421007faa0e7c94d237e53186379990e3f0 (commit)
This update added new revisions after undoing existing revisions. That is
to say, the old revision is not a strict subset of the new revision. This
situation occurs when you --force push a change and generate a repository
containing something like this:
* -- * -- B -- O -- O -- O (320360e2a5f79585c86b5b4260c8266b3ee18d31)
\
N -- N -- N (798f3c247984a53ab8e5c68beff106b45a40b7ae)
When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=798f3c247984a53ab8e5c68beff106b4…
commit 798f3c247984a53ab8e5c68beff106b45a40b7ae
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Nov 6 15:43:10 2014 +0100
sgsn: Don't assign a new P-TMSI if one is pending (TODO)
Currently every time a RA Update Req or an Attach Req is processed, a
new P-TMSI is alocated. When an MS issues another of these messages
before it has completed the first procedure, old_ptmsi is replaced by
ptmsi (and thus lost) and ptmsi is replaced by the newly allocated
P-TMSI. This can confuse the gbproxy, which can loose track of the
logical link then. At least a blackberry emits a double set of RA Upd
Req messages from time to time which may be just 20ms apart.
This patch adds a check whether mm->ptmsi or mm->old_ptmsi are not
both set. If both are set, the P-TMSI is not re-allocated. This is
only the case, if the Complete message has not been received since
that resets old_ptmsi.
TODO:
- Test case
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=41bfd4bc8731b7f6ce16f4b4097afb29…
commit 41bfd4bc8731b7f6ce16f4b4097afb29b92e20bb
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Nov 6 13:43:41 2014 +0100
sgsn: Cleanup after RA Update Reject (TODO)
Currently, the LLME is not cleanup up after sending an RA Update
Reject. This happens after entering a routing area from outside,
since in that case the SGSN sends an RA Update Reject (implicitly
detached) which causes the MS to restart the attach procedure.
This patch changes gsm48_rx_gmm_ra_upd_req to unassign the LLME or
free the MM context (if available) after a Reject message has been
sent.
TODO:
- test cases
Ticket: OW#1324
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=fab825a4637c1210187f05a93392be70…
commit fab825a4637c1210187f05a93392be7072a87575
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Sep 30 13:53:26 2014 +0200
sgsn: Added TODOs (TODO)
TODO:
- fix and remove TODOs
- add test cases for Detach(reattach)
- add test cases for PDP context deletion (OW#1311)
- add test cases for Cancel pending timer in sgsn_mm_ctx_free
- remove this commit
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=f9947e70d3a0f6bc70a9d9767b988ceb…
commit f9947e70d3a0f6bc70a9d9767b988ceb15fa6266
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Oct 17 10:08:02 2014 +0200
sgsn: Do not die in _bssgp_tx_dl_ud on TLLI mismatch (TODO)
Currently an OSMO_ASSERT fails, if the message's and the mmctx's
TLLIs do not match.
This commit turns the assertion into an ERROR log message and uses
the default values for IMSI, DRX, and RA CAP instead of the MM
context values in this case.
TODO:
- find the real source for the problem
- add test cases derived from what is being described in the ticket
Ticket: OW#1322
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=9e80019b7c3389843ba2020c3ae0e64e…
commit 9e80019b7c3389843ba2020c3ae0e64e6d83e8c9
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Nov 4 12:44:15 2014 +0100
sgsn: Notify an affected MM context if an ACL rule is removed
Currently if an ACL access rule is removed, MS already attached are
not affected until they try to reattach to the SGSN.
This patch extends sgsn_acl_del to re-authenticate an MM context if
it matches the IMSI.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=ec75ba6ffa901c81ab936f95a8b887fe…
commit ec75ba6ffa901c81ab936f95a8b887fe2174019b
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Nov 4 10:08:37 2014 +0100
sgsn: Add 'acl-only' authentication policy
Currently the VTY 'auth-policy' command results in setting or clearing
the acl_enabled flag. This also enables the matching of the MCC/MNC
prefix of the IMSI.
This patch adds an additional policy 'acl-only' which disables the
MCC/MNC matching and relies on the ACL only.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=e444e3bb8a48bf751cb9286d80ddcdf7…
commit e444e3bb8a48bf751cb9286d80ddcdf7b101011b
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Nov 4 11:15:01 2014 +0100
sgsn/test: Add VTY tests for the SGSN
This patch adds some basic SGSN tests to vty_test_runner.py:
- check for config tree nodes
- check specific show commands
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=c16741bf78ba1ac4586cefbff0f4c250…
commit c16741bf78ba1ac4586cefbff0f4c2508a2d8fed
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Oct 24 18:09:54 2014 +0200
sgsn: Make authorization asynchronous
Currently the authorization of an IMSI is done by checking ACLs
synchronously which is not feasible when the subscriber data has to
be retrieved from an external source.
This patch changes this by using a callback when the information is
available. This is also done when only ACL are checked, in this case
the callback is invoked from within sgsn_auth_request(). The callback
function sgsn_update_subscriber_data calls sgsn_auth_update which
in turn calls either gsm0408_gprs_access_granted or
gsm0408_gprs_access_denied. gsm48_gmm_authorize is extended by a call
to sgsn_auth_request when IMSI and IMEI are available but the
auth_state is unknown.
The change has been successfully tested with single phones (E71 and
IPhone 5c).
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=825eae2fa138e92d98d3b0d58cbf7c80…
commit 825eae2fa138e92d98d3b0d58cbf7c807c1ea491
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Nov 3 12:48:43 2014 +0100
bsc: Fix use-after-free on OML NM messages from the BTS
Currently the sign_link pointer is dereferenced after a call to
osmo_signal_dispatch, which can indirectly call
e1inp_sign_link_destroy. If that happens, accessing *sign_link is
illegal and can lead to a segmentation violation.
Since only the bts pointer is needed from sign_link after the call to
osmo_signal_dispatch, this patch changes abis_nm_rcvmsg_fom to save
that pointer to a local variable earlier.
Addresses:
<0019> input/ipa.c:250 accept()ed new link from 192.168.1.101 to port 3002
SET ATTR NACK CAUSE=Message cannot be performed
<0005> bsc_init.c:52 Got a NACK going to drop the OML links.
<001b> bsc_init.c:319 Lost some E1 TEI link: 1 0xb351a830
=================================================================
==13198== ERROR: AddressSanitizer: heap-use-after-free on address 0xb5d1bc70 at pc 0x80a6e3d bp 0xbfbb33d8 sp 0xbfbb33cc
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=194943609b16f88539edadd11a15d560…
commit 194943609b16f88539edadd11a15d56080d06b29
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Wed Oct 29 22:12:20 2014 +0100
sgsn: Move IMSI authorization to gsm48_gmm_authorize
Currently the IMSI is only checked immediately when an Attach Request
is received that contains an IMSI IE. If it contains a P-TMSI
instead, access is always granted.
This commit moves the IMSI check to gsm48_gmm_authorize where it is
applied when IMSI and IMEI have been acquired. This fixes the
authorization when the Attach Accept doesn't contain an IMSI.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=e2c08577a8c0ceae7c2c6f82c328d04d…
commit e2c08577a8c0ceae7c2c6f82c328d04d9086175c
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Oct 31 12:27:11 2014 +0100
sgsn: Fix LLME leak when forcing a reattach
Currently when forceing a reattach by sending a Detach
Request (reattach), the SGSN waits for the Detach Accept until it
frees the MM context (if present) and the LLME. If that message gets
lost or isn't sent by the MS, the LLME is never freed if it isn't
bound to an MM context.
This patch adds code to free the MM context/LLME when forcing a
reattachment.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=b1751e0b0cb2b153d98d951fb46745d2…
commit b1751e0b0cb2b153d98d951fb46745d24d06b53d
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Oct 31 12:20:49 2014 +0100
sgsn: Split gsm0408_gprs_force_reattach into 2 functions
This patch replaces gsm0408_gprs_force_reattach(msg, mmctx) by two
functions
- gsm0408_gprs_force_reattach(mmctx)
- gsm0408_gprs_force_reattach_oldmsg(msg)
The old function basically consists of the code of the two new
functions, where the code patch selected depends on mmctx == NULL,
which is harder to maintain, less obvious to use, and not consistent
with many other SGSN functions.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=b44a1895051b222c1aa0d1f1bce268a8…
commit b44a1895051b222c1aa0d1f1bce268a84a8c6116
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Mon Nov 3 10:12:52 2014 +0100
sgsn: Call mm_ctx_cleanup_free to deregister MM context
Currently the MM context isn't always removed when it is
de-registered (mmctx_timer_cb), mm_state is set to GMM_DEREGISTERED
instead. This can lead to left-over MM contexts which are only
cleaned up if the MS reattaches.
This patch replaces all of these assignments by a call to
mm_ctx_cleanup_free.
Ticket: OW#1324
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=fd0b34a3fa0485eef7a8b7745d452ac7…
commit fd0b34a3fa0485eef7a8b7745d452ac7904a8111
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Oct 28 16:23:46 2014 +0100
sgsn: Cleanup GMM state transitions
Currently the GMM state is set to GMM-REGISTERED when an Attach
Accept or a RA Update Accept message is sent, even if a new P-TMSI is
included. In this case 04.08 requires (see 4.7.3.1.3 and 4.7.5.1.3),
that the state is set to GMM-COMMON-PROCEDURE-INITIATED when the
Accept is sent. When the Complete is received, the SGSN shall set
the state to GMM-REGISTERED.
This patch modifies the state updates accordingly.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=7f416f4799814d179b5cbf9c272b8df4…
commit 7f416f4799814d179b5cbf9c272b8df45e646754
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Wed Oct 29 12:11:58 2014 +0100
sgsn/test: Add test_gmm_attach
This test checks the attach procedure until the Attach Complete is
received.
Note that authorization and GMM state updates are not working
properly yet.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=b62b4af85781e2e17b4cee35ac129451…
commit b62b4af85781e2e17b4cee35ac129451bb8036b7
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Wed Oct 29 10:31:18 2014 +0100
sgsn/test: Move message sending to send_0408_message
This replaces serveral occurences of duplicated code for message
creation and sending (passing to gsm0408_gprs_rcvmsg) into a single
function. In addition, the sgsn_tx_counter is always reset within
send_0408_message to simplify the code that checks for the number of
messages sent.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=f462d2ebbc68c36a511ae9ab7088e5ae…
commit f462d2ebbc68c36a511ae9ab7088e5ae0bd1dec1
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Oct 28 12:23:29 2014 +0100
sgsn: Reorganize and fix gsm48_gmm_authorize
Currently the order of the 'if' clauses in gsm48_gmm_authorize
doesn't match the order in which the conditional parts are entered.
This makes it difficult to maintain. In addition the t3350_mode is
not stored in every path, so that this information is lost when the
identification procedure is started. Since the default value
coincidentally is GMM_T3350_MODE_ATT, this doesn't hurt for Attach
Requests which are the only messages that initially trigger the
authentication yet.
This patch changes the order of the 'if' clause to match the
processing order, it removes the t3350_mode parameter entirely and
introduces a mm->pending_req field. The latter must be set when the
request that causes the authorization before calling
gsm48_gmm_authorize. The gprs_t3350_mode enum is extended by
GMM_T3350_MODE_NONE (value 0, which is the default) to make it
possible to detect related initialisation errors or race conditions.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=843caa4a7f2a0d27378fe97f405c65b5…
commit 843caa4a7f2a0d27378fe97f405c65b5899c61ca
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Oct 31 10:47:29 2014 +0100
gbproxy: Honour the BSS TLLI type when creating an SGSN TLLI
Currently gbproxy_make_sgsn_tlli always returns a foreign TLLI when
it uses the (SGSN) P-TMSI to generate one.
This patch changes the implementation to return a SGSN TLLI of the
same type like the BSS TLLI in that case.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=d6964dc0113acd2ccc9b792d846dbd7e…
commit d6964dc0113acd2ccc9b792d846dbd7e7aa24a14
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Oct 30 17:15:43 2014 +0100
gbproxy: Reset TLLIs when the link_info is found by IMSI/P-TMSI
Currently when the MS does a re-attach without doing a proper detach
first, the gbproxy uses the old local TLLI if patching and the keep
mode are enabled. This leads to a failing attachment procedure when
TLLI patching is also enabled.
This patch changes gbproxy_get_link_info_ul to reset all TLLIs within the
link_info if the message contains an unknown TLLI and an MI. This is
generally the case with Attach Request messages.
Ticket: OW#1324
Sponsored-by: On-Waves ehf
-----------------------------------------------------------------------
Summary of changes:
openbsc/src/gprs/gprs_gmm.c | 38 +++++++++++++++++++++++++++++++-------
1 file changed, 31 insertions(+), 7 deletions(-)
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, master has been updated
via 9d0fb1e97adbf5d241b46d374c2aa9c3af6c1e6b (commit)
via de74e721b213c41a3b1837fabdd377deeeed9378 (commit)
via 14ae58206406b6cb78113f3460de44376bcd765d (commit)
via 70671421007faa0e7c94d237e53186379990e3f0 (commit)
from db64f2e45adf7ac95070361f5b7ec76a44e084fb (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=9d0fb1e97adbf5d241b46d374c2aa9c3…
commit 9d0fb1e97adbf5d241b46d374c2aa9c3af6c1e6b
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Oct 31 10:43:44 2014 +0100
gbproxy/test: Extend test_gbproxy_keep_info
Add new test message sequences:
- Normal attach (with IMSI) after detach (ok)
- Normal attach (with local TLLI) after detach (ok)
- Unexpected attach (with IMSI) after successful TLLI validation (fails)
- Unexpected attach (with P-TMSI) after successful TLLI validation (fails)
Ticket: OW#1324
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=de74e721b213c41a3b1837fabdd377de…
commit de74e721b213c41a3b1837fabdd377deeeed9378
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Oct 28 11:29:43 2014 +0100
gbproxy: Fixed VTY doc for delete-gbproxy-link
The command definition delete_gb_link_by_id_cmd lacks a description
for the sgsn-nsei token.
This patch adds the missing description.
Addresses:
Verifying src/gprs/osmo-gbproxy -c doc/examples/osmo-gbproxy/osmo-gbproxy.cfg, test verify_doc
Documentation error (missing docs):
<command id='delete-gbproxy-link <0-65534> (tlli|imsi|sgsn-nsei) IDENT'>
<param name='IDENT' doc='(null)' />
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=14ae58206406b6cb78113f3460de4437…
commit 14ae58206406b6cb78113f3460de44376bcd765d
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Oct 28 09:47:03 2014 +0100
sgsn: Unassign the LLME after GMM Status without mmctx
Currently the LLME is not deleted when a GMM Status message is
received for which a mmctx cannot be found. This can fill the LLME
list with unneeded entries.
This patch adds code to unassign the LLME in that case.
Ticket: OW#1324
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=70671421007faa0e7c94d237e5318637…
commit 70671421007faa0e7c94d237e53186379990e3f0
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Wed Oct 29 22:57:30 2014 +0100
sgsn: Remove unused static functions from gprs_gmm.c
The following functions are not being used:
- gsm48_tx_gmm_status_oldmsg
- gsm48_tx_sm_status_oldmsg
This patch removes the function definitions.
Sponsored-by: On-Waves ehf
-----------------------------------------------------------------------
Summary of changes:
openbsc/src/gprs/gb_proxy_vty.c | 1 +
openbsc/src/gprs/gprs_gmm.c | 22 +-
openbsc/tests/gbproxy/gbproxy_test.c | 375 ++++++++++++++++++++
openbsc/tests/gbproxy/gbproxy_test.ok | 638 ++++++++++++++++++++++++++++++----
openbsc/tests/sgsn/sgsn_test.c | 39 +++
openbsc/tests/sgsn/sgsn_test.ok | 1 +
6 files changed, 994 insertions(+), 82 deletions(-)
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNURadio hardware abstraction block".
The branch, master has been updated
via 9fd5b367c115c19402d35e3408daf45888918b43 (commit)
via a45968f3381f33b86ca344bb76bd62c131d98d93 (commit)
via 6e75abf1986ff4c3a3b71d0c32537956adce8118 (commit)
via 7f82d289a6f196a6f7b72bc0cff1807870ee8837 (commit)
via 23b1b9cdb1349bb61b9fa2acae6482c654d2a8f6 (commit)
from 42c66fdd70a70115f6cbc390f801ca4ca42e581d (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/gr-osmosdr/commit/?id=9fd5b367c115c19402d35e3408daf…
commit 9fd5b367c115c19402d35e3408daf45888918b43
Author: Dimitri Stolnikov <horiz0n(a)gmx.net>
Date: Wed Nov 5 00:07:26 2014 +0100
update version to 0.1.5git
http://cgit.osmocom.org/gr-osmosdr/commit/?id=a45968f3381f33b86ca344bb76bd6…
commit a45968f3381f33b86ca344bb76bd62c131d98d93
Author: Dimitri Stolnikov <horiz0n(a)gmx.net>
Date: Wed Nov 5 00:07:07 2014 +0100
update version to 0.1.4
http://cgit.osmocom.org/gr-osmosdr/commit/?id=6e75abf1986ff4c3a3b71d0c32537…
commit 6e75abf1986ff4c3a3b71d0c32537956adce8118
Author: Jon Szymaniak <jon.szymaniak(a)gmail.com>
Date: Sun Oct 26 16:08:42 2014 -0400
bladeRF: Don't fail out until 3 consecutive errors have occurred
This change is intended to make the bladeRF source/sink implementations
slightly more resilient to any transient issues in a flow graph.
For poor choices of buffers/transfers or under high CPU load, an RX or
TX operation might time out. Instead of immediately reporting WORK_DONE
and bailing out, an error message is now printed and the device will
attempt to continue transmitting/receiving samples.
After 3 consecutive errors have occurred on an RX/TX operation, the
device will report WORK_DONE; in this situation, something is likely
very wrong.
http://cgit.osmocom.org/gr-osmosdr/commit/?id=7f82d289a6f196a6f7b72bc0cff18…
commit 7f82d289a6f196a6f7b72bc0cff1807870ee8837
Author: Jon Szymaniak <jon.szymaniak(a)gmail.com>
Date: Sat Oct 25 16:23:58 2014 -0400
bladeRF: Default num_transfers to min(32, num_buffers/2)
This avoids inadvertently attempting to use a larger number of transfers
than the underlying USB library/interface allows by specifying a large
value for num_buffers.
Users can specify up to (num_buffers - 1) transfers. However, it is
generally recommended to use half as many transfers as buffers.
http://cgit.osmocom.org/gr-osmosdr/commit/?id=23b1b9cdb1349bb61b9fa2acae648…
commit 23b1b9cdb1349bb61b9fa2acae6482c654d2a8f6
Author: Jon Szymaniak <jon.szymaniak(a)gmail.com>
Date: Sat Oct 25 15:11:57 2014 -0400
bladeRF: Removed unused bladerf_metadata parameter from rx/tx calls
It is safe (and preferred) to pass NULL for the metadata paremeter when
using a format that does utilize the metadata structure.
-----------------------------------------------------------------------
Summary of changes:
CMakeLists.txt | 2 +-
lib/bladerf/bladerf_common.cc | 17 +++++++++++++----
lib/bladerf/bladerf_common.h | 3 +++
lib/bladerf/bladerf_sink_c.cc | 15 ++++++++++++---
lib/bladerf/bladerf_source_c.cc | 15 ++++++++++++---
5 files changed, 41 insertions(+), 11 deletions(-)
hooks/post-receive
--
GNURadio hardware abstraction block
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNURadio hardware abstraction block".
The annotated tag, v0.1.4 has been created
at 3d4fc14343eff2f3ac450d6ac438949313f0235e (tag)
tagging a45968f3381f33b86ca344bb76bd62c131d98d93 (commit)
replaces v0.1.3
tagged by Dimitri Stolnikov
on Wed Nov 5 00:10:08 2014 +0100
- Log -----------------------------------------------------------------
gnuradio 3.7.5git-0-g2bb2b314
gr-iqbal 44ab02f6
gr-fcdproplus 1edbe523
uhd d99ce4ef99
librtlsdr v0.5.3-6-gd447
libmirisdr 3174
libosmosdr v0.1-43-gb697
libhackrf 635d429a
libbladeRF af887e5d
libairspy b4c38a71
Dimitri Stolnikov (5):
update version to 0.1.4git
source/sink: don't discover devices if already specified via args
hackrf: disable AMP gain stage by default to protect it from damage
hackrf: update copyright for SSE/AVX routines
update version to 0.1.4
Jon Szymaniak (3):
bladeRF: Removed unused bladerf_metadata parameter from rx/tx calls
bladeRF: Default num_transfers to min(32, num_buffers/2)
bladeRF: Don't fail out until 3 consecutive errors have occurred
-----------------------------------------------------------------------
hooks/post-receive
--
GNURadio hardware abstraction block
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, jerlbeck/wip/gprs-patching has been updated
discards d4e5342b0f3b28caaf10bc51e916904572074e25 (commit)
discards c6abb6e5708fb85bdcba0e02b06f4d4bdc246fbe (commit)
discards 279b012bd62518c45a4fa300a94cd9bfe5219665 (commit)
via 320360e2a5f79585c86b5b4260c8266b3ee18d31 (commit)
via bfe6df93178cc46c317edb4aa53cd5643a30896b (commit)
via 2d193dc608e8cd15482ca477f04fa24762136707 (commit)
via a1f9bd765cda631ddcd7c0f6700b6ad013f5c31a (commit)
via 3edce24bbad14d2c205678df1373e23d639eaf65 (commit)
via d63d2bbe52d4cd789559cd18fa4d01548b8a6e3f (commit)
This update added new revisions after undoing existing revisions. That is
to say, the old revision is not a strict subset of the new revision. This
situation occurs when you --force push a change and generate a repository
containing something like this:
* -- * -- B -- O -- O -- O (d4e5342b0f3b28caaf10bc51e916904572074e25)
\
N -- N -- N (320360e2a5f79585c86b5b4260c8266b3ee18d31)
When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=320360e2a5f79585c86b5b4260c8266b…
commit 320360e2a5f79585c86b5b4260c8266b3ee18d31
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Sep 30 13:53:26 2014 +0200
sgsn: Added TODOs (TODO)
TODO:
- fix and remove TODOs
- add test cases for Detach(reattach)
- add test cases for PDP context deletion (OW#1311)
- add test cases for Cancel pending timer in sgsn_mm_ctx_free
- remove this commit
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=bfe6df93178cc46c317edb4aa53cd564…
commit bfe6df93178cc46c317edb4aa53cd5643a30896b
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Oct 17 10:08:02 2014 +0200
sgsn: Do not die in _bssgp_tx_dl_ud on TLLI mismatch (TODO)
Currently an OSMO_ASSERT fails, if the message's and the mmctx's
TLLIs do not match.
This commit turns the assertion into an ERROR log message and uses
the default values for IMSI, DRX, and RA CAP instead of the MM
context values in this case.
TODO:
- find the real source for the problem
- add test cases derived from what is being described in the ticket
Ticket: OW#1322
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=2d193dc608e8cd15482ca477f04fa247…
commit 2d193dc608e8cd15482ca477f04fa24762136707
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Nov 4 12:44:15 2014 +0100
sgsn: Notify an affected MM context if an ACL rule is removed
Currently if an ACL access rule is removed, MS already attached are
not affected until they try to reattach to the SGSN.
This patch extends sgsn_acl_del to re-authenticate an MM context if
it matches the IMSI.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=a1f9bd765cda631ddcd7c0f6700b6ad0…
commit a1f9bd765cda631ddcd7c0f6700b6ad013f5c31a
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Nov 4 10:08:37 2014 +0100
sgsn: Add 'acl-only' authentication policy
Currently the VTY 'auth-policy' command results in setting or clearing
the acl_enabled flag. This also enables the matching of the MCC/MNC
prefix of the IMSI.
This patch adds an additional policy 'acl-only' which disables the
MCC/MNC matching and relies on the ACL only.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=3edce24bbad14d2c205678df1373e23d…
commit 3edce24bbad14d2c205678df1373e23d639eaf65
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Nov 4 11:15:01 2014 +0100
sgsn/test: Add VTY tests for the SGSN
This patch adds some basic SGSN tests to vty_test_runner.py:
- check for config tree nodes
- check specific show commands
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/openbsc/commit/?id=d63d2bbe52d4cd789559cd18fa4d0154…
commit d63d2bbe52d4cd789559cd18fa4d01548b8a6e3f
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Oct 24 18:09:54 2014 +0200
sgsn: Make authorization asynchronous
Currently the authorization of an IMSI is done by checking ACLs
synchronously which is not feasible when the subscriber data has to
be retrieved from an external source.
This patch changes this by using a callback when the information is
available. This is also done when only ACL are checked, in this case
the callback is invoked from within sgsn_auth_request(). The callback
function sgsn_update_subscriber_data calls sgsn_auth_update which
in turn calls either gsm0408_gprs_access_granted or
gsm0408_gprs_access_denied. gsm48_gmm_authorize is extended by a call
to sgsn_auth_request when IMSI and IMEI are available but the
auth_state is unknown.
The change has been successfully tested with single phones (E71 and
IPhone 5c).
Sponsored-by: On-Waves ehf
-----------------------------------------------------------------------
Summary of changes:
openbsc/include/openbsc/gprs_sgsn.h | 2 +
openbsc/include/openbsc/sgsn.h | 8 +++-
openbsc/src/gprs/gprs_gmm.c | 7 +++-
openbsc/src/gprs/sgsn_auth.c | 74 +++++++++++++++++++++++++++----------
openbsc/src/gprs/sgsn_main.c | 2 +-
openbsc/src/gprs/sgsn_vty.c | 25 +++++++++----
openbsc/tests/sgsn/sgsn_test.c | 3 +-
openbsc/tests/vty_test_runner.py | 69 ++++++++++++++++++++++++++++++++++
8 files changed, 156 insertions(+), 34 deletions(-)
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)