osmocom-commitlog November 2014

osmocom-commitlog@lists.osmocom.org

1 participants
44 discussions

Start a nNew thread

openbsc.git branch jerlbeck/wip/gprs-patching updated. 0.13.0-763-g24b1a8b
by gitosis＠osmocom.org 13 Nov '14

13 Nov '14

1 0

openbsc.git branch jerlbeck/wip/gprs-patching updated. 0.13.0-762-gf610132
by gitosis＠osmocom.org 12 Nov '14

12 Nov '14

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, jerlbeck/wip/gprs-patching has been updated discards c93f898e6de4dfc3328b206cd2b8724c6c133215 (commit) discards 6d1dc3c02f5a2839e998c7ec1275270d49b9db9e (commit) discards d49b478c9b91a14daf37de826533fb793827939e (commit) discards c09bee263d257e6f7ac574a542057c2181cd5da8 (commit) discards 1fcb88a3db244830c07f28dcde6467ba3ac9239d (commit) discards 5b98e682e5985fe60a9ebdaae8134a305021ff25 (commit) discards 418c164fa36acbe33b2ec75eccbbba551f62a844 (commit) discards f12e41de7dc441f8c2837f792853511a0e038ddb (commit) discards 3191e00c847cd780d220aa7c9b50c2a5906217a4 (commit) discards e0e0217321efd2d1103d9fa4e73a7a116fa83c6e (commit) discards b460f57502f7a0cc21a5171f877d9528c144c7f7 (commit) discards 3245dbc7a695da12e88991918f73dc8abea8c3fe (commit) discards b88c41d64c2b2df18fc578f996f00cdd76f222af (commit) discards 56e655632df54283b3634e2a2e2dac96710830ff (commit) discards 79a481bfc005283221f300b01efdefad4dcdb9d3 (commit) discards 8e2148ab0ec232b50484c01876316f1417822bde (commit) discards a312c4bb27e6dd1fa03e78138370d583570380d6 (commit) discards 81b6311deaaac6fe97ba11eee94dc922b6b16e14 (commit) discards 5bc648f29af30528349aaabcce8c962210a7b50f (commit) discards db483b72f1c8e2c397f88baa05b6b53f76362a04 (commit) discards 7d8e8b9a13b3b2ea8404581f980869b711617e2e (commit) discards 2c00b904bb31f807c501c26addcc046ca8496521 (commit) discards f9330da55561d3cad6220e8c0a6dea53990309fc (commit) via f61013282c9aee2287bc901261c025f55cc34399 (commit) via d568ce8d2e751553edb2e39c101a813572720b5b (commit) via 90a1647f413b5113f9e3e0fd8dabf78a00e984c9 (commit) via a14c0882329fbb1bf139bc5d9945758c3d06d575 (commit) via 56f869d67f8ae3160a5821df28b688f8b16beace (commit) via 25a2b945cee417df29ce14d8b92744416db2611b (commit) via b7def117ed68d8e99e1488bab2dbcb80ea60b2e6 (commit) via 42ae521031e8d705baf5132471d51780310fb787 (commit) via 66789456de5982e1caa053a59037cc45cd853d8a (commit) via 6d65e861ac5d955ed3746ea513b41a4600bd6ed7 (commit) via e4537ac238e033dc04606139489ee94571fcb991 (commit) via 6a41825bd4f3d222bae2bf34593c50dcda671882 (commit) via ad30d8d3b3af86a789e42ab3804f14aba98c43e0 (commit) via 49ac6fcf3bd39aa6f1fa19fb199de6e45bf1e2f6 (commit) via c11c6b97f6c20739a39edc10cf5988c2583b951e (commit) via 40415c5655d5f5b67c557f733f0c47b2d60eae88 (commit) via be35395defcd81d7661365b97c072711e0e55d23 (commit) via a00c3bd090b024f116c6e134b668cade04b535c1 (commit) via 62a432c7db59c3004a9fc3272d46a6cc9c4269aa (commit) via 584bf98d87497381ea30526d73899d3a5542eb61 (commit) via b8242b0c2422a948fdce005558fc8e5738555ff0 (commit) via acc28f5fa7b9c1ad607bddb47429a04a068c14ef (commit) via 3911880b68ddd92c9dd89d6ac20c26807e33f905 (commit) via cdd4302c6dde84693a16b33362a75061480333cd (commit) via 27cb4d57e049b173fb4cacc78b947f70c691c111 (commit) via 94ef1c0da9a80869256e6a5966d1f1571955c813 (commit) via 41108680293f703da976efe64ea8388ef7a2cd7e (commit) via 0d8ac0eac0a919cb2620d94e661d60b2a96501d3 (commit) via 054bc24e6dc700d4b8e8eec647cbead63454671e (commit) via 74b2028167ddf04a867ae9f269bfa3435c93f252 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (c93f898e6de4dfc3328b206cd2b8724c6c133215) \ N -- N -- N (f61013282c9aee2287bc901261c025f55cc34399) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=f61013282c9aee2287bc901261c025f5… commit f61013282c9aee2287bc901261c025f55cc34399 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Nov 11 14:01:48 2014 +0100 sgsn: Add VTY commands to manage subscriber cache This adds the following commands to the ENABLE node: - show subscriber cache - update-subscriber imsi IMSI insert authorized (0|1) - update-subscriber imsi IMSI cancel These commands are mainly testing tools and maintenance helpers. The update commands work asynchronously and can be used to complete a pending update request or to terminate an existing connection. Note that the subscriber cache is not stored persistently and will always be empty after an SGSN restart. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=d568ce8d2e751553edb2e39c101a8135… commit d568ce8d2e751553edb2e39c101a813572720b5b Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Nov 11 14:47:38 2014 +0100 sgsn: Add gsm0408_gprs_access_cancelled (TODO) This function is called to delete an established MM context without invoking a detach procedure that could disable the GPRS functionality of the MS until the next power cycle. It is called when a subscriber is cancelled. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=90a1647f413b5113f9e3e0fd8dabf78a… commit 90a1647f413b5113f9e3e0fd8dabf78a00e984c9 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Wed Nov 12 10:18:09 2014 +0100 sgsn: Integrate subscriber handling into the SGSN (TODO) This commit adds a new authorization policy 'remote' and uses the subscriber cache for authorization when this policy is being used. Note that there is no remote backend implemented yet. TODO: - tests Ticket: OW#???? Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=a14c0882329fbb1bf139bc5d9945758c… commit a14c0882329fbb1bf139bc5d9945758c3d06d575 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Wed Nov 12 10:12:11 2014 +0100 sgsn: Add gprs_subscriber.c (TODO) This adds GPRS specific functions for gsm_subscriber objects. The sgsn_update_subscriber_data callback is extended by a parameter that passes a reference to a gsm_subscriber. TODO: - tests Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=56f869d67f8ae3160a5821df28b688f8… commit 56f869d67f8ae3160a5821df28b688f8b16beace Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Wed Nov 12 09:53:45 2014 +0100 sgsn: Extend gsm_subscriber and sgsn_mm_ctx by references This adds a field mm to struct gsm_subscriber that will be used by the SGSN to store a reference to the current MM context (or NULL if there is none). This also adds a field subscr to struct sgsn_mm_ctx that reversely points to a gsm_subscriber (or NULL if there is none). Either both fields are NULL or both fields are non-NULL. Note that subscr is being reference counted. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=25a2b945cee417df29ce14d8b9274441… commit 25a2b945cee417df29ce14d8b92744416db2611b Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Fri Nov 7 14:17:44 2014 +0100 sgsn: Refactor sgsn_auth to separate request and authorization (TODO) Currently the authorization is done in sgsn_auth_request for ACL based authorization. This doesn't match the way remote authorization would work, so that there is a second call to sgsn_auth_state already present in sgsn_auth_update. This patch removes the autorization check completely from sgsn_auth_request which in turn now calls sgsn_auth_update directly. TODO: - Use sgsn_instance instead of config as parameter - more commit message text Ticket: OW#???? Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=b7def117ed68d8e99e1488bab2dbcb80… commit b7def117ed68d8e99e1488bab2dbcb80ea60b2e6 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Thu Nov 6 15:43:10 2014 +0100 sgsn: Don't assign a new P-TMSI if one is pending (TODO) Currently every time a RA Update Req or an Attach Req is processed, a new P-TMSI is alocated. When an MS issues another of these messages before it has completed the first procedure, old_ptmsi is replaced by ptmsi (and thus lost) and ptmsi is replaced by the newly allocated P-TMSI. This can confuse the gbproxy, which can loose track of the logical link then. At least a blackberry emits a double set of RA Upd Req messages from time to time which may be just 20ms apart. This patch adds a check whether mm->ptmsi or mm->old_ptmsi are not both set. If both are set, the P-TMSI is not re-allocated. This is only the case, if the Complete message has not been received since that resets old_ptmsi. TODO: - Test case Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=42ae521031e8d705baf5132471d51780… commit 42ae521031e8d705baf5132471d51780310fb787 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Sep 30 13:53:26 2014 +0200 sgsn: Added TODOs (TODO) TODO: - fix and remove TODOs - add test cases for Detach(reattach) - add test cases for PDP context deletion (OW#1311) - add test cases for Cancel pending timer in sgsn_mm_ctx_free - remove this commit Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=66789456de5982e1caa053a59037cc45… commit 66789456de5982e1caa053a59037cc45cd853d8a Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Fri Oct 17 10:08:02 2014 +0200 sgsn: Do not die in _bssgp_tx_dl_ud on TLLI mismatch (TODO) Currently an OSMO_ASSERT fails, if the message's and the mmctx's TLLIs do not match. This commit turns the assertion into an ERROR log message and uses the default values for IMSI, DRX, and RA CAP instead of the MM context values in this case. TODO: - find the real source for the problem - add test cases derived from what is being described in the ticket Ticket: OW#1322 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=6d65e861ac5d955ed3746ea513b41a46… commit 6d65e861ac5d955ed3746ea513b41a4600bd6ed7 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Nov 11 08:55:13 2014 +0100 sgsn: Don't send XID reset after Detach Accept Currently when a Detach Accept is received for an unknown TLLI (which is in general the case afer the SGSN has requested the detachment), an XID reset is sent to the BSS, causing a BSSGP Status message. This happens in gsm0408_rcv_gmm. This patch moves the corresponding call to gprs_llgmm_reset downwards so that it is not being called in that case. Addresses: SGSN->BSS TLLI: 0xd75b91d9 SAPI: LLGMM, UI (DTAP) (GMM) Detach Request BSS->SGSN TLLI: 0xd75b91d9 SAPI: LLGMM, UI (DTAP) (GMM) Detach Accept SGSN->BSS TLLI: 0xd75b91d9 SAPI: LLGMM, U, XID (Reset, IOV-UI) BSS->SGSN TLLI: --- BSSGP STATUS (Unknown MS) Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=e4537ac238e033dc04606139489ee945… commit e4537ac238e033dc04606139489ee94571fcb991 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Thu Nov 6 13:43:41 2014 +0100 sgsn: Cleanup after RA Update Reject / Attach Reject Currently, the LLME is not cleanup up after sending an RA Update Reject. This happens after entering a routing area from outside, since in that case the SGSN sends an RA Update Reject (implicitly detached) which causes the MS to restart the attach procedure. The LLME is also not updated if an Attach Request with message errors (encoding, invalid MI type) is received or if an MM context cannot be allocated. This patch changes gsm48_rx_gmm_ra_upd_req and gsm48_rx_gmm_att_req to unassign the LLME or free the MM context (if available) after a Reject message has been sent. Ticket: OW#1324 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=6a41825bd4f3d222bae2bf34593c50dc… commit 6a41825bd4f3d222bae2bf34593c50dcda671882 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Nov 4 12:44:15 2014 +0100 sgsn: Notify an affected MM context if an ACL rule is removed Currently if an ACL access rule is removed, MS already attached are not affected until they try to reattach to the SGSN. This patch extends sgsn_acl_del to re-authenticate an MM context if it matches the IMSI. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=ad30d8d3b3af86a789e42ab3804f14ab… commit ad30d8d3b3af86a789e42ab3804f14aba98c43e0 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Nov 4 10:08:37 2014 +0100 sgsn: Add 'acl-only' authentication policy Currently the VTY 'auth-policy' command results in setting or clearing the acl_enabled flag. This also enables the matching of the MCC/MNC prefix of the IMSI. This patch adds an additional policy 'acl-only' which disables the MCC/MNC matching and relies on the ACL only. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=49ac6fcf3bd39aa6f1fa19fb199de6e4… commit 49ac6fcf3bd39aa6f1fa19fb199de6e45bf1e2f6 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Nov 4 11:15:01 2014 +0100 sgsn/test: Add VTY tests for the SGSN This patch adds some basic SGSN tests to vty_test_runner.py: - check for config tree nodes - check specific show commands Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=c11c6b97f6c20739a39edc10cf5988c2… commit c11c6b97f6c20739a39edc10cf5988c2583b951e Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Fri Oct 24 18:09:54 2014 +0200 sgsn: Make authorization asynchronous Currently the authorization of an IMSI is done by checking ACLs synchronously which is not feasible when the subscriber data has to be retrieved from an external source. This patch changes this by using a callback when the information is available. This is also done when only ACL are checked, in this case the callback is invoked from within sgsn_auth_request(). The callback function sgsn_update_subscriber_data calls sgsn_auth_update which in turn calls either gsm0408_gprs_access_granted or gsm0408_gprs_access_denied. gsm48_gmm_authorize is extended by a call to sgsn_auth_request when IMSI and IMEI are available but the auth_state is unknown. The change has been successfully tested with single phones (E71 and IPhone 5c). Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=40415c5655d5f5b67c557f733f0c47b2… commit 40415c5655d5f5b67c557f733f0c47b2d60eae88 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Wed Oct 29 22:12:20 2014 +0100 sgsn: Move IMSI authorization to gsm48_gmm_authorize Currently the IMSI is only checked immediately when an Attach Request is received that contains an IMSI IE. If it contains a P-TMSI instead, access is always granted. This commit moves the IMSI check to gsm48_gmm_authorize where it is applied when IMSI and IMEI have been acquired. This fixes the authorization when the Attach Accept doesn't contain an IMSI. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=be35395defcd81d7661365b97c072711… commit be35395defcd81d7661365b97c072711e0e55d23 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Fri Oct 31 12:27:11 2014 +0100 sgsn: Fix LLME leak when forcing a reattach Currently when forceing a reattach by sending a Detach Request (reattach), the SGSN waits for the Detach Accept until it frees the MM context (if present) and the LLME. If that message gets lost or isn't sent by the MS, the LLME is never freed if it isn't bound to an MM context. This patch adds code to free the MM context/LLME when forcing a reattachment. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=a00c3bd090b024f116c6e134b668cade… commit a00c3bd090b024f116c6e134b668cade04b535c1 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Fri Oct 31 12:20:49 2014 +0100 sgsn: Split gsm0408_gprs_force_reattach into 2 functions This patch replaces gsm0408_gprs_force_reattach(msg, mmctx) by two functions - gsm0408_gprs_force_reattach(mmctx) - gsm0408_gprs_force_reattach_oldmsg(msg) The old function basically consists of the code of the two new functions, where the code patch selected depends on mmctx == NULL, which is harder to maintain, less obvious to use, and not consistent with many other SGSN functions. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=62a432c7db59c3004a9fc3272d46a6cc… commit 62a432c7db59c3004a9fc3272d46a6cc9c4269aa Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Nov 3 10:12:52 2014 +0100 sgsn: Call mm_ctx_cleanup_free to deregister MM context Currently the MM context isn't always removed when it is de-registered (mmctx_timer_cb), mm_state is set to GMM_DEREGISTERED instead. This can lead to left-over MM contexts which are only cleaned up if the MS reattaches. This patch replaces all of these assignments by a call to mm_ctx_cleanup_free. Ticket: OW#1324 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=584bf98d87497381ea30526d73899d3a… commit 584bf98d87497381ea30526d73899d3a5542eb61 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Oct 28 16:23:46 2014 +0100 sgsn: Cleanup GMM state transitions Currently the GMM state is set to GMM-REGISTERED when an Attach Accept or a RA Update Accept message is sent, even if a new P-TMSI is included. In this case 04.08 requires (see 4.7.3.1.3 and 4.7.5.1.3), that the state is set to GMM-COMMON-PROCEDURE-INITIATED when the Accept is sent. When the Complete is received, the SGSN shall set the state to GMM-REGISTERED. This patch modifies the state updates accordingly. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=b8242b0c2422a948fdce005558fc8e57… commit b8242b0c2422a948fdce005558fc8e5738555ff0 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Oct 28 12:23:29 2014 +0100 sgsn: Reorganize and fix gsm48_gmm_authorize Currently the order of the 'if' clauses in gsm48_gmm_authorize doesn't match the order in which the conditional parts are entered. This makes it difficult to maintain. In addition the t3350_mode is not stored in every path, so that this information is lost when the identification procedure is started. Since the default value coincidentally is GMM_T3350_MODE_ATT, this doesn't hurt for Attach Requests which are the only messages that initially trigger the authentication yet. This patch changes the order of the 'if' clause to match the processing order, it removes the t3350_mode parameter entirely and introduces a mm->pending_req field. The latter must be set when the request that causes the authorization before calling gsm48_gmm_authorize. The gprs_t3350_mode enum is extended by GMM_T3350_MODE_NONE (value 0, which is the default) to make it possible to detect related initialisation errors or race conditions. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=acc28f5fa7b9c1ad607bddb47429a04a… commit acc28f5fa7b9c1ad607bddb47429a04a068c14ef Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Thu Oct 30 17:15:43 2014 +0100 gbproxy: Reset TLLIs when the link_info is found by IMSI/P-TMSI Currently when the MS does a re-attach without doing a proper detach first, the gbproxy uses the old local TLLI if patching and the keep mode are enabled. This leads to a failing attachment procedure when TLLI patching is also enabled. This patch changes gbproxy_update_link_state_ul to reset all TLLIs within the link_info if the message contains an unknown TLLI and an MI. This is generally the case with Attach Request messages. The gbproxy_get_link_info_ul gets an additional tlli_is_invalid output parameter that is set, when a TLLI was present but not found. This value is then used instead of checking tlli.current == 0 to handle e.g. Attach Requests when a link_info was already present for the P-TMSI/IMSI used in such a request. Ticket: OW#1324 Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: openbsc/contrib/systemd/osmo-bsc.service | 2 +- openbsc/include/openbsc/gprs_gmm.h | 1 + openbsc/include/openbsc/gprs_sgsn.h | 14 ++++ openbsc/src/gprs/gb_proxy_tlli.c | 27 ++++--- openbsc/src/gprs/gprs_gmm.c | 33 ++++++++- openbsc/src/gprs/gprs_sgsn.c | 9 +-- openbsc/src/gprs/gprs_subscriber.c | 105 +++++++++++++++++++++++---- openbsc/src/gprs/sgsn_auth.c | 16 ++++- openbsc/src/gprs/sgsn_vty.c | 120 +++++++++++++++++++++++++++++++ openbsc/src/libbsc/abis_nm.c | 4 +- openbsc/src/libbsc/bsc_ctrl_commands.c | 5 ++ openbsc/tests/ctrl_test_runner.py | 20 ++++++ openbsc/tests/vty_test_runner.py | 3 + 13 files changed, 319 insertions(+), 40 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

1 0

openbsc.git branch master updated. 0.13.0-740-g3911880
by gitosis＠osmocom.org 11 Nov '14

11 Nov '14

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, master has been updated via 3911880b68ddd92c9dd89d6ac20c26807e33f905 (commit) via cdd4302c6dde84693a16b33362a75061480333cd (commit) via 27cb4d57e049b173fb4cacc78b947f70c691c111 (commit) via 94ef1c0da9a80869256e6a5966d1f1571955c813 (commit) via 41108680293f703da976efe64ea8388ef7a2cd7e (commit) from 0d8ac0eac0a919cb2620d94e661d60b2a96501d3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=3911880b68ddd92c9dd89d6ac20c2680… commit 3911880b68ddd92c9dd89d6ac20c26807e33f905 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Fri Nov 7 14:07:48 2014 +0100 bsc: Move gsm_subscriber_base.c to libcommon Since it is planned to use struct gsm_subscriber to manage subscriber data in the SGSN, this file which contains the generic subscriber related methods is moved to libcommon. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=cdd4302c6dde84693a16b33362a75061… commit cdd4302c6dde84693a16b33362a75061480333cd Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Nov 10 11:21:32 2014 +0100 bsc: Move gsm_network_init function to libbsc Currently libcommon depends on libbsc, because gsm_network_init (libcommon/gsm_data.c) directly calls gsm_net_update_ctype (libbsc/gsm_04_08_utils.c). This patch moves gsm_network_init to a new file libbsc/net_init.c. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=27cb4d57e049b173fb4cacc78b947f70… commit 27cb4d57e049b173fb4cacc78b947f70c691c111 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Wed Oct 29 12:11:58 2014 +0100 sgsn/test: Add test_gmm_attach This test checks the attach procedure until the Attach Complete is received. Note that authorization and GMM state updates are not working properly yet. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=94ef1c0da9a80869256e6a5966d1f157… commit 94ef1c0da9a80869256e6a5966d1f1571955c813 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Wed Oct 29 10:31:18 2014 +0100 sgsn/test: Move message sending to send_0408_message This replaces serveral occurences of duplicated code for message creation and sending (passing to gsm0408_gprs_rcvmsg) into a single function. In addition, the sgsn_tx_counter is always reset within send_0408_message to simplify the code that checks for the number of messages sent. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=41108680293f703da976efe64ea8388e… commit 41108680293f703da976efe64ea8388ef7a2cd7e Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Fri Oct 31 10:47:29 2014 +0100 gbproxy: Honour the BSS TLLI type when creating an SGSN TLLI Currently gbproxy_make_sgsn_tlli always returns a foreign TLLI when it uses the (SGSN) P-TMSI to generate one. This patch changes the implementation to return a SGSN TLLI of the same type like the BSS TLLI in that case. Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: openbsc/src/gprs/gb_proxy.c | 7 +- openbsc/src/libbsc/Makefile.am | 4 +- openbsc/src/libbsc/net_init.c | 102 ++++++++++++ openbsc/src/libcommon/Makefile.am | 4 +- openbsc/src/libcommon/gsm_data.c | 80 ---------- .../{libbsc => libcommon}/gsm_subscriber_base.c | 0 openbsc/src/osmo-bsc_nat/Makefile.am | 3 +- openbsc/src/utils/Makefile.am | 4 +- openbsc/tests/channel/Makefile.am | 8 +- openbsc/tests/sgsn/sgsn_test.c | 176 +++++++++++++++++---- openbsc/tests/sgsn/sgsn_test.ok | 1 + 11 files changed, 269 insertions(+), 120 deletions(-) create mode 100644 openbsc/src/libbsc/net_init.c rename openbsc/src/{libbsc => libcommon}/gsm_subscriber_base.c (100%) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

1 0

openbsc.git branch master updated. 0.13.0-735-g0d8ac0e
by gitosis＠osmocom.org 11 Nov '14

11 Nov '14

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, master has been updated via 0d8ac0eac0a919cb2620d94e661d60b2a96501d3 (commit) from 054bc24e6dc700d4b8e8eec647cbead63454671e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=0d8ac0eac0a919cb2620d94e661d60b2… commit 0d8ac0eac0a919cb2620d94e661d60b2a96501d3 Author: Henning Heinold <henning(a)itconsulting-heinold.de> Date: Tue Nov 11 17:11:41 2014 +0100 systemd: use Wants for the dependency btw. osmo-bsc-mgcp and osmo-bsc * osmo-bsc and osmo-bsc-mgcp are needed to run * with Wants, both are started but can be indepently controlled via systemctl Fixes: SYS#738 ----------------------------------------------------------------------- Summary of changes: openbsc/contrib/systemd/osmo-bsc.service | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

1 0

libosmocore.git branch master updated. 0.7.0-74-g8497b0a
by gitosis＠osmocom.org 10 Nov '14

10 Nov '14

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via 8497b0a78671e09015ec2cb40f0a21cae7baf5ad (commit) from 0673b70f7d6c608566da84410c58f2ad5f290027 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=8497b0a78671e09015ec2cb40f0a… commit 8497b0a78671e09015ec2cb40f0a21cae7baf5ad Author: Ciaby <ciaby(a)autistici.org> Date: Mon Nov 10 12:33:35 2014 -0600 Fix debian packaging - Added debian/libosmosim0.install - Added libosmosim definition in debian/control ----------------------------------------------------------------------- Summary of changes: debian/control | 6 ++++++ debian/libosmosim0.install | 1 + 2 files changed, 7 insertions(+) create mode 100644 debian/libosmosim0.install hooks/post-receive -- An utility library for Open Source Mobile Communications

1 0

osmo-bts.git branch master updated. 0.3.0-250-g4d4dc26
by gitosis＠osmocom.org 10 Nov '14

10 Nov '14

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom BTS-side code (Abis, scheduling, ...)". The branch, master has been updated via 4d4dc2674252658330cdd581757d6168087ba4fb (commit) via 48eb374a9640aab799958590ef35dc3d1bdebefb (commit) via 2fa6ef26879607ab01795259720857091e76d852 (commit) via 6d8bcbd192d6d5bfe5077fd675e12734b72fb2be (commit) from b89a5fa55d712a257ee17bbaed41cdb1ee8d7f75 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-bts/commit/?id=4d4dc2674252658330cdd581757d616… commit 4d4dc2674252658330cdd581757d6168087ba4fb Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Mon Nov 10 15:13:05 2014 +0100 bts: Move BTS and children into the enabled state after opstart With "show bts 0" all objects were still listed as dependency. Once the BTS has been started.. move all the other objects into the enabled state. Our OpenBSC OML code doesn't care but people using the VTY to inspect state will be more happy. One day... we will create proper statemachines inside the BTS and the BSC instead of changing the state in the BTS impl. Fixes: ONW#1330 http://cgit.osmocom.org/osmo-bts/commit/?id=48eb374a9640aab799958590ef35dc3… commit 48eb374a9640aab799958590ef35dc3d1bdebefb Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Mon Nov 10 15:09:52 2014 +0100 bts: Start with the site manager being enabled and available We would never transition the sitemanager to anything. Our SW does not support SW activation's so we are always ready. Related: ONW#1330 http://cgit.osmocom.org/osmo-bts/commit/?id=2fa6ef26879607ab017952597208570… commit 2fa6ef26879607ab01795259720857091e76d852 Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Mon Nov 10 13:18:59 2014 +0100 bts: Mark NSVC1 as offline. We do not expose a second NSVC OsmoBSC> show bts 0 ... GPRS NSVC1: Oper 'Disabled', Admin 'unknown 0x0', Avail 'Off line' http://cgit.osmocom.org/osmo-bts/commit/?id=6d8bcbd192d6d5bfe5077fd675e1273… commit 6d8bcbd192d6d5bfe5077fd675e12734b72fb2be Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Mon Nov 10 13:01:33 2014 +0100 bts: Fix typo in OML comment ----------------------------------------------------------------------- Summary of changes: src/common/bts.c | 7 +++++-- src/osmo-bts-sysmo/oml.c | 6 ++++++ 2 files changed, 11 insertions(+), 2 deletions(-) hooks/post-receive -- Osmocom BTS-side code (Abis, scheduling, ...)

1 0

osmo-bts.git branch master updated. 0.3.0-246-gb89a5fa
by gitosis＠osmocom.org 10 Nov '14

10 Nov '14

1 0

openbsc.git branch master updated. 0.13.0-734-g054bc24
by gitosis＠osmocom.org 10 Nov '14

10 Nov '14

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, master has been updated via 054bc24e6dc700d4b8e8eec647cbead63454671e (commit) from 74b2028167ddf04a867ae9f269bfa3435c93f252 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=054bc24e6dc700d4b8e8eec647cbead6… commit 054bc24e6dc700d4b8e8eec647cbead63454671e Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Mon Nov 10 11:41:03 2014 +0100 bts: Allow to set the LAC through the CTRL interface Allow to set the LAC of the BTS through the CTRL interface. The change will not be effective immediately. Fixes: SYS#738 ----------------------------------------------------------------------- Summary of changes: openbsc/src/libbsc/bsc_ctrl_commands.c | 5 +++++ openbsc/tests/ctrl_test_runner.py | 20 ++++++++++++++++++++ 2 files changed, 25 insertions(+) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

1 0

osmo-bts.git branch master updated. 0.3.0-245-g9f0002b
by gitosis＠osmocom.org 10 Nov '14

10 Nov '14

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom BTS-side code (Abis, scheduling, ...)". The branch, master has been updated via 9f0002b52bdc560587744e17243440951273a153 (commit) via 1cce69364dbbc5fd8ed6765063c84f415da7ce02 (commit) via 8332e29c9f3f97cbe22f83673cac4e68c57959f1 (commit) via be63f03254c036a8466c434b6391ad1a2c2a18bc (commit) from 9f22fcfd367adbc88183079e27b1cd790a04a6f0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-bts/commit/?id=9f0002b52bdc560587744e172434409… commit 9f0002b52bdc560587744e17243440951273a153 Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Mon Nov 10 12:04:48 2014 +0100 ctrl: Fix compiler warning bts_ctrl_lookup.c: In function 'bts_controlif_setup': bts_ctrl_lookup.c:97:2: warning: implicit declaration of function 'bts_ctrl_cmds_install' [-Wimplicit-function-declaration] rc = bts_ctrl_cmds_install(bts); ^ http://cgit.osmocom.org/osmo-bts/commit/?id=1cce69364dbbc5fd8ed6765063c84f4… commit 1cce69364dbbc5fd8ed6765063c84f415da7ce02 Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Mon Nov 10 12:02:45 2014 +0100 abis: Fix compiler warning and remove const from syntax libosmo-abis doesn't make it easy to have these parameters as const.. just declare it non-const in the api. We pass a static string but we know it will not be modified. http://cgit.osmocom.org/osmo-bts/commit/?id=8332e29c9f3f97cbe22f83673cac4e6… commit 8332e29c9f3f97cbe22f83673cac4e68c57959f1 Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Mon Nov 10 11:59:53 2014 +0100 tch: Avoid compiler warnings when using the direct RTP mode tch.c: In function 'l1_to_rtppayload_amr': tch.c:247:29: warning: unused variable 'amr_mrc' [-Wunused-variable] struct amr_multirate_conf *amr_mrc = &lchan->tch.amr_mr; ^ tch.c: In function 'rtppayload_to_l1_amr': tch.c:335:10: warning: unused variable 'amr_if2_core_len' [-Wunused-variable] uint8_t amr_if2_core_len = payload_len - 2; http://cgit.osmocom.org/osmo-bts/commit/?id=be63f03254c036a8466c434b6391ad1… commit be63f03254c036a8466c434b6391ad1a2c2a18bc Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Mon Nov 10 11:58:21 2014 +0100 sysmobts: Call the routine send and receive instead of get ----------------------------------------------------------------------- Summary of changes: include/osmo-bts/abis.h | 4 ++-- include/osmo-bts/control_if.h | 1 + src/common/abis.c | 4 ++-- src/osmo-bts-sysmo/misc/sysmobts_mgr_2050.c | 8 ++++---- src/osmo-bts-sysmo/tch.c | 5 ++++- 5 files changed, 13 insertions(+), 9 deletions(-) hooks/post-receive -- Osmocom BTS-side code (Abis, scheduling, ...)

1 0

openbsc.git branch jerlbeck/wip/gprs-patching updated. 0.13.0-755-gc93f898
by gitosis＠osmocom.org 10 Nov '14

10 Nov '14

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, jerlbeck/wip/gprs-patching has been updated discards 8d570c15a946c8adf874db68ef12e046cfd98fd0 (commit) discards 016051129a239d6a16bd06b93716f03c145aedbb (commit) discards b915d5bb9726712a7e6c154559d205dc0591d393 (commit) discards ffefe0e35f9b106ba11071c903f2b7e700990a58 (commit) discards 6ebd49eaed937f62b42281281434a6031cfbe2c1 (commit) discards 0c401f18259d6223fc417aefd3d088b20ce52542 (commit) discards b0e9dd487f84254f0884dfba0af1237b82525734 (commit) discards a6a499fc8174e77bc468c2f593fe86ca4b0363b5 (commit) discards 3f2dfee7ca5769b351b2d2a9d6ecdd5903243e87 (commit) discards 06e8cf5c76a900227f8ed32489ecfd4a683ee5f6 (commit) discards 60e0f06e985106204be526b9a90f21e7c417a0b6 (commit) discards e7308002c55da89a76f4b5db4cae2e4df5024375 (commit) discards c2f6fab069d14382dc444753bd59f62d87623aeb (commit) discards 41fde68761737c8590b68e4b1aed102b62b4c2e6 (commit) discards 597583f635d377d24cf00c3ba93e303735cc270c (commit) discards dd79c53aa6a7ea844852ca257f58a71aa422b747 (commit) discards 7dc3f3cc4ec9067bbeb7c030f42396bd866efbb4 (commit) discards f47bdf819239b9eb44350497e6c4f95ef31e7e25 (commit) discards d0998fbe927ac54e0f50326b161773f8a5728b18 (commit) via c93f898e6de4dfc3328b206cd2b8724c6c133215 (commit) via 6d1dc3c02f5a2839e998c7ec1275270d49b9db9e (commit) via d49b478c9b91a14daf37de826533fb793827939e (commit) via c09bee263d257e6f7ac574a542057c2181cd5da8 (commit) via 1fcb88a3db244830c07f28dcde6467ba3ac9239d (commit) via 5b98e682e5985fe60a9ebdaae8134a305021ff25 (commit) via 418c164fa36acbe33b2ec75eccbbba551f62a844 (commit) via f12e41de7dc441f8c2837f792853511a0e038ddb (commit) via 3191e00c847cd780d220aa7c9b50c2a5906217a4 (commit) via e0e0217321efd2d1103d9fa4e73a7a116fa83c6e (commit) via b460f57502f7a0cc21a5171f877d9528c144c7f7 (commit) via 3245dbc7a695da12e88991918f73dc8abea8c3fe (commit) via b88c41d64c2b2df18fc578f996f00cdd76f222af (commit) via 56e655632df54283b3634e2a2e2dac96710830ff (commit) via 79a481bfc005283221f300b01efdefad4dcdb9d3 (commit) via 8e2148ab0ec232b50484c01876316f1417822bde (commit) via a312c4bb27e6dd1fa03e78138370d583570380d6 (commit) via 81b6311deaaac6fe97ba11eee94dc922b6b16e14 (commit) via 5bc648f29af30528349aaabcce8c962210a7b50f (commit) via db483b72f1c8e2c397f88baa05b6b53f76362a04 (commit) via 7d8e8b9a13b3b2ea8404581f980869b711617e2e (commit) via 2c00b904bb31f807c501c26addcc046ca8496521 (commit) via f9330da55561d3cad6220e8c0a6dea53990309fc (commit) via 33f2c4d898c59a05c8122fd9897cbd22f643b367 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (8d570c15a946c8adf874db68ef12e046cfd98fd0) \ N -- N -- N (c93f898e6de4dfc3328b206cd2b8724c6c133215) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=c93f898e6de4dfc3328b206cd2b8724c… commit c93f898e6de4dfc3328b206cd2b8724c6c133215 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Nov 10 10:35:51 2014 +0100 sgsn: Use gsm_subscriber (TODO) TODO: - commit message - continue impl. Ticket: OW#???? Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=6d1dc3c02f5a2839e998c7ec1275270d… commit 6d1dc3c02f5a2839e998c7ec1275270d49b9db9e Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Fri Nov 7 14:17:44 2014 +0100 sgsn: Refactor sgsn_auth (TODO) TODO: - Commit title - Commit message - Use sgsn_instance instead of config as parameter Ticket: OW#???? Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=d49b478c9b91a14daf37de826533fb79… commit d49b478c9b91a14daf37de826533fb793827939e Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Thu Nov 6 15:43:10 2014 +0100 sgsn: Don't assign a new P-TMSI if one is pending (TODO) Currently every time a RA Update Req or an Attach Req is processed, a new P-TMSI is alocated. When an MS issues another of these messages before it has completed the first procedure, old_ptmsi is replaced by ptmsi (and thus lost) and ptmsi is replaced by the newly allocated P-TMSI. This can confuse the gbproxy, which can loose track of the logical link then. At least a blackberry emits a double set of RA Upd Req messages from time to time which may be just 20ms apart. This patch adds a check whether mm->ptmsi or mm->old_ptmsi are not both set. If both are set, the P-TMSI is not re-allocated. This is only the case, if the Complete message has not been received since that resets old_ptmsi. TODO: - Test case Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=c09bee263d257e6f7ac574a542057c21… commit c09bee263d257e6f7ac574a542057c2181cd5da8 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Sep 30 13:53:26 2014 +0200 sgsn: Added TODOs (TODO) TODO: - fix and remove TODOs - add test cases for Detach(reattach) - add test cases for PDP context deletion (OW#1311) - add test cases for Cancel pending timer in sgsn_mm_ctx_free - remove this commit Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=1fcb88a3db244830c07f28dcde6467ba… commit 1fcb88a3db244830c07f28dcde6467ba3ac9239d Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Fri Oct 17 10:08:02 2014 +0200 sgsn: Do not die in _bssgp_tx_dl_ud on TLLI mismatch (TODO) Currently an OSMO_ASSERT fails, if the message's and the mmctx's TLLIs do not match. This commit turns the assertion into an ERROR log message and uses the default values for IMSI, DRX, and RA CAP instead of the MM context values in this case. TODO: - find the real source for the problem - add test cases derived from what is being described in the ticket Ticket: OW#1322 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=5b98e682e5985fe60a9ebdaae8134a30… commit 5b98e682e5985fe60a9ebdaae8134a305021ff25 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Fri Nov 7 14:07:48 2014 +0100 bsc: Move gsm_subscriber_base.c to libcommon Since it is planned to use struct gsm_subscriber to manage subscriber data in the SGSN, this file which contains the generic subscriber related methods is moved to libcommon. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=418c164fa36acbe33b2ec75eccbbba55… commit 418c164fa36acbe33b2ec75eccbbba551f62a844 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Nov 10 11:21:32 2014 +0100 bsc: Move gsm_network_init function to libbsc Currently libcommon depends on libbsc, because gsm_network_init (libcommon/gsm_data.c) directly calls gsm_net_update_ctype (libbsc/gsm_04_08_utils.c). This patch moves gsm_network_init to a new file libbsc/net_init.c. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=f12e41de7dc441f8c2837f792853511a… commit f12e41de7dc441f8c2837f792853511a0e038ddb Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Thu Nov 6 13:43:41 2014 +0100 sgsn: Cleanup after RA Update Reject / Attach Reject Currently, the LLME is not cleanup up after sending an RA Update Reject. This happens after entering a routing area from outside, since in that case the SGSN sends an RA Update Reject (implicitly detached) which causes the MS to restart the attach procedure. The LLME is also not updated if an Attach Request with message errors (encoding, invalid MI type) is received or if an MM context cannot be allocated. This patch changes gsm48_rx_gmm_ra_upd_req and gsm48_rx_gmm_att_req to unassign the LLME or free the MM context (if available) after a Reject message has been sent. Ticket: OW#1324 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=3191e00c847cd780d220aa7c9b50c2a5… commit 3191e00c847cd780d220aa7c9b50c2a5906217a4 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Nov 4 12:44:15 2014 +0100 sgsn: Notify an affected MM context if an ACL rule is removed Currently if an ACL access rule is removed, MS already attached are not affected until they try to reattach to the SGSN. This patch extends sgsn_acl_del to re-authenticate an MM context if it matches the IMSI. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=e0e0217321efd2d1103d9fa4e73a7a11… commit e0e0217321efd2d1103d9fa4e73a7a116fa83c6e Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Nov 4 10:08:37 2014 +0100 sgsn: Add 'acl-only' authentication policy Currently the VTY 'auth-policy' command results in setting or clearing the acl_enabled flag. This also enables the matching of the MCC/MNC prefix of the IMSI. This patch adds an additional policy 'acl-only' which disables the MCC/MNC matching and relies on the ACL only. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=b460f57502f7a0cc21a5171f877d9528… commit b460f57502f7a0cc21a5171f877d9528c144c7f7 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Nov 4 11:15:01 2014 +0100 sgsn/test: Add VTY tests for the SGSN This patch adds some basic SGSN tests to vty_test_runner.py: - check for config tree nodes - check specific show commands Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=3245dbc7a695da12e88991918f73dc8a… commit 3245dbc7a695da12e88991918f73dc8abea8c3fe Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Fri Oct 24 18:09:54 2014 +0200 sgsn: Make authorization asynchronous Currently the authorization of an IMSI is done by checking ACLs synchronously which is not feasible when the subscriber data has to be retrieved from an external source. This patch changes this by using a callback when the information is available. This is also done when only ACL are checked, in this case the callback is invoked from within sgsn_auth_request(). The callback function sgsn_update_subscriber_data calls sgsn_auth_update which in turn calls either gsm0408_gprs_access_granted or gsm0408_gprs_access_denied. gsm48_gmm_authorize is extended by a call to sgsn_auth_request when IMSI and IMEI are available but the auth_state is unknown. The change has been successfully tested with single phones (E71 and IPhone 5c). Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=b88c41d64c2b2df18fc578f996f00cdd… commit b88c41d64c2b2df18fc578f996f00cdd76f222af Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Nov 3 12:48:43 2014 +0100 bsc: Fix use-after-free on OML NM messages from the BTS Currently the sign_link pointer is dereferenced after a call to osmo_signal_dispatch, which can indirectly call e1inp_sign_link_destroy. If that happens, accessing *sign_link is illegal and can lead to a segmentation violation. Since only the bts pointer is needed from sign_link after the call to osmo_signal_dispatch, this patch changes abis_nm_rcvmsg_fom to save that pointer to a local variable earlier. Addresses: <0019> input/ipa.c:250 accept()ed new link from 192.168.1.101 to port 3002 SET ATTR NACK CAUSE=Message cannot be performed <0005> bsc_init.c:52 Got a NACK going to drop the OML links. <001b> bsc_init.c:319 Lost some E1 TEI link: 1 0xb351a830 ================================================================= ==13198== ERROR: AddressSanitizer: heap-use-after-free on address 0xb5d1bc70 at pc 0x80a6e3d bp 0xbfbb33d8 sp 0xbfbb33cc Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=56e655632df54283b3634e2a2e2dac96… commit 56e655632df54283b3634e2a2e2dac96710830ff Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Wed Oct 29 22:12:20 2014 +0100 sgsn: Move IMSI authorization to gsm48_gmm_authorize Currently the IMSI is only checked immediately when an Attach Request is received that contains an IMSI IE. If it contains a P-TMSI instead, access is always granted. This commit moves the IMSI check to gsm48_gmm_authorize where it is applied when IMSI and IMEI have been acquired. This fixes the authorization when the Attach Accept doesn't contain an IMSI. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=79a481bfc005283221f300b01efdefad… commit 79a481bfc005283221f300b01efdefad4dcdb9d3 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Fri Oct 31 12:27:11 2014 +0100 sgsn: Fix LLME leak when forcing a reattach Currently when forceing a reattach by sending a Detach Request (reattach), the SGSN waits for the Detach Accept until it frees the MM context (if present) and the LLME. If that message gets lost or isn't sent by the MS, the LLME is never freed if it isn't bound to an MM context. This patch adds code to free the MM context/LLME when forcing a reattachment. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=8e2148ab0ec232b50484c01876316f14… commit 8e2148ab0ec232b50484c01876316f1417822bde Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Fri Oct 31 12:20:49 2014 +0100 sgsn: Split gsm0408_gprs_force_reattach into 2 functions This patch replaces gsm0408_gprs_force_reattach(msg, mmctx) by two functions - gsm0408_gprs_force_reattach(mmctx) - gsm0408_gprs_force_reattach_oldmsg(msg) The old function basically consists of the code of the two new functions, where the code patch selected depends on mmctx == NULL, which is harder to maintain, less obvious to use, and not consistent with many other SGSN functions. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=a312c4bb27e6dd1fa03e78138370d583… commit a312c4bb27e6dd1fa03e78138370d583570380d6 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Nov 3 10:12:52 2014 +0100 sgsn: Call mm_ctx_cleanup_free to deregister MM context Currently the MM context isn't always removed when it is de-registered (mmctx_timer_cb), mm_state is set to GMM_DEREGISTERED instead. This can lead to left-over MM contexts which are only cleaned up if the MS reattaches. This patch replaces all of these assignments by a call to mm_ctx_cleanup_free. Ticket: OW#1324 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=81b6311deaaac6fe97ba11eee94dc922… commit 81b6311deaaac6fe97ba11eee94dc922b6b16e14 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Oct 28 16:23:46 2014 +0100 sgsn: Cleanup GMM state transitions Currently the GMM state is set to GMM-REGISTERED when an Attach Accept or a RA Update Accept message is sent, even if a new P-TMSI is included. In this case 04.08 requires (see 4.7.3.1.3 and 4.7.5.1.3), that the state is set to GMM-COMMON-PROCEDURE-INITIATED when the Accept is sent. When the Complete is received, the SGSN shall set the state to GMM-REGISTERED. This patch modifies the state updates accordingly. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=5bc648f29af30528349aaabcce8c9622… commit 5bc648f29af30528349aaabcce8c962210a7b50f Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Wed Oct 29 12:11:58 2014 +0100 sgsn/test: Add test_gmm_attach This test checks the attach procedure until the Attach Complete is received. Note that authorization and GMM state updates are not working properly yet. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=db483b72f1c8e2c397f88baa05b6b53f… commit db483b72f1c8e2c397f88baa05b6b53f76362a04 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Wed Oct 29 10:31:18 2014 +0100 sgsn/test: Move message sending to send_0408_message This replaces serveral occurences of duplicated code for message creation and sending (passing to gsm0408_gprs_rcvmsg) into a single function. In addition, the sgsn_tx_counter is always reset within send_0408_message to simplify the code that checks for the number of messages sent. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=7d8e8b9a13b3b2ea8404581f980869b7… commit 7d8e8b9a13b3b2ea8404581f980869b711617e2e Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Oct 28 12:23:29 2014 +0100 sgsn: Reorganize and fix gsm48_gmm_authorize Currently the order of the 'if' clauses in gsm48_gmm_authorize doesn't match the order in which the conditional parts are entered. This makes it difficult to maintain. In addition the t3350_mode is not stored in every path, so that this information is lost when the identification procedure is started. Since the default value coincidentally is GMM_T3350_MODE_ATT, this doesn't hurt for Attach Requests which are the only messages that initially trigger the authentication yet. This patch changes the order of the 'if' clause to match the processing order, it removes the t3350_mode parameter entirely and introduces a mm->pending_req field. The latter must be set when the request that causes the authorization before calling gsm48_gmm_authorize. The gprs_t3350_mode enum is extended by GMM_T3350_MODE_NONE (value 0, which is the default) to make it possible to detect related initialisation errors or race conditions. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=2c00b904bb31f807c501c26addcc046c… commit 2c00b904bb31f807c501c26addcc046ca8496521 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Fri Oct 31 10:47:29 2014 +0100 gbproxy: Honour the BSS TLLI type when creating an SGSN TLLI Currently gbproxy_make_sgsn_tlli always returns a foreign TLLI when it uses the (SGSN) P-TMSI to generate one. This patch changes the implementation to return a SGSN TLLI of the same type like the BSS TLLI in that case. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=f9330da55561d3cad6220e8c0a6dea53… commit f9330da55561d3cad6220e8c0a6dea53990309fc Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Thu Oct 30 17:15:43 2014 +0100 gbproxy: Reset TLLIs when the link_info is found by IMSI/P-TMSI Currently when the MS does a re-attach without doing a proper detach first, the gbproxy uses the old local TLLI if patching and the keep mode are enabled. This leads to a failing attachment procedure when TLLI patching is also enabled. This patch changes gbproxy_get_link_info_ul to reset all TLLIs within the link_info if the message contains an unknown TLLI and an MI. This is generally the case with Attach Request messages. Ticket: OW#1324 Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: openbsc/include/openbsc/gprs_sgsn.h | 9 +- openbsc/include/openbsc/gsm_subscriber.h | 4 + openbsc/include/openbsc/sgsn.h | 3 +- openbsc/src/gprs/Makefile.am | 2 +- openbsc/src/gprs/gprs_sgsn.c | 31 ++++++- openbsc/src/gprs/gprs_subscriber.c | 73 +++++++++++++++ openbsc/src/gprs/sgsn_auth.c | 52 ++++++++--- openbsc/src/gprs/sgsn_main.c | 3 - openbsc/src/gprs/sgsn_vty.c | 8 +- openbsc/src/libbsc/Makefile.am | 4 +- openbsc/src/libbsc/bts_ipaccess_nanobts.c | 6 +- openbsc/src/libbsc/net_init.c | 102 +++++++++++++++++++++ openbsc/src/libcommon/Makefile.am | 4 +- openbsc/src/libcommon/gsm_data.c | 80 ---------------- .../{libbsc => libcommon}/gsm_subscriber_base.c | 0 openbsc/src/osmo-bsc_nat/Makefile.am | 3 +- openbsc/src/utils/Makefile.am | 4 +- openbsc/tests/channel/Makefile.am | 8 +- openbsc/tests/sgsn/Makefile.am | 2 + 19 files changed, 280 insertions(+), 118 deletions(-) create mode 100644 openbsc/src/gprs/gprs_subscriber.c create mode 100644 openbsc/src/libbsc/net_init.c rename openbsc/src/{libbsc => libcommon}/gsm_subscriber_base.c (100%) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

osmocom-commitlog November 2014