osmocom-commitlog November 2014

osmocom-commitlog@lists.osmocom.org

1 participants
44 discussions

Start a nNew thread

openbsc.git branch master updated. 0.13.0-756-g619b014

by gitosis＠osmocom.org

9 years, 10 months

libosmocore.git branch laforge/nuttx updated. 0.6.5-25-g7711ef7

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, laforge/nuttx has been updated via 7711ef73f32c1eaaa20b4fd5ba1a7b3d9bdcd25d (commit) from d41f44875385717cb665059a9ab0d5a632cff0bf (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=7711ef73f32c1eaaa20b4fd5ba1a… commit 7711ef73f32c1eaaa20b4fd5ba1a7b3d9bdcd25d Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com> Date: Mon Nov 17 14:44:25 2014 +0100 msgb/embedded: Do not depend on talloc for allocations We don't want to run talloc on the embedded platform. Use "EMBEDDED" as we don't seem to export TALLOC handling. ----------------------------------------------------------------------- Summary of changes: src/msgb.c | 9 +++++++++ 1 file changed, 9 insertions(+) hooks/post-receive -- An utility library for Open Source Mobile Communications

9 years, 11 months

openbsc.git branch ciaby/rhizomatica-token updated. 0.13.0-762-gb33b50f

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, ciaby/rhizomatica-token has been updated discards b52338d4a9ef6442b2e23228f24cb62e49f8d978 (commit) via b33b50fdbc44f1d22584383df1018b28e80f50d8 (commit) via cc4f017034bce80516c09bf2347a094d36954500 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (b52338d4a9ef6442b2e23228f24cb62e49f8d978) \ N -- N -- N (b33b50fdbc44f1d22584383df1018b28e80f50d8) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=b33b50fdbc44f1d22584383df1018b28… commit b33b50fdbc44f1d22584383df1018b28e80f50d8 Author: Ciaby <ciaby(a)rhizomatica.org> Date: Sun Nov 16 23:07:55 2014 -0600 Updated changelog, bumped version to +rhizo3. http://cgit.osmocom.org/openbsc/commit/?id=cc4f017034bce80516c09bf2347a094d… commit cc4f017034bce80516c09bf2347a094d36954500 Author: Ciaby <ciaby(a)rhizomatica.org> Date: Sun Nov 16 23:06:47 2014 -0600 Handover fix, needs to be tested. ----------------------------------------------------------------------- Summary of changes: debian/changelog | 3 ++- openbsc/src/libbsc/handover_logic.c | 4 ++++ 2 files changed, 6 insertions(+), 1 deletion(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

9 years, 11 months

openbsc.git branch ciaby/rhizomatica-token created. 0.13.0-761-gb52338d

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, ciaby/rhizomatica-token has been created at b52338d4a9ef6442b2e23228f24cb62e49f8d978 (commit) - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=b52338d4a9ef6442b2e23228f24cb62e… commit b52338d4a9ef6442b2e23228f24cb62e49f8d978 Author: Ciaby <ciaby(a)rhizomatica.org> Date: Sun Nov 16 17:12:50 2014 -0600 Updated changelog, bumped version to +rhizo3. http://cgit.osmocom.org/openbsc/commit/?id=0c0453c74165f49439a952787496d4c7… commit 0c0453c74165f49439a952787496d4c7dfe8f3dc Author: Ruben Pollan <meskio(a)sindominio.net> Date: Sun Nov 16 13:04:01 2014 -0600 Configure the auth token sms text in the database http://cgit.osmocom.org/openbsc/commit/?id=8ba3e2e27b5063304679077aa851cb02… commit 8ba3e2e27b5063304679077aa851cb02fad6850a Author: Ciaby <ciaby(a)autistici.org> Date: Sun May 4 20:04:11 2014 +0200 Revert MNCC_SOCK_VERSION to 2 (from 4), otherwise there is no know LCR version which can work with it :) Also mentioned at: https://gitorious.org/sysmocom-openembedded/meta-telephony/commit/4da2963d8… http://cgit.osmocom.org/openbsc/commit/?id=9a1742f1e78d85d2e9ae1685cafb3db1… commit 9a1742f1e78d85d2e9ae1685cafb3db1e3c6a380 Author: Ciaby <ciaby(a)autistici.org> Date: Sat Mar 8 20:25:48 2014 +0100 Disable the gbproxy test (failing). Bump the debian version in the changelog. http://cgit.osmocom.org/openbsc/commit/?id=4ea053240bd0b720351d1b118f233a33… commit 4ea053240bd0b720351d1b118f233a33a73e64c4 Author: Ciaby <ciaby(a)autistici.org> Date: Fri Mar 7 15:50:51 2014 +0100 DIRTY HACK: Force all SMSs to SMPP. http://cgit.osmocom.org/openbsc/commit/?id=d884ddcaafad17931c9dbb679408fe67… commit d884ddcaafad17931c9dbb679408fe678bcb6b10 Author: Ciaby <ciaby(a)autistici.org> Date: Fri Mar 7 15:36:22 2014 +0100 Added SMPP support in the debian build, include libsmpp34-dev as a dependency. ----------------------------------------------------------------------- hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

9 years, 11 months

libosmocore.git branch laforge/nuttx updated. 0.6.5-24-gd41f448

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, laforge/nuttx has been updated via d41f44875385717cb665059a9ab0d5a632cff0bf (commit) from 93a5b9110d896d8500edc8448148a1024768cdef (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=d41f44875385717cb665059a9ab0… commit d41f44875385717cb665059a9ab0d5a632cff0bf Author: Daniel Laszlo Sitzer <dlsitzer(a)sysmocom.de> Date: Mon Jul 7 15:51:40 2014 +0200 tlv/msgb: Be able to generate and parse TLV as used by LLDP The Link Layer Discovery Protocol is using a Tag Length Value (TLV) structure. What is different is that the tag and length do not stop at byte boundaries. This commit introduces methods to msgb and tlv to be able to create such a tag/length header and a way to parse it using the tlv_parse routine. When it comes to parsing we have an issue that the new TLV_TYPE_T7L9V should not be mixed with the other types inside the same tlv definition. This is due the bitshifting required to identify the tag. The code likely requires work on big-endian machines but so does most of the other code as well. ----------------------------------------------------------------------- Summary of changes: .gitignore | 1 + include/osmocom/gsm/tlv.h | 14 ++++ src/gsm/tlv_parser.c | 19 +++++ tests/Makefile.am | 8 +- tests/testsuite.at | 6 ++ tests/tlv/tlv_test.c | 205 ++++++++++++++++++++++++++++++++++++++++++++++ tests/tlv/tlv_test.ok | 8 ++ 7 files changed, 259 insertions(+), 2 deletions(-) create mode 100644 tests/tlv/tlv_test.c create mode 100644 tests/tlv/tlv_test.ok hooks/post-receive -- An utility library for Open Source Mobile Communications

9 years, 11 months

libosmocore.git branch master updated. 0.7.0-80-g20144f7

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via 20144f7bc5c04e57da36cd7d7883f576510f0298 (commit) via 78a870ed0fc7ec03d0eb24241d9772470e4a78ae (commit) via 7b74dda31bc05a7210bbbcb382b78d6f9cde5b15 (commit) via b592ab71a7e3d49d62ea986401f0902953375057 (commit) via 9e166e8e0815a5b429738614025fc2beb96473d4 (commit) from 18bcc8ab6214e92539370eb3c5b601f18def4dde (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/libosmocore/commit/?id=20144f7bc5c04e57da36cd7d7883… commit 20144f7bc5c04e57da36cd7d7883f576510f0298 Author: Harald Welte <laforge(a)gnumonks.org> Date: Tue Mar 11 10:47:08 2014 +0100 vty/vector.c: Use string.h, not memory.h http://cgit.osmocom.org/libosmocore/commit/?id=78a870ed0fc7ec03d0eb24241d97… commit 78a870ed0fc7ec03d0eb24241d9772470e4a78ae Author: Harald Welte <laforge(a)gnumonks.org> Date: Tue Mar 11 10:45:38 2014 +0100 remove references to u_long type, use 'unsigned long' instead .. Nuttx doesn't know u_long http://cgit.osmocom.org/libosmocore/commit/?id=7b74dda31bc05a7210bbbcb382b7… commit 7b74dda31bc05a7210bbbcb382b78d6f9cde5b15 Author: Harald Welte <laforge(a)gnumonks.org> Date: Tue Mar 11 10:31:19 2014 +0100 remove references to u_char type, use 'unsigned char' instead ... u_char not being defined on Nuttx. http://cgit.osmocom.org/libosmocore/commit/?id=b592ab71a7e3d49d62ea986401f0… commit b592ab71a7e3d49d62ea986401f0902953375057 Author: Harald Welte <laforge(a)gnumonks.org> Date: Mon Mar 10 18:12:17 2014 +0100 strrb.c: Use string.h, not strings.h Not all systems have strings.h http://cgit.osmocom.org/libosmocore/commit/?id=9e166e8e0815a5b429738614025f… commit 9e166e8e0815a5b429738614025fc2beb96473d4 Author: Harald Welte <laforge(a)gnumonks.org> Date: Mon Mar 10 17:28:33 2014 +0100 select.c: Add missing #include lines for string.h and sys/select.h This is needed on Nuttx. ----------------------------------------------------------------------- Summary of changes: include/osmocom/vty/buffer.h | 2 +- include/osmocom/vty/command.h | 2 +- src/select.c | 2 ++ src/strrb.c | 2 +- src/vty/buffer.c | 4 ++-- src/vty/vector.c | 2 +- src/vty/vty.c | 6 +++--- 7 files changed, 11 insertions(+), 9 deletions(-) hooks/post-receive -- An utility library for Open Source Mobile Communications

9 years, 11 months

libosmocore.git branch master updated. 0.7.0-75-g18bcc8a

by gitosis＠osmocom.org

9 years, 11 months

openbsc.git branch master updated. 0.13.0-755-g02ab91e

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, master has been updated via 02ab91e6a73e16da51918b52548a0f4be4c6a0f6 (commit) via a0b6efb3685ea90190cfbd9423a74c181ea4f12f (commit) via f951a01bb227e524eb369051c95fbebace7570d0 (commit) via f6e7d99d54cc75fdc19433011afb5eaaa8a2a002 (commit) via c4f9bf3142f54b63174f653b07103dd6ab36b1ae (commit) via 80d07e30c76f2bd72ee382b4b7941262c1d5865d (commit) via 106f547733450afda1ddbd7e886dc8c902fed4d4 (commit) via 144b8b1ca77f628ea4cf87ff903b7e79f0abf9dd (commit) via 423f8bfa027d544867dcf7afc188a8ea5221e2bc (commit) via 0c06f98ced2b70801147eb52d6596079e473dfc9 (commit) via b1c074f62c1d04138b751f71e3b07fbb0a521898 (commit) via abdf02b9b988a816201b4530f36f709ca4c146ac (commit) via a790456f1b826ea204f47c4aa4973dc777d00d2a (commit) via 0074a77424c95d2d7d0608dc0dfabc1948e62fe0 (commit) via 93eae8ec78d145cf87b7858ebee60c72da7a2d20 (commit) from 3911880b68ddd92c9dd89d6ac20c26807e33f905 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=02ab91e6a73e16da51918b52548a0f4b… commit 02ab91e6a73e16da51918b52548a0f4be4c6a0f6 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Wed Nov 12 09:53:45 2014 +0100 sgsn: Cross-link gsm_subscriber and sgsn_mm_ctx To implement subscriber based authorization a data structure is needed that keeps the subscriber data. The MSC already uses a similar struct named gsm_subscriber whose implementation is split into a generic part (allocation, retrieval, reference counting, list maintenance) and MSC related parts. For GPRS, only the generic part will be used and specific fields may be added when needed. This patch adds a field mm to struct gsm_subscriber that will be used by the SGSN to store a reference to the current MM context (or NULL if there is none). This also adds a field subscr to struct sgsn_mm_ctx that reversely points to a gsm_subscriber (or NULL if there is none). Either both fields are NULL or both fields are non-NULL. Note that subscr is being reference counted. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=a0b6efb3685ea90190cfbd9423a74c18… commit a0b6efb3685ea90190cfbd9423a74c181ea4f12f Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Thu Nov 13 10:48:39 2014 +0100 sgsn: Remove explicit sgsn_instance parameters Currently the function in sgsn_auth.c either have an sgsn_config or an sgsn_instance parameter. Since then global sgsn variable is already being used in that file and since other parts of the SGSN related code also rely on a global sgsn singleton, these parameters pretend to provide a flexibility that is not really supported. Therefore this patch removes these parameters except for the ACL related functions, which do not call code that uses the sgsn variable. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=f951a01bb227e524eb369051c95fbeba… commit f951a01bb227e524eb369051c95fbebace7570d0 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Fri Nov 7 14:17:44 2014 +0100 sgsn: Refactor sgsn_auth to separate request and authorization Currently the authorization is done in sgsn_auth_request for ACL based authorization. This doesn't match the way remote authorization would work, so that there is a second call to sgsn_auth_state already present in sgsn_auth_update. This patch removes the autorization check completely from sgsn_auth_request which in turn calls sgsn_auth_update directly now. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=f6e7d99d54cc75fdc19433011afb5eaa… commit f6e7d99d54cc75fdc19433011afb5eaaa8a2a002 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Thu Nov 6 15:43:10 2014 +0100 sgsn: Don't assign a new P-TMSI if one is pending Currently every time an RA Update Req or an Attach Req is processed, a new P-TMSI is allocated. When an MS issues another of these messages before it has completed the first procedure, old_ptmsi is replaced by ptmsi (and thus lost) and ptmsi is replaced by the newly allocated P-TMSI. This can confuse the gbproxy, which can loose track of the logical link then. At least a Blackberry emits a double set of RA Upd Req messages from time to time which may be just 20ms apart. This patch adds a check whether mm->ptmsi or mm->old_ptmsi are set. If both are set, the P-TMSI is not re-allocated. This is only the case, when the Complete message has not been received yet, since that message will reset old_ptmsi. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=c4f9bf3142f54b63174f653b07103dd6… commit c4f9bf3142f54b63174f653b07103dd6ab36b1ae Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Nov 11 08:55:13 2014 +0100 sgsn: Don't send XID reset after Detach Accept Currently when a Detach Accept is received for an unknown TLLI (which is in general the case afer the SGSN has requested the detachment), an XID reset is sent to the BSS, causing a BSSGP Status message. This happens in gsm0408_rcv_gmm. This patch moves the corresponding call to gprs_llgmm_reset downwards so that it is not being called in that case. Addresses: SGSN->BSS TLLI: 0xd75b91d9 SAPI: LLGMM, UI (DTAP) (GMM) Detach Request BSS->SGSN TLLI: 0xd75b91d9 SAPI: LLGMM, UI (DTAP) (GMM) Detach Accept SGSN->BSS TLLI: 0xd75b91d9 SAPI: LLGMM, U, XID (Reset, IOV-UI) BSS->SGSN TLLI: --- BSSGP STATUS (Unknown MS) Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=80d07e30c76f2bd72ee382b4b7941262… commit 80d07e30c76f2bd72ee382b4b7941262c1d5865d Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Thu Nov 6 13:43:41 2014 +0100 sgsn: Cleanup after RA Update Reject / Attach Reject Currently, the LLME is not cleaned up after sending an RA Update Reject. This happens after entering a routing area from outside, since in that case the SGSN sends an RA Update Reject (implicitly detached) which causes the MS to restart the attach procedure. The LLME is also not updated if an Attach Request with message errors (encoding, invalid MI type) is received or if an MM context cannot be allocated. This patch changes gsm48_rx_gmm_ra_upd_req and gsm48_rx_gmm_att_req to unassign the LLME or free the MM context (if available) after a Reject message has been sent. Ticket: OW#1324 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=106f547733450afda1ddbd7e886dc8c9… commit 106f547733450afda1ddbd7e886dc8c902fed4d4 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Nov 4 10:08:37 2014 +0100 sgsn: Add 'acl-only' authentication policy Currently the VTY 'auth-policy' command results in setting or clearing the acl_enabled flag. This also enables the matching of the MCC/MNC prefix of the IMSI. This patch adds an additional policy 'acl-only' which disables the MCC/MNC matching and relies on the ACL only. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=144b8b1ca77f628ea4cf87ff903b7e79… commit 144b8b1ca77f628ea4cf87ff903b7e79f0abf9dd Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Nov 4 11:15:01 2014 +0100 sgsn/test: Add VTY tests for the SGSN This patch adds some basic SGSN tests to vty_test_runner.py: - check for config tree nodes - check specific show commands Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=423f8bfa027d544867dcf7afc188a8ea… commit 423f8bfa027d544867dcf7afc188a8ea5221e2bc Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Fri Oct 24 18:09:54 2014 +0200 sgsn: Make authorization asynchronous Currently the authorization of an IMSI is done by checking ACLs synchronously which is not feasible when the subscriber data has to be retrieved from an external source. This patch changes this by using a callback when the information is available. This is also done when only ACL are checked, in this case the callback is invoked from within sgsn_auth_request(). The callback function sgsn_update_subscriber_data calls sgsn_auth_update which in turn calls either gsm0408_gprs_access_granted or gsm0408_gprs_access_denied. gsm48_gmm_authorize is extended by a call to sgsn_auth_request when IMSI and IMEI are available but the auth_state is unknown. The change has been successfully tested with single phones (E71 and IPhone 5c). Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=0c06f98ced2b70801147eb52d6596079… commit 0c06f98ced2b70801147eb52d6596079e473dfc9 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Wed Oct 29 22:12:20 2014 +0100 sgsn: Move IMSI authorization to gsm48_gmm_authorize Currently the IMSI is only checked immediately when an Attach Request is received that contains an IMSI IE. If it contains a P-TMSI instead, access is always granted. This commit moves the IMSI check to gsm48_gmm_authorize where it is applied when IMSI and IMEI have been acquired. This fixes the authorization when the Attach Accept doesn't contain an IMSI. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=b1c074f62c1d04138b751f71e3b07fbb… commit b1c074f62c1d04138b751f71e3b07fbb0a521898 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Fri Oct 31 12:27:11 2014 +0100 sgsn: Fix LLME leak when forcing a reattach Currently when forceing a reattach by sending a Detach Request (reattach), the SGSN waits for the Detach Accept until it frees the MM context (if present) and the LLME. If that message gets lost or isn't sent by the MS, the LLME is never freed if it isn't bound to an MM context. This patch adds code to free the MM context/LLME when forcing a reattachment. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=abdf02b9b988a816201b4530f36f709c… commit abdf02b9b988a816201b4530f36f709ca4c146ac Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Fri Oct 31 12:20:49 2014 +0100 sgsn: Split gsm0408_gprs_force_reattach into 2 functions This patch replaces gsm0408_gprs_force_reattach(msg, mmctx) by two functions - gsm0408_gprs_force_reattach(mmctx) - gsm0408_gprs_force_reattach_oldmsg(msg) The old function basically consists of the code of the two new functions, where the code path selected depends on mmctx == NULL, which is harder to maintain, less obvious to use, and not consistent with many other SGSN functions. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=a790456f1b826ea204f47c4aa4973dc7… commit a790456f1b826ea204f47c4aa4973dc777d00d2a Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Mon Nov 3 10:12:52 2014 +0100 sgsn: Call mm_ctx_cleanup_free to deregister MM context Currently the MM context isn't always removed when it is de-registered (mmctx_timer_cb), mm_state is set to GMM_DEREGISTERED instead. This can lead to left-over MM contexts which are only cleaned up if the MS reattaches. This patch replaces all of these assignments by a call to mm_ctx_cleanup_free. Ticket: OW#1324 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=0074a77424c95d2d7d0608dc0dfabc19… commit 0074a77424c95d2d7d0608dc0dfabc1948e62fe0 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Oct 28 16:23:46 2014 +0100 sgsn: Cleanup GMM state transitions Currently the GMM state is set to GMM-REGISTERED when an Attach Accept or a RA Update Accept message is sent, even if a new P-TMSI is included. In this case 04.08 requires (see 4.7.3.1.3 and 4.7.5.1.3), that the state is set to GMM-COMMON-PROCEDURE-INITIATED when the Accept is sent. When the Complete is received, the SGSN shall set the state to GMM-REGISTERED. This patch modifies the state updates accordingly. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=93eae8ec78d145cf87b7858ebee60c72… commit 93eae8ec78d145cf87b7858ebee60c72da7a2d20 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Oct 28 12:23:29 2014 +0100 sgsn: Reorganize and fix gsm48_gmm_authorize Currently the order of the 'if' clauses in gsm48_gmm_authorize doesn't match the order in which the conditional parts are entered. This makes it difficult to maintain. In addition the t3350_mode is not stored in every path, so that this information is lost when the identification procedure is started. Since the default value coincidentally is GMM_T3350_MODE_ATT, this doesn't hurt for Attach Requests which are the only messages that initially trigger the authentication yet. This patch changes the order of the 'if' clause to match the processing order, it removes the t3350_mode parameter entirely and introduces a mm->pending_req field. The latter must be set when the request that causes the authorization before calling gsm48_gmm_authorize. The gprs_t3350_mode enum is extended by GMM_T3350_MODE_NONE (value 0, which is the default) to make it possible to detect related initialisation errors or race conditions. Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: openbsc/include/openbsc/gprs_gmm.h | 5 +- openbsc/include/openbsc/gprs_sgsn.h | 35 ++- openbsc/include/openbsc/gsm_subscriber.h | 4 + openbsc/include/openbsc/sgsn.h | 8 +- openbsc/src/gprs/gprs_gmm.c | 264 +++++++++++++++++------ openbsc/src/gprs/gprs_sgsn.c | 8 +- openbsc/src/gprs/sgsn_auth.c | 102 ++++++++- openbsc/src/gprs/sgsn_main.c | 4 +- openbsc/src/gprs/sgsn_vty.c | 25 ++- openbsc/tests/sgsn/sgsn_test.c | 352 ++++++++++++++++++++++++++++++- openbsc/tests/sgsn/sgsn_test.ok | 10 + openbsc/tests/vty_test_runner.py | 69 ++++++ 12 files changed, 792 insertions(+), 94 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

9 years, 11 months

openbsc.git branch jerlbeck/wip/gprs-patching updated. 0.13.0-763-g4193f17

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, jerlbeck/wip/gprs-patching has been updated discards dd15d7cf6c51f254c8356fca8dd47af000bc8cab (commit) discards 0a9dcc451a7183976acbb002e18a5c4df49ceccc (commit) discards df18ef6a8274e2fcc6a535330a8c597c80c961ae (commit) discards 7c608eeffca7293723716fd0d96733f869a064ae (commit) discards 0c35de23f88097264deba8348224dfe9afeba156 (commit) discards c177731fae604a3b59add47541d124144311e034 (commit) discards 817d01a640fdd8ad0a27d77832f3609d720cfa15 (commit) via 4193f174dd6cdaabf2d4319faec463261a37d5af (commit) via 95f84db2402d458fd5b3d899f08cb33ec9cd3212 (commit) via 7518cdd42e257e70d9ec52ebb3567ab2df1472d6 (commit) via dd9645c9e2cf910bd30abedecc086e7207bdce92 (commit) via aa5dd818449d27659cb9e8b10d69ba3e9f875097 (commit) via 6e8c0bd7c97273f0ab171471a4725447ade17ae3 (commit) via a374e69d392dc4cfccf7a367c74961b2786bbc90 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (dd15d7cf6c51f254c8356fca8dd47af000bc8cab) \ N -- N -- N (4193f174dd6cdaabf2d4319faec463261a37d5af) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=4193f174dd6cdaabf2d4319faec46326… commit 4193f174dd6cdaabf2d4319faec463261a37d5af Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Sep 30 13:53:26 2014 +0200 sgsn: Added TODOs (TODO) TODO: - fix and remove TODOs - add test cases for Detach(reattach) - add test cases for PDP context deletion (OW#1311) - add test cases for Cancel pending timer in sgsn_mm_ctx_free - remove this commit Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=95f84db2402d458fd5b3d899f08cb33e… commit 95f84db2402d458fd5b3d899f08cb33ec9cd3212 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Nov 4 12:44:15 2014 +0100 sgsn: Notify an affected MM context if an ACL rule is removed (TODO) Currently if an ACL access rule is removed, MS already attached are not affected until they try to reattach to the SGSN. This patch adds sgsn_auth_update_all() that iterates through allMM contexts and calls sgsn_auth_update() on each of them. This function is then called when 'imsi-acl del IMSI' is executed after the ACL has been removed. TODO: - decide, whether ito replace that by a dedicated update command in the VTY ENABLE node Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=7518cdd42e257e70d9ec52ebb3567ab2… commit 7518cdd42e257e70d9ec52ebb3567ab2df1472d6 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Fri Oct 17 10:08:02 2014 +0200 sgsn: Do not die in _bssgp_tx_dl_ud on TLLI mismatch (TODO) Currently an OSMO_ASSERT fails, if the message's and the mmctx's TLLIs do not match. This commit turns the assertion into an ERROR log message and uses the default values for IMSI, DRX, and RA CAP instead of the MM context values in this case. TODO: - find the real source for the problem - add test cases derived from what is being described in the ticket Ticket: OW#1322 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=dd9645c9e2cf910bd30abedecc086e72… commit dd9645c9e2cf910bd30abedecc086e7207bdce92 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Nov 11 14:01:48 2014 +0100 sgsn: Add VTY commands to manage subscriber cache This adds the following commands to the ENABLE node: - show subscriber cache - update-subscriber imsi IMSI insert authorized (0|1) - update-subscriber imsi IMSI cancel These commands are mainly testing tools and maintenance helpers. The update commands work asynchronously and can be used to complete a pending update request or to terminate an existing connection. Note that the subscriber cache is not stored persistently and will always be empty after an SGSN restart. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=aa5dd818449d27659cb9e8b10d69ba3e… commit aa5dd818449d27659cb9e8b10d69ba3e9f875097 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Nov 11 14:47:38 2014 +0100 sgsn: Add gsm0408_gprs_access_cancelled (TODO) This function is called to delete an established MM context without invoking a detach procedure that could disable the GPRS functionality of the MS until the next power cycle. It is called when a subscriber is cancelled. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=6e8c0bd7c97273f0ab171471a4725447… commit 6e8c0bd7c97273f0ab171471a4725447ade17ae3 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Wed Nov 12 10:18:09 2014 +0100 sgsn: Integrate subscriber handling into the SGSN (TODO) This commit adds a new authorization policy 'remote' and uses the subscriber cache for authorization when this policy is being used. Note that there is no remote backend implemented yet. TODO: - tests - decide, whether 'remote' could be named better, e.g. sth based on 'subscriber' Ticket: OW#???? Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=a374e69d392dc4cfccf7a367c74961b2… commit a374e69d392dc4cfccf7a367c74961b2786bbc90 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Wed Nov 12 10:12:11 2014 +0100 sgsn: Add gprs_subscriber.c This patch adds GPRS specific functions for gsm_subscriber objects (allocation, retrieval, deletion) and subscriber data requests/updates. The sgsn_update_subscriber_data callback is used to notify the sgsn about updates and is extended by a parameter that passes a reference to a gsm_subscriber. Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: openbsc/tests/sgsn/Makefile.am | 3 +++ openbsc/tests/sgsn/sgsn_test.c | 47 ++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 50 insertions(+) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

9 years, 11 months

openbsc.git branch jerlbeck/wip/gprs-patching updated. 0.13.0-763-gdd15d7c

by gitosis＠osmocom.org

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, jerlbeck/wip/gprs-patching has been updated discards 24b1a8bf002583822cae8726e7ae2c3574421f35 (commit) discards 7cef2c1fa8c7a59ea46781166d2fd067b44b6f8d (commit) discards 170b60d84192ccc65ed480490220d2f829212b99 (commit) discards 7158c0d5c7ecb5a3fe45704dd0adf932e492fecb (commit) discards 83aba155f4bbab37aa9e5036018feb33fb780f1f (commit) discards cea90341104665f67680d262ea49a4e7e34f5fb4 (commit) discards 97e2eb3ad1305d35c59be88ce544684386a19998 (commit) discards e981df3e20d9ec9f7c83b0b359b5f093df42a8fa (commit) via dd15d7cf6c51f254c8356fca8dd47af000bc8cab (commit) via 0a9dcc451a7183976acbb002e18a5c4df49ceccc (commit) via df18ef6a8274e2fcc6a535330a8c597c80c961ae (commit) via 7c608eeffca7293723716fd0d96733f869a064ae (commit) via 0c35de23f88097264deba8348224dfe9afeba156 (commit) via c177731fae604a3b59add47541d124144311e034 (commit) via 817d01a640fdd8ad0a27d77832f3609d720cfa15 (commit) via 4cc973bce2eded371712ec73475d6d62c4aa91e7 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (24b1a8bf002583822cae8726e7ae2c3574421f35) \ N -- N -- N (dd15d7cf6c51f254c8356fca8dd47af000bc8cab) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=dd15d7cf6c51f254c8356fca8dd47af0… commit dd15d7cf6c51f254c8356fca8dd47af000bc8cab Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Sep 30 13:53:26 2014 +0200 sgsn: Added TODOs (TODO) TODO: - fix and remove TODOs - add test cases for Detach(reattach) - add test cases for PDP context deletion (OW#1311) - add test cases for Cancel pending timer in sgsn_mm_ctx_free - remove this commit Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=0a9dcc451a7183976acbb002e18a5c4d… commit 0a9dcc451a7183976acbb002e18a5c4df49ceccc Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Nov 4 12:44:15 2014 +0100 sgsn: Notify an affected MM context if an ACL rule is removed (TODO) Currently if an ACL access rule is removed, MS already attached are not affected until they try to reattach to the SGSN. This patch adds sgsn_auth_update_all() that iterates through allMM contexts and calls sgsn_auth_update() on each of them. This function is then called when 'imsi-acl del IMSI' is executed after the ACL has been removed. TODO: - decide, whether ito replace that by a dedicated update command in the VTY ENABLE node Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=df18ef6a8274e2fcc6a535330a8c597c… commit df18ef6a8274e2fcc6a535330a8c597c80c961ae Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Fri Oct 17 10:08:02 2014 +0200 sgsn: Do not die in _bssgp_tx_dl_ud on TLLI mismatch (TODO) Currently an OSMO_ASSERT fails, if the message's and the mmctx's TLLIs do not match. This commit turns the assertion into an ERROR log message and uses the default values for IMSI, DRX, and RA CAP instead of the MM context values in this case. TODO: - find the real source for the problem - add test cases derived from what is being described in the ticket Ticket: OW#1322 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=7c608eeffca7293723716fd0d96733f8… commit 7c608eeffca7293723716fd0d96733f869a064ae Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Nov 11 14:01:48 2014 +0100 sgsn: Add VTY commands to manage subscriber cache This adds the following commands to the ENABLE node: - show subscriber cache - update-subscriber imsi IMSI insert authorized (0|1) - update-subscriber imsi IMSI cancel These commands are mainly testing tools and maintenance helpers. The update commands work asynchronously and can be used to complete a pending update request or to terminate an existing connection. Note that the subscriber cache is not stored persistently and will always be empty after an SGSN restart. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=0c35de23f88097264deba8348224dfe9… commit 0c35de23f88097264deba8348224dfe9afeba156 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Tue Nov 11 14:47:38 2014 +0100 sgsn: Add gsm0408_gprs_access_cancelled (TODO) This function is called to delete an established MM context without invoking a detach procedure that could disable the GPRS functionality of the MS until the next power cycle. It is called when a subscriber is cancelled. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=c177731fae604a3b59add47541d12414… commit c177731fae604a3b59add47541d124144311e034 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Wed Nov 12 10:18:09 2014 +0100 sgsn: Integrate subscriber handling into the SGSN (TODO) This commit adds a new authorization policy 'remote' and uses the subscriber cache for authorization when this policy is being used. Note that there is no remote backend implemented yet. TODO: - tests - decide, whether 'remote' could be named better, e.g. sth based on 'subscriber' Ticket: OW#???? Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=817d01a640fdd8ad0a27d77832f3609d… commit 817d01a640fdd8ad0a27d77832f3609d720cfa15 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Wed Nov 12 10:12:11 2014 +0100 sgsn: Add gprs_subscriber.c This patch adds GPRS specific functions for gsm_subscriber objects (allocation, retrieval, deletion) and subscriber data requests/updates. The sgsn_update_subscriber_data callback is used to notify the sgsn about updates and is extended by a parameter that passes a reference to a gsm_subscriber. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=4cc973bce2eded371712ec73475d6d62… commit 4cc973bce2eded371712ec73475d6d62c4aa91e7 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Wed Nov 12 09:53:45 2014 +0100 sgsn: Cross-link gsm_subscriber and sgsn_mm_ctx To implement subscriber based authorization a data structure is needed that keeps the subscriber data. The MSC already uses a similar struct named gsm_subscriber whose implementation is split into a generic part (allocation, retrieval, reference counting, list maintenance) and MSC related parts. For GPRS, only the generic part will be used and specific fields may be added when needed. This patch adds a field mm to struct gsm_subscriber that will be used by the SGSN to store a reference to the current MM context (or NULL if there is none). This also adds a field subscr to struct sgsn_mm_ctx that reversely points to a gsm_subscriber (or NULL if there is none). Either both fields are NULL or both fields are non-NULL. Note that subscr is being reference counted. Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: openbsc/tests/sgsn/sgsn_test.c | 49 ++++++++++++++++++++++++++++++++++++++++- openbsc/tests/sgsn/sgsn_test.ok | 1 + 2 files changed, 49 insertions(+), 1 deletion(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

9 years, 11 months

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

osmocom-commitlog November 2014