- gerrit-log - lists.osmocom.org

[L] Change in pysim[master]: card_key_provider: add PostgreSQL support
by daniel 26 Nov '25

26 Nov '25

Attention is currently required from: dexter, laforge. daniel has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41508?usp=email ) Change subject: card_key_provider: add PostgreSQL support ...................................................................... Patch Set 4: Code-Review-1 (8 comments) Commit Message: https://gerrit.osmocom.org/c/pysim/+/41508/comment/830fbe59_38a2a5b1?usp=em… : PS4, Line 15: a remove ```suggestion This patch adds PostgreSQL support next to the existing CSV ``` File docs/card-key-provider.rst: https://gerrit.osmocom.org/c/pysim/+/41508/comment/416458c8_79aedbad?usp=em… : PS4, Line 25: CardKeyProviderCsv ```suggestion to retrieve the key material from a PostgreSQL database (`CardKeyProviderPgsql`). ``` https://gerrit.osmocom.org/c/pysim/+/41508/comment/2ffa0714_cff589f2?usp=em… : PS4, Line 142: ma may https://gerrit.osmocom.org/c/pysim/+/41508/comment/1d98c1e2_4365c390?usp=em… : PS4, Line 245: Csv ```suggestion available from within pySim-shell via the `CardKeyProviderPgsql`. ``` https://gerrit.osmocom.org/c/pysim/+/41508/comment/11c4895c_135a7fa2?usp=em… : PS4, Line 293: CardKeyProviderCsv ```suggestion As soon as the CardKeyProvider finds a line (row) in your CSV file ``` File pySim-shell.py: https://gerrit.osmocom.org/c/pysim/+/41508/comment/8fc0f5c2_901d0501?usp=em… : PS4, Line 1186: card_key_provider_register(CardKeyProviderPgsql(opts.pqsql, column_keys)) That means you can use both providers at the same time, right? File pySim/card_key_provider.py: https://gerrit.osmocom.org/c/pysim/+/41508/comment/ef0e5aef_fab2de36?usp=em… : PS4, Line 218: column_names = "" : for f in fields: : column_names += f.lower() + ", " : column_names = column_names[:-2] This can be done with join: ``` column_names = ", ".join([f.lower() for f in fields]) ``` https://gerrit.osmocom.org/c/pysim/+/41508/comment/1fed683c_51be4aaf?usp=em… : PS4, Line 229: cur.execute("SELECT column_name FROM information_schema.columns where table_name = '%s';" % t) I believe here and in all other cur.execute statements you don't want to use '%". See https://www.psycopg.org/docs/usage.html#sql-injection psycopg takes care of escaping etc., just pass the arguments in a tuple as a separate parameter (e.g. `, (t,)` instead of `% t` here) That's probably even more important in the import script above! -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41508?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icba625c02a60d7e1f519b506a46bda5ded0537d3 Gerrit-Change-Number: 41508 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 26 Nov 2025 11:33:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-dev[master]: all.desp: libosmo-sigtran depends on libosmo-asn1-tcap
by pespin 26 Nov '25

26 Nov '25

Attention is currently required from: daniel, fixeria, laforge, lynxis lazus, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-dev/+/41496?usp=email ) Change subject: all.desp: libosmo-sigtran depends on libosmo-asn1-tcap ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-dev/+/41496/comment/4dd6619d_0633350c?usp… : PS1, Line 9: --enable-tcap-loadsharing > You would need to add it to https://gitea.osmocom. […] Thanks for the feedback. I updated this patch and https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41497, let me know if they are good now. -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/41496?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Ibc51a818b859d40ab8a34d9299d0f955cf6d966e Gerrit-Change-Number: 41496 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 26 Nov 2025 11:16:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv: Build libosmo-sigtran with --enable-tcap-loadsharing
by pespin 26 Nov '25

26 Nov '25

Attention is currently required from: daniel, fixeria, laforge, lynxis lazus, osmith, pespin. Hello Jenkins Builder, daniel, fixeria, laforge, lynxis lazus, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41497?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Code-Review+2 by osmith, Verified+1 by Jenkins Builder The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: testenv: Build libosmo-sigtran with --enable-tcap-loadsharing ...................................................................... testenv: Build libosmo-sigtran with --enable-tcap-loadsharing STP_Tests_TCAP use this feature. Depends: osmo-dev.git Change-Id Ibc51a818b859d40ab8a34d9299d0f955cf6d966e Change-Id: I7b29d00befa94412bef56a4b8e4d788674028b12 --- M _testenv/testenv/osmo_dev.py 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/97/41497/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41497?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7b29d00befa94412bef56a4b8e4d788674028b12 Gerrit-Change-Number: 41497 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-dev[master]: all.desp: libosmo-sigtran depends on libosmo-asn1-tcap
by pespin 26 Nov '25

26 Nov '25

Attention is currently required from: daniel, fixeria, laforge, lynxis lazus, osmith, pespin. Hello Jenkins Builder, daniel, fixeria, laforge, lynxis lazus, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-dev/+/41496?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Code-Review+1 by lynxis lazus, Code-Review+2 by osmith, Verified+1 by Jenkins Builder The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: all.desp: libosmo-sigtran depends on libosmo-asn1-tcap ...................................................................... all.desp: libosmo-sigtran depends on libosmo-asn1-tcap When built with --enable-tcap-loadsharing, libosmo-sigtran requires libosmo-asn1-tcap. Add a libosmo-sigtran_with_tcap.opts so users of osmo-dev can easily enable the feature. Change-Id: Ibc51a818b859d40ab8a34d9299d0f955cf6d966e --- M all.deps A libosmo-sigtran_with_tcap.opts 2 files changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/96/41496/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/41496?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Ibc51a818b859d40ab8a34d9299d0f955cf6d966e Gerrit-Change-Number: 41496 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XL] Change in osmo-upf[master]: Split up_peer into pfcp_{node,entity}_peer
by pespin 26 Nov '25

26 Nov '25

Attention is currently required from: fixeria, laforge, neels. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-upf/+/41470?usp=email ) Change subject: Split up_peer into pfcp_{node,entity}_peer ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: ping -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/41470?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ie64be4fd55157e9646e250f8cbe93ba3f3c19b17 Gerrit-Change-Number: 41470 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 26 Nov 2025 11:05:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in osmo-hnbgw[master]: Split UPF into its own object
by osmith 26 Nov '25

26 Nov '25

Attention is currently required from: laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/41483?usp=email ) Change subject: Split UPF into its own object ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/41483?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I624bafe2fa150f7480b6fb44433c34e83154e06c Gerrit-Change-Number: 41483 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 26 Nov 2025 10:30:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-hnbgw[master]: Split UPF into its own object
by pespin 26 Nov '25

26 Nov '25

Attention is currently required from: laforge, osmith, pespin. Hello Jenkins Builder, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/41483?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Code-Review+1 by osmith, Verified-1 by Jenkins Builder Change subject: Split UPF into its own object ...................................................................... Split UPF into its own object This allows easily extending per-peer (UPF) functionalities, eg. adding Heartbeat procedure, as well as a step towards supporting a UPF pool in the future. Depends: libosmo-pfcp.git Change-Id I31498c407a8fffd8b47cce8c6bf89dc6e3fcefd2 Related: SYS#7294 Change-Id: I624bafe2fa150f7480b6fb44433c34e83154e06c --- M TODO-RELEASE M include/osmocom/hnbgw/hnbgw.h M include/osmocom/hnbgw/hnbgw_pfcp.h M src/osmo-hnbgw/hnbgw_pfcp.c M src/osmo-hnbgw/hnbgw_ranap.c M src/osmo-hnbgw/osmo_hnbgw_main.c M src/osmo-hnbgw/ps_rab_ass_fsm.c M src/osmo-hnbgw/ps_rab_fsm.c 8 files changed, 92 insertions(+), 36 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/83/41483/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/41483?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I624bafe2fa150f7480b6fb44433c34e83154e06c Gerrit-Change-Number: 41483 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-dev[master]: src/_update_src_copy: don't copy deleted files
by pespin 26 Nov '25

26 Nov '25

Attention is currently required from: fixeria, lynxis lazus, osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-dev/+/41514?usp=email ) Change subject: src/_update_src_copy: don't copy deleted files ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/41514?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I232263bc5bd26c90f1e73b115480269165a1e1f8 Gerrit-Change-Number: 41514 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 26 Nov 2025 10:26:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-hnbgw[master]: Split UPF into its own object
by osmith 26 Nov '25

26 Nov '25

Attention is currently required from: laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/41483?usp=email ) Change subject: Split UPF into its own object ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/41483?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I624bafe2fa150f7480b6fb44433c34e83154e06c Gerrit-Change-Number: 41483 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 26 Nov 2025 10:22:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-msc[master]: ASCI: Fix establishment of calls when ciphering is enabled
by pespin 26 Nov '25

26 Nov '25

Attention is currently required from: jolly. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-msc/+/41504?usp=email ) Change subject: ASCI: Fix establishment of calls when ciphering is enabled ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/libvlr/vlr_access_req_fsm.c: https://gerrit.osmocom.org/c/osmo-msc/+/41504/comment/7ebf8aa3_685c8c16?usp… : PS1, Line 305: * Also continue without ciphering, if ASCI call was requested. */ may be worth leaving a comment here regarding why we don't enable ciphering for ASCI calls. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41504?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ic59221e6b0f64c9f19508ae31cc3672548d0666e Gerrit-Change-Number: 41504 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Wed, 26 Nov 2025 10:21:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

2025

2024

2023

2022

gerrit-log