- gerrit-log - lists.osmocom.org

[M] Change in libosmo-sigtran[master]: xua_asp_fsm: Move common ipa/xua ASP_DOWN onenter code to helper func...
by daniel 26 Nov '25

26 Nov '25

Attention is currently required from: fixeria, laforge, lynxis lazus, pespin. daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41515?usp=email ) Change subject: xua_asp_fsm: Move common ipa/xua ASP_DOWN onenter code to helper function ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41515?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ia445ebc9a3bbad903d26259453e403fd450e8075 Gerrit-Change-Number: 41515 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 26 Nov 2025 12:31:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv: Build libosmo-sigtran with --enable-tcap-loadsharing
by pespin 26 Nov '25

26 Nov '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41497?usp=email ) Change subject: testenv: Build libosmo-sigtran with --enable-tcap-loadsharing ...................................................................... testenv: Build libosmo-sigtran with --enable-tcap-loadsharing STP_Tests_TCAP use this feature. Depends: osmo-dev.git Change-Id Ibc51a818b859d40ab8a34d9299d0f955cf6d966e Change-Id: I7b29d00befa94412bef56a4b8e4d788674028b12 --- M _testenv/testenv/osmo_dev.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/_testenv/testenv/osmo_dev.py b/_testenv/testenv/osmo_dev.py index 0b6bdf0..8f2fcfd 100644 --- a/_testenv/testenv/osmo_dev.py +++ b/_testenv/testenv/osmo_dev.py @@ -92,6 +92,7 @@ "hnbgw_with_nftables.opts", "hnbgw_with_pfcp.opts", "iu.opts", + "libosmo-sigtran_with_tcap.opts", "no_dahdi.opts", "no_doxygen.opts", "no_man_pages.opts", -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41497?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7b29d00befa94412bef56a4b8e4d788674028b12 Gerrit-Change-Number: 41497 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-dev[master]: all.deps: libosmo-sigtran depends on libosmo-asn1-tcap
by pespin 26 Nov '25

26 Nov '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/41496?usp=email ) Change subject: all.deps: libosmo-sigtran depends on libosmo-asn1-tcap ...................................................................... all.deps: libosmo-sigtran depends on libosmo-asn1-tcap When built with --enable-tcap-loadsharing, libosmo-sigtran requires libosmo-asn1-tcap. Add a libosmo-sigtran_with_tcap.opts so users of osmo-dev can easily enable the feature. Change-Id: Ibc51a818b859d40ab8a34d9299d0f955cf6d966e --- M all.deps A libosmo-sigtran_with_tcap.opts 2 files changed, 3 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/all.deps b/all.deps index 3439de7..f0e99a1 100644 --- a/all.deps +++ b/all.deps @@ -1,9 +1,10 @@ # project build these first libosmocore +libosmo-asn1-tcap libosmo-netif libosmocore libosmo-abis libosmocore libosmo-netif libosmo-gprs libosmocore -libosmo-sigtran libosmo-netif +libosmo-sigtran libosmo-netif libosmo-asn1-tcap libsmpp34 libasn1c osmo-ggsn libosmocore libgtpnl diff --git a/libosmo-sigtran_with_tcap.opts b/libosmo-sigtran_with_tcap.opts new file mode 100644 index 0000000..d294680 --- /dev/null +++ b/libosmo-sigtran_with_tcap.opts @@ -0,0 +1 @@ +libosmo-sigtran --enable-tcap-loadsharing -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/41496?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Ibc51a818b859d40ab8a34d9299d0f955cf6d966e Gerrit-Change-Number: 41496 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-dev[master]: all.deps: libosmo-sigtran depends on libosmo-asn1-tcap
by osmith 26 Nov '25

26 Nov '25

Attention is currently required from: daniel, fixeria, laforge, lynxis lazus, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-dev/+/41496?usp=email ) Change subject: all.deps: libosmo-sigtran depends on libosmo-asn1-tcap ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/41496?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Ibc51a818b859d40ab8a34d9299d0f955cf6d966e Gerrit-Change-Number: 41496 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 26 Nov 2025 12:24:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-sigtran[master]: xua_asp_fsm: Move common ipa/xua ASP_DOWN onenter code to helper func...
by osmith 26 Nov '25

26 Nov '25

Attention is currently required from: daniel, fixeria, laforge, lynxis lazus, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41515?usp=email ) Change subject: xua_asp_fsm: Move common ipa/xua ASP_DOWN onenter code to helper function ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41515?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ia445ebc9a3bbad903d26259453e403fd450e8075 Gerrit-Change-Number: 41515 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 26 Nov 2025 12:24:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-dev[master]: all.deps: libosmo-sigtran depends on libosmo-asn1-tcap
by pespin 26 Nov '25

26 Nov '25

Attention is currently required from: daniel, fixeria, laforge, lynxis lazus, osmith, pespin. Hello Jenkins Builder, daniel, fixeria, laforge, lynxis lazus, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-dev/+/41496?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+2 by osmith The change is no longer submittable: Code-Review is unsatisfied now. Change subject: all.deps: libosmo-sigtran depends on libosmo-asn1-tcap ...................................................................... all.deps: libosmo-sigtran depends on libosmo-asn1-tcap When built with --enable-tcap-loadsharing, libosmo-sigtran requires libosmo-asn1-tcap. Add a libosmo-sigtran_with_tcap.opts so users of osmo-dev can easily enable the feature. Change-Id: Ibc51a818b859d40ab8a34d9299d0f955cf6d966e --- M all.deps A libosmo-sigtran_with_tcap.opts 2 files changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/96/41496/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/41496?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Ibc51a818b859d40ab8a34d9299d0f955cf6d966e Gerrit-Change-Number: 41496 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv: Build libosmo-sigtran with --enable-tcap-loadsharing
by osmith 26 Nov '25

26 Nov '25

Attention is currently required from: daniel, fixeria, laforge, lynxis lazus, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41497?usp=email ) Change subject: testenv: Build libosmo-sigtran with --enable-tcap-loadsharing ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41497?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7b29d00befa94412bef56a4b8e4d788674028b12 Gerrit-Change-Number: 41497 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 26 Nov 2025 12:22:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-dev[master]: all.desp: libosmo-sigtran depends on libosmo-asn1-tcap
by osmith 26 Nov '25

26 Nov '25

Attention is currently required from: daniel, fixeria, laforge, lynxis lazus, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-dev/+/41496?usp=email ) Change subject: all.desp: libosmo-sigtran depends on libosmo-asn1-tcap ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-dev/+/41496/comment/666d4b26_f216763d?usp… : PS1, Line 9: --enable-tcap-loadsharing > Thanks for the feedback. I updated this patch and https://gerrit.osmocom. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/41496?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Ibc51a818b859d40ab8a34d9299d0f955cf6d966e Gerrit-Change-Number: 41496 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 26 Nov 2025 12:22:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in libosmo-sigtran[master]: xua_asp_fsm: Move common ipa/xua ASP_DOWN onenter code to helper func...
by pespin 26 Nov '25

26 Nov '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41515?usp=email ) Change subject: xua_asp_fsm: Move common ipa/xua ASP_DOWN onenter code to helper function ...................................................................... xua_asp_fsm: Move common ipa/xua ASP_DOWN onenter code to helper function This is a preparation patch since that function (and AS loop inside it) will be doing more stuff in the future, like tearing down TCAP loadsharing state. Change-Id: Ia445ebc9a3bbad903d26259453e403fd450e8075 --- M src/xua_asp_fsm.c M src/xua_internal.h M src/xua_rkm.c 3 files changed, 26 insertions(+), 32 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/15/41515/1 diff --git a/src/xua_asp_fsm.c b/src/xua_asp_fsm.c index d10420f..7a6979d 100644 --- a/src/xua_asp_fsm.c +++ b/src/xua_asp_fsm.c @@ -477,6 +477,30 @@ } +static void common_asp_fsm_down_onenter(struct osmo_ss7_asp *asp) +{ + struct osmo_ss7_as *as, *as2; + struct osmo_ss7_instance *inst = asp->inst; + + /* First notify all AS associated to the ASP that it went down: */ + dispatch_to_all_as(asp->fi, XUA_ASPAS_ASP_DOWN_IND, asp); + + /* Implicit clean up tasks: */ + llist_for_each_entry_safe(as, as2, &inst->as_list, list) { + if (!osmo_ss7_as_has_asp(as, asp)) + continue; + if (as->rkm_dyn_allocated) { + /* RFC 4666 4.4.2: "An ASP SHOULD deregister from all Application Servers + * of which it is a member before attempting to move to the ASP-Down state [...] + * If a Deregistration results in no more ASPs in an Application Server, + * an SG MAY delete the Routing Key data." + * In case it didn't deregsitrer explicitly, make sure to implicitly deregister it: + */ + ss7_as_del_asp(as, asp); + } + } +} + #define ENSURE_ASP_OR_IPSP(fi, event) \ do { \ struct xua_asp_fsm_priv *_xafp = fi->priv; \ @@ -513,14 +537,7 @@ struct xua_asp_fsm_priv *xafp = fi->priv; struct osmo_ss7_asp *asp = xafp->asp; xua_t_beat_stop(fi); - dispatch_to_all_as(fi, XUA_ASPAS_ASP_DOWN_IND, asp); - /* RFC 4666 4.4.2: "An ASP SHOULD deregister from all Application Servers of which it is a - * member before attempting to move to the ASP-Down state [...] - * If a Deregistration results in no more ASPs in an Application Server, an SG MAY delete - * the Routing Key data." - * In case it didn't deregsitrer explicitly, make sure to implicitly deregister it: - */ - xua_rkm_cleanup_dyn_as_for_asp(asp); + common_asp_fsm_down_onenter(asp); } static void xua_asp_fsm_down(struct osmo_fsm_inst *fi, uint32_t event, void *data) @@ -1107,14 +1124,7 @@ struct xua_asp_fsm_priv *xafp = fi->priv; struct osmo_ss7_asp *asp = xafp->asp; ipa_t_beat_stop(fi); - dispatch_to_all_as(fi, XUA_ASPAS_ASP_DOWN_IND, asp); - /* RFC 4666 4.4.2: "An ASP SHOULD deregister from all Application Servers of which it is a - * member before attempting to move to the ASP-Down state [...] - * If a Deregistration results in no more ASPs in an Application Server, an SG MAY delete - * the Routing Key data." - * In case it didn't deregsitrer explicitly, make sure to implicitly deregister it: - */ - xua_rkm_cleanup_dyn_as_for_asp(asp); + common_asp_fsm_down_onenter(asp); } static void ipa_asp_fsm_down(struct osmo_fsm_inst *fi, uint32_t event, void *data) diff --git a/src/xua_internal.h b/src/xua_internal.h index 90a68be..a6cb961 100644 --- a/src/xua_internal.h +++ b/src/xua_internal.h @@ -92,7 +92,6 @@ int m3ua_decode_notify(struct osmo_xlm_prim_notify *npar, void *ctx, const struct xua_msg *xua); int m3ua_rx_rkm(struct osmo_ss7_asp *asp, struct xua_msg *xua); -void xua_rkm_cleanup_dyn_as_for_asp(struct osmo_ss7_asp *asp); struct osmo_xlm_prim *xua_xlm_prim_alloc(enum osmo_xlm_prim_type prim_type, enum osmo_prim_operation op); diff --git a/src/xua_rkm.c b/src/xua_rkm.c index 2de830f..9713e3a 100644 --- a/src/xua_rkm.c +++ b/src/xua_rkm.c @@ -623,18 +623,3 @@ msgb_free(prim->oph.msg); return 0; } - -/* clean-up any dynamically created ASs + routes */ -void xua_rkm_cleanup_dyn_as_for_asp(struct osmo_ss7_asp *asp) -{ - struct osmo_ss7_instance *inst = asp->inst; - struct osmo_ss7_as *as, *as2; - - llist_for_each_entry_safe(as, as2, &inst->as_list, list) { - if (!as->rkm_dyn_allocated) - continue; - if (!osmo_ss7_as_has_asp(as, asp)) - continue; - ss7_as_del_asp(as, asp); - } -} -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41515?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ia445ebc9a3bbad903d26259453e403fd450e8075 Gerrit-Change-Number: 41515 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[L] Change in pysim[master]: card_key_provider: add PostgreSQL support
by laforge 26 Nov '25

26 Nov '25

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41508?usp=email ) Change subject: card_key_provider: add PostgreSQL support ...................................................................... Patch Set 4: Code-Review-1 (1 comment) File pySim/card_key_provider.py: https://gerrit.osmocom.org/c/pysim/+/41508/comment/7abd6bed_c71e9487?usp=em… : PS4, Line 229: cur.execute("SELECT column_name FROM information_schema.columns where table_name = '%s';" % t) > I believe here and in all other cur.execute statements you don't want to use '%". See https://www. […] yeah. this is actually true in any programming language: Always use the parameter expansion/susbstitution features of the library, never use format strings. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41508?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icba625c02a60d7e1f519b506a46bda5ded0537d3 Gerrit-Change-Number: 41508 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 26 Nov 2025 11:54:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>

1 0

2025

2024

2023

2022

gerrit-log