- gerrit-log - lists.osmocom.org

[XS] Change in osmo-ttcn3-hacks[master]: s1gw: f_ConnHdlr_conn_track_disable(): set conn_track := null
by pespin 14 Mar '26

14 Mar '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42345?usp=email ) Change subject: s1gw: f_ConnHdlr_conn_track_disable(): set conn_track := null ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42345?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0b71b543fc7c4e87a86381cc3be23728e75cb59b Gerrit-Change-Number: 42345 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 13 Mar 2026 15:35:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: s1gw: f_ConnHdlr_rx_handover_cmd(): fix missing semicolon
by pespin 14 Mar '26

14 Mar '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42344?usp=email ) Change subject: s1gw: f_ConnHdlr_rx_handover_cmd(): fix missing semicolon ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42344?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5db5fc01308f6834545b4be57631d77f1d2a3746 Gerrit-Change-Number: 42344 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 13 Mar 2026 15:35:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: s1gw: fix f_ConnHdlr_erab_release_cmd_(): do not discard cause
by pespin 14 Mar '26

14 Mar '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42343?usp=email ) Change subject: s1gw: fix f_ConnHdlr_erab_release_cmd_(): do not discard cause ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42343?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8c75e08dd041ce805aa232984445ba1e2bde40fa Gerrit-Change-Number: 42343 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 13 Mar 2026 15:35:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: s1gw: fix TC_e_rab_setup_failure: expect a specific S1AP PDU
by pespin 14 Mar '26

14 Mar '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42342?usp=email ) Change subject: s1gw: fix TC_e_rab_setup_failure: expect a specific S1AP PDU ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42342?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6dbe272af4302c83ac26db9b7da5a7f7bc96daa7 Gerrit-Change-Number: 42342 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 13 Mar 2026 15:35:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: s1gw: fix TC_uemux_e_rab_release_ind: pass release_ind := true
by pespin 14 Mar '26

14 Mar '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42341?usp=email ) Change subject: s1gw: fix TC_uemux_e_rab_release_ind: pass release_ind := true ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42341?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ieed5d8a2bf4f696efc1071569090facc7b731f96 Gerrit-Change-Number: 42341 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 13 Mar 2026 15:34:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in ...osmo-s1gw[master]: mme_registry: add backwards compat for old sctp_client config
by fixeria 14 Mar '26

14 Mar '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42352?usp=email ) Change subject: mme_registry: add backwards compat for old sctp_client config ...................................................................... mme_registry: add backwards compat for old sctp_client config When 'mme_pool' is absent from the config, automatically populate the MME pool with a single 'default' entry derived from the 'sctp_client' section (including legacy mme_loc_addr/mme_rem_addr params), and emit a deprecation warning. osmo_s1gw_sup:init/1 normalises 'sctp_client' in the app env (with all defaults applied) before children start, so mme_registry can safely read it without duplicating the parsing logic. Change-Id: Ia97fb61bbb5ace6f43d1a6768fb5fb6883158532 Related: SYS#7052 --- M src/mme_registry.erl M src/osmo_s1gw_sup.erl 2 files changed, 33 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/52/42352/1 diff --git a/src/mme_registry.erl b/src/mme_registry.erl index 291c767..d9ca43a 100644 --- a/src/mme_registry.erl +++ b/src/mme_registry.erl @@ -270,8 +270,13 @@ -spec mme_list_from_env() -> mme_list(). mme_list_from_env() -> - MMEs = osmo_s1gw:get_env(mme_pool, []), - lists:foldl(fun mme_add_from_env/2, [], MMEs). + case application:get_env(osmo_s1gw, mme_pool) of + {ok, MMEs} -> + lists:foldl(fun mme_add_from_env/2, [], MMEs); + undefined -> + %% no mme_pool configured, fall back to sctp_client for compat + mme_list_from_sctp_client() + end. -spec mme_add_from_env(mme_info(), mme_list()) -> mme_list(). @@ -280,4 +285,18 @@ MMEs1. +-spec mme_list_from_sctp_client() -> mme_list(). +mme_list_from_sctp_client() -> + %% osmo_s1gw_sup:init/1 sets 'sctp_client' with all fields populated + Cfg = osmo_s1gw:get_env(sctp_client, #{ }), + ?LOG_WARNING("'mme_pool' is not configured; falling back to 'sctp_client' " + "{laddr, raddr, rport} (deprecated, please use 'mme_pool' instead)"), + MmeInfo = #{name => "default", + laddr => maps:get(laddr, Cfg), + raddr => maps:get(raddr, Cfg), + rport => maps:get(rport, Cfg)}, + {ok, MMEs} = mme_add(MmeInfo, []), + MMEs. + + %% vim:set ts=4 sw=4 et: diff --git a/src/osmo_s1gw_sup.erl b/src/osmo_s1gw_sup.erl index d661af6..875e19b 100644 --- a/src/osmo_s1gw_sup.erl +++ b/src/osmo_s1gw_sup.erl @@ -66,6 +66,14 @@ PfcpLocAddr = osmo_s1gw:get_env(pfcp_loc_addr, ?ENV_DEFAULT_PFCP_LOC_ADDR), PfcpRemAddr = osmo_s1gw:get_env(pfcp_rem_addr, ?ENV_DEFAULT_PFCP_REM_ADDR), + ClientCfg = client_cfg(), + ServerCfg = server_cfg(ClientCfg), + + %% Set a complete 'sctp_client' section with all fields populated. + %% This may be used by mme_registry:mme_list_from_sctp_client/0 + %% if the 'mme_pool' is missing in the configuration file. + osmo_s1gw:set_env(sctp_client, ClientCfg), + EnbRegistry = {enb_registry, {enb_registry, start_link, []}, permanent, 5000, @@ -76,7 +84,7 @@ 5000, worker, [mme_registry]}, - SctpServer = {sctp_server, {sctp_server, start_link, [server_cfg()]}, + SctpServer = {sctp_server, {sctp_server, start_link, [ServerCfg]}, permanent, 5000, worker, @@ -136,8 +144,8 @@ sockopts => sctp_common:gen_sockopts(SockOpts)}. --spec server_cfg() -> sctp_server:cfg(). -server_cfg() -> +-spec server_cfg(term()) -> sctp_server:cfg(). +server_cfg(Priv) -> %% parse old/legacy environment options, if any DefCfg = parse_env_map(#{laddr => s1gw_bind_addr, lport => s1gw_bind_port}), @@ -151,7 +159,7 @@ lport => maps:get(lport, Cfg, ?ENV_DEFAULT_S1GW_BIND_PORT), sockopts => sctp_common:gen_sockopts(SockOpts), handler => enb_proxy, - priv => client_cfg()}. + priv => Priv}. -spec gtpu_kpi_cfg() -> gtpu_kpi:cfg(). -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42352?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ia97fb61bbb5ace6f43d1a6768fb5fb6883158532 Gerrit-Change-Number: 42352 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: s1gw: f_ConnHdlr_rx_handover_cmd(): fix missing semicolon
by fixeria 14 Mar '26

14 Mar '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42344?usp=email ) Change subject: s1gw: f_ConnHdlr_rx_handover_cmd(): fix missing semicolon ...................................................................... s1gw: f_ConnHdlr_rx_handover_cmd(): fix missing semicolon Change-Id: I5db5fc01308f6834545b4be57631d77f1d2a3746 --- M s1gw/S1GW_ConnHdlr.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/44/42344/1 diff --git a/s1gw/S1GW_ConnHdlr.ttcn b/s1gw/S1GW_ConnHdlr.ttcn index 1301bbd..3decbcf 100644 --- a/s1gw/S1GW_ConnHdlr.ttcn +++ b/s1gw/S1GW_ConnHdlr.ttcn @@ -1322,7 +1322,7 @@ var template (present) E_RABDataForwardingItem item; var ERabIdx idx := erabs_forward[i]; - item := tr_E_RABDataForwardingItem(rab_id := g_pars.erabs[idx].erab_id) + item := tr_E_RABDataForwardingItem(rab_id := g_pars.erabs[idx].erab_id); items_forward[i] := tr_E_RABSubjecttoDataForwardingList(item)[0]; } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42344?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5db5fc01308f6834545b4be57631d77f1d2a3746 Gerrit-Change-Number: 42344 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: s1gw: f_ConnHdlr_conn_track_disable(): set conn_track := null
by fixeria 14 Mar '26

14 Mar '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42345?usp=email ) Change subject: s1gw: f_ConnHdlr_conn_track_disable(): set conn_track := null ...................................................................... s1gw: f_ConnHdlr_conn_track_disable(): set conn_track := null After deactivate, conn_track still holds the now-dead reference. A second call (which can happen if any test explicitly calls this before f_ConnHdlr_s1ap_disconnect()) will attempt to deactivate an already-inactive default, which is a TTCN-3 runtime error. Change-Id: I0b71b543fc7c4e87a86381cc3be23728e75cb59b Fixes: adc942a94 ("s1gw: track eNB connection, fail immediately on loss") --- M s1gw/S1GW_ConnHdlr.ttcn 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/45/42345/1 diff --git a/s1gw/S1GW_ConnHdlr.ttcn b/s1gw/S1GW_ConnHdlr.ttcn index 3decbcf..298a983 100644 --- a/s1gw/S1GW_ConnHdlr.ttcn +++ b/s1gw/S1GW_ConnHdlr.ttcn @@ -113,6 +113,7 @@ function f_ConnHdlr_conn_track_disable() runs on ConnHdlr { if (conn_track != null) { deactivate(conn_track); + conn_track := null; } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42345?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0b71b543fc7c4e87a86381cc3be23728e75cb59b Gerrit-Change-Number: 42345 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: s1gw: f_ConnHdlr_handover_rqd(): drop unused ERabList
by fixeria 14 Mar '26

14 Mar '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42346?usp=email ) Change subject: s1gw: f_ConnHdlr_handover_rqd(): drop unused ERabList ...................................................................... s1gw: f_ConnHdlr_handover_rqd(): drop unused ERabList Change-Id: If471e9f8daba918d1de90725db34e1930fd2e4d5 Fixes: 8eba9aada ("S1GW tests: Add test cases for S1 handover procedure") --- M s1gw/S1GW_ConnHdlr.ttcn 1 file changed, 2 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/46/42346/1 diff --git a/s1gw/S1GW_ConnHdlr.ttcn b/s1gw/S1GW_ConnHdlr.ttcn index 298a983..615f13e 100644 --- a/s1gw/S1GW_ConnHdlr.ttcn +++ b/s1gw/S1GW_ConnHdlr.ttcn @@ -1776,11 +1776,10 @@ function f_ConnHdlr_handover_rqd_() runs on ConnHdlr { - f_ConnHdlr_handover_rqd(g_pars.erabs, g_pars.mme_ue_id, g_pars.idx); + f_ConnHdlr_handover_rqd(g_pars.mme_ue_id, g_pars.idx); } -function f_ConnHdlr_handover_rqd(in ERabList erabs, - MME_UE_S1AP_ID mme_ue_id, +function f_ConnHdlr_handover_rqd(MME_UE_S1AP_ID mme_ue_id, ENB_UE_S1AP_ID enb_ue_id) runs on ConnHdlr { log("[eNB -> S1GW] -> MME: HANDOVER REQUIRED"); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42346?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If471e9f8daba918d1de90725db34e1930fd2e4d5 Gerrit-Change-Number: 42346 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: s1gw: S1GW_UEMux.f_trx_s1ap_pdu(): fix setverdict() message param
by fixeria 14 Mar '26

14 Mar '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42347?usp=email ) Change subject: s1gw: S1GW_UEMux.f_trx_s1ap_pdu(): fix setverdict() message param ...................................................................... s1gw: S1GW_UEMux.f_trx_s1ap_pdu(): fix setverdict() message param On timeout pdu was never assigned (it's an out parameter), so TITAN logs <unbound>. The useful diagnostic is the expected template, not the received value. Change-Id: Idceefa82ec1b5fc71228b3847c7a22f419c9675e Fixes: 325d07697 ("s1gw: add TC_uemux_uldl_nas_release") --- M s1gw/S1GW_UEMux.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/47/42347/1 diff --git a/s1gw/S1GW_UEMux.ttcn b/s1gw/S1GW_UEMux.ttcn index baecaff..977ceb1 100644 --- a/s1gw/S1GW_UEMux.ttcn +++ b/s1gw/S1GW_UEMux.ttcn @@ -65,7 +65,7 @@ Misc_Helpers.f_shutdown(__BFILE__, __LINE__); } [] T.timeout { - setverdict(fail, "Timeout waiting for S1AP PDU (", dir, "): ", pdu); + setverdict(fail, "Timeout waiting for S1AP PDU (", dir, "): ", tr_pdu); Misc_Helpers.f_shutdown(__BFILE__, __LINE__); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42347?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idceefa82ec1b5fc71228b3847c7a22f419c9675e Gerrit-Change-Number: 42347 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log