- gerrit-log - lists.osmocom.org

[S] Change in ...pyosmocom[master]: Fix lint errors: don't use star imports
by osmith 13 Mar '26

13 Mar '26

Attention is currently required from: fixeria, osmith, pespin. Hello Jenkins Builder, fixeria, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/python/pyosmocom/+/41384?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by pespin, Code-Review+2 by fixeria, Verified+1 by Jenkins Builder Change subject: Fix lint errors: don't use star imports ...................................................................... Fix lint errors: don't use star imports tests/test_tlv.py:21:1: F403 `from osmocom.tlv import *` used; unable to detect undefined names | 19 | import unittest 20 | from construct import Int8ub, GreedyBytes 21 | from osmocom.tlv import * | ^^^^^^^^^^^^^^^^^^^^^^^^^ F403 22 | from osmocom.utils import h2b Change-Id: I0ca76a40d47f72635682de9303ff73e9b2197266 --- M src/osmocom/gsmtap.py M tests/test_construct.py M tests/test_gsup.py M tests/test_tlv.py M tests/test_utils.py 5 files changed, 9 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/python/pyosmocom refs/changes/84/41384/3 -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/41384?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I0ca76a40d47f72635682de9303ff73e9b2197266 Gerrit-Change-Number: 41384 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: 5gc: Introduce tests for emergency services
by osmith 13 Mar '26

13 Mar '26

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42332?usp=email ) Change subject: 5gc: Introduce tests for emergency services ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42332?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie853b184da7ac8026bb0c360baabba762a7942e0 Gerrit-Change-Number: 42332 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 13 Mar 2026 08:48:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: 5gc: parametrize RequestType in f_pdu_sess_establish()
by osmith 13 Mar '26

13 Mar '26

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42329?usp=email ) Change subject: 5gc: parametrize RequestType in f_pdu_sess_establish() ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42329?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I69d6be5e581565720a21c719b0f982eb31ec2adf Gerrit-Change-Number: 42329 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 13 Mar 2026 08:48:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: 5gc: Introduce TC_handover_inter_ngran_n2_cancel
by osmith 13 Mar '26

13 Mar '26

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42328?usp=email ) Change subject: 5gc: Introduce TC_handover_inter_ngran_n2_cancel ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42328?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1137c9a82478cca0372678d3c3299e9eebc79bd5 Gerrit-Change-Number: 42328 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 13 Mar 2026 08:47:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in osmo-ttcn3-hacks[master]: 5gc: Introduce TC_handover_inter_ngran_n2
by osmith 13 Mar '26

13 Mar '26

Attention is currently required from: laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42326?usp=email ) Change subject: 5gc: Introduce TC_handover_inter_ngran_n2 ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File 5gc/C5G_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42326/comment/a7a49ca4_14a2… : PS1, Line 714: COORD.receive(Handover_n2_Pars:?) -> value ho_n2_pars; is this already guarded by a timer, or could it hang forever here? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42326?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I90c7cc6c92864732a36556163aed692b2a1531b0 Gerrit-Change-Number: 42326 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 13 Mar 2026 08:46:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XL] Change in osmo-ccid-firmware[master]: fw source: force reformat once and for all
by osmith 13 Mar '26

13 Mar '26

Attention is currently required from: Hoernchen. osmith has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42330?usp=email ) Change subject: fw source: force reformat once and for all ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > This is the result of clang-format-20 --verbose -style=file:. […] jenkins was using clang-format 14 from debian 12. This patch changes it to clang-format 19 from debian 13: https://gerrit.osmocom.org/c/osmo-ci/+/42336 and this patch makes it print the version: https://gerrit.osmocom.org/c/osmo-ci/+/42337 I re-ran it on this patch with clang-format 19 and it doesn't show a diff for clang-format anymore: https://jenkins.osmocom.org/jenkins/job/gerrit-lint/27389/console -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42330?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Iacc086bb566551225e7a21b639a1ad2ec257484f Gerrit-Change-Number: 42330 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Fri, 13 Mar 2026 08:03:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: lint/lint_diff: print clang-format version
by osmith 13 Mar '26

13 Mar '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/42337?usp=email ) Change subject: lint/lint_diff: print clang-format version ...................................................................... lint/lint_diff: print clang-format version Change-Id: I076a518dccdb241a57628c385a60bffe30298a10 --- M lint/lint_diff.sh 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/37/42337/1 diff --git a/lint/lint_diff.sh b/lint/lint_diff.sh index e37de17..aa328ba 100755 --- a/lint/lint_diff.sh +++ b/lint/lint_diff.sh @@ -86,6 +86,8 @@ echo "Running clang-format on 'git diff $COMMIT'..." echo + clang-format --version + # Run clang-format-diff and colorize its output local diff="$(git diff -U0 --relative "$COMMIT" \ | clang-format-diff -p1 \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42337?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I076a518dccdb241a57628c385a60bffe30298a10 Gerrit-Change-Number: 42337 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: jobs/gerrit-lint: use debian 13
by osmith 13 Mar '26

13 Mar '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/42336?usp=email ) Change subject: jobs/gerrit-lint: use debian 13 ...................................................................... jobs/gerrit-lint: use debian 13 Use debian 13, so we have a newer clang-format version (14 -> 19). Change-Id: I747dce009bb2e91f16a15e79dbe274c162f64813 --- M jobs/gerrit-lint.yml 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/36/42336/1 diff --git a/jobs/gerrit-lint.yml b/jobs/gerrit-lint.yml index 661a600..d621aa5 100644 --- a/jobs/gerrit-lint.yml +++ b/jobs/gerrit-lint.yml @@ -62,7 +62,7 @@ -v ./code-from-gerrit:/build/code-from-gerrit \ -v ./osmo-ci:/build/osmo-ci \ -w /build/code-from-gerrit \ - "$USER/debian-bookworm-build" \ + "$USER/debian-trixie-build" \ /build/osmo-ci/lint/lint_diff.sh HEAD~1 wrappers: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42336?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I747dce009bb2e91f16a15e79dbe274c162f64813 Gerrit-Change-Number: 42336 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XL] Change in osmo-ccid-firmware[master]: fw source: force reformat once and for all
by Jenkins Builder 13 Mar '26

13 Mar '26

Attention is currently required from: Hoernchen. Jenkins Builder has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42330?usp=email ) Change subject: fw source: force reformat once and for all ...................................................................... Patch Set 1: (3 comments) File ccid_common/iso7816_fsm.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42330/comment/ebf48f22_a1… : PS1, Line 940: restart: labels should not be indented File sysmoOCTSIM/dfu_descriptors.h: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42330/comment/35369d98_53… : PS1, Line 30: #define DFURT_IF_DESCRIPTOR_STRUCT \ macros should not use a trailing semicolon File sysmoOCTSIM/talloc.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42330/comment/1b767782_ab… : PS1, Line 254: #define TC_UNDEFINE_GROW_CHUNK(_tc, _new_size) \ Single statement macros should not use a do {} while (0) loop -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42330?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Iacc086bb566551225e7a21b639a1ad2ec257484f Gerrit-Change-Number: 42330 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Fri, 13 Mar 2026 08:00:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XL] Change in osmo-ccid-firmware[master]: fw source: force reformat once and for all
by osmith 13 Mar '26

13 Mar '26

Attention is currently required from: Hoernchen. osmith has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42330?usp=email ) Change subject: fw source: force reformat once and for all ...................................................................... Patch Set 1: Code-Review-1 (5 comments) Patchset: PS1: went through the first files this patch touches and pointed out where the config would IMHO need to be adjusted to not do these kinds of reformattings File ccid_common/ccid_device.c: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42330/comment/71f02887_4c… : PS1, Line 547: // break; not useful IMHO. this is also in other places in this patch. File ccid_common/ccid_proto.h: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42330/comment/c3dbb98b_cc… : PS1, Line 366: #define CCID_CMD_STATUS_TIME_EXT 0x80 here and in enum ccid_error_code below, it is more readable to keep the values directly below each other IMHO File ccid_common/ccid_proto.c: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42330/comment/237bb22e_2b… : PS1, Line 70: { CCID_ERR_CMD_ABORTED, "CMD_ABORTED" }, > for the record, I don't think this is an improvement in readability at all. +1 File ccid_common/iso7816_3.c: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42330/comment/0b5ba4a2_68… : PS1, Line 50: 0, doesn't seem useful to reformat it like this? -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42330?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Iacc086bb566551225e7a21b639a1ad2ec257484f Gerrit-Change-Number: 42330 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Fri, 13 Mar 2026 07:52:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

2026

2025

2024

2023

2022

gerrit-log