- gerrit-log - lists.osmocom.org

Change in libosmo-sccp[master]: cosmetic: improve usage help of example code
by msuraev 17 Aug '22

17 Aug '22

msuraev has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29086 ) Change subject: cosmetic: improve usage help of example code ...................................................................... cosmetic: improve usage help of example code * document -C option for example server * move misplaced comma * drop empty #define from example code Change-Id: I342dc227afbfe6c3540eb3285677c568d2fe3166 --- M examples/sccp_demo_user.c 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified neels: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/examples/sccp_demo_user.c b/examples/sccp_demo_user.c index 1a4ebac..df6c9af 100644 --- a/examples/sccp_demo_user.c +++ b/examples/sccp_demo_user.c @@ -105,7 +105,6 @@ #define DEFAULT_LOCAL_PORT_CLIENT M3UA_PORT #define DEFAULT_REMOTE_PORT_CLIENT DEFAULT_LOCAL_PORT_SERVER #define DEFAULT_REMOTE_PORT_SERVER DEFAULT_LOCAL_PORT_CLIENT -#define DEFAULT_REMOTE_PORT_SERVER_STR DEFAULT_LOCAL_PORT_CLIENT_STR #define DEFAULT_PC_SERVER 1 #define DEFAULT_PC_CLIENT 23 @@ -116,13 +115,14 @@ "Options:\n" " -p: protocol to use (m3ua, sua, ipa; default is ipa)\n" " -c: Run in client mode (default is server mode)\n" + " -C filename The config file to use\n" " -l: local IP address and SCTP port (default is %s:%d in server mode,\n" " %s:%d in client mode)\n" " -r: remote IP address and SCTP port (default is %s:%d in server mode,\n" " %s:%d in client mode)\n" " -L: local point code (default is %d in server mode, %d in client mode)\n" - " -R: remote point code (default is %d in server mode, %d in client mode)\n", - " -d: LOGMASK (libosmocore log mask string, e.g. -d DLINP,1:DLSS7,2)\n" + " -R: remote point code (default is %d in server mode, %d in client mode)\n" + " -d: LOGMASK (libosmocore log mask string, e.g. -d DLINP,1:DLSS7,2)\n", DEFAULT_LOCAL_ADDRESS_SERVER, DEFAULT_LOCAL_PORT_SERVER, DEFAULT_LOCAL_ADDRESS_CLIENT, DEFAULT_LOCAL_PORT_CLIENT, DEFAULT_REMOTE_ADDRESS_SERVER, DEFAULT_REMOTE_PORT_SERVER, 9 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29086 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I342dc227afbfe6c3540eb3285677c568d2fe3166 Gerrit-Change-Number: 29086 Gerrit-PatchSet: 10 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in libosmo-sccp[master]: SCCP: enforce optional data length limits
by msuraev 17 Aug '22

17 Aug '22

Attention is currently required from: neels. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29083 ) Change subject: SCCP: enforce optional data length limits ...................................................................... Patch Set 5: (1 comment) File src/sccp.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29083/comment/c80251cb_d07e3355 PS4, Line 234: return -EBADSLT; > EBADSLT "Invalid slot"? how about EMSGSIZE Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29083 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Icc3bd0a71b29cf61a259c5d97e7dd85beb4397bd Gerrit-Change-Number: 29083 Gerrit-PatchSet: 5 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Aug 2022 04:48:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in libosmo-sccp[master]: Log more data on CR and N-CONNECT
by msuraev 17 Aug '22

17 Aug '22

Attention is currently required from: neels. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29085 ) Change subject: Log more data on CR and N-CONNECT ...................................................................... Patch Set 8: (1 comment) Patchset: PS7: > i'd solve this question by looking at wireshark instead of logging? Those're not mutually exclusive. Although I should try GSMTAP log target to see both at the same place. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29085 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I4d7fc44fde5b900907ec5ebec0450040a764802a Gerrit-Change-Number: 29085 Gerrit-PatchSet: 8 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Aug 2022 04:48:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in libosmo-sccp[master]: SIGTRAN: add function to check connection existence
by msuraev 17 Aug '22

17 Aug '22

Attention is currently required from: neels, fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29087 ) Change subject: SIGTRAN: add function to check connection existence ...................................................................... Patch Set 9: (1 comment) File examples/sccp_test_vty.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29087/comment/35adf953_392149f8 PS8, Line 44: int conn_id = atoi(argv[0]), ret; > please declare 'int ret;' on a separate line Why? I don't recall anything about it from Linux kernel coding style. Having it on the same line makes it easier to read. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29087 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Iffedf55b4c292ee6b2f97bcdeef6dc13c050ce01 Gerrit-Change-Number: 29087 Gerrit-PatchSet: 9 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Aug 2022 04:47:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in libosmo-sccp[master]: SIGTRAN: enforce length limits on SCCP Optional Data
by msuraev 17 Aug '22

17 Aug '22

Attention is currently required from: neels. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 ) Change subject: SIGTRAN: enforce length limits on SCCP Optional Data ...................................................................... Patch Set 4: (2 comments) Commit Message: https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/7f33be80_6ebfb2a4 PS4, Line 7: SIGTRAN: enforce optional data length limits > "enforce length limits on SCCP Optional Data" ? Done File src/sccp_scoc.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/5066f7ee_e94b5471 PS4, Line 617: /* optional: hop coun */ > "count" ? Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I0033faf9da393418930252233ce74d62cd1cef8a Gerrit-Change-Number: 29084 Gerrit-PatchSet: 4 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Aug 2022 04:45:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in libosmo-sccp[master]: SCCP: enforce optional data length limits
by msuraev 17 Aug '22

17 Aug '22

Attention is currently required from: msuraev. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29083 to look at the new patch set (#5). Change subject: SCCP: enforce optional data length limits ...................................................................... SCCP: enforce optional data length limits Limit length of optional Data parameter to 130 bytes to conform with ITU-T Rec Q.713 §4.2..§4.5 while receiving SCCP messages. Related: OS#5579 Change-Id: Icc3bd0a71b29cf61a259c5d97e7dd85beb4397bd --- M include/osmocom/sccp/sccp_types.h M src/sccp.c 2 files changed, 29 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/83/29083/5 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29083 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Icc3bd0a71b29cf61a259c5d97e7dd85beb4397bd Gerrit-Change-Number: 29083 Gerrit-PatchSet: 5 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in libosmo-sccp[master]: SIGTRAN: add function to check connection existence
by msuraev 17 Aug '22

17 Aug '22

Attention is currently required from: fixeria, msuraev. Hello Jenkins Builder, neels, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29087 to look at the new patch set (#9). Change subject: SIGTRAN: add function to check connection existence ...................................................................... SIGTRAN: add function to check connection existence Add convenience helper to check if particular connection ID exists and use it to properly report errors when attempting to send messages over non-existent connections. Change-Id: Iffedf55b4c292ee6b2f97bcdeef6dc13c050ce01 --- M examples/sccp_test_vty.c M include/osmocom/sigtran/sccp_helpers.h M src/sccp_helpers.c M src/sccp_scoc.c 4 files changed, 41 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/87/29087/9 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29087 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Iffedf55b4c292ee6b2f97bcdeef6dc13c050ce01 Gerrit-Change-Number: 29087 Gerrit-PatchSet: 9 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in libosmo-sccp[master]: SIGTRAN: enforce length limits on SCCP Optional Data
by msuraev 17 Aug '22

17 Aug '22

Attention is currently required from: msuraev. Hello Jenkins Builder, neels, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 to look at the new patch set (#5). Change subject: SIGTRAN: enforce length limits on SCCP Optional Data ...................................................................... SIGTRAN: enforce length limits on SCCP Optional Data Limit length of optional Data parameter to 130 bytes to conform with ITU-T Rec Q.713 §4.2..§4.5 while sending SCCP messages. Related: OS#5579 Change-Id: I0033faf9da393418930252233ce74d62cd1cef8a --- M src/sccp_scoc.c 1 file changed, 31 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/84/29084/5 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I0033faf9da393418930252233ce74d62cd1cef8a Gerrit-Change-Number: 29084 Gerrit-PatchSet: 5 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

Change in osmo-hnbgw[master]: make: fix -l order: first libosmo-pfcp, then -gtlv
by neels 17 Aug '22

17 Aug '22

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29118 ) Change subject: make: fix -l order: first libosmo-pfcp, then -gtlv ...................................................................... make: fix -l order: first libosmo-pfcp, then -gtlv During debian package building on OBS, the package build fails if libosmo-gtlv is listed before libosmo-pfcp. Change-Id: Ibbddef02edbd6eb58828ca496f3b36613d4285fc --- M src/osmo-hnbgw/Makefile.am 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/18/29118/1 diff --git a/src/osmo-hnbgw/Makefile.am b/src/osmo-hnbgw/Makefile.am index 1d907ba..3f397ec 100644 --- a/src/osmo-hnbgw/Makefile.am +++ b/src/osmo-hnbgw/Makefile.am @@ -62,12 +62,12 @@ if ENABLE_PFCP AM_CFLAGS += \ - $(LIBOSMOGTLV_CFLAGS) \ $(LIBOSMOPFCP_CFLAGS) \ + $(LIBOSMOGTLV_CFLAGS) \ $(NULL) osmo_hnbgw_LDADD += \ - $(LIBOSMOGTLV_LIBS) \ $(LIBOSMOPFCP_LIBS) \ + $(LIBOSMOGTLV_LIBS) \ $(NULL) osmo_hnbgw_SOURCES += \ hnbgw_pfcp.c \ -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29118 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ibbddef02edbd6eb58828ca496f3b36613d4285fc Gerrit-Change-Number: 29118 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-ci[master]: obs: add README
by neels 17 Aug '22

17 Aug '22

Attention is currently required from: osmith. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29110 ) Change subject: obs: add README ...................................................................... Patch Set 3: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29110 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4d1303e0c04e827200b48a9fe4aea3680c9c9f84 Gerrit-Change-Number: 29110 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Aug 2022 02:12:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log