- gerrit-log - lists.osmocom.org

Change in osmo-ci[master]: obs: tweak logging output
by neels 17 Aug '22

17 Aug '22

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/29117 ) Change subject: obs: tweak logging output ...................................................................... obs: tweak logging output Change-Id: I203cb7f0aa21b59b06973e8f329cffdc64aa8d47 --- M scripts/obs/lib/git.py 1 file changed, 5 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/17/29117/1 diff --git a/scripts/obs/lib/git.py b/scripts/obs/lib/git.py index 67f1d5e..29c183b 100644 --- a/scripts/obs/lib/git.py +++ b/scripts/obs/lib/git.py @@ -28,10 +28,10 @@ if os.path.exists(repo_path): if fetch: - print(f"{project}: cloning {url} (cached, fetching)") + print(f"{project}: 'git fetch'") lib.run_cmd(["git", "fetch"], cwd=repo_path) else: - print(f"{project}: cloning {url} (cached, not fetching)") + print(f"{project}: using cached {url} (not cloning, not fetching)") return print(f"{project}: cloning {url}") @@ -46,13 +46,15 @@ def clean(project): repo_path = get_repo_path(project) + print(f"{project}: 'git clean -ffxd'") lib.run_cmd(["git", "clean", "-ffxd"], cwd=repo_path) def checkout(project, branch): repo_path = get_repo_path(project) - print(f"{project}: checking out {branch}") + print(f"{project}: 'git checkout -f {branch}'") lib.run_cmd(["git", "checkout", "-f", branch], cwd=repo_path) + print(f"{project}: 'git reset --hard {branch}'") lib.run_cmd(["git", "reset", "--hard", branch], cwd=repo_path) -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29117 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I203cb7f0aa21b59b06973e8f329cffdc64aa8d47 Gerrit-Change-Number: 29117 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-ci[master]: obs: add explicit --git-branch arg
by neels 17 Aug '22

17 Aug '22

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/29116 ) Change subject: obs: add explicit --git-branch arg ...................................................................... obs: add explicit --git-branch arg Change-Id: I612c18e533542f442e0571927fee8b8be9fb8c2b --- M scripts/obs/build_srcpkg.py M scripts/obs/lib/__init__.py M scripts/obs/lib/srcpkg.py M scripts/obs/update_obs_project.py 4 files changed, 22 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/16/29116/1 diff --git a/scripts/obs/build_srcpkg.py b/scripts/obs/build_srcpkg.py index ccf82d7..ea7ab34 100755 --- a/scripts/obs/build_srcpkg.py +++ b/scripts/obs/build_srcpkg.py @@ -40,7 +40,7 @@ lib.metapkg.build(args.feed, args.conflict_version) if args.package: - lib.srcpkg.build(args.package, args.feed, args.conflict_version, + lib.srcpkg.build(args.package, args.feed, args.git_branch, args.conflict_version, args.git_fetch) diff --git a/scripts/obs/lib/__init__.py b/scripts/obs/lib/__init__.py index 193c248..8473ab9 100644 --- a/scripts/obs/lib/__init__.py +++ b/scripts/obs/lib/__init__.py @@ -16,6 +16,9 @@ parser.add_argument("-f", "--feed", help="package feed (default: nightly)", metavar="FEED", default="nightly", choices=lib.config.feeds) + parser.add_argument("-b", "--git-branch", help="instead of using a branch" + " named like the feed, checkout this git branch", + metavar="BRANCH", default=None) parser.add_argument("-d", "--docker", help="run in docker to avoid installing required pkgs", action="store_true") diff --git a/scripts/obs/lib/srcpkg.py b/scripts/obs/lib/srcpkg.py index 468a240..6148883 100644 --- a/scripts/obs/lib/srcpkg.py +++ b/scripts/obs/lib/srcpkg.py @@ -7,9 +7,11 @@ import lib.rpm_spec -def checkout_for_feed(project, feed): +def checkout_for_feed(project, feed, branch=None): """ checkout a commit, either latest tag or master or 20YY branch """ - if feed == "latest": + if branch: + lib.git.checkout(project, branch) + elif feed == "latest": lib.git.checkout_latest_tag(project) elif feed == "nightly": lib.git.checkout_default_branch(project) @@ -118,10 +120,12 @@ f.write(f"{version}\n") -def build(project, feed, conflict_version, fetch): +def build(project, feed, branch, conflict_version, fetch): + if not branch: + branch = feed lib.git.clone(project, fetch) lib.git.clean(project) - checkout_for_feed(project, feed) + checkout_for_feed(project, feed, branch) version = get_version_for_feed(project, feed, conflict_version) epoch = get_epoch(project) version_epoch = f"{epoch}:{version}" if epoch else version @@ -132,6 +136,7 @@ if project in lib.config.projects_osmocom: metapkg = f"osmocom-{feed}" + lib.debian.control_add_depend(project, metapkg, conflict_version) if has_rpm_spec: lib.rpm_spec.add_depend(project, metapkg, conflict_version) diff --git a/scripts/obs/update_obs_project.py b/scripts/obs/update_obs_project.py index 759acfe..02db7ce 100755 --- a/scripts/obs/update_obs_project.py +++ b/scripts/obs/update_obs_project.py @@ -32,7 +32,7 @@ return ret -def build_srcpkg(feed, package, conflict_version, fetch, is_meta_pkg): +def build_srcpkg(feed, branch, package, conflict_version, fetch, is_meta_pkg): global srcpkgs_built global srcpkgs_failed_build @@ -42,7 +42,7 @@ if is_meta_pkg: version = lib.metapkg.build(feed, conflict_version) else: - version = lib.srcpkg.build(package, feed, conflict_version, fetch) + version = lib.srcpkg.build(package, feed, branch, conflict_version, fetch) srcpkgs_built[package] = version except Exception as ex: traceback.print_exception(type(ex), ex, ex.__traceback__) @@ -62,7 +62,7 @@ return False -def build_srcpkg_if_needed(proj, feed, pkgs_remote, package, conflict_version, +def build_srcpkg_if_needed(proj, feed, branch, pkgs_remote, package, conflict_version, fetch, is_meta_pkg, skip_up_to_date): global srcpkgs_skipped @@ -96,7 +96,7 @@ print(f"{package}: building source package (outdated:" f" {latest_version} <=> {obs_version} in OBS)") - build_srcpkg(feed, package, conflict_version, fetch, is_meta_pkg) + build_srcpkg(feed, branch, package, conflict_version, fetch, is_meta_pkg) def upload_srcpkg(proj, feed, pkgs_remote, package, version): @@ -105,18 +105,18 @@ lib.osc.update_package(proj, package, version) -def build_srcpkgs(proj, feed, pkgs_remote, packages, conflict_version, fetch, +def build_srcpkgs(proj, feed, branch, pkgs_remote, packages, conflict_version, fetch, meta, skip_up_to_date): print() print("### Building source packages ###") print() if meta: - build_srcpkg_if_needed(proj, feed, pkgs_remote, f"osmocom-{feed}", + build_srcpkg_if_needed(proj, feed, branch, pkgs_remote, f"osmocom-{feed}", conflict_version, fetch, True, skip_up_to_date) for package in packages: - build_srcpkg_if_needed(proj, feed, pkgs_remote, package, + build_srcpkg_if_needed(proj, feed, branch, pkgs_remote, package, conflict_version, fetch, False, skip_up_to_date) @@ -191,6 +191,7 @@ args = parser.parse_args() proj = args.obs_project feed = args.feed + branch = args.git_branch packages = parse_packages(args.package) lib.set_cmds_verbose(args.verbose) @@ -205,7 +206,7 @@ pkgs_remote = lib.osc.get_remote_pkgs(proj) - build_srcpkgs(proj, feed, pkgs_remote, packages, args.conflict_version, + build_srcpkgs(proj, feed, branch, pkgs_remote, packages, args.conflict_version, args.git_fetch, args.meta, args.skip_up_to_date) upload_srcpkgs(proj, feed, pkgs_remote) exit_with_summary() -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29116 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I612c18e533542f442e0571927fee8b8be9fb8c2b Gerrit-Change-Number: 29116 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-bsc[master]: BSSMAP: make sure we don't try to reset non-existent entity
by neels 17 Aug '22

17 Aug '22

Attention is currently required from: pespin, msuraev. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28892 ) Change subject: BSSMAP: make sure we don't try to reset non-existent entity ...................................................................... Patch Set 2: Code-Review-1 (3 comments) Patchset: PS2: in OS#5551 i explain why this fix seems to be not needed. If there is ever a situation where bssmap_reset == NULL, we need to find that and fix it. I currently don't see how that is possible at all. There is not even uncertainty, race or async things going on, it is simply not possible. File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/28892/comment/e679b15c_f951f808 PS2, Line 3393: if (!msc->a.bssmap_reset) { Wording confusion: - this is not about "Resetting the BSSMAP interface", it is about sending a BSSMAP Reset message to the peer. - this is not about an unallocated MSC. If the MSC is not allocated, above 'if (!msc)' triggers. If bssmap_reset is NULL, then the RESET message handling FSM instance has not been initialized / already torn down. The code below is about sending a BSSMAP RESET message, so the log should say something like "Unable to send BSSMAP RESET message, bssmap_reset FSM not allocated" But did you actually face a situation like this? Seems unlikely to happen. File src/osmo-bsc/bssmap_reset.c: https://gerrit.osmocom.org/c/osmo-bsc/+/28892/comment/ef077194_f2e3c53d PS2, Line 249: LOGP(DMSC, LOGL_ERROR, "Attempt to reset non-existent BSSMAP\n"); No caller should call this function with a NULL argument. Otherwise we'd need to add such NULL checks to all of the API functions everywhere. If it is really plausible, then: Wording confusion: rather "Unable to send BSSMAP RESET message, no FSM instance present" -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28892 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I235bdd42ea82e7b5a1a40f437ca34c49ad239c48 Gerrit-Change-Number: 28892 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Aug 2022 02:09:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-msc[master]: cosmetic: use proper name for SMPP handlers
by neels 17 Aug '22

17 Aug '22

Attention is currently required from: msuraev. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28840 ) Change subject: cosmetic: use proper name for SMPP handlers ...................................................................... Patch Set 25: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28840 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I0d714e927e287a0ea9362008ed050a492510e22b Gerrit-Change-Number: 28840 Gerrit-PatchSet: 25 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Aug 2022 01:47:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-msc[master]: Make esme struct shared
by neels 17 Aug '22

17 Aug '22

Attention is currently required from: pespin, msuraev, dexter. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28846 ) Change subject: Make esme struct shared ...................................................................... Patch Set 19: Code-Review-1 (4 comments) File include/osmocom/smpp/smpp.h: https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/75e5796c_038ce042 PS19, Line 14: struct esme { prefer 'struct smpp_esme' since it is from smpp.h File include/osmocom/smpp/smpp_smsc.h: https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/eb66d78b_c63ea6c8 PS19, Line 32: struct esme *esme; just 'struct esme esme;' (non-pointer) to avoid extra talloc, then smpp_esme_init(&osmo_esme.esme) instead of esme_alloc() File src/libsmpputil/smpp_smsc.c: https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/dcef0350_bd4e35a1 PS19, Line 900: esme->esme = esme_alloc(esme); ...because the esme_alloc() appears to unconditionally take place after talloc(struct osmo_esme) anyway. File src/utils/Makefile.am: https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/f65950f5_9b47607a PS19, Line 45: $(top_builddir)/src/libvlr/libvlr.a \ smpp_mirror certainly does not need libvlr.a. also looks weird to require libmsc.a. and pull in ASN1C, SIGTRAN and SQLITE3 below... can you find a way to not pull in all sorts of unrelated dependencies? just guessing, maybe move the esme implementation from libmsc to libsmpputil? -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28846 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I8f7ac2c00d16660925dd0b03aa1a0973edf9eb70 Gerrit-Change-Number: 28846 Gerrit-PatchSet: 19 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Aug 2022 01:47:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Build failure of network:osmocom:nightly/osmo-iuh in Raspbian_11/armv7l
by OBS Notification 17 Aug '22

17 Aug '22

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/o… Package network:osmocom:nightly/osmo-iuh failed to build in Raspbian_11/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-iuh Last lines of build log: [ 196s] update-alternatives: using /usr/share/docutils/scripts/python3/rst2xml to provide /usr/bin/rst2xml (rst2xml) in auto mode [ 196s] update-alternatives: using /usr/share/docutils/scripts/python3/rstpep2html to provide /usr/bin/rstpep2html (rstpep2html) in auto mode [ 197s] [452/485] installing python3-reportlab-3.5.59-2 [ 199s] [453/485] installing g++-4:10.2.1-1+rpi1 [ 199s] update-alternatives: using /usr/bin/g++ to provide /usr/bin/c++ (c++) in auto mode [ 199s] [454/485] installing libosmo-netif-dev-1.2.0.7.c824.202208170052 [ 200s] [455/485] installing mount-2.36.1-8+deb11u1 [ 200s] [456/485] installing texlive-latex-extra-2020.20210202-3 [ 203s] [457/485] installing debhelper-13.3.4 [ 204s] [458/485] installing bash-5.1-2+deb11u1 [ 205s] update-alternatives: using /usr/share/man/man7/bash-builtins.7.gz to provide /usr/share/man/man7/builtins.7.gz (builtins.7.gz) in auto mode [ 205s] [459/485] installing libosmo-sigtran-dev-1.6.0.1.e6ce.202208170052 [ 205s] [460/485] installing build-essential-12.9 [ 205s] [461/485] installing python3-blockdiag-2.0.1+dfsg-1 [ 206s] [462/485] installing texlive-xetex-2020.20210202-3 [ 208s] dpkg-deb (subprocess): decompressing archive '.init_b_cache/texlive-xetex.deb' (size=12542520) member 'data.tar': lzma error: compressed data is corrupt [ 208s] dpkg-deb: error: <decompress> subprocess returned error exit status 2 [ 208s] dpkg: error processing archive .init_b_cache/texlive-xetex.deb (--install): [ 208s] cannot copy extracted data for './usr/share/doc/texlive-doc/xetex/xesearch/xesearch.pdf' to '/usr/share/doc/texlive-doc/xetex/xesearch/xesearch.pdf.dpkg-new': unexpected end of file or stream [ 208s] Errors were encountered while processing: [ 208s] .init_b_cache/texlive-xetex.deb [ 208s] exit ... [ 208s] ### VM INTERACTION START ### [ 208s] [ 183.908582] sysrq: SysRq : Power Off [ 208s] [ 183.910438] reboot: Power down [ 208s] ### VM INTERACTION END ### [ 208s] [ 208s] armbuild02 failed "build osmo-iuh_1.3.0.2.a9c38.202208170052.dsc" at Wed Aug 17 01:36:59 UTC 2022. [ 208s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)

1 0

Change in osmo-msc[master]: Use libsmpputil functions in smpp_mirror tool
by neels 17 Aug '22

17 Aug '22

Attention is currently required from: msuraev. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28847 ) Change subject: Use libsmpputil functions in smpp_mirror tool ...................................................................... Patch Set 26: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28847 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Icb046570803acb3eff89e2a4eb979c4899d485f7 Gerrit-Change-Number: 28847 Gerrit-PatchSet: 26 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Aug 2022 01:28:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmo-sccp[master]: SIGTRAN: enforce optional data length limits
by neels 17 Aug '22

17 Aug '22

Attention is currently required from: msuraev. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 ) Change subject: SIGTRAN: enforce optional data length limits ...................................................................... Patch Set 4: Code-Review-1 (5 comments) Commit Message: https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/06c69059_3b261ef1 PS4, Line 7: SIGTRAN: enforce optional data length limits "enforce length limits on SCCP Optional Data" ? File src/sccp_scoc.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/c270a568_6601112b PS4, Line 580: if (prim && msgb_l2(prim->oph.msg) && msgb_l2len(prim->oph.msg)) { exit early if (!(...)) return true; if (msgb...) { ... } xua_msg_add_data(...); return true; https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/3dbb9804_bdfbc6b7 PS4, Line 585: xua_msg_free(xua); freeing here is very confusing memory management. The caller should do this free when receiving an error rc. https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/d876a623_fb00d419 PS4, Line 615: if (!xua_add_data(prim, xua, "4.2")) this looks like a mem leak of above xua_msg_alloc(). the free should not be in xua_add_data() https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/0191abbb_68985a90 PS4, Line 617: /* optional: hop coun */ "count" ? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I0033faf9da393418930252233ce74d62cd1cef8a Gerrit-Change-Number: 29084 Gerrit-PatchSet: 4 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Aug 2022 01:26:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmo-sccp[master]: SCCP: enforce optional data length limits
by neels 17 Aug '22

17 Aug '22

Attention is currently required from: msuraev. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29083 ) Change subject: SCCP: enforce optional data length limits ...................................................................... Patch Set 4: (1 comment) File src/sccp.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29083/comment/c02401cf_f835e08c PS4, Line 234: return -EBADSLT; EBADSLT "Invalid slot"? how about EMSGSIZE -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29083 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Icc3bd0a71b29cf61a259c5d97e7dd85beb4397bd Gerrit-Change-Number: 29083 Gerrit-PatchSet: 4 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Aug 2022 01:19:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in libosmo-sccp[master]: Log more data on CR and N-CONNECT
by neels 17 Aug '22

17 Aug '22

Attention is currently required from: msuraev. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29085 ) Change subject: Log more data on CR and N-CONNECT ...................................................................... Patch Set 7: Code-Review+1 (1 comment) Patchset: PS7: i'd solve this question by looking at wireshark instead of logging? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29085 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I4d7fc44fde5b900907ec5ebec0450040a764802a Gerrit-Change-Number: 29085 Gerrit-PatchSet: 7 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Aug 2022 01:15:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log