- gerrit-log - lists.osmocom.org

Change in libosmo-sccp[master]: cosmetic: improve usage help of example code
by neels 17 Aug '22

17 Aug '22

Attention is currently required from: msuraev. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29086 ) Change subject: cosmetic: improve usage help of example code ...................................................................... Patch Set 9: Code-Review+2 (1 comment) File examples/sccp_demo_user.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29086/comment/4870380e_37b52936 PS9, Line 124: , nice catch! -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29086 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I342dc227afbfe6c3540eb3285677c568d2fe3166 Gerrit-Change-Number: 29086 Gerrit-PatchSet: 9 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Aug 2022 01:12:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmo-sccp[master]: SIGTRAN: add function to check connection existence
by neels 17 Aug '22

17 Aug '22

Attention is currently required from: fixeria, msuraev. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29087 ) Change subject: SIGTRAN: add function to check connection existence ...................................................................... Patch Set 8: Code-Review-1 (2 comments) Patchset: PS8: the added function and the changed VTY behavior have to be two separate patches File examples/sccp_test_vty.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29087/comment/59fb8c4d_6b3379bb PS8, Line 44: int conn_id = atoi(argv[0]), ret; please declare 'int ret;' on a separate line. we usually call it rc. (ret only when it gets returned, rc for functions we are calling) -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29087 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Iffedf55b4c292ee6b2f97bcdeef6dc13c050ce01 Gerrit-Change-Number: 29087 Gerrit-PatchSet: 8 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Aug 2022 01:09:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmocore[master]: Add osmo_sockaddr_strs_to_str()
by neels 17 Aug '22

17 Aug '22

Attention is currently required from: msuraev. neels has created a revert of this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28992 ) Change subject: Add osmo_sockaddr_strs_to_str() ...................................................................... -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28992 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic0d7c08f669994e37a2314555ecac85d28c42c89 Gerrit-Change-Number: 28992 Gerrit-PatchSet: 8 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: revert

1 0

Change in libosmocore[master]: Revert "Add osmo_sockaddr_strs_to_str()"
by neels 17 Aug '22

17 Aug '22

Attention is currently required from: laforge, pespin, msuraev. Hello Jenkins Builder, laforge, pespin, msuraev, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/libosmocore/+/29123 to review the following change. Change subject: Revert "Add osmo_sockaddr_strs_to_str()" ...................................................................... Revert "Add osmo_sockaddr_strs_to_str()" This reverts commit e145e28a91eeca65d34d7b82caa2190fa89492b4. Reason for revert: The function osmo_sockaddr_strs_to_str() should not be part of the osmo_sockaddr_str API. The implementation of this should live in the function multiaddr_snprintf() added in patch Icef53fe4b6e51563d97a1bc48001d67679b3b6e9 and should not use dynamic allocation. Change-Id: I263dfd68313b896c5b474025fbca13c22ce41cdc --- M include/osmocom/core/sockaddr_str.h M src/sockaddr_str.c M tests/sockaddr_str/sockaddr_str_test.c M tests/sockaddr_str/sockaddr_str_test.ok 4 files changed, 8 insertions(+), 115 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/23/29123/1 diff --git a/include/osmocom/core/sockaddr_str.h b/include/osmocom/core/sockaddr_str.h index 604f926..a46ad59 100644 --- a/include/osmocom/core/sockaddr_str.h +++ b/include/osmocom/core/sockaddr_str.h @@ -59,14 +59,12 @@ * struct osmo_sockaddr_str *my_sockaddr_str = ...; * printf("got " OSMO_SOCKADDR_STR_FMT "\n", OSMO_SOCKADDR_STR_FMT_ARGS(my_sockaddr_str)); */ -#define OSMO_SOCKADDR_STR_NO_PORT_FMT "%s%s%s" -#define OSMO_SOCKADDR_STR_NO_PORT_FMT_ARGS(R) \ - ((R) && (R)->af == AF_INET6) ? "[" : "", \ - (R) ? (R)->ip : "NULL", \ - ((R) && (R)->af == AF_INET6) ? "]" : "" - -#define OSMO_SOCKADDR_STR_FMT OSMO_SOCKADDR_STR_NO_PORT_FMT ":%u" -#define OSMO_SOCKADDR_STR_FMT_ARGS(R) OSMO_SOCKADDR_STR_NO_PORT_FMT_ARGS(R), (R) ? (R)->port : 0 +#define OSMO_SOCKADDR_STR_FMT "%s%s%s:%u" +#define OSMO_SOCKADDR_STR_FMT_ARGS(R) \ + ((R) && (R)->af == AF_INET6)? "[" : "", \ + (R)? (R)->ip : "NULL", \ + ((R) && (R)->af == AF_INET6)? "]" : "", \ + (R)? (R)->port : 0 bool osmo_sockaddr_str_is_set(const struct osmo_sockaddr_str *sockaddr_str); bool osmo_sockaddr_str_is_nonzero(const struct osmo_sockaddr_str *sockaddr_str); @@ -90,7 +88,6 @@ int osmo_sockaddr_str_to_sockaddr_in(const struct osmo_sockaddr_str *sockaddr_str, struct sockaddr_in *dst); int osmo_sockaddr_str_to_sockaddr_in6(const struct osmo_sockaddr_str *sockaddr_str, struct sockaddr_in6 *dst); int osmo_sockaddr_str_to_sockaddr(const struct osmo_sockaddr_str *sockaddr_str, struct sockaddr_storage *dst); -int osmo_sockaddr_strs_to_str(char *buf, size_t buf_len, const struct osmo_sockaddr_str **sa_str, size_t sa_str_count); int osmo_sockaddr_str_from_32n(struct osmo_sockaddr_str *sockaddr_str, uint32_t ip, uint16_t port) OSMO_DEPRECATED("osmo_sockaddr_str_from_32n() actually uses *host* byte order. Use osmo_sockaddr_str_from_32h() instead"); diff --git a/src/sockaddr_str.c b/src/sockaddr_str.c index b5007c3..70927a7 100644 --- a/src/sockaddr_str.c +++ b/src/sockaddr_str.c @@ -541,48 +541,5 @@ } } -/*! Convert array of osmo_sockaddr_str address strings into a string representation of the address set, in the form: - * buf_len == 0: "()" - * buf_len == 1: "hostA" - * buf_len >= 2: (hostA|hostB|...|...) - * The port information is ignored. - * \param[out] buf The buffer to store address set representation in. - * \param[in] buf_len The size of buffer for address set representation. - * \param[in] sa_str The array of osmo_sockaddr_str structs. - * \param[in] sa_str_count Number of osmo_sockaddr_str structs to convert. - * \return 0 on success, negative on error. - */ -int osmo_sockaddr_strs_to_str(char *buf, size_t buf_len, const struct osmo_sockaddr_str **sa_str, size_t sa_str_count) -{ - size_t i; - struct osmo_strbuf sb = { .buf = buf, .len = buf_len }; - char *after; - - if (buf_len < 3) - return -ENOMEM; - - if (sa_str_count != 1) - OSMO_STRBUF_PRINTF(sb, "("); - - for (i = 0; i < sa_str_count; i++) { - if (sa_str_count == 1) - after = ""; - else - after = (i == (sa_str_count - 1)) ? ")" : "|"; - - if (sa_str[i]) - OSMO_STRBUF_PRINTF(sb, OSMO_SOCKADDR_STR_NO_PORT_FMT "%s", - OSMO_SOCKADDR_STR_NO_PORT_FMT_ARGS(sa_str[i]), after); - } - - if (sa_str_count == 0) - OSMO_STRBUF_PRINTF(sb, ")"); - - if (sb.chars_needed >= buf_len) - return -ENOSPC; - - return sb.chars_needed; -} - /*! @} */ #endif // HAVE_NETINET_IN_H diff --git a/tests/sockaddr_str/sockaddr_str_test.c b/tests/sockaddr_str/sockaddr_str_test.c index 8077b9a..0d0674b 100644 --- a/tests/sockaddr_str/sockaddr_str_test.c +++ b/tests/sockaddr_str/sockaddr_str_test.c @@ -24,10 +24,7 @@ #include <errno.h> #include <string.h> #include <osmocom/core/sockaddr_str.h> -#include <osmocom/core/application.h> -#include <osmocom/core/logging.h> #include <osmocom/core/utils.h> -#include <osmocom/core/socket.h> #include <netinet/in.h> struct osmo_sockaddr_str oip_data[] = { @@ -262,62 +259,10 @@ } } -static int test_sockaddr_strs_dump(void *ctx, struct osmo_sockaddr_str *xdata, size_t count) -{ - char buf[OSMO_SOCK_NAME_MAXLEN * OSMO_SOCK_MAX_ADDRS * 2]; - struct osmo_sockaddr_str *sa_strs[OSMO_SOCK_MAX_ADDRS]; - int i, j, rc; - - for (i = 0, j = 0; j < count && i < OSMO_SOCK_MAX_ADDRS; j++) {//ARRAY_SIZE(oip_data) - sa_strs[i] = talloc_zero(ctx, struct osmo_sockaddr_str); - struct sockaddr_storage tmp; - if (osmo_sockaddr_str_to_sockaddr(&xdata[j], &tmp) == 0) {//&oip_data[j] - rc = osmo_sockaddr_str_from_sockaddr(sa_strs[i], &tmp); - if (rc < 0) { - printf("osmo_sockaddr_str_from_sockaddr(%d) failed on ", i); - dump_oip(&xdata[j]);//&oip_data[j] - return rc; - } - i++; - } - } - rc = osmo_sockaddr_strs_to_str(buf, sizeof(buf), (const struct osmo_sockaddr_str **)sa_strs, i); - printf("\nTest data [%d == %ld]: %s\n", rc, strlen(buf), buf); - return rc; -} - -const struct log_info_cat default_categories[] = { -}; - -static struct log_info info = { - .cat = default_categories, - .num_cat = ARRAY_SIZE(default_categories), -}; - int main(int argc, char **argv) { - int rc; - void *ctx = talloc_named_const(NULL, 0, "sockaddr_str__test"); - osmo_init_logging2(ctx, &info); - log_set_use_color(osmo_stderr_target, 0); - log_set_print_filename2(osmo_stderr_target, LOG_FILENAME_NONE); - log_set_print_category(osmo_stderr_target, 0); - log_set_print_category_hex(osmo_stderr_target, 0); - sockaddr_str_test_conversions(); test_osmo_sockaddr_str_cmp(); - - rc = test_sockaddr_strs_dump(ctx, oip_data, ARRAY_SIZE(oip_data)); - if (rc < 0) - return EXIT_FAILURE; - - rc = test_sockaddr_strs_dump(ctx, oip_data, 1); - if (rc < 0) - return EXIT_FAILURE; - - rc = test_sockaddr_strs_dump(ctx, oip_data, 0); - if (rc < 0) - return EXIT_FAILURE; - - return EXIT_SUCCESS; + return 0; } + diff --git a/tests/sockaddr_str/sockaddr_str_test.ok b/tests/sockaddr_str/sockaddr_str_test.ok index 504231c..910e919 100644 --- a/tests/sockaddr_str/sockaddr_str_test.ok +++ b/tests/sockaddr_str/sockaddr_str_test.ok @@ -937,9 +937,3 @@ osmo_sockaddr_str_cmp(): [0::]:5(zero) > 0.0.0.0:5(zero) osmo_sockaddr_str_cmp(): [0::]:5(zero) == [::]:5(zero) osmo_sockaddr_str_cmp(): [0::]:5(zero) == [0::]:5(zero) - -Test data [179 == 179]: (1.2.3.4|0.0.0.0|255.255.255.255|[1:2:3::4]|[::]|[::1]|[ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff]|[ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff]|1.2.3.4|[::1:a09:807]|0.0.0.0|[::]|[::]) - -Test data [7 == 7]: 1.2.3.4 - -Test data [2 == 2]: () -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29123 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I263dfd68313b896c5b474025fbca13c22ce41cdc Gerrit-Change-Number: 29123 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in libosmocore[master]: Add function to guess AF_UNSPEC address
by neels 17 Aug '22

17 Aug '22

Attention is currently required from: msuraev. neels has created a revert of this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28994 ) Change subject: Add function to guess AF_UNSPEC address ...................................................................... -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28994 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1c90c56ce832f53b65e0d18d3cea94621c02a69a Gerrit-Change-Number: 28994 Gerrit-PatchSet: 5 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: revert

1 0

Change in libosmocore[master]: Revert "Add function to guess AF_UNSPEC address"
by neels 17 Aug '22

17 Aug '22

Attention is currently required from: laforge, fixeria, msuraev. Hello Jenkins Builder, laforge, fixeria, msuraev, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/libosmocore/+/29122 to review the following change. Change subject: Revert "Add function to guess AF_UNSPEC address" ...................................................................... Revert "Add function to guess AF_UNSPEC address" This reverts commit a4063efa7deb6632c228037c47effca22ad0f781. Reason for revert: It is not possible to guess the IP address family from uninitialized memory. This function simply glorifies random noise into an IPv6 address. It makes no sense to have it. Change-Id: Ifadd614604cf9d0c2ed1a405493c1c3fcb37ae23 --- M include/osmocom/core/sockaddr_str.h M src/sockaddr_str.c 2 files changed, 2 insertions(+), 35 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/22/29122/1 diff --git a/include/osmocom/core/sockaddr_str.h b/include/osmocom/core/sockaddr_str.h index a46ad59..f474fa0 100644 --- a/include/osmocom/core/sockaddr_str.h +++ b/include/osmocom/core/sockaddr_str.h @@ -41,7 +41,6 @@ */ int osmo_ip_str_type(const char *ip); -unsigned osmo_sockaddr_guess_unspec(const struct sockaddr *src); struct osmo_sockaddr_str { /*! AF_INET for IPv4 address, or AF_INET6 for IPv6 address. */ diff --git a/src/sockaddr_str.c b/src/sockaddr_str.c index 70927a7..9f1e897 100644 --- a/src/sockaddr_str.c +++ b/src/sockaddr_str.c @@ -184,38 +184,6 @@ return AF_UNSPEC; } -/*! Guess whether struct sockaddr with AF_UNSPEC family has valid IPv4 or IPv6 address. - * The IPv6 is tried first to take into account "IPv4 mapped addresses". - * \param[in] src Generic struct sockaddr pointer. - * \return AF_INET or AF_INET6, AF_UNSPEC or original sa_family which are unsigned type according to <sys/socket.h>. - */ -unsigned osmo_sockaddr_guess_unspec(const struct sockaddr *src) -{ - int rc; - struct osmo_sockaddr_str sa; - struct osmo_sockaddr_str *tmp = &sa; - const struct sockaddr_in6 *src6 = (const struct sockaddr_in6 *)src; - const struct sockaddr_in *src4 = (const struct sockaddr_in *)src; - - if (!src) - return AF_UNSPEC; - - if (src->sa_family != AF_UNSPEC) - return src->sa_family; - - /* IPv6? */ - rc = osmo_sockaddr_str_from_in6_addr(tmp, &src6->sin6_addr, osmo_ntohs(src6->sin6_port)); - if (rc == 0 && osmo_ip_str_type(tmp->ip) == AF_INET6) - return AF_INET6; - - /* IPv4? */ - rc = osmo_sockaddr_str_from_in_addr(tmp, &src4->sin_addr, osmo_ntohs(src4->sin_port)); - if (rc == 0 && osmo_ip_str_type(tmp->ip) == AF_INET) - return AF_INET; - - return AF_UNSPEC; -} - /*! Safely copy the given ip string to sockaddr_str, classify to AF_INET or AF_INET6. * Data will be written to sockaddr_str even if an error is returned. * \param[out] sockaddr_str The instance to copy to. @@ -349,7 +317,7 @@ return -ENOSPC; if (!src) return -EINVAL; - if (src->sin_family != AF_INET && osmo_sockaddr_guess_unspec((const struct sockaddr *)src) != AF_INET) + if (src->sin_family != AF_INET) return -EINVAL; return osmo_sockaddr_str_from_in_addr(sockaddr_str, &src->sin_addr, osmo_ntohs(src->sin_port)); } @@ -365,7 +333,7 @@ return -ENOSPC; if (!src) return -EINVAL; - if (src->sin6_family != AF_INET6 && osmo_sockaddr_guess_unspec((const struct sockaddr *)src) != AF_INET6) + if (src->sin6_family != AF_INET6) return -EINVAL; return osmo_sockaddr_str_from_in6_addr(sockaddr_str, &src->sin6_addr, osmo_ntohs(src->sin6_port)); } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29122 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ifadd614604cf9d0c2ed1a405493c1c3fcb37ae23 Gerrit-Change-Number: 29122 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in libosmocore[master]: Add function to guess AF_UNSPEC address
by neels 17 Aug '22

17 Aug '22

Attention is currently required from: msuraev. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28994 ) Change subject: Add function to guess AF_UNSPEC address ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: I'm sorry that I am late for code review here. As Pau has explained, this function has a flaw in principles, and it makes no sense to have it. I would welcome if we could revert this commit before the next release. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28994 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1c90c56ce832f53b65e0d18d3cea94621c02a69a Gerrit-Change-Number: 28994 Gerrit-PatchSet: 5 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Aug 2022 00:55:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in libosmocore[master]: Make osmo_sockaddr_str_from_sockaddr() less picky
by neels 17 Aug '22

17 Aug '22

Attention is currently required from: pespin, msuraev, dexter. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28995 ) Change subject: Make osmo_sockaddr_str_from_sockaddr() less picky ...................................................................... Patch Set 8: Code-Review-2 (1 comment) Patchset: PS8: AF_UNSPEC is not valid and should return an error rc. Do not turn uninitialized memory into an IPv6 address representation! -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28995 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I36f20701663c3c7eae7fedc6551da44800b325bf Gerrit-Change-Number: 28995 Gerrit-PatchSet: 8 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Aug 2022 00:52:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmocore[master]: Use osmo_sockaddr_strs_to_str() for multiaddr helper
by neels 17 Aug '22

17 Aug '22

Attention is currently required from: msuraev. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28993 ) Change subject: Use osmo_sockaddr_strs_to_str() for multiaddr helper ...................................................................... Patch Set 8: Code-Review-1 (3 comments) Patchset: PS8: the code added in https://gerrit.osmocom.org/c/libosmocore/+/28992 should move to this function, as indicated below File src/socket.c: https://gerrit.osmocom.org/c/libosmocore/+/28993/comment/dda0b532_5a697daa PS8, Line 208: * buf_len >= 2: (hostA|hostB|...|...) (this doc is wrong) https://gerrit.osmocom.org/c/libosmocore/+/28993/comment/16eeb34d_42c05fa7 PS8, Line 211: { if you use an implementation like this here, we don't need to add osmo_sockaddr_strs_to_str() at all and save a lot of dynamic allocations: struct osmo_strbuf sb = { ... }; if (i != 1) OSMO_STRBUF_PRINTF(sb, "("); for (...) { struct osmo_sockaddr_str ss; if (i) OSMO_STRBUF_PRINTF(sb, "|"); osmo_sockaddr_str_from_str2(&ss, hosts[i]); OSMO_STRBUF_PRINTF(sb, OSMO_SOCKADDR_STR_FMT, OSMO_SOCKADDR_STR_FMT_ARGS(&ss)); } if (i != 1) OSMO_STRBUF_PRINTF(sb, ")"); return sb.chars_needed; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28993 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icef53fe4b6e51563d97a1bc48001d67679b3b6e9 Gerrit-Change-Number: 28993 Gerrit-PatchSet: 8 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Aug 2022 00:48:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmocore[master]: Diversify osmo_sockaddr_str_*() error codes
by neels 17 Aug '22

17 Aug '22

Attention is currently required from: laforge, pespin, msuraev. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28996 ) Change subject: Diversify osmo_sockaddr_str_*() error codes ...................................................................... Patch Set 6: Code-Review-2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28996 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic1be25a076776de5b417cb5ac66f954ac5680e10 Gerrit-Change-Number: 28996 Gerrit-PatchSet: 6 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Aug 2022 00:39:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log