Attention is currently required from: neels, fixeria, msuraev.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29122 )
Change subject: Revert "Add function to guess AF_UNSPEC address"
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> I disagree - see osmo_ip_str_type(): this function is just convenience wrapper over it. […]
osmo_ip_str_type operates on a text string, which will contain an address. i guess the perceived danger of this new function is that there is code that doesnt set the AF?more explanation and/or examples required
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29122
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ifadd614604cf9d0c2ed1a405493c1c3fcb37ae23
Gerrit-Change-Number: 29122
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 17 Aug 2022 05:22:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: osmith, neels.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29110 )
Change subject: obs: add README
......................................................................
Patch Set 3:
(1 comment)
File scripts/obs/README:
https://gerrit.osmocom.org/c/osmo-ci/+/29110/comment/1e69c512_cad09fc0
PS3, Line 35: Replace "api.opensuse.org" with "obs.osmocom.org" in two places:
Isn't the "-A https://lobs.osmocom.org" the proper way to do this?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29110
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I4d1303e0c04e827200b48a9fe4aea3680c9c9f84
Gerrit-Change-Number: 29110
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 17 Aug 2022 05:17:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: neels, laforge, fixeria.
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29122 )
Change subject: Revert "Add function to guess AF_UNSPEC address"
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
Patchset:
PS1:
I disagree - see osmo_ip_str_type(): this function is just convenience wrapper over it. So we should either remove both or keep both of them.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29122
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ifadd614604cf9d0c2ed1a405493c1c3fcb37ae23
Gerrit-Change-Number: 29122
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 17 Aug 2022 04:54:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment