- gerrit-log - lists.osmocom.org

Change in osmo-hnbgw[master]: manual: update IuCS/IuPS protocol stack chart
by laforge 17 Aug '22

17 Aug '22

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29093 ) Change subject: manual: update IuCS/IuPS protocol stack chart ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29093 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I4496a6ffdda511875208bebbe68dbc9e69541fc0 Gerrit-Change-Number: 29093 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Aug 2022 05:53:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-hnbgw[master]: manual: update overview chart with PFCP
by laforge 17 Aug '22

17 Aug '22

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29076 ) Change subject: manual: update overview chart with PFCP ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29076 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ifd8843aeb8ff28fec53323c8fb37b10d4d1f2f9b Gerrit-Change-Number: 29076 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Aug 2022 05:53:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-hnbgw[master]: manual: explain the PFCP port
by laforge 17 Aug '22

17 Aug '22

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29075 ) Change subject: manual: explain the PFCP port ...................................................................... Patch Set 2: (1 comment) File doc/manuals/chapters/running.adoc: https://gerrit.osmocom.org/c/osmo-hnbgw/+/29075/comment/ce9a44fb_63eea54d PS2, Line 147: optionally supports if this is a compile-time option, it should be stated here to avoid users assuming they can just always use the below config snippet without using any special compile options. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29075 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I383befb226caa49e4a2577657806aef1ee11faa3 Gerrit-Change-Number: 29075 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Aug 2022 05:53:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-hnbgw[master]: manual: add missing bit on the MGCP port
by laforge 17 Aug '22

17 Aug '22

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29074 ) Change subject: manual: add missing bit on the MGCP port ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29074 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ic18180793f0c1497b020e5f4a8cd34d6b519b85f Gerrit-Change-Number: 29074 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Aug 2022 05:51:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-hnbgw[master]: osmo-hnbgw.cfg example: add pfcp
by laforge 17 Aug '22

17 Aug '22

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29073 ) Change subject: osmo-hnbgw.cfg example: add pfcp ...................................................................... Patch Set 2: Code-Review-1 (1 comment) Patchset: PS2: well, actually we made this optional, right? I think if pfcp support is not enabled in a default build, then the default example config file should also not use it. Feel free to add a separate example config file for that situation. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29073 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I62c4935bcc7f684bfe850f88f1b80e8970e0e098 Gerrit-Change-Number: 29073 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Aug 2022 05:51:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-hnbgw[master]: osmo-hnbgw.cfg example: add pfcp
by laforge 17 Aug '22

17 Aug '22

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29073 ) Change subject: osmo-hnbgw.cfg example: add pfcp ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29073 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I62c4935bcc7f684bfe850f88f1b80e8970e0e098 Gerrit-Change-Number: 29073 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Aug 2022 05:50:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-hnbgw[master]: make: fix -l order: first libosmo-pfcp, then -gtlv
by laforge 17 Aug '22

17 Aug '22

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29118 ) Change subject: make: fix -l order: first libosmo-pfcp, then -gtlv ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29118 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ibbddef02edbd6eb58828ca496f3b36613d4285fc Gerrit-Change-Number: 29118 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Aug 2022 05:50:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: BSSMAP: make sure we don't try to reset non-existent entity
by laforge 17 Aug '22

17 Aug '22

Attention is currently required from: pespin, msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28892 ) Change subject: BSSMAP: make sure we don't try to reset non-existent entity ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: I didm't do a thorough analysis myself, but agree with neels, if he thinks there is no code path leading to this. Certainly we don't want to check everything for NULL in our code base. On the other hand, if we are sure that it's never NULL, we might add an OSMO_ASSERT(). -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28892 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I235bdd42ea82e7b5a1a40f437ca34c49ad239c48 Gerrit-Change-Number: 28892 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Aug 2022 05:50:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in libosmo-sccp[master]: SIGTRAN: add function to check connection existence
by laforge 17 Aug '22

17 Aug '22

Attention is currently required from: neels, fixeria, msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29087 ) Change subject: SIGTRAN: add function to check connection existence ...................................................................... Patch Set 9: Code-Review-1 (1 comment) Patchset: PS9: this doesn't just add a function, but it also adds additional debug output on the message size. I'm fine with the function and adding log output in error situations. But I don't like the additonal debug logging, see my comment to the other patch. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29087 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Iffedf55b4c292ee6b2f97bcdeef6dc13c050ce01 Gerrit-Change-Number: 29087 Gerrit-PatchSet: 9 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Aug 2022 05:41:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmo-sccp[master]: Log more data on CR and N-CONNECT
by laforge 17 Aug '22

17 Aug '22

Attention is currently required from: neels, msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29085 ) Change subject: Log more data on CR and N-CONNECT ...................................................................... Patch Set 8: Code-Review-1 (1 comment) Patchset: PS8: I also think it's not entirely customary to log the size of each message we're sending. This can easily be done with wireshark, or with a debugger/tracepoint or (like I'd do it these days) some kind of bfptrace program attached to the specific funciton. the latter can even draw you nice histogram of message sizes with something like 5 lines of code. At zero overhead for the normal non-debug use case. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29085 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I4d7fc44fde5b900907ec5ebec0450040a764802a Gerrit-Change-Number: 29085 Gerrit-PatchSet: 8 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Aug 2022 05:40:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log