- gerrit-log - lists.osmocom.org

Change in libosmocore[master]: Add osmo_sockaddr_strs_to_str()
by neels 17 Aug '22

17 Aug '22

Attention is currently required from: msuraev. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28992 ) Change subject: Add osmo_sockaddr_strs_to_str() ...................................................................... Patch Set 8: (9 comments) Patchset: PS8: I'm sorry that I'm late for this patch review. This patch has a number of rough edges, I would welcome if we could revert it and get some more review cycles. File src/sockaddr_str.c: https://gerrit.osmocom.org/c/libosmocore/+/28992/comment/6219adc6_145bfcb8 PS8, Line 547: * buf_len >= 2: (hostA|hostB|...|...) buf_len is the buffer size of the output string buffer *buf. A buf_len == 0 cannot return any "()" string, it has zero size. buf_len == 1 cannot contain "hostA". Did you mean sa_str_count? https://gerrit.osmocom.org/c/libosmocore/+/28992/comment/d27293a9_acbb2b9e PS8, Line 555: int osmo_sockaddr_strs_to_str(char *buf, size_t buf_len, const struct osmo_sockaddr_str **sa_str, size_t sa_str_count) i find it odd that you want to pass an array of osmo_sockaddr_str POINTERS, instead of an array of osmo_sockaddr_str instances. i.e. i would expect an arg like 'const struct osmo_sockaddr_str *sa_strs', not '**'. https://gerrit.osmocom.org/c/libosmocore/+/28992/comment/316d840f_674d4fd8 PS8, Line 562: return -ENOMEM; this check should not be here. The idea is to always return the nr of characters needed to output the full string, regardless of the underlying buffer length. If you return -ENOMEM on some specific buffer lengths, you destroy the ability of finding a sufficient buffer length from the return value. The OSMO_STRBUF macros deal with all cases of insufficient buffer length, just let it play through to the end, so that the proper sb.chars_needed is returned. https://gerrit.osmocom.org/c/libosmocore/+/28992/comment/fdcd0fdd_b3bde8dc PS8, Line 567: for (i = 0; i < sa_str_count; i++) { for (...) { if (i) OSMO_STRBUF_PRINTF(sb, "|"); if (sa_str[i]) OSMO_STRBUF_PRINTF(sb, OSMO_SOCKADDR_STR_NO_PORT_FMT, OSMO_SOCKADDR_STR_NO_PORT_FMT_ARGS(sa_str[i])); } if (sa_str_count != 1) OSMO_STRBUF_PRINTF(sb, ")"); File tests/sockaddr_str/sockaddr_str_test.c: https://gerrit.osmocom.org/c/libosmocore/+/28992/comment/078d4d8b_e4da2349 PS8, Line 28: #include <osmocom/core/logging.h> why add application and logging? there should be no select loop. nothing about osmo_sockaddr_str should ever cause osmocom logging. https://gerrit.osmocom.org/c/libosmocore/+/28992/comment/a57e7473_891bec86 PS8, Line 268: struct osmo_sockaddr_str *sa_strs[OSMO_SOCK_MAX_ADDRS]; (...and here just a struct osmo_sockaddr_str sa_strs[N], no need to talloc instances below) https://gerrit.osmocom.org/c/libosmocore/+/28992/comment/998f5771_bdf3e063 PS8, Line 271: for (i = 0, j = 0; j < count && i < OSMO_SOCK_MAX_ADDRS; j++) {//ARRAY_SIZE(oip_data) can we drop the // comments? https://gerrit.osmocom.org/c/libosmocore/+/28992/comment/146c54fa_9c1e2c65 PS8, Line 290: }; why add logging infrastructure?? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28992 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic0d7c08f669994e37a2314555ecac85d28c42c89 Gerrit-Change-Number: 28992 Gerrit-PatchSet: 8 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Aug 2022 00:34:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in libosmo-pfcp[master]: RPM: fix configure and typo "gltv" in .spec.in
by neels 17 Aug '22

17 Aug '22

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/29115 ) Change subject: RPM: fix configure and typo "gltv" in .spec.in ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29115 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: Ideff7942a3250fa6541cfa6252a1c2927afdfc45 Gerrit-Change-Number: 29115 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Wed, 17 Aug 2022 00:11:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in libosmo-pfcp[master]: RPM: fix configure and typo "gltv" in .spec.in
by neels 17 Aug '22

17 Aug '22

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/29115 ) Change subject: RPM: fix configure and typo "gltv" in .spec.in ...................................................................... RPM: fix configure and typo "gltv" in .spec.in Change-Id: Ideff7942a3250fa6541cfa6252a1c2927afdfc45 --- M contrib/libosmo-pfcp.spec.in 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-pfcp refs/changes/15/29115/1 diff --git a/contrib/libosmo-pfcp.spec.in b/contrib/libosmo-pfcp.spec.in index 9e2c06a..286a644 100644 --- a/contrib/libosmo-pfcp.spec.in +++ b/contrib/libosmo-pfcp.spec.in @@ -71,7 +71,8 @@ %build echo "%{version}" >.tarball-version autoreconf -fi -%configure +%configure \ + --includedir="%_includedir/%name" make %{?_smp_mflags} %install @@ -87,7 +88,7 @@ %postun -n libosmo-pfcp0 -p /sbin/ldconfig %files -n libosmo-gtlv0 -%{_libdir}/libosmo-gltv.so.0* +%{_libdir}/libosmo-gtlv.so.0* %files -n libosmo-gtlv-devel %dir %{_includedir}/%{name} -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/29115 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: Ideff7942a3250fa6541cfa6252a1c2927afdfc45 Gerrit-Change-Number: 29115 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in libosmo-gprs[master]: contrib/libosmo-gprs.spec.in: properly define RPM packages
by fixeria 17 Aug '22

17 Aug '22

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29114 ) Change subject: contrib/libosmo-gprs.spec.in: properly define RPM packages ...................................................................... contrib/libosmo-gprs.spec.in: properly define RPM packages Change-Id: I9be45c43ba3e342e1dba4b60561880c00841f549 --- M contrib/libosmo-gprs.spec.in 1 file changed, 74 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/14/29114/1 diff --git a/contrib/libosmo-gprs.spec.in b/contrib/libosmo-gprs.spec.in index 1a85f9e..6cc8c47 100644 --- a/contrib/libosmo-gprs.spec.in +++ b/contrib/libosmo-gprs.spec.in @@ -10,12 +10,59 @@ BuildRequires: automake >= 1.9 BuildRequires: libtool >= 2 BuildRequires: pkgconfig >= 0.20 -BuildRequires: pkgconfig(libosmocore) >= 1.6.0 +BuildRequires: pkgconfig(libosmocore) >= 1.7.0 BuildRequires: pkgconfig(talloc) %description libosmo-gprs: Osmocom GPRS libraries (CSN.1, RLC/MAC) +This package provides Osmocom GPRS libraries used by osmocom-bb and +osmo-pcu: libosmo-csn1, libosmo-gprs-rlcmac. + + +%package -n libosmo-csn1-0 +Summary: CSN.1 (Concrete Syntax Notation 1) codec +License: GPL-2.0-or-later +Group: System/Libraries + +%description -n libosmo-csn1-0 +This package provides facilities for encoding, decoding, and declarative +definition of protocols using CSN.1 (Concrete Syntax Notation 1). This +implementation was originally developed by ST-Ericsson (Jari Sassi) and +later adopted by Wireshark and osmo-pcu. + + +%package -n libosmo-csn1-devel +Summary: Development files for libosmo-csn1 +License: GPL-2.0-or-later +Group: Development/Libraries/C and C++ +Requires: libosmo-csn1-0 = %{version} + +%description -n libosmo-csn1-devel +This package provides development files for compiling a program using +libosmo-csn1 - CSN.1 (Concrete Syntax Notation 1) codec. + + +%package -n libosmo-gprs-rlcmac0 +Summary: CSN.1 (Concrete Syntax Notation 1) codec +License: GPL-2.0-or-later +Group: System/Libraries + +%description -n libosmo-gprs-rlcmac0 +This package provides RLC/MAC protocol definitions for (E)GPRS. + +%package -n libosmo-gprs-rlcmac-devel +Summary: Development files for libosmo-gprs-rlcmac +License: GPL-2.0-or-later +Group: Development/Libraries/C and C++ +Requires: libosmo-gprs-rlcmac0 = %{version} +Requires: libosmo-csn1-devel = %{version} + +%description -n libosmo-gprs-rlcmac-devel +This package provides development files for compiling a program using +libosmo-gprs-rlcmac - RLC/MAC protocol definitions for (E)GPRS. + + %prep %setup -q @@ -31,9 +78,31 @@ %check make %{?_smp_mflags} check || (find . -name testsuite.log -exec cat {} +) -%files -%license COPYING -%doc README.md -%{_bindir}/libosmo-gprs +%post -n libosmo-csn1-0 -p /sbin/ldconfig +%postun -n libosmo-csn1-0 -p /sbin/ldconfig +%post -n libosmo-gprs-rlcmac0 -p /sbin/ldconfig +%postun -n libosmo-gprs-rlcmac0 -p /sbin/ldconfig + +%files -n libosmo-csn1-0 +%{_libdir}/libosmo-csn1.so.0* + +%files -n libosmo-csn1-devel +%dir %{_includedir}/%{name} +%dir %{_includedir}/%{name}/osmocom +%{_includedir}/%{name}/osmocom/csn1 +%{_libdir}/libosmo-csn1.so +%{_libdir}/libosmo-csn1.a +%{_libdir}/pkgconfig/libosmo-csn1.pc + +%files -n libosmo-gprs-rlcmac0 +%{_libdir}/libosmo-gprs-rlcmac.so.0* + +%files -n libosmo-gprs-rlcmac-devel +%dir %{_includedir}/%{name} +%dir %{_includedir}/%{name}/osmocom +%{_includedir}/%{name}/osmocom/gprs/rlcmac +%{_libdir}/libosmo-gprs-rlcmac.so +%{_libdir}/libosmo-gprs-rlcmac.a +%{_libdir}/pkgconfig/libosmo-gprs-rlcmac.pc %changelog -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/29114 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I9be45c43ba3e342e1dba4b60561880c00841f549 Gerrit-Change-Number: 29114 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in docker-playground[master]: osmo-hlr-master: install libsqlite3-dev/sqlite-devel
by fixeria 17 Aug '22

17 Aug '22

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/29112 ) Change subject: osmo-hlr-master: install libsqlite3-dev/sqlite-devel ...................................................................... osmo-hlr-master: install libsqlite3-dev/sqlite-devel osmo-hlr is using libsqlite3 directly, not via libdbd. Change-Id: I99e43dff8f94fbef1a2dd9934caf6ba1fa7cc1f7 --- M osmo-hlr-master/Dockerfile 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/12/29112/1 diff --git a/osmo-hlr-master/Dockerfile b/osmo-hlr-master/Dockerfile index 9ddc193..1c3251a 100644 --- a/osmo-hlr-master/Dockerfile +++ b/osmo-hlr-master/Dockerfile @@ -8,7 +8,7 @@ debian*) \ apt-get update && \ apt-get install -y --no-install-recommends \ - libdbd-sqlite3 \ + libsqlite3-dev \ libosmo-abis-dev \ libosmo-netif-dev \ libosmo-sigtran-dev \ @@ -22,6 +22,7 @@ "pkgconfig(libosmoctrl)" \ "pkgconfig(libosmogsm)" \ "pkgconfig(libosmovty)" \ + sqlite-devel \ python3 \ ;; \ esac -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29112 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I99e43dff8f94fbef1a2dd9934caf6ba1fa7cc1f7 Gerrit-Change-Number: 29112 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in docker-playground[master]: osmo-msc-master: install libsqlite3-dev/sqlite-devel
by fixeria 17 Aug '22

17 Aug '22

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/29113 ) Change subject: osmo-msc-master: install libsqlite3-dev/sqlite-devel ...................................................................... osmo-msc-master: install libsqlite3-dev/sqlite-devel Since recenly, osmo-msc is using libsqlite3 directly. Change-Id: I4b0ecfcc9a25797eb8e12f07e039160dfc296d4c --- M osmo-msc-master/Dockerfile 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/13/29113/1 diff --git a/osmo-msc-master/Dockerfile b/osmo-msc-master/Dockerfile index 1ad4684..7d79988 100644 --- a/osmo-msc-master/Dockerfile +++ b/osmo-msc-master/Dockerfile @@ -9,8 +9,7 @@ apt-get update && \ apt-get install -y --no-install-recommends \ libasn1c-dev \ - libdbd-sqlite3 \ - libdbi-dev \ + libsqlite3-dev \ libosmo-abis-dev \ libosmo-mgcp-client-dev \ libosmo-gsup-client-dev \ @@ -37,6 +36,7 @@ "pkgconfig(libosmogsm)" \ "pkgconfig(libosmovty)" \ "pkgconfig(libsmpp34)" \ + sqlite-devel \ ;; \ esac -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29113 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I4b0ecfcc9a25797eb8e12f07e039160dfc296d4c Gerrit-Change-Number: 29113 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-ci[master]: readme, and sanitize feed name
by neels 16 Aug '22

16 Aug '22

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/29110 to look at the new patch set (#2). Change subject: readme, and sanitize feed name ...................................................................... readme, and sanitize feed name In a README, explain how to use these scripts to test a private branch. The README suggests using a private branch as feed. I am not sure whether a forward slash is allowed in a feed name, but I know that the feed name is put in a sed 's/../../' command, hence sanitize feed name. Change-Id: I4d1303e0c04e827200b48a9fe4aea3680c9c9f84 --- A scripts/obs/README M scripts/obs/lib/config.py M scripts/obs/lib/srcpkg.py 3 files changed, 122 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/10/29110/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29110 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4d1303e0c04e827200b48a9fe4aea3680c9c9f84 Gerrit-Change-Number: 29110 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

Change in osmo-upf[master]: debian: add missing changelog
by neels 16 Aug '22

16 Aug '22

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-upf/+/29111 ) Change subject: debian: add missing changelog ...................................................................... debian: add missing changelog Change-Id: I53551ce1a6d3176d480a56f8f5d2441da7346711 --- M debian/changelog 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/11/29111/1 diff --git a/debian/changelog b/debian/changelog index e69de29..ca2e0ba 100644 --- a/debian/changelog +++ b/debian/changelog @@ -0,0 +1,5 @@ +osmo-upf (0.1.0) testing; urgency=low + + Create new Debian package. + + -- Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Tue, 16 Aug 2022 23:17:05 +0200 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/29111 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I53551ce1a6d3176d480a56f8f5d2441da7346711 Gerrit-Change-Number: 29111 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-ci[master]: readme, and sanitize feed name
by neels 16 Aug '22

16 Aug '22

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/29110 ) Change subject: readme, and sanitize feed name ...................................................................... readme, and sanitize feed name In a README, explain how to use these scripts to test a private branch. The README suggests using a private branch as feed. I am not sure whether a forward slash is allowed in a feed name, but I know that the feed name is put in a sed 's/../../' command, hence sanitize feed name. Change-Id: I4d1303e0c04e827200b48a9fe4aea3680c9c9f84 --- A scripts/obs/README M scripts/obs/lib/config.py M scripts/obs/lib/srcpkg.py 3 files changed, 121 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/10/29110/1 diff --git a/scripts/obs/README b/scripts/obs/README new file mode 100644 index 0000000..995344a --- /dev/null +++ b/scripts/obs/README @@ -0,0 +1,115 @@ +Submitting source packages to Osmocom's OBS build server +======================================================== + +Dependencies: + + apt-get install dh-python meson osc rebar3 + +Usage Example +============= + +I want to test changes to the packaging of osmo-hnbgw. +They are committed on a private branch osmo-hnbgw.git:neels/gtpmap. +I want to test this in my OBS "Home Project" called home:nhofmeyr:test. + +Here are the steps of what I do: + +OBS home project +---------------- + +Sign up / sign in to obs.osmocom.org and create the "test" project under the +"Home Project" link (right next to the "Logout" link on the OBS web interface), +so that https://obs.osmocom.org/project/show/home:nhofmeyr:test exists. + +Make sure I can list the project using the 'osc' tool. +That requires an osc config file. +Easiest is to let osc create one and then edit it: + + $ osc list home:nhofmeyr:test + Username: nhofmeyr + Password: ************ + Select credentials manager: 4 + Server returned an error: HTTP Error 401: Unauthorized + +Now edit ~/.config/osc/oscrc and set the API URL to obs.osmocom.org: +Replace "api.opensuse.org" with "obs.osmocom.org" in two places: + + sed -i 's/api\.opensuse\.org/obs.osmocom.org/' ~/.config/osc/oscrc + +Now the 'osc list' command should no longer fail: + + $ osc list home:nhofmeyr:test + libosmo-pfcp + +Publish patches in private branch +--------------------------------- + +Push my private branch to Osmocom's git upstream -- not submit for review, just +push a private branch. + +Why is that? The obs scripts here modify the git tree, so it is better to build +the source packages on a separate git clone. + + cd ~/osmo-dev/src/osmo-hnbgw + git push --set-upstream origin neels/gtpmap + +Clone source tree into the cache +-------------------------------- + + cd ~/osmo-dev/src/osmo-ci/scripts/obs/ + ./build_srcpkg.py osmo-hnbgw + +Now there is a git clone in ./_cache/osmo-hnbgw/ + +Checkout my branch +------------------ + +#if 0 + git -C _cache/osmo-hnbgw checkout neels/gtpmap +#else +One step of update_obs_project.py is to checkout the right branch. +In order to checkout my branch, I add my branch as a feed to +./lib/config.py: + + ... + feeds = [ + "2022q1", + "2022q2", + "latest", + "nightly", + "neels/gtpmap", + ] + ... + +Now I can tell update_obs_project.py to build my branch using the -f option (see +below). +#endif + +Build and upload source package to OBS +-------------------------------------- + + ./update_obs_project.py -f neels/gtpmap home:nhofmeyr:test osmo-hnbgw + +See results +----------- + +I can now see my hnbgw package listed: + + $ osc list home:nhofmeyr:test + libosmo-pfcp + osmo-hnbgw + +I could query things via the osc tool: + + $ osc results home:nhofmeyr:test osmo-hnbgw + neels_test2 aarch64 unresolvable + neels_test2 armv7l broken + neels_test2 i586 broken + neels_test2 x86_64 unresolvable + neels_test aarch64 unresolvable + neels_test armv7l unresolvable + neels_test i586 unresolvable + neels_test x86_64 failed + +Or point my web browser at +https://obs.osmocom.org/project/show/home:nhofmeyr:test diff --git a/scripts/obs/lib/config.py b/scripts/obs/lib/config.py index 997fff2..517fe48 100644 --- a/scripts/obs/lib/config.py +++ b/scripts/obs/lib/config.py @@ -32,6 +32,7 @@ "2022q2", "latest", "nightly", + "neels/gtpmap", ] # Osmocom projects: generated source packages will depend on a meta package, diff --git a/scripts/obs/lib/srcpkg.py b/scripts/obs/lib/srcpkg.py index 468a240..3fce993 100644 --- a/scripts/obs/lib/srcpkg.py +++ b/scripts/obs/lib/srcpkg.py @@ -132,6 +132,11 @@ if project in lib.config.projects_osmocom: metapkg = f"osmocom-{feed}" + + # replace special chars with '_' in the feed name, + # e.g. from a user's private git branch 'johndoe/wip' + metapkg = [c for c in metapkg if c.isalnum() else '_'] + lib.debian.control_add_depend(project, metapkg, conflict_version) if has_rpm_spec: lib.rpm_spec.add_depend(project, metapkg, conflict_version) -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29110 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4d1303e0c04e827200b48a9fe4aea3680c9c9f84 Gerrit-Change-Number: 29110 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

Change in osmo-ci[master]: obs: add libosmo-pfcp, osmo-upf
by neels 16 Aug '22

16 Aug '22

Attention is currently required from: osmith. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29047 ) Change subject: obs: add libosmo-pfcp, osmo-upf ...................................................................... Patch Set 4: Code-Review+2 (1 comment) Patchset: PS4: combine votes -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29047 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I7192f4c9e77035cebb147b8186296bcd741d419b Gerrit-Change-Number: 29047 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 16 Aug 2022 21:13:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log