- gerrit-log - lists.osmocom.org

Change in osmo-dev[master]: all.deps, {sanitize,werror}.opts: add project - libosmo-gprs
by fixeria 16 Aug '22

16 Aug '22

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/29089 ) Change subject: all.deps, {sanitize,werror}.opts: add project - libosmo-gprs ...................................................................... all.deps, {sanitize,werror}.opts: add project - libosmo-gprs Change-Id: I707e6ee0af6bcb940d5e77475bc581c0d07de6d7 --- M all.deps M sanitize.opts M werror.opts 3 files changed, 4 insertions(+), 1 deletion(-) Approvals: osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, approved; Verified diff --git a/all.deps b/all.deps index 7e099cf..5cb4811 100644 --- a/all.deps +++ b/all.deps @@ -1,6 +1,7 @@ # project build these first libosmocore libosmo-abis libosmocore +libosmo-gprs libosmocore libosmo-netif libosmo-abis libosmo-sccp libosmo-netif libsmpp34 @@ -19,7 +20,7 @@ # When omitting --enable-sanitize from osmo-trx only, its 'make check' will fail. # So if you want osmo-trx, use no sanitize.opts, or use LD_PRELOAD for osmo-trx binaries. osmo-trx libosmocore -osmo-pcu libosmocore +osmo-pcu libosmocore libosmo-gprs asn1c libasn1c osmo-gbproxy libosmocore osmo-pcap libosmocore diff --git a/sanitize.opts b/sanitize.opts index 51721bc..7abb8c6 100644 --- a/sanitize.opts +++ b/sanitize.opts @@ -1,6 +1,7 @@ libasn1c --enable-sanitize libosmo-abis --enable-sanitize libosmocore --enable-sanitize +libosmo-gprs --enable-sanitize libosmo-netif --enable-sanitize libosmo-sccp --enable-sanitize libosmo-pfcp --enable-sanitize diff --git a/werror.opts b/werror.opts index af7c8dd..1e7079a 100644 --- a/werror.opts +++ b/werror.opts @@ -1,6 +1,7 @@ libasn1c --enable-werror libosmo-abis --enable-werror libosmocore --enable-werror +libosmo-gprs --enable-werror libosmo-netif --enable-werror libosmo-sccp --enable-werror libosmo-pfcp --enable-werror -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/29089 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I707e6ee0af6bcb940d5e77475bc581c0d07de6d7 Gerrit-Change-Number: 29089 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-dev[master]: gen_makefile.py: add missing --jobs to target 'regen'
by fixeria 16 Aug '22

16 Aug '22

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/29091 ) Change subject: gen_makefile.py: add missing --jobs to target 'regen' ...................................................................... gen_makefile.py: add missing --jobs to target 'regen' Change-Id: I68adde5c3ea602d6dbbfb26e07ce44247cad89f9 --- M gen_makefile.py 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, approved; Verified diff --git a/gen_makefile.py b/gen_makefile.py index 05bf9ff..b859112 100755 --- a/gen_makefile.py +++ b/gen_makefile.py @@ -395,6 +395,7 @@ --src-dir {src_dir} \ --make-dir {make_dir} \ --build-dir {build_dir} \ + --jobs {jobs} \ --url "{url}"{push_url}{sudo_make_install}{no_ldconfig}{ldconfig_without_sudo}{make_check}{docker_cmd}{build_debug}{auto_distclean} '''.format( @@ -404,6 +405,7 @@ makefile=args.output, src_dir=os.path.relpath(args.src_dir, make_dir), build_dir=os.path.relpath(build_dir, make_dir), + jobs=args.jobs, url=args.url, push_url=(" \\\n\t\t--push-url '%s'"%args.push_url) if args.push_url else '', sudo_make_install=' \\\n\t\t--sudo-make-install' if args.sudo_make_install else '', -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/29091 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I68adde5c3ea602d6dbbfb26e07ce44247cad89f9 Gerrit-Change-Number: 29091 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-dev[master]: gen_makefile.py: use --long params for target 'regen'
by fixeria 16 Aug '22

16 Aug '22

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/29090 ) Change subject: gen_makefile.py: use --long params for target 'regen' ...................................................................... gen_makefile.py: use --long params for target 'regen' This way the resulting Makefile is easier to read and understand, no need to lookup short params in help of gen_makefile.py. Change-Id: Iba7f148fb1880af2f05cf3ca74cfb0737befeea0 --- M gen_makefile.py 1 file changed, 8 insertions(+), 8 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, approved; Verified diff --git a/gen_makefile.py b/gen_makefile.py index 6459846..05bf9ff 100755 --- a/gen_makefile.py +++ b/gen_makefile.py @@ -391,11 +391,11 @@ regen: {script} \ {configure_opts} \ - -m {make_dir} \ - -o {makefile} \ - -s {src_dir} \ - -b {build_dir} \ - -u "{url}"{push_url}{sudo_make_install}{no_ldconfig}{ldconfig_without_sudo}{make_check}{docker_cmd}{build_debug}{auto_distclean} + --output {makefile} \ + --src-dir {src_dir} \ + --make-dir {make_dir} \ + --build-dir {build_dir} \ + --url "{url}"{push_url}{sudo_make_install}{no_ldconfig}{ldconfig_without_sudo}{make_check}{docker_cmd}{build_debug}{auto_distclean} '''.format( script=os.path.relpath(sys.argv[0], make_dir), @@ -405,9 +405,9 @@ src_dir=os.path.relpath(args.src_dir, make_dir), build_dir=os.path.relpath(build_dir, make_dir), url=args.url, - push_url=(" \\\n\t\t-p '%s'"%args.push_url) if args.push_url else '', - sudo_make_install=' \\\n\t\t-I' if args.sudo_make_install else '', - no_ldconfig=' \\\n\t\t-L' if args.no_ldconfig else '', + push_url=(" \\\n\t\t--push-url '%s'"%args.push_url) if args.push_url else '', + sudo_make_install=' \\\n\t\t--sudo-make-install' if args.sudo_make_install else '', + no_ldconfig=' \\\n\t\t--no-ldconfig' if args.no_ldconfig else '', ldconfig_without_sudo=' \\\n\t\t--ldconfig-without-sudo' if args.ldconfig_without_sudo else '', make_check='' if args.make_check else " \\\n\t\t--no-make-check", docker_cmd=f' \\\n\t\t--docker-cmd "{args.docker_cmd}"' if args.docker_cmd else '', -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/29090 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Iba7f148fb1880af2f05cf3ca74cfb0737befeea0 Gerrit-Change-Number: 29090 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-dev[master]: gen_makefile.py: use s#git://#https://# in git clone base URL
by fixeria 16 Aug '22

16 Aug '22

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/29088 ) Change subject: gen_makefile.py: use s#git://#https://# in git clone base URL ...................................................................... gen_makefile.py: use s#git://#https://# in git clone base URL Unencrypted git:// protocol offers no integrity or authentication, making it subject to tampering. Use https:// instead. https://github.blog/2021-09-01-improving-git-protocol-security-github/#no-m… https://blog.readthedocs.com/github-git-protocol-deprecation/ Using https:// is also required for some new repositories (like libosmo-gprs.git), which are intentionally unavailable over git://. Change-Id: I503f0e1b5258102d771597f1b5b753f670832fcb --- M gen_makefile.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: osmith: Looks good to me, approved fixeria: Verified diff --git a/gen_makefile.py b/gen_makefile.py index 0e0df10..6459846 100755 --- a/gen_makefile.py +++ b/gen_makefile.py @@ -70,8 +70,8 @@ help='''Parent dir for all build trees (default: directly in the make-dir).''') -parser.add_argument('-u', '--url', dest='url', default='git://git.osmocom.org', - help='''git clone base URL. Default is 'git://git.osmocom.org'. +parser.add_argument('-u', '--url', dest='url', default='https://git.osmocom.org', + help='''git clone base URL. Default is 'https://git.osmocom.org'. e.g. with a config like this in your ~/.ssh/config: host go hostname gerrit.osmocom.org -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/29088 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I503f0e1b5258102d771597f1b5b753f670832fcb Gerrit-Change-Number: 29088 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 0

Change in osmo-dev[master]: gen_makefile.py: add missing --jobs to target 'regen'
by fixeria 16 Aug '22

16 Aug '22

Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/29091 ) Change subject: gen_makefile.py: add missing --jobs to target 'regen' ...................................................................... Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/29091 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I68adde5c3ea602d6dbbfb26e07ce44247cad89f9 Gerrit-Change-Number: 29091 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 16 Aug 2022 15:27:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-dev[master]: gen_makefile.py: use --long params for target 'regen'
by fixeria 16 Aug '22

16 Aug '22

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/29090 ) Change subject: gen_makefile.py: use --long params for target 'regen' ...................................................................... Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/29090 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Iba7f148fb1880af2f05cf3ca74cfb0737befeea0 Gerrit-Change-Number: 29090 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 16 Aug 2022 15:27:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-dev[master]: all.deps, {sanitize,werror}.opts: add project - libosmo-gprs
by fixeria 16 Aug '22

16 Aug '22

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/29089 ) Change subject: all.deps, {sanitize,werror}.opts: add project - libosmo-gprs ...................................................................... Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/29089 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I707e6ee0af6bcb940d5e77475bc581c0d07de6d7 Gerrit-Change-Number: 29089 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 16 Aug 2022 15:27:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-dev[master]: gen_makefile.py: use s#git://#https://# in git clone base URL
by fixeria 16 Aug '22

16 Aug '22

Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/29088 ) Change subject: gen_makefile.py: use s#git://#https://# in git clone base URL ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/29088 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I503f0e1b5258102d771597f1b5b753f670832fcb Gerrit-Change-Number: 29088 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 16 Aug 2022 15:27:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ci[master]: obs: add libosmo-gprs
by osmith 16 Aug '22

16 Aug '22

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29096 ) Change subject: obs: add libosmo-gprs ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29096 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I96f48cfc328f61bcbee98c4675896cc4c4e9a48f Gerrit-Change-Number: 29096 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 16 Aug 2022 14:49:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-ci[master]: obs: add libosmo-pfcp, osmo-upf
by osmith 16 Aug '22

16 Aug '22

Attention is currently required from: neels. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29047 ) Change subject: obs: add libosmo-pfcp, osmo-upf ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29047 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I7192f4c9e77035cebb147b8186296bcd741d419b Gerrit-Change-Number: 29047 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 16 Aug 2022 14:49:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log