- gerrit-log - lists.osmocom.org

[XS] Change in osmocom-bb[master]: firmware/layer1: toa_input(): minor formatting fix
by laforge 16 Mar '26

16 Mar '26

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/42398?usp=email ) Change subject: firmware/layer1: toa_input(): minor formatting fix ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/42398?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iba061badfde8a3875cbf7e7cd19ef89064922f57 Gerrit-Change-Number: 42398 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Mar 2026 00:16:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmocom-bb[master]: firmware/layer1: l1a_rach_compl(): fix copy-pasted comment
by laforge 16 Mar '26

16 Mar '26

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/42397?usp=email ) Change subject: firmware/layer1: l1a_rach_compl(): fix copy-pasted comment ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/42397?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I8000218836bcb58946db48184360f821617dc93f Gerrit-Change-Number: 42397 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Mar 2026 00:16:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmocom-bb[master]: firmware/layer1: l1s_tch_{cmd,resp}(): fix misspelled FACCH
by laforge 16 Mar '26

16 Mar '26

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/42396?usp=email ) Change subject: firmware/layer1: l1s_tch_{cmd,resp}(): fix misspelled FACCH ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/42396?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I85646a8a0b37478ca517407fcca92d0b89d6aaca Gerrit-Change-Number: 42396 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Mar 2026 00:16:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in pysim[master]: personalization: add param_source.py, add batch.py
by neels 16 Mar '26

16 Mar '26

Attention is currently required from: dexter, laforge. neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/41845?usp=email ) Change subject: personalization: add param_source.py, add batch.py ...................................................................... Patch Set 8: (1 comment) Patchset: PS8: I have squashed a few later patches into this one to avoid merge conflicts and reduce the load on jenkins. Also code review items have been applied; one part of which is a rejigger of the ParamSource constructor. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41845?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I01ae40a06605eb205bfb409189fcd2b3a128855a Gerrit-Change-Number: 41845 Gerrit-PatchSet: 8 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sun, 15 Mar 2026 23:22:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in libosmocore[master]: gsm48: remove duplicate GSM48_MT_RR_HANDO_INFO
by fixeria 16 Mar '26

16 Mar '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/42408?usp=email ) Change subject: gsm48: remove duplicate GSM48_MT_RR_HANDO_INFO ...................................................................... gsm48: remove duplicate GSM48_MT_RR_HANDO_INFO Change-Id: Ic1cbba2b2a746667b9920ed2ed19b3848185977d --- M include/osmocom/gsm/protocol/gsm_04_08.h M src/gsm/gsm48.c 2 files changed, 0 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/08/42408/1 diff --git a/include/osmocom/gsm/protocol/gsm_04_08.h b/include/osmocom/gsm/protocol/gsm_04_08.h index 27182b6..c3263be 100644 --- a/include/osmocom/gsm/protocol/gsm_04_08.h +++ b/include/osmocom/gsm/protocol/gsm_04_08.h @@ -1571,7 +1571,6 @@ #define GSM48_MT_RR_HANDO_COMPL 0x2c #define GSM48_MT_RR_HANDO_FAIL 0x28 #define GSM48_MT_RR_HANDO_INFO 0x2d -#define GSM48_MT_RR_HANDO_INFO 0x2d #define GSM48_MT_RR_DTM_ASS_CMD 0x4c #define GSM48_MT_RR_CELL_CHG_ORDER 0x08 diff --git a/src/gsm/gsm48.c b/src/gsm/gsm48.c index 99d93ec..57e39ab 100644 --- a/src/gsm/gsm48.c +++ b/src/gsm/gsm48.c @@ -1572,7 +1572,6 @@ OSMO_VALUE_STRING(GSM48_MT_RR_HANDO_COMPL), OSMO_VALUE_STRING(GSM48_MT_RR_HANDO_FAIL), OSMO_VALUE_STRING(GSM48_MT_RR_HANDO_INFO), - OSMO_VALUE_STRING(GSM48_MT_RR_HANDO_INFO), OSMO_VALUE_STRING(GSM48_MT_RR_DTM_ASS_CMD), OSMO_VALUE_STRING(GSM48_MT_RR_CELL_CHG_ORDER), -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42408?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic1cbba2b2a746667b9920ed2ed19b3848185977d Gerrit-Change-Number: 42408 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: gsm48: fix missing/misspelled value-strings
by fixeria 16 Mar '26

16 Mar '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/42407?usp=email ) Change subject: gsm48: fix missing/misspelled value-strings ...................................................................... gsm48: fix missing/misspelled value-strings Change-Id: I8d2333290c7715fd75ce7e7c759cb564a26b7461 --- M src/gsm/gsm48.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/07/42407/1 diff --git a/src/gsm/gsm48.c b/src/gsm/gsm48.c index 71e0186..99d93ec 100644 --- a/src/gsm/gsm48.c +++ b/src/gsm/gsm48.c @@ -330,7 +330,7 @@ { GSM48_MT_CC_CONG_CTRL, "CONG_CTRL" }, { GSM48_MT_CC_FACILITY, "FACILITY" }, { GSM48_MT_CC_STATUS, "STATUS" }, - { GSM48_MT_CC_NOTIFY, "NOTFIY" }, + { GSM48_MT_CC_NOTIFY, "NOTIFY" }, { 0, NULL } }; @@ -346,7 +346,7 @@ { GSM48_MT_RR_INIT_REQ, "RR INITIALISATION REQUEST" }, { GSM48_MT_RR_ADD_ASS, "ADDITIONAL ASSIGNMENT" }, { GSM48_MT_RR_IMM_ASS, "IMMEDIATE ASSIGNMENT" }, - { GSM48_MT_RR_IMM_ASS_EXT, "MMEDIATE ASSIGNMENT EXTENDED" }, + { GSM48_MT_RR_IMM_ASS_EXT, "IMMEDIATE ASSIGNMENT EXTENDED" }, { GSM48_MT_RR_IMM_ASS_REJ, "IMMEDIATE ASSIGNMENT REJECT" }, { GSM48_MT_RR_DTM_ASS_FAIL, "DTM ASSIGNMENT FAILURE" }, { GSM48_MT_RR_DTM_REJECT, "DTM REJECT" }, @@ -433,7 +433,7 @@ /* VGCS uplink control messages */ { GSM48_MT_RR_VGCS_UPL_GRANT, "VGCS UPLINK GRANT" }, { GSM48_MT_RR_UPLINK_RELEASE, "UPLINK RELEASE" }, - { GSM48_MT_RR_UPLINK_FREE, "0c" }, + { GSM48_MT_RR_UPLINK_FREE, "UPLINK FREE" }, { GSM48_MT_RR_UPLINK_BUSY, "UPLINK BUSY" }, { GSM48_MT_RR_TALKER_IND, "TALKER INDICATION" }, -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42407?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8d2333290c7715fd75ce7e7c759cb564a26b7461 Gerrit-Change-Number: 42407 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: gsmtap_util: gsmtap_gsm_channel_names[]: fix PTCCH string
by fixeria 16 Mar '26

16 Mar '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/42409?usp=email ) Change subject: gsmtap_util: gsmtap_gsm_channel_names[]: fix PTCCH string ...................................................................... gsmtap_util: gsmtap_gsm_channel_names[]: fix PTCCH string Change-Id: Ic65668ae0363b991966bcf8ba4fb913940639964 --- M src/core/gsmtap_util.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/09/42409/1 diff --git a/src/core/gsmtap_util.c b/src/core/gsmtap_util.c index b46f273..1bda690 100644 --- a/src/core/gsmtap_util.c +++ b/src/core/gsmtap_util.c @@ -598,7 +598,7 @@ { GSMTAP_CHANNEL_PACCH, "PACCH" }, { GSMTAP_CHANNEL_CBCH52, "CBCH" }, { GSMTAP_CHANNEL_PDCH, "PDCH" } , - { GSMTAP_CHANNEL_PTCCH, "PTTCH" }, + { GSMTAP_CHANNEL_PTCCH, "PTCCH" }, { GSMTAP_CHANNEL_CBCH51, "CBCH" }, { GSMTAP_CHANNEL_ACCH | GSMTAP_CHANNEL_SDCCH, "LSACCH" }, { GSMTAP_CHANNEL_ACCH | GSMTAP_CHANNEL_SDCCH4, "SACCH/4" }, -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42409?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic65668ae0363b991966bcf8ba4fb913940639964 Gerrit-Change-Number: 42409 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[L] Change in pysim[master]: personalization: add param_source.py, add batch.py
by neels 16 Mar '26

16 Mar '26

Attention is currently required from: dexter, laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/41845?usp=email to look at the new patch set (#8). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: personalization: add param_source.py, add batch.py ...................................................................... personalization: add param_source.py, add batch.py Implement pySim.esim.saip.batch.BatchPersonalization, generating N eSIM profiles from a preset configuration. Batch parameters can be fed by a constant, incrementing, random or from CSV rows: add pySim.esim.saip.param_source.* classes to feed such input to each of the BatchPersonalization's ConfigurableParameter instances. Related: SYS#6768 Change-Id: I01ae40a06605eb205bfb409189fcd2b3a128855a --- A pySim/esim/saip/batch.py A pySim/esim/saip/param_source.py 2 files changed, 325 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/45/41845/8 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41845?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I01ae40a06605eb205bfb409189fcd2b3a128855a Gerrit-Change-Number: 41845 Gerrit-PatchSet: 8 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[L] Change in pysim[master]: personalization: add param_source.py, add batch.py
by neels 16 Mar '26

16 Mar '26

Attention is currently required from: dexter, laforge. neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/41845?usp=email ) Change subject: personalization: add param_source.py, add batch.py ...................................................................... Patch Set 7: (12 comments) File pySim/esim/saip/batch.py: https://gerrit.osmocom.org/c/pysim/+/41845/comment/87b50309_cca942f4?usp=em… : PS6, Line 65: params: list[ParamAndSrc]=None, > IIRC the linter warns against passing empty lists as default argument, because in python there can a […] Done https://gerrit.osmocom.org/c/pysim/+/41845/comment/a1278baf_7973bef3?usp=em… : PS6, Line 92: csv_columns = next(self.csv_rows) > hm that's right, it has to be an iter(list), thx Done https://gerrit.osmocom.org/c/pysim/+/41845/comment/ee3801c0_43243e2f?usp=em… : PS6, Line 97: csv_row = None > it is optional, configured by the caller, whether a CSV file is present. […] Done File pySim/esim/saip/param_source.py: https://gerrit.osmocom.org/c/pysim/+/41845/comment/097eacb1_97e92446?usp=em… : PS6, Line 31: class ParamSource: > That is right. […] Done https://gerrit.osmocom.org/c/pysim/+/41845/comment/0b078810_199635ae?usp=em… : PS6, Line 42: so the user can enter '0000' to get a four digit random number.""" > Hmm. it's even worse, most subclasses completely replace this. I will make a better plan, thanks. Done https://gerrit.osmocom.org/c/pysim/+/41845/comment/87a9f9be_2aa2726c?usp=em… : PS6, Line 51: > yea you're right, sometimes i do sometimes i don't, thx. […] Done https://gerrit.osmocom.org/c/pysim/+/41845/comment/5d7a009c_99dc6ec7?usp=em… : PS6, Line 65: def __init__(self, num_digits, first_value, last_value): > Maybe add type annotations and agree on one distinct type? At the moment this function can accepts a […] Done https://gerrit.osmocom.org/c/pysim/+/41845/comment/92b2f56b_245598a9?usp=em… : PS6, Line 80: > If this is a private/internal method, I would mark it with double underscore or single underscore? not intended, in particular, to be internal https://gerrit.osmocom.org/c/pysim/+/41845/comment/ba0fa97e_5d986644?usp=em… : PS6, Line 95: last_value = int(last_str) if last_str is not None else "9" * len(first_str) > heh funny code =) you are right Done https://gerrit.osmocom.org/c/pysim/+/41845/comment/691ffc9a_b4ce4220?usp=em… : PS6, Line 121: val = random.randbytes(self.num_digits // 2) # TODO secure random source? > This uses the fact that all BinaryParameter can take a bytes as input value. […] Done https://gerrit.osmocom.org/c/pysim/+/41845/comment/c9bf8e23_3f3f390f?usp=em… : PS6, Line 149: if val > self.val_first_last[1]: > self.last_value would be easier to read. Done https://gerrit.osmocom.org/c/pysim/+/41845/comment/2c36f403_8e1416cd?usp=em… : PS6, Line 174: return val > it's more like […] Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41845?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I01ae40a06605eb205bfb409189fcd2b3a128855a Gerrit-Change-Number: 41845 Gerrit-PatchSet: 7 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sun, 15 Mar 2026 22:46:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in pysim[master]: personalization: indicate default ParamSource per ConfigurableParameter
by neels 16 Mar '26

16 Mar '26

Attention is currently required from: dexter, laforge. neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/40200?usp=email ) Change subject: personalization: indicate default ParamSource per ConfigurableParameter ...................................................................... Patch Set 10: Code-Review+2 (1 comment) Patchset: PS10: (re-add +2 after rebase) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40200?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie58d13bce3fa1aa2547cf3cee918c2f5b30a8b32 Gerrit-Change-Number: 40200 Gerrit-PatchSet: 10 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sun, 15 Mar 2026 22:46:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log