- gerrit-log - lists.osmocom.org

[S] Change in pysim[master]: personalization: indicate default ParamSource per ConfigurableParameter
by neels 16 Mar '26

16 Mar '26

Attention is currently required from: dexter, laforge. Hello Jenkins Builder, dexter, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/40200?usp=email to look at the new patch set (#10). The following approvals got outdated and were removed: Code-Review+1 by dexter, Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: personalization: indicate default ParamSource per ConfigurableParameter ...................................................................... personalization: indicate default ParamSource per ConfigurableParameter Add default_source class members pointing to ParamSource classes to all ConfigurableParameter subclasses. This is useful to automatically set up a default ParamSource for a given ConfigurableParameter subclass, during user interaction to produce a batch personalization. For example, if the user selects a Pin1 parameter, a calling program can implicitly set this to a RandomDigitSource, which will magically make it work the way that most users need. BTW, default_source and default_value can be combined to configure a matching ParamSource instance: my_source = MyParam.default_source.from_str( MyParam.default_value ) Change-Id: Ie58d13bce3fa1aa2547cf3cee918c2f5b30a8b32 --- M pySim/esim/saip/personalization.py 1 file changed, 16 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/00/40200/10 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40200?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie58d13bce3fa1aa2547cf3cee918c2f5b30a8b32 Gerrit-Change-Number: 40200 Gerrit-PatchSet: 10 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in pysim[master]: personalization: indicate default ParamSource per ConfigurableParameter
by neels 16 Mar '26

16 Mar '26

Attention is currently required from: dexter. neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/40200?usp=email ) Change subject: personalization: indicate default ParamSource per ConfigurableParameter ...................................................................... Patch Set 9: (1 comment) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/40200/comment/5017d927_a08d38f5?usp=em… : PS9, Line 362: default_source = param_source.IncDigitSource > The ICCID has a luhn checksum at the end. […] the luhn is added implicitly, the editable part is without the luhn. I know this because we've already published ICCID on production SM-DP+ with this code. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40200?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie58d13bce3fa1aa2547cf3cee918c2f5b30a8b32 Gerrit-Change-Number: 40200 Gerrit-PatchSet: 9 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sun, 15 Mar 2026 22:44:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in pysim[master]: personalization: allow reading back multiple values from PES
by neels 16 Mar '26

16 Mar '26

Attention is currently required from: dexter, laforge. neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/40199?usp=email ) Change subject: personalization: allow reading back multiple values from PES ...................................................................... Patch Set 11: Code-Review+2 (1 comment) Patchset: PS11: (re add +2 after trivial rebase) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40199?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iecb68af7c216c6b9dc3add469564416b6f37f7b2 Gerrit-Change-Number: 40199 Gerrit-PatchSet: 11 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sun, 15 Mar 2026 22:42:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: personalization: allow reading back multiple values from PES
by neels 16 Mar '26

16 Mar '26

Attention is currently required from: dexter, laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/40199?usp=email to look at the new patch set (#11). The following approvals got outdated and were removed: Code-Review+2 by laforge, Verified+1 by Jenkins Builder The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: personalization: allow reading back multiple values from PES ...................................................................... personalization: allow reading back multiple values from PES Change-Id: Iecb68af7c216c6b9dc3add469564416b6f37f7b2 --- M pySim/esim/saip/personalization.py 1 file changed, 22 insertions(+), 16 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/99/40199/11 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40199?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iecb68af7c216c6b9dc3add469564416b6f37f7b2 Gerrit-Change-Number: 40199 Gerrit-PatchSet: 11 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in pysim[master]: personalization: allow reading back multiple values from PES
by neels 16 Mar '26

16 Mar '26

Attention is currently required from: dexter. neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/40199?usp=email ) Change subject: personalization: allow reading back multiple values from PES ...................................................................... Patch Set 10: (1 comment) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/40199/comment/93fc667c_d8eae896?usp=em… : PS10, Line 209: def get_values_from_pes(cls, pes: ProfileElementSequence) -> Generator: > Ah, ok here you fix the comment chars. Should be ok then. Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40199?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iecb68af7c216c6b9dc3add469564416b6f37f7b2 Gerrit-Change-Number: 40199 Gerrit-PatchSet: 10 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sun, 15 Mar 2026 22:42:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: socket: osmo_sockaddr_from_str_and_uint(): fix memleak
by fixeria 16 Mar '26

16 Mar '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/42404?usp=email ) Change subject: socket: osmo_sockaddr_from_str_and_uint(): fix memleak ...................................................................... socket: osmo_sockaddr_from_str_and_uint(): fix memleak `addrinfo_helper()` internally calls `getaddrinfo()`, whose result must be freed with `freeaddrinfo()`. On the size-check error path the function returns early without freeing. Fix this. Change-Id: Ib05e1b8f2465e0db79e7b45de151dc9945e27924 --- M src/core/socket.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/04/42404/1 diff --git a/src/core/socket.c b/src/core/socket.c index 6cd82f0..3a2d7b7 100644 --- a/src/core/socket.c +++ b/src/core/socket.c @@ -1762,8 +1762,10 @@ if (!ai) return -EIO; - if (ai->ai_addrlen > sizeof(*osa_out)) + if (ai->ai_addrlen > sizeof(*osa_out)) { + freeaddrinfo(ai); return -ENOSPC; + } memcpy(&osa_out->u.sa, ai->ai_addr, ai->ai_addrlen); freeaddrinfo(ai); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42404?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib05e1b8f2465e0db79e7b45de151dc9945e27924 Gerrit-Change-Number: 42404 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: gsup: encode_pdp_info(): fix wrong pdp_address index
by fixeria 16 Mar '26

16 Mar '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/42403?usp=email ) Change subject: gsup: encode_pdp_info(): fix wrong pdp_address index ...................................................................... gsup: encode_pdp_info(): fix wrong pdp_address index The `PDP_TYPE_N_IETF_IPv4v6` case encodes two addresses: IPv4 from `pdp_address[0]` and IPv6 from `pdp_address[1]`. The IPv4 part is encoded correctly, but the IPv6 part checks the wrong index. The decoder decode_pdp_address() correctly puts the IPv4 address in `pdp_address[0]` and the IPv6 address in `pdp_address[1]`. Because `pdp_address[0].sa_family` is `AF_INET` (not `AF_INET6`), the second condition is always false in a proper dual-stack context, so the IPv6 part is silently dropped from every outgoing dual-stack GSUP message. Change-Id: Ibc4a438ee7b06346839e78dc14d9d5b11b1c5bbd --- M src/gsm/gsup.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/03/42403/1 diff --git a/src/gsm/gsup.c b/src/gsm/gsup.c index 4f0a1b5..1e4ee6a 100644 --- a/src/gsm/gsup.c +++ b/src/gsm/gsup.c @@ -689,7 +689,7 @@ pdp_addr.ietf.v4v6.v4 = pdp_info->pdp_address[0].u.sin.sin_addr.s_addr; pdp_addr_len += sizeof(pdp_addr.ietf.v4v6.v4); } - if (pdp_info->pdp_address[0].u.sa.sa_family == AF_INET6) { + if (pdp_info->pdp_address[1].u.sa.sa_family == AF_INET6) { memcpy(pdp_addr.ietf.v4v6.v6, &pdp_info->pdp_address[1].u.sin6.sin6_addr, sizeof(pdp_addr.ietf.v4v6.v6)); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42403?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibc4a438ee7b06346839e78dc14d9d5b11b1c5bbd Gerrit-Change-Number: 42403 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: stats: osmo_stats_reporter_udp_open(): fix unconditional jump
by fixeria 16 Mar '26

16 Mar '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/42405?usp=email ) Change subject: stats: osmo_stats_reporter_udp_open(): fix unconditional jump ...................................................................... stats: osmo_stats_reporter_udp_open(): fix unconditional jump Change-Id: Ifb4842ea11e4df0cae8733438b3812a086396b99 Fixes: cc3694b65 ("Fix build for OSX") --- M src/core/stats.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/05/42405/1 diff --git a/src/core/stats.c b/src/core/stats.c index 16e6f62..617c1a5 100644 --- a/src/core/stats.c +++ b/src/core/stats.c @@ -471,7 +471,8 @@ static int val = 1; rc = setsockopt(sock, SOL_SOCKET, SO_NOSIGPIPE, (void*)&val, sizeof(val)); - goto failed; + if (rc == -1) + goto failed; } #endif if (srep->bind_addr_len > 0) { -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42405?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ifb4842ea11e4df0cae8733438b3812a086396b99 Gerrit-Change-Number: 42405 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: netdev: netdev_mnl_set_mtu(): drop unneeded variables
by fixeria 16 Mar '26

16 Mar '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/42406?usp=email ) Change subject: netdev: netdev_mnl_set_mtu(): drop unneeded variables ...................................................................... netdev: netdev_mnl_set_mtu(): drop unneeded variables Setting an MTU via `RTM_NEWLINK` does not require `ifi_flags`/ `ifi_change`, so we don't really need to set these fields. Change-Id: I8f9d39733a80a0ec4e8c462f4ae32b4ac52b5849 --- M src/core/netdev.c 1 file changed, 0 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/06/42406/1 diff --git a/src/core/netdev.c b/src/core/netdev.c index 7e5a409..e63bbc3 100644 --- a/src/core/netdev.c +++ b/src/core/netdev.c @@ -541,8 +541,6 @@ char buf[MNL_SOCKET_BUFFER_SIZE]; struct nlmsghdr *nlh = mnl_nlmsg_put_header(buf); struct ifinfomsg *ifm; - unsigned int change = 0; - unsigned int flags = 0; nlh->nlmsg_type = RTM_NEWLINK; nlh->nlmsg_flags = NLM_F_REQUEST | NLM_F_ACK; @@ -550,8 +548,6 @@ ifm = mnl_nlmsg_put_extra_header(nlh, sizeof(*ifm)); ifm->ifi_family = AF_UNSPEC; - ifm->ifi_change = change; - ifm->ifi_flags = flags; ifm->ifi_index = if_index; mnl_attr_put_u32(nlh, IFLA_MTU, mtu); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42406?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8f9d39733a80a0ec4e8c462f4ae32b4ac52b5849 Gerrit-Change-Number: 42406 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in pysim[master]: personalization: implement reading back values from a PES
by neels 16 Mar '26

16 Mar '26

Attention is currently required from: dexter, laforge. neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/40198?usp=email ) Change subject: personalization: implement reading back values from a PES ...................................................................... Patch Set 12: Code-Review+2 (1 comment) Patchset: PS12: (re-applying earlier +2 after trivial changes) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40198?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I234fc4317f0bdc1a486f0cee4fa432c1dce9b463 Gerrit-Change-Number: 40198 Gerrit-PatchSet: 12 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sun, 15 Mar 2026 22:41:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log