- gerrit-log - lists.osmocom.org

[M] Change in pysim[master]: personalization: implement reading back values from a PES
by neels 16 Mar '26

16 Mar '26

Attention is currently required from: dexter, laforge, neels. Hello Jenkins Builder, dexter, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/40198?usp=email to look at the new patch set (#12). The following approvals got outdated and were removed: Code-Review+1 by dexter, Code-Review+1 by laforge, Code-Review+2 by neels, Verified+1 by Jenkins Builder The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: personalization: implement reading back values from a PES ...................................................................... personalization: implement reading back values from a PES Implement get_values_from_pes(), the reverse direction of apply_val(): read back and return values from a ProfileElementSequence. Implement for all ConfigurableParameter subclasses. Future: SdKey.get_values_from_pes() is reading pe.decoded[], which works fine, but I07dfc378705eba1318e9e8652796cbde106c6a52 will change this implementation to use the higher level ProfileElementSD members. Implementation detail: Implement get_values_from_pes() as classmethod that returns a generator. Subclasses should yield all occurences of their parameter in a given PES. For example, the ICCID can appear in multiple places. Iccid.get_values_from_pes() yields all of the individual values. A set() of the results quickly tells whether the PES is consistent. Rationales for reading back values: This allows auditing an eSIM profile, particularly for producing an output.csv from a batch personalization (that generated lots of random key material which now needs to be fed to an HLR...). Reading back from a binary result is more reliable than storing the values that were fed into a personalization. By auditing final DER results with this code, I discovered: - "oh, there already was some key material in my UPP template." - "all IMSIs ended up the same, forgot to set up the parameter." - the SdKey.apply() implementations currently don't work, see I07dfc378705eba1318e9e8652796cbde106c6a52 for a fix. Change-Id: I234fc4317f0bdc1a486f0cee4fa432c1dce9b463 --- M pySim/esim/saip/personalization.py 1 file changed, 151 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/98/40198/12 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40198?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I234fc4317f0bdc1a486f0cee4fa432c1dce9b463 Gerrit-Change-Number: 40198 Gerrit-PatchSet: 12 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[M] Change in pysim[master]: personalization: implement reading back values from a PES
by neels 16 Mar '26

16 Mar '26

Attention is currently required from: dexter. neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/40198?usp=email ) Change subject: personalization: implement reading back values from a PES ...................................................................... Patch Set 11: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40198?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I234fc4317f0bdc1a486f0cee4fa432c1dce9b463 Gerrit-Change-Number: 40198 Gerrit-PatchSet: 11 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sun, 15 Mar 2026 22:40:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in pysim[master]: personalization: implement reading back values from a PES
by neels 16 Mar '26

16 Mar '26

Attention is currently required from: dexter. neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/40198?usp=email ) Change subject: personalization: implement reading back values from a PES ...................................................................... Patch Set 11: (4 comments) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/40198/comment/0f6ea6c7_7c4edfa6?usp=em… : PS11, Line 209: def get_values_from_pes(cls, pes: ProfileElementSequence) -> Generator: > As far as I understand ''' just marks a multiline comment, but shouldn't this be a doctstring? if you mean the triple single quotes -- AFAIK *any* string format in this location is a docstring. Though laforge has indicated that i sould follow the triple double quote convention. https://gerrit.osmocom.org/c/pysim/+/40198/comment/077471e9_e2401188?usp=em… : PS11, Line 290: def decimal_hex_to_str(cls, val): > also have not seen single quotes as comment chars before... Done https://gerrit.osmocom.org/c/pysim/+/40198/comment/a27f69de_37436e9b?usp=em… : PS11, Line 292: if isinstance(val, bytes): > Is it always ensured that we won't get sometimes bytes and sometimes bytearrays? the values are coming from a ProfileElementSequence's decoded section, should always be either a hexstr or bytes. ok? https://gerrit.osmocom.org/c/pysim/+/40198/comment/8184e5b7_69812655?usp=em… : PS11, Line 297: val = unrpad(val, c) > You are sure that you want to turn val to ascii, like "4141" => "AA"? (am a bit confused since the m […] I got this code from elsewhere (or reversing code from elsewhere?) and I am positively sure that it works as intended. this is how PIN and PUK are stored, apparently actually the ascii codes of the PIN/PUK digits. The function makes a PIN/PUK human readable. The only reason to not directly do a .decode('ascii') is apparently the rpad / unrpad. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40198?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I234fc4317f0bdc1a486f0cee4fa432c1dce9b463 Gerrit-Change-Number: 40198 Gerrit-PatchSet: 11 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sun, 15 Mar 2026 22:40:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[L] Change in pysim[master]: personalization: add param_source.py, add batch.py
by neels 16 Mar '26

16 Mar '26

Attention is currently required from: dexter, laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/41845?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: personalization: add param_source.py, add batch.py ...................................................................... personalization: add param_source.py, add batch.py Implement pySim.esim.saip.batch.BatchPersonalization, generating N eSIM profiles from a preset configuration. Batch parameters can be fed by a constant, incrementing, random or from CSV rows: add pySim.esim.saip.param_source.* classes to feed such input to each of the BatchPersonalization's ConfigurableParameter instances. Related: SYS#6768 Change-Id: I01ae40a06605eb205bfb409189fcd2b3a128855a --- A pySim/esim/saip/batch.py A pySim/esim/saip/param_source.py 2 files changed, 324 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/45/41845/7 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41845?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I01ae40a06605eb205bfb409189fcd2b3a128855a Gerrit-Change-Number: 41845 Gerrit-PatchSet: 7 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in osmocom-bb[master]: firmware/layer1: toa_input(): minor formatting fix
by fixeria 16 Mar '26

16 Mar '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/42398?usp=email ) Change subject: firmware/layer1: toa_input(): minor formatting fix ...................................................................... firmware/layer1: toa_input(): minor formatting fix Change-Id: Iba061badfde8a3875cbf7e7cd19ef89064922f57 --- M src/target/firmware/layer1/toa.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/98/42398/1 diff --git a/src/target/firmware/layer1/toa.c b/src/target/firmware/layer1/toa.c index 4c9fff8..d6f37ff 100644 --- a/src/target/firmware/layer1/toa.c +++ b/src/target/firmware/layer1/toa.c @@ -54,7 +54,7 @@ { int valid = 1; - if (snr < TOA_SNR_THRESHOLD || offset < 0 || offset >31) + if (snr < TOA_SNR_THRESHOLD || offset < 0 || offset > 31) valid = 0; runavg_input(&toa_state.ravg, offset, valid); runavg_check_output(&toa_state.ravg); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/42398?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iba061badfde8a3875cbf7e7cd19ef89064922f57 Gerrit-Change-Number: 42398 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmocom-bb[master]: firmware/layer1: l1a_rach_compl(): fix copy-pasted comment
by fixeria 16 Mar '26

16 Mar '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/42397?usp=email ) Change subject: firmware/layer1: l1a_rach_compl(): fix copy-pasted comment ...................................................................... firmware/layer1: l1a_rach_compl(): fix copy-pasted comment Change-Id: I8000218836bcb58946db48184360f821617dc93f --- M src/target/firmware/layer1/prim_rach.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/97/42397/1 diff --git a/src/target/firmware/layer1/prim_rach.c b/src/target/firmware/layer1/prim_rach.c index 580131e..bb8c4f2 100644 --- a/src/target/firmware/layer1/prim_rach.c +++ b/src/target/firmware/layer1/prim_rach.c @@ -106,7 +106,7 @@ SCHED_END_SET() }; -/* Asynchronous completion handler for FB detection */ +/* Asynchronous completion handler for RACH detection */ static void l1a_rach_compl(__unused enum l1_compl c) { struct msgb *msg; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/42397?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I8000218836bcb58946db48184360f821617dc93f Gerrit-Change-Number: 42397 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmocom-bb[master]: firmware/layer1: l1s_tch_{cmd,resp}(): fix misspelled FACCH
by fixeria 16 Mar '26

16 Mar '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/42396?usp=email ) Change subject: firmware/layer1: l1s_tch_{cmd,resp}(): fix misspelled FACCH ...................................................................... firmware/layer1: l1s_tch_{cmd,resp}(): fix misspelled FACCH Change-Id: I85646a8a0b37478ca517407fcca92d0b89d6aaca --- M src/target/firmware/layer1/prim_tch.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/96/42396/1 diff --git a/src/target/firmware/layer1/prim_tch.c b/src/target/firmware/layer1/prim_tch.c index 1bc842b..7fe6d74 100644 --- a/src/target/firmware/layer1/prim_tch.c +++ b/src/target/firmware/layer1/prim_tch.c @@ -236,7 +236,7 @@ /* FACCH/F: B0(0...7),B1(4...11),B2(8...11,0...3) (mod 13) */ facch_rx_now = ((rx_time.fn % 13) % 4) == 3; } else { - /* FAACH/H: See GSM 05.02 Clause 7 Table 1of9 */ + /* FACCH/H: See GSM 05.02 Clause 7 Table 1of9 */ uint8_t t2_norm = rx_time.t2 - tch_sub; facch_rx_now = (t2_norm == 15) || (t2_norm == 23) || @@ -411,7 +411,7 @@ /* FACCH/F: B0(0...7),B1(4...11),B2(8...11,0...3) */ facch_tx_now = ((l1s.next_time.fn % 13) % 4) == 3; } else { - /* FAACH/H: See GSM 05.02 Clause 7 Table 1of9 */ + /* FACCH/H: See GSM 05.02 Clause 7 Table 1of9 */ uint8_t t2_norm = l1s.next_time.t2 - tch_sub; facch_tx_now = (t2_norm == 23) || (t2_norm == 6) || -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/42396?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I85646a8a0b37478ca517407fcca92d0b89d6aaca Gerrit-Change-Number: 42396 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmocom-bb[master]: layer23: gsm_mncc_names[]: fix whitespace in a string
by fixeria 16 Mar '26

16 Mar '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/42400?usp=email ) Change subject: layer23: gsm_mncc_names[]: fix whitespace in a string ...................................................................... layer23: gsm_mncc_names[]: fix whitespace in a string Change-Id: I93b5445db267985f3d8c53cde08ff28f166ae79c --- M src/host/layer23/src/mobile/gsm48_cc.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/00/42400/1 diff --git a/src/host/layer23/src/mobile/gsm48_cc.c b/src/host/layer23/src/mobile/gsm48_cc.c index 94b81cb..2a8823f 100644 --- a/src/host/layer23/src/mobile/gsm48_cc.c +++ b/src/host/layer23/src/mobile/gsm48_cc.c @@ -138,7 +138,7 @@ { MNCC_CALL_CONF_REQ, "MNCC_CALL_CONF_REQ" }, { MNCC_START_DTMF_REQ, "MNCC_START_DTMF_REQ" }, { MNCC_STOP_DTMF_REQ, "MNCC_STOP_DTMF_REQ" }, - { MNCC_HOLD_REQ, "MNCC_HOLD_REQ " }, + { MNCC_HOLD_REQ, "MNCC_HOLD_REQ" }, { MNCC_RETRIEVE_REQ, "MNCC_RETRIEVE_REQ" }, { MNCC_FRAME_RECV, "MNCC_FRAME_RECV" }, { MNCC_FRAME_DROP, "MNCC_FRAME_DROP" }, -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/42400?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I93b5445db267985f3d8c53cde08ff28f166ae79c Gerrit-Change-Number: 42400 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmocom-bb[master]: layer23: gsm48_sysinfo_dump(): remove unused print argument
by fixeria 16 Mar '26

16 Mar '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/42399?usp=email ) Change subject: layer23: gsm48_sysinfo_dump(): remove unused print argument ...................................................................... layer23: gsm48_sysinfo_dump(): remove unused print argument Change-Id: I0a26d5ac3183dc7ccb2e7d3d77ab41b58ad5b871 --- M src/host/layer23/src/common/sysinfo.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/99/42399/1 diff --git a/src/host/layer23/src/common/sysinfo.c b/src/host/layer23/src/common/sysinfo.c index 1046e78..42fab5f 100644 --- a/src/host/layer23/src/common/sysinfo.c +++ b/src/host/layer23/src/common/sysinfo.c @@ -312,7 +312,7 @@ if (s->t3212) print(priv, "T3212 = %d sec.\n", s->t3212); else - print(priv, "T3212 = disabled\n", s->t3212); + print(priv, "T3212 = disabled\n"); /* channel description */ if (s->h) -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/42399?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I0a26d5ac3183dc7ccb2e7d3d77ab41b58ad5b871 Gerrit-Change-Number: 42399 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmocom-bb[master]: mobile: gsm48_cc_tx_release_compl(): actually send the message
by fixeria 16 Mar '26

16 Mar '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/42401?usp=email ) Change subject: mobile: gsm48_cc_tx_release_compl(): actually send the message ...................................................................... mobile: gsm48_cc_tx_release_compl(): actually send the message The message buffer is allocated, filled in, and then leaked when `trans_free(trans)` is called. The RELEASE COMPLETE message is never transmitted to the network. Change-Id: Ic754fe1ddd7e2908627374590f01e6fc81a73c77 --- M src/host/layer23/src/mobile/gsm48_cc.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/01/42401/1 diff --git a/src/host/layer23/src/mobile/gsm48_cc.c b/src/host/layer23/src/mobile/gsm48_cc.c index 2a8823f..869f57a 100644 --- a/src/host/layer23/src/mobile/gsm48_cc.c +++ b/src/host/layer23/src/mobile/gsm48_cc.c @@ -1710,6 +1710,8 @@ if (rel->fields & MNCC_F_SSVERSION) gsm48_encode_ssversion(nmsg, &rel->ssversion); + gsm48_cc_to_mm(nmsg, trans, GSM48_MMCC_DATA_REQ); + /* release without sending MMCC_REL_REQ */ new_cc_state(trans, GSM_CSTATE_NULL); trans->callref = 0; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/42401?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ic754fe1ddd7e2908627374590f01e6fc81a73c77 Gerrit-Change-Number: 42401 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log