- gerrit-log - lists.osmocom.org

[XS] Change in osmo-gsm-manuals[master]: Corrected description of MSISDN IE and IMEI IE coding

by pespin

Attention is currently required from: jolly. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/40424?usp=email ) Change subject: Corrected description of MSISDN IE and IMEI IE coding ...................................................................... Patch Set 2: (1 comment) File common/chapters/gsup.adoc: https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/40424/comment/d63b05e1_c22a… : PS1, Line 1513: The length of the BCD content specifies how many subsequent octets contain BCD data, > I find this sentence hard to read, specially the "but it". […] Uuuh well I meant specially on the gsup.adoc file, not only in the commit description ;) -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/40424?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I4db05e4a01199334b75fffd60270b88f541b98f4 Gerrit-Change-Number: 40424 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Wed, 04 Jun 2025 10:01:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

3 weeks, 1 day

1
0
0 0

[XS] Change in ...pyosmocom[master]: Corrected decoding of MSISDN IE and IMEI IE

by jolly

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/python/pyosmocom/+/40423?usp=email to look at the new patch set (#2). Change subject: Corrected decoding of MSISDN IE and IMEI IE ...................................................................... Corrected decoding of MSISDN IE and IMEI IE 1 2 3 4 5 6 7 8 +-------------------------------+ | MSISDN IE type |Res| octet 1 +-------------------------------+ | Length of IE content | octet 2 +-------------------------------+ | Length of BCD content | octet 3 +-------------------------------+ | Digit 1 | Digit 2 | octet 4..n | .... | | +-------------------------------+ The length of the BCD content specifies how many subsequent octets contain BCD data (it does *not* indicate the number of digits). This length must be less than the total length of the IE content. Any octets following the BCD content shall be ignored. Related: OS#6797 Change-Id: Idd2bee3d8f662d028001392cfd0332a265fbc91a --- M src/osmocom/gsup/message.py 1 file changed, 2 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/python/pyosmocom refs/changes/23/40423/2 -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/40423?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: Idd2bee3d8f662d028001392cfd0332a265fbc91a Gerrit-Change-Number: 40423 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder

3 weeks, 1 day

1
0
0 0

[XS] Change in osmo-gsm-manuals[master]: Corrected description of MSISDN IE and IMEI IE coding

by jolly

Attention is currently required from: jolly. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/40424?usp=email to look at the new patch set (#2). Change subject: Corrected description of MSISDN IE and IMEI IE coding ...................................................................... Corrected description of MSISDN IE and IMEI IE coding 1 2 3 4 5 6 7 8 +-------------------------------+ | MSISDN IE type |Res| octet 1 +-------------------------------+ | Length of IE content | octet 2 +-------------------------------+ | Length of BCD content | octet 3 +-------------------------------+ | Digit 1 | Digit 2 | octet 4..n | .... | | +-------------------------------+ The length of the BCD content specifies how many subsequent octets contain BCD data (it does *not* indicate the number of digits). This length must be less than the total length of the IE content. Any octets following the BCD content shall be ignored. Related: OS#6797 Change-Id: I4db05e4a01199334b75fffd60270b88f541b98f4 --- M common/chapters/gsup.adoc 1 file changed, 6 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/24/40424/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/40424?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I4db05e4a01199334b75fffd60270b88f541b98f4 Gerrit-Change-Number: 40424 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu>

3 weeks, 1 day

1
0
0 0

[XS] Change in osmo-msc[master]: vlr: remove old TODO to switch to osmo_tdef_fsm_inst_state_chg

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/40422?usp=email ) Change subject: vlr: remove old TODO to switch to osmo_tdef_fsm_inst_state_chg ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/40422?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I1eecfeec494a2e129c41a6e964c56ed4430611de Gerrit-Change-Number: 40422 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 04 Jun 2025 09:54:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 weeks, 1 day

1
0
0 0

[M] Change in osmo-msc[master]: vlr: when receiving imsi detach, purge the subscriber towards HLR

by pespin

Attention is currently required from: lynxis lazus, neels. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38489?usp=email ) Change subject: vlr: when receiving imsi detach, purge the subscriber towards HLR ...................................................................... Patch Set 9: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38489?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9c2569c45e69b422ce26050b682e6eb26c1c2625 Gerrit-Change-Number: 38489 Gerrit-PatchSet: 9 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 04 Jun 2025 09:54:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 weeks, 1 day

1
0
0 0

[XS] Change in osmo-gsm-manuals[master]: Corrected description of MSISDN IE and IMEI IE coding

by pespin

Attention is currently required from: jolly. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/40424?usp=email ) Change subject: Corrected description of MSISDN IE and IMEI IE coding ...................................................................... Patch Set 1: (1 comment) File common/chapters/gsup.adoc: https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/40424/comment/a0deec1d_11d8… : PS1, Line 1513: The length of the BCD content specifies how many subsequent octets contain BCD data, I find this sentence hard to read, specially the "but it". I think removing the "but" word already helps. Maybe also use parenthesis: The length of the BCD content specifies how many subsequent octets contain BCD data (it does *not* indicate the number of digits). -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/40424?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I4db05e4a01199334b75fffd60270b88f541b98f4 Gerrit-Change-Number: 40424 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Wed, 04 Jun 2025 09:52:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

3 weeks, 1 day

1
0
0 0

[XS] Change in ...pyosmocom[master]: Corrected decoding of MSISDN IE and IMEI IE

by jolly

jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/40423?usp=email ) Change subject: Corrected decoding of MSISDN IE and IMEI IE ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/40423?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: Idd2bee3d8f662d028001392cfd0332a265fbc91a Gerrit-Change-Number: 40423 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Wed, 04 Jun 2025 09:37:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

3 weeks, 1 day

1
0
0 0

[XS] Change in osmo-gsm-manuals[master]: Corrected description of MSISDN IE and IMEI IE coding

by jolly

jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/40424?usp=email ) Change subject: Corrected description of MSISDN IE and IMEI IE coding ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/40424?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I4db05e4a01199334b75fffd60270b88f541b98f4 Gerrit-Change-Number: 40424 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Wed, 04 Jun 2025 09:36:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

3 weeks, 1 day

1
0
0 0

[XS] Change in osmo-gsm-manuals[master]: Corrected description of MSISDN IE and IMEI IE coding

by jolly

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/40424?usp=email ) Change subject: Corrected description of MSISDN IE and IMEI IE coding ...................................................................... Corrected description of MSISDN IE and IMEI IE coding 1 2 3 4 5 6 7 8 +-------------------------------+ | MSISDN IE type |Res| octet 1 +-------------------------------+ | Length of IE content | octet 2 +-------------------------------+ | Length of BCD content | octet 3 +-------------------------------+ | Digit 1 | Digit 2 | octet 4..n | .... | | +-------------------------------+ The length of the BCD content specifies how many subsequent octets contain BCD data, but it does not indicate the number of digits. This length must be less than the total length of the IE content. Any octets following the BCD content shall be ignored. Related: OS#6797 Change-Id: I4db05e4a01199334b75fffd60270b88f541b98f4 --- M common/chapters/gsup.adoc 1 file changed, 6 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/24/40424/1 diff --git a/common/chapters/gsup.adoc b/common/chapters/gsup.adoc index f5cce14..96930b9 100644 --- a/common/chapters/gsup.adoc +++ b/common/chapters/gsup.adoc @@ -1510,6 +1510,10 @@ BCD Number in 3GPP TS 24.008. It will be stored by the SGSN or VLR and then passed as is to the GGSN during the activation of the primary PDP Context. +The length of the BCD content specifies how many subsequent octets contain BCD data, +but it does not indicate the number of digits. This length must be less than the total +length of the IE content. Any octets following the BCD content shall be ignored. + [packetdiag] ---- { @@ -1519,9 +1523,7 @@ 0-6: PDP type IEI 7: Res 8-15: Length of IE content - 16-19: NPI - 20-22: TON - 23: ext + 16-23: Length of BCD content 24-27: Digit 1 28-31: Digit 2 32-35: Digit ... @@ -1628,6 +1630,7 @@ ==== IMEI The IMEI encoded as Called Party BCD Number in 3GPP TS 24.008. +This IE has the same format as described in <<gsup-ie-msisdn>>. [[gsup-ie-imei-result]] ==== IMEI Check Result -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/40424?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I4db05e4a01199334b75fffd60270b88f541b98f4 Gerrit-Change-Number: 40424 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu>

3 weeks, 1 day

1
0
0 0

[XS] Change in ...pyosmocom[master]: Corrected decoding of MSISDN IE and IMEI IE

by jolly

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/40423?usp=email ) Change subject: Corrected decoding of MSISDN IE and IMEI IE ...................................................................... Corrected decoding of MSISDN IE and IMEI IE 1 2 3 4 5 6 7 8 +-------------------------------+ | MSISDN IE type |Res| octet 1 +-------------------------------+ | Length of IE content | octet 2 +-------------------------------+ | Length of BCD content | octet 3 +-------------------------------+ | Digit 1 | Digit 2 | octet 4..n | .... | | +-------------------------------+ The length of the BCD content specifies how many subsequent octets contain BCD data, but it does not indicate the number of digits. This length must be less than the total length of the IE content. Any octets following the BCD content shall be ignored. Related: OS#6797 Change-Id: Idd2bee3d8f662d028001392cfd0332a265fbc91a --- M src/osmocom/gsup/message.py 1 file changed, 2 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/python/pyosmocom refs/changes/23/40423/1 diff --git a/src/osmocom/gsup/message.py b/src/osmocom/gsup/message.py index 8ab7881..e48cd54 100644 --- a/src/osmocom/gsup/message.py +++ b/src/osmocom/gsup/message.py @@ -133,8 +133,7 @@ _construct = None # empty class MSISDN(GSUP_TLV_IE, tag=0x08): - # TODO: do all existing implementations use ton/npi? - _construct = Struct('ton_npi'/TonNpi, 'digits'/PaddedBcdAdapter(GreedyBytes)) + _construct = Struct('bcd_len'/Byte, 'digits'/PaddedBcdAdapter(Bytes(this.bcd_len))) class HlrNumber(GSUP_TLV_IE, tag=0x09): _construct = Struct('ton_npi'/TonNpi, 'digits'/PaddedBcdAdapter(GreedyBytes)) @@ -185,7 +184,7 @@ _construct = Enum(Int8ub, ms_present=1, memory_available=2) class IMEI(GSUP_TLV_IE, tag=0x50): - _construct = PaddedBcdAdapter(GreedyBytes) + _construct = Struct('bcd_len'/Byte, 'digits'/PaddedBcdAdapter(Bytes(this.bcd_len))) class ImeiCheckResult(GSUP_TLV_IE, tag=0x51): _construct = Enum(Int8ub, ack=0, nack=1) -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/40423?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: Idd2bee3d8f662d028001392cfd0332a265fbc91a Gerrit-Change-Number: 40423 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu>

3 weeks, 1 day

1
0
0 0

2025

2024

2023

2022

gerrit-log