[M] Change in osmo-remsim[master]: Update osmo-remsim-apitool to support maintenance flag
Attention is currently required from: laforge, lynxis, pespin. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-remsim/+/43747?usp=email ) Change subject: Update osmo-remsim-apitool to support maintenance flag ...................................................................... Patch Set 11: (2 comments) File contrib/osmo-remsim-apitool: https://gerrit.osmocom.org/c/osmo-remsim/+/43747/comment/013cb124_f3252f1e?u... : PS10, Line 70: if priority:
this matches for 0 and for False (future hopefully None). […] I changed the default to None. '0' will match because the argument is a string. (And timeout an integer.)
https://gerrit.osmocom.org/c/osmo-remsim/+/43747/comment/75e3c192_b27d8a90?u... : PS10, Line 84:
default of "false" sounds a bit odd for a parameter that has an integer value and no a bool? Should […] This was some leftover from the old version with boolean priority.
-- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/43747?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Iaac6423b3a2f7209d0c26e9624d90b21b7c39f89 Gerrit-Change-Number: 43747 Gerrit-PatchSet: 11 Gerrit-Owner: jolly <andreas@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: lynxis <lynxis@fe80.eu> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Attention: lynxis <lynxis@fe80.eu> Gerrit-Comment-Date: Wed, 18 Nov 2026 10:12:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge@osmocom.org>
participants (1)
-
jolly