[XS] Change in osmo-uecups[master]: cups_client: Mark field NULL after destroying it
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-uecups/+/44098?usp=email ) Change subject: cups_client: Mark field NULL after destroying it ...................................................................... cups_client: Mark field NULL after destroying it We are seeing sporadic crashes around connection teardown, so while this probably doesn't fix the problem, at least may be useful to track if that pointer is reused after either cc or cc->srv are freed. Related: SYS#6997 Change-Id: I014b05a343835b5e401b5e0fb9f8c482bc53bb87 --- M daemon/cups_client.c 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/daemon/cups_client.c b/daemon/cups_client.c index a96861f..58f1149 100644 --- a/daemon/cups_client.c +++ b/daemon/cups_client.c @@ -805,6 +805,7 @@ if (cc->srv) { osmo_stream_srv_set_data(cc->srv, NULL); osmo_stream_srv_destroy(cc->srv); + cc->srv = NULL; } talloc_free(cc); } -- To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/44098?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-uecups Gerrit-Branch: master Gerrit-Change-Id: I014b05a343835b5e401b5e0fb9f8c482bc53bb87 Gerrit-Change-Number: 44098 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de>
participants (1)
-
pespin